Maven Sling Plugin 2.3.4 requires Java 8

[Carsten Ziegeler]

Hi,

for some time I noticed a problem with our latest parent pom when using
Java 7 to build some modules. It seems that the latest version of the
Sling Plugin requires Java 8 although it does not declare this.
As we're still supporting and using Java 7 in many modules as the base,
we should fix this.

I've created https://issues.apache.org/jira/browse/SLING-7644 to track this.

Downgrading to version 2.3.2 of the plugin fixes the problem

Regards
Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Created] (SLING-7644) Maven-Sling-Plugin requires Java 8

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-7644:
---

 Summary: Maven-Sling-Plugin requires Java 8
 Key: SLING-7644
 URL: https://issues.apache.org/jira/browse/SLING-7644
 Project: Sling
  Issue Type: Bug
  Components: Maven Plugins and Archetypes
Affects Versions: Maven Sling Plugin 2.3.4
Reporter: Carsten Ziegeler
 Fix For: Maven Sling Plugin 2.3.6


When using the maven sling plugin 2.3.4 with Java 7, the following error occurs:

[ERROR] Failed to execute goal 
org.apache.sling:maven-sling-plugin:2.3.4:generate-adapter-metadata 
(generate-adapter-metadata) on project org.apache.sling.resourceresolver: 
Execution generate-adapter-metadata of goal 
org.apache.sling:maven-sling-plugin:2.3.4:generate-adapter-metadata failed: An 
API incompatibility was encountered while executing 
org.apache.sling:maven-sling-plugin:2.3.4:generate-adapter-metadata: 
java.lang.UnsupportedClassVersionError: javax/json/JsonException : Unsupported 
major.minor version 52.0
[ERROR] -
[ERROR] realm =    plugin>org.apache.sling:maven-sling-plugin:2.3.4
[ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
[ERROR] urls[0] = 
file:/Users/cziegeler/.m2/repository/org/apache/sling/maven-sling-plugin/2.3.4/maven-sling-plugin-2.3.4.jar
[

Reverting to version 2.3.2 fixes the problem



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] cziegeler closed pull request #6: SLING-3524: Allow distinguishing cloning from normal login in providers.

[GitBox]

cziegeler closed pull request #6: SLING-3524: Allow distinguishing cloning from 
normal login in providers.
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/6
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pom.xml b/pom.xml
index 2d9af60..b2094b9 100644
--- a/pom.xml
+++ b/pom.xml
@@ -110,7 +110,7 @@
 
 org.apache.sling
 org.apache.sling.api
-2.18.0
+2.18.1-SNAPSHOT
 provided
 
 
diff --git 
a/src/main/java/org/apache/sling/resourceresolver/impl/CommonResourceResolverFactoryImpl.java
 
b/src/main/java/org/apache/sling/resourceresolver/impl/CommonResourceResolverFactoryImpl.java
index 8cef27d..11c6b24 100644
--- 
a/src/main/java/org/apache/sling/resourceresolver/impl/CommonResourceResolverFactoryImpl.java
+++ 
b/src/main/java/org/apache/sling/resourceresolver/impl/CommonResourceResolverFactoryImpl.java
@@ -62,6 +62,8 @@
 
 private static final Logger LOG = 
LoggerFactory.getLogger(CommonResourceResolverFactoryImpl.class);
 
+private static final String[] FORBIDDEN_AUTH_INFO_KEYS = 
{ResourceProvider.AUTH_CLONE};
+
 /** Helper for the resource resolver. */
 private MapEntriesHandler mapEntries = MapEntriesHandler.EMPTY;
 
@@ -129,6 +131,32 @@ public void run() {
 }
 
 // -- Resource Resolver Factory 

+
+/**
+ * Sanitize the authentication info passed from external code. This method 
will always make a defensive
+ * copy of the argument, also making sure that the copy is mutable. Nulls 
are turned into empty (mutable) maps.
+ * Keys that are used to communicate with resource providers are removed 
from the copy, and optionally
+ * other keys can be removed as well.
+ * @param authenticationInfo The authentication info to sanitize, may be 
null.
+ * @param extraForbiddenKeys Keys that should be removed from the returned 
copy.
+ * @return A sanitized mutable map.
+ */
+@Nonnull
+static Map sanitizeAuthenticationInfo(Map 
authenticationInfo, String... extraForbiddenKeys) {
+if (authenticationInfo == null) {
+// nothing to sanitize, just return an empty mutable map
+return new HashMap<>();
+} else {
+Map sanitized = new HashMap<>(authenticationInfo);
+for (String key : FORBIDDEN_AUTH_INFO_KEYS) {
+sanitized.remove(key);
+}
+for (String key : extraForbiddenKeys) {
+sanitized.remove(key);
+}
+return sanitized;
+}
+}
 
 /**
  * @see 
org.apache.sling.api.resource.ResourceResolverFactory#getAdministrativeResourceResolver(java.util.Map)
@@ -139,15 +167,10 @@ public ResourceResolver 
getAdministrativeResourceResolver(final Map authenticationInfo = new HashMap<>();
+// make sure there is no leaking of service info props
+// (but the bundle info is passed on as we need it downstream)
+final Map authenticationInfo = 
sanitizeAuthenticationInfo(passedAuthenticationInfo, SUBSERVICE);
 authenticationInfo.put(ResourceProvider.AUTH_ADMIN, Boolean.TRUE);
-if ( passedAuthenticationInfo != null ) {
-authenticationInfo.putAll(passedAuthenticationInfo);
-// make sure there is no leaking of service info props
-// (but the bundle info is passed on as we need it downstream)
-authenticationInfo.remove(SUBSERVICE);
-}
 
 return getResourceResolverInternal(authenticationInfo, true);
 }
@@ -161,14 +184,8 @@ public ResourceResolver getResourceResolver(final 
Map passedAuth
 throws LoginException {
 checkIsLive();
 
-// create a copy of the passed authentication info as we modify the map
-final Map authenticationInfo = new HashMap<>();
-if ( passedAuthenticationInfo != null ) {
-authenticationInfo.putAll(passedAuthenticationInfo);
-// make sure there is no leaking of service bundle and info props
-authenticationInfo.remove(ResourceProvider.AUTH_SERVICE_BUNDLE);
-authenticationInfo.remove(SUBSERVICE);
-}
+// make sure there is no leaking of service bundle and info props
+final Map authenticationInfo = 
sanitizeAuthenticationInfo(passedAuthenticationInfo, 
ResourceProvider.AUTH_SERVICE_BUNDLE, SUBSERVICE);
 

[jira] [Assigned] (SLING-3524) ResourceResolver.clone(null) should not share the same JCR session

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-3524:
---

Assignee: Carsten Ziegeler

> ResourceResolver.clone(null) should not share the same JCR session
> --
>
> Key: SLING-3524
> URL: https://issues.apache.org/jira/browse/SLING-3524
> Project: Sling
>  Issue Type: Improvement
>  Components: API, JCR, ResourceResolver
>Affects Versions: Resource Resolver 1.0.6
>Reporter: Alexander Klimetschek
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: API 2.18.2, JCR Resource 3.0.10, Resource Resolver 1.6.2
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> {{ResourceResolver.clone()}} will reuse the same JCR session in case it was 
> created by passing an existing session using 
> {{JcrResourceConstants.AUTHENTICATION_INFO_SESSION}}. If you need a clone of 
> the resource resolver to pass into a new, separate thread, and use 
> {{ResourceResolver.clone(null)}}, you will actually share the session, but 
> this is not obvious. The problem is that a JCR session cannot be shared 
> across threads.
> The javadocs of clone() say "the same credential data is used as was used to 
> create this instance".
> There are a few problems with this:
> - seeing the session object itself as "credential data" is unintuitive
> - in my code, I have no idea what the original credential data was, so I 
> don't know what kind of credential data it was to make the right decision
> - since sharing a JCR session is to be avoided at all times, the resource 
> resolver should prevent one from this
> A solution would be if a plain {{ResourceResolver.clone(null)}} would return 
> a session that impersonated itself, abstracting this from the resource 
> resolver user. Additionally, it might be worth looking that clone always 
> returns a new session, unless specifically stated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SLING-7506) org.apache.sling.scripting.jsp.taglib: update esapi dependency

[Dan Klco (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco reassigned SLING-7506:
---

Assignee: Dan Klco

> org.apache.sling.scripting.jsp.taglib: update esapi dependency
> --
>
> Key: SLING-7506
> URL: https://issues.apache.org/jira/browse/SLING-7506
> Project: Sling
>  Issue Type: Task
>  Components: Scripting
>Reporter: Julian Reschke
>Assignee: Dan Klco
>Priority: Major
>
> To 
>   https://mvnrepository.com/artifact/org.owasp.esapi/esapi/2.1.0.1
> due to the current transitive dep on
>   https://mvnrepository.com/artifact/org.owasp.antisamy/antisamy/1.4.3
> which has several CVEs reported against..



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7506) org.apache.sling.scripting.jsp.taglib: update esapi dependency

[Dan Klco (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461645#comment-16461645
 ] 

Dan Klco commented on SLING-7506:
-

Fixed in 
https://github.com/apache/sling-org-apache-sling-scripting-jsp-taglib/commit/5a268075a0196312bfe4656c238786f995cb99c7

> org.apache.sling.scripting.jsp.taglib: update esapi dependency
> --
>
> Key: SLING-7506
> URL: https://issues.apache.org/jira/browse/SLING-7506
> Project: Sling
>  Issue Type: Task
>  Components: Scripting
>Reporter: Julian Reschke
>Assignee: Dan Klco
>Priority: Major
>
> To 
>   https://mvnrepository.com/artifact/org.owasp.esapi/esapi/2.1.0.1
> due to the current transitive dep on
>   https://mvnrepository.com/artifact/org.owasp.antisamy/antisamy/1.4.3
> which has several CVEs reported against..



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7506) org.apache.sling.scripting.jsp.taglib: update esapi dependency

[Dan Klco (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco resolved SLING-7506.
-
Resolution: Fixed

> org.apache.sling.scripting.jsp.taglib: update esapi dependency
> --
>
> Key: SLING-7506
> URL: https://issues.apache.org/jira/browse/SLING-7506
> Project: Sling
>  Issue Type: Task
>  Components: Scripting
>Reporter: Julian Reschke
>Assignee: Dan Klco
>Priority: Major
>
> To 
>   https://mvnrepository.com/artifact/org.owasp.esapi/esapi/2.1.0.1
> due to the current transitive dep on
>   https://mvnrepository.com/artifact/org.owasp.antisamy/antisamy/1.4.3
> which has several CVEs reported against..



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7643) Add Support for Context Aware Configuration Resources

[Dan Klco (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco resolved SLING-7643.
-
Resolution: Fixed

Fixed in: 
https://github.com/apache/sling-org-apache-sling-scripting-jsp-taglib/commit/5a268075a0196312bfe4656c238786f995cb99c7

> Add Support for Context Aware Configuration Resources
> -
>
> Key: SLING-7643
> URL: https://issues.apache.org/jira/browse/SLING-7643
> Project: Sling
>  Issue Type: Improvement
>  Components: Scripting
>Affects Versions: Scripting JSP Taglib 2.2.6
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: Scripting JSP Taglib 2.2.8
>
>
> Currently, it is not possible to interact with Context Aware configuations 
> via JSP, at minimum, there should be tags and functions to retrieve CA Config 
> resources and resource collections.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7642) Adapt To Tag / Function Logging too Verbose

[Dan Klco (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco resolved SLING-7642.
-
Resolution: Fixed

Fixed in: 
https://github.com/apache/sling-org-apache-sling-scripting-jsp-taglib/commit/e349a7a2cf9e68037ed6e223eeedebac1122db46

> Adapt To Tag / Function Logging too Verbose
> ---
>
> Key: SLING-7642
> URL: https://issues.apache.org/jira/browse/SLING-7642
> Project: Sling
>  Issue Type: Improvement
>  Components: Scripting
>Affects Versions: Scripting JSP Taglib 2.2.6
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: Scripting JSP Taglib 2.2.8
>
>
> Currently, the adaptTo tag and function log at WARNING if the supplied 
> adaptor is null. This can cause excessive logs for an expected and handled 
> case.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7641) Use Default if Value is Blank on sling:encode Tag

[Dan Klco (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco resolved SLING-7641.
-
Resolution: Fixed

Fixed in 
https://github.com/apache/sling-org-apache-sling-scripting-jsp-taglib/commit/48cd7272aac009022b0ccc3e7ff0fc9e36d872f0

> Use Default if Value is Blank on sling:encode Tag
> -
>
> Key: SLING-7641
> URL: https://issues.apache.org/jira/browse/SLING-7641
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting JSP Taglib 2.2.6
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: Scripting JSP Taglib 2.2.8
>
>
> According to the description in the TLD, the blank value is:
> "The default value to be used if the value is either null or an empty 
> string." 
> However, the Encode Tag only uses a null check to decide to use the default 
> value. This should instead check if the string is null or empty.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7643) Add Support for Context Aware Configuration Resources

[Dan Klco (JIRA)]

Dan Klco created SLING-7643:
---

 Summary: Add Support for Context Aware Configuration Resources
 Key: SLING-7643
 URL: https://issues.apache.org/jira/browse/SLING-7643
 Project: Sling
  Issue Type: Improvement
  Components: Scripting
Affects Versions: Scripting JSP Taglib 2.2.6
Reporter: Dan Klco
Assignee: Dan Klco
 Fix For: Scripting JSP Taglib 2.2.8


Currently, it is not possible to interact with Context Aware configuations via 
JSP, at minimum, there should be tags and functions to retrieve CA Config 
resources and resource collections.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7642) Adapt To Tag / Function Logging to Verbose

[Dan Klco (JIRA)]

Dan Klco created SLING-7642:
---

 Summary: Adapt To Tag / Function Logging to Verbose
 Key: SLING-7642
 URL: https://issues.apache.org/jira/browse/SLING-7642
 Project: Sling
  Issue Type: Improvement
  Components: Scripting
Affects Versions: Scripting JSP Taglib 2.2.6
Reporter: Dan Klco
Assignee: Dan Klco
 Fix For: Scripting JSP Taglib 2.2.8


Currently, the adaptTo tag and function log at WARNING if the supplied adaptor 
is null. This can cause excessive logs for an expected and handled case.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7642) Adapt To Tag / Function Logging too Verbose

[Dan Klco (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco updated SLING-7642:

Summary: Adapt To Tag / Function Logging too Verbose  (was: Adapt To Tag / 
Function Logging to Verbose)

> Adapt To Tag / Function Logging too Verbose
> ---
>
> Key: SLING-7642
> URL: https://issues.apache.org/jira/browse/SLING-7642
> Project: Sling
>  Issue Type: Improvement
>  Components: Scripting
>Affects Versions: Scripting JSP Taglib 2.2.6
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: Scripting JSP Taglib 2.2.8
>
>
> Currently, the adaptTo tag and function log at WARNING if the supplied 
> adaptor is null. This can cause excessive logs for an expected and handled 
> case.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7641) Use Default if Value is Blank on sling:encode Tag

[Dan Klco (JIRA)]

Dan Klco created SLING-7641:
---

 Summary: Use Default if Value is Blank on sling:encode Tag
 Key: SLING-7641
 URL: https://issues.apache.org/jira/browse/SLING-7641
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Affects Versions: Scripting JSP Taglib 2.2.6
Reporter: Dan Klco
Assignee: Dan Klco
 Fix For: Scripting JSP Taglib 2.2.8


According to the description in the TLD, the blank value is:

"The default value to be used if the value is either null or an empty string." 

However, the Encode Tag only uses a null check to decide to use the default 
value. This should instead check if the string is null or empty.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-3524) ResourceResolver.clone(null) should not share the same JCR session

[Csaba Varga (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461478#comment-16461478
 ] 

Csaba Varga commented on SLING-3524:


Pushed a new test case that will exercise the JCR login and logout 
functionality in all the eight combinations we were talking about. I hope I 
could express all API guarantees as tests, so they won't get broken again in 
the future.

> ResourceResolver.clone(null) should not share the same JCR session
> --
>
> Key: SLING-3524
> URL: https://issues.apache.org/jira/browse/SLING-3524
> Project: Sling
>  Issue Type: Improvement
>  Components: API, JCR, ResourceResolver
>Affects Versions: Resource Resolver 1.0.6
>Reporter: Alexander Klimetschek
>Priority: Major
> Fix For: API 2.18.2, JCR Resource 3.0.10, Resource Resolver 1.6.2
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> {{ResourceResolver.clone()}} will reuse the same JCR session in case it was 
> created by passing an existing session using 
> {{JcrResourceConstants.AUTHENTICATION_INFO_SESSION}}. If you need a clone of 
> the resource resolver to pass into a new, separate thread, and use 
> {{ResourceResolver.clone(null)}}, you will actually share the session, but 
> this is not obvious. The problem is that a JCR session cannot be shared 
> across threads.
> The javadocs of clone() say "the same credential data is used as was used to 
> create this instance".
> There are a few problems with this:
> - seeing the session object itself as "credential data" is unintuitive
> - in my code, I have no idea what the original credential data was, so I 
> don't know what kind of credential data it was to make the right decision
> - since sharing a JCR session is to be avoided at all times, the resource 
> resolver should prevent one from this
> A solution would be if a plain {{ResourceResolver.clone(null)}} would return 
> a session that impersonated itself, abstracting this from the resource 
> resolver user. Additionally, it might be worth looking that clone always 
> returns a new session, unless specifically stated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-3524) ResourceResolver.clone(null) should not share the same JCR session

[Csaba Varga (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461281#comment-16461281
 ] 

Csaba Varga commented on SLING-3524:


I've added a [new 
commit|https://github.com/csaboka/sling-org-apache-sling-resourceresolver/commit/0f444aa5c6537d480badcf4ca7b2af557f09d48a]
 to clear the CLONE key from the authentication info before passing it to the 
resource resolver. I hope I've caught all the paths from external clients to 
the ResourceResolverImpl constructor. The upside is that now the code has a 
central place where new "forbidden properties" can be added as necessary.

> ResourceResolver.clone(null) should not share the same JCR session
> --
>
> Key: SLING-3524
> URL: https://issues.apache.org/jira/browse/SLING-3524
> Project: Sling
>  Issue Type: Improvement
>  Components: API, JCR, ResourceResolver
>Affects Versions: Resource Resolver 1.0.6
>Reporter: Alexander Klimetschek
>Priority: Major
> Fix For: API 2.18.2, JCR Resource 3.0.10, Resource Resolver 1.6.2
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> {{ResourceResolver.clone()}} will reuse the same JCR session in case it was 
> created by passing an existing session using 
> {{JcrResourceConstants.AUTHENTICATION_INFO_SESSION}}. If you need a clone of 
> the resource resolver to pass into a new, separate thread, and use 
> {{ResourceResolver.clone(null)}}, you will actually share the session, but 
> this is not obvious. The problem is that a JCR session cannot be shared 
> across threads.
> The javadocs of clone() say "the same credential data is used as was used to 
> create this instance".
> There are a few problems with this:
> - seeing the session object itself as "credential data" is unintuitive
> - in my code, I have no idea what the original credential data was, so I 
> don't know what kind of credential data it was to make the right decision
> - since sharing a JCR session is to be avoided at all times, the resource 
> resolver should prevent one from this
> A solution would be if a plain {{ResourceResolver.clone(null)}} would return 
> a session that impersonated itself, abstracting this from the resource 
> resolver user. Additionally, it might be worth looking that clone always 
> returns a new session, unless specifically stated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7640) Package pipe

[Nicolas Peltier (JIRA)]

Nicolas Peltier created SLING-7640:
--

 Summary: Package pipe
 Key: SLING-7640
 URL: https://issues.apache.org/jira/browse/SLING-7640
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: pipes 2.0.2
Reporter: Nicolas Peltier


à la Authorizable pipe, both reader & writer, ability to read apache filevault 
package filters, or write some.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Subject: [VOTE][CLOSED] Release Apache Sling JCR Content Parser version 1.2.6

[Jason E Bailey]

closing to combine votes since releases share a repo

- Jason

On Wed, May 2, 2018, at 11:22 AM, Jason E Bailey wrote:
> Yes it does. I'll resend out the Vote to cover both
> 
> - Jason
> 
> On Wed, May 2, 2018, at 11:18 AM, Robert Munteanu wrote:
> > Does this contain both artefacts? You can just start a vote for both in
> > that case, no need to drop them.
> > 
> > Robert
> > 
> > On Wed, 2018-05-02 at 08:19 -0400, Jason E Bailey wrote:
> > > The sling query was my first attempt at following the release
> > > documentation and I failed to close out the repository before
> > > starting the content parser release.
> > > 
> > > Any suggestions on how I should handle this? I could close out both
> > > and restart the votes with separate repos.
> > > 
> > > - Jason
> > > 
> > > On Wed, May 2, 2018, at 3:08 AM, Robert Munteanu wrote:
> > > > On Tue, 2018-05-01 at 11:55 -0400, Jason E Bailey wrote:
> > > > > sh check_staged_release.sh 1897/tmp/sling-staging
> > > > 
> > > > That repo seems to be for a Sling Query release.
> > > > 
> > > > Robert
> > 

Re: [VOTE][CLOSED] Release Apache Sling Query version 4.0.2

[Jason E Bailey]

Combining votes into one since they share the same repo

- Jason

On Wed, May 2, 2018, at 3:18 AM, Robert Munteanu wrote:
> On Mon, 2018-04-30 at 12:03 -0400, Jason E Bailey wrote:
> > Please vote to approve this release:
> 
> +1
> 
> It would also be good to fix the versioning to not rely on the
> project's version for the next release
> 
> [WARNING] org.apache.sling.query: Excessive version increase; detected
> 4.0.2, suggested 4.0.0
> [WARNING] org.apache.sling.query: Version has been increased but
> analysis detected no changes; detected 4.0.2, suggested 4.0.0
> [WARNING] org.apache.sling.query.api: Excessive version increase;
> detected 4.0.2, suggested 4.0.0
> [WARNING] org.apache.sling.query.api: Version has been increased but
> analysis detected no changes; detected 4.0.2, suggested 4.0.0
> 
> Robert
> Email had 1 attachment:
> + signature.asc
>   1k (application/pgp-signature)

[VOTE] Release Apache Sling JCR Content Parser version 1.2.6 and Apache Sling Query version 4.0.2

[Jason E Bailey]

Hi,

This combines two releases

We solved 2 issues in this release of JCR Content Parser:
https://issues.apache.org/jira/projects/SLING/versions/12341009

We solved 3  issues in this release of Sling Query:
https://issues.apache.org/jira/projects/SLING/versions/12341713

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1897/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 1897 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

- Jason

--
Jason

Re: Subject: [VOTE] Release Apache Sling JCR Content Parser version 1.2.6

[Jason E Bailey]

Yes it does. I'll resend out the Vote to cover both

- Jason

On Wed, May 2, 2018, at 11:18 AM, Robert Munteanu wrote:
> Does this contain both artefacts? You can just start a vote for both in
> that case, no need to drop them.
> 
> Robert
> 
> On Wed, 2018-05-02 at 08:19 -0400, Jason E Bailey wrote:
> > The sling query was my first attempt at following the release
> > documentation and I failed to close out the repository before
> > starting the content parser release.
> > 
> > Any suggestions on how I should handle this? I could close out both
> > and restart the votes with separate repos.
> > 
> > - Jason
> > 
> > On Wed, May 2, 2018, at 3:08 AM, Robert Munteanu wrote:
> > > On Tue, 2018-05-01 at 11:55 -0400, Jason E Bailey wrote:
> > > > sh check_staged_release.sh 1897/tmp/sling-staging
> > > 
> > > That repo seems to be for a Sling Query release.
> > > 
> > > Robert
> 

Re: Subject: [VOTE] Release Apache Sling JCR Content Parser version 1.2.6

[Robert Munteanu]

Does this contain both artefacts? You can just start a vote for both in
that case, no need to drop them.

Robert

On Wed, 2018-05-02 at 08:19 -0400, Jason E Bailey wrote:
> The sling query was my first attempt at following the release
> documentation and I failed to close out the repository before
> starting the content parser release.
> 
> Any suggestions on how I should handle this? I could close out both
> and restart the votes with separate repos.
> 
> - Jason
> 
> On Wed, May 2, 2018, at 3:08 AM, Robert Munteanu wrote:
> > On Tue, 2018-05-01 at 11:55 -0400, Jason E Bailey wrote:
> > > sh check_staged_release.sh 1897/tmp/sling-staging
> > 
> > That repo seems to be for a Sling Query release.
> > 
> > Robert

Re: [Feature Model] Moving the Feature Model out of sling-whiteboard

[Bertrand Delacretaz]

On Wed, May 2, 2018 at 3:13 PM, David Bosschaert
 wrote:
> ...I have now added readme.md files to all feature model related repos. They
> are short and should definitely be expanded, but they might do for the
> 0.1.0 release...

Cool, thanks!

Should those README point to
https://github.com/apache/sling-org-apache-sling-feature as the source
of documentation?

If that's the idea I can make that change later today, unless you beat me to it!

Note that https://github.com/apache/sling-org-apache-sling-feature
doesn't show up in the "feature" group at
http://sling.apache.org/repolist.html due to the rules used to extract
groups - I don't think we want to change that logic, so if that
repository is meant as the entry point for documentation I think we
add links to those READMEs as it would be easy to miss that
repository.

-Bertrand

[jira] [Created] (SLING-7639) Enhance error message when additional script has erros

[Nicolas Peltier (JIRA)]

Nicolas Peltier created SLING-7639:
--

 Summary: Enhance error message when additional script has erros
 Key: SLING-7639
 URL: https://issues.apache.org/jira/browse/SLING-7639
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: pipes 2.0.2
Reporter: Nicolas Peltier


{{org.apache.sling.pipes.PipeBindings unable to execute ..blah.js}} is pretty 
useless...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [Feature Model] Moving the Feature Model out of sling-whiteboard

[David Bosschaert]

I have now added readme.md files to all feature model related repos. They
are short and should definitely be expanded, but they might do for the
0.1.0 release.

Best regards,

David

On 2 May 2018 at 11:40, David Bosschaert  wrote:

> Hi Bertrand,
>
> Good point. The original featuremodel component in the sling whiteboard
> had a readme which went to sling-org-apache-sling-feature.
> However the other repos don't have a readme yet.
>
> Best regards,
>
> David
>
> On 2 May 2018 at 10:49, Bertrand Delacretaz 
> wrote:
>
>> Hi,
>>
>> On Mon, Apr 30, 2018 at 12:32 PM, David Bosschaert
>>  wrote:
>> > With the Sling Feature Model now being outside of the Sling Whiteboard
>> in
>> > proper Git repositories, I'd like to do a an initial release of the
>> > following components some time soon...
>>
>> Do we have any documentation about that?
>>
>> There's some of that at
>> https://github.com/apache/sling-org-apache-sling-feature but unless I
>> missed something most of the new repositories don't even have a
>> README.
>>
>> I think we should have something before releasing, even if that's
>> minimal - at least a mention at
>> http://sling.apache.org/documentation/bundles.html which might link to
>> an informative README.
>>
>> I'm happy to help review those docs - I'm not familiar with the whole
>> thing so far so probably a good candidate ;-)
>>
>> -Bertrand
>>
>
>

[jira] [Created] (SLING-7638) Pipe binding expression instantiation failure should break the containing pipe

[Nicolas Peltier (JIRA)]

Nicolas Peltier created SLING-7638:
--

 Summary: Pipe binding expression instantiation failure should 
break the containing pipe
 Key: SLING-7638
 URL: https://issues.apache.org/jira/browse/SLING-7638
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: pipes 2.0.2
Reporter: Nicolas Peltier


now a failed expression instantation just take the source, which is always a 
problem, the pipe should rather fail



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Subject: [VOTE] Release Apache Sling JCR Content Parser version 1.2.6

[Jason E Bailey]

The sling query was my first attempt at following the release documentation and 
I failed to close out the repository before starting the content parser release.

Any suggestions on how I should handle this? I could close out both and restart 
the votes with separate repos.

- Jason

On Wed, May 2, 2018, at 3:08 AM, Robert Munteanu wrote:
> On Tue, 2018-05-01 at 11:55 -0400, Jason E Bailey wrote:
> > sh check_staged_release.sh 1897/tmp/sling-staging
> 
> That repo seems to be for a Sling Query release.
> 
> Robert

Re: [GSOC2018] Project Idea : Provide an OpenID Connect Authentication Handler

[Robert Munteanu]

On Wed, 2018-05-02 at 13:24 +0200, Bertrand Delacretaz wrote:
> Hi,
> 
> On Sat, Apr 28, 2018 at 9:35 PM, Hasini Witharana
>  wrote:
> > ...I have done some changes to the estimated schedule and end
> > deliverables
> > sections,...
> 
> One small but important thing, the deliverables should include
> contributing the implementation to Apache Sling.
> 
> Ideally (but I'll let Robert decide) the code should be developed in
> a
> Sling code repository, maybe
> https://github.com/apache/sling-whiteboard

That's a very good point, Bertrand. The code should be periodically
submitted as pull requests to the whiteboard repository.

Hasini - I suggest that you submit a pull request which just adds a
folder for your work and a README file to make sure everything works at
your end.

Robert

Failing Launchpad ITs

[Robert Munteanu]

Hi,

I took a stab at stabilizing the launchpad ITs but there still some
more work to be done.

There are some tests listed at [1] which capture the remaining work .
It would be great it someone could start looking into them. I don't
expect anything huge, maybe they are related to the recent changes
related to anonymous access and moving the starter content under a
specific path.

Thanks,

Robert


[1]: https://issues.apache.org/jira/issues/?jql=labels%20%3D%20sling-IT
%20and%20resolution%20is%20empty%20and%20(created%20%3E%3D%20%20%20%272
018%2F05%2F02%27%20and%20created%20%3C%20%20%20%272018%2F05%2F03%27%20)

[jira] [Created] (SLING-7637) PropertyRenderingTest fails

[Robert Munteanu (JIRA)]

Robert Munteanu created SLING-7637:
--

 Summary: PropertyRenderingTest fails
 Key: SLING-7637
 URL: https://issues.apache.org/jira/browse/SLING-7637
 Project: Sling
  Issue Type: Bug
  Components: Testing
Reporter: Robert Munteanu


org.apache.sling.launchpad.webapp.integrationtest.PropertyRenderingTest.testMultiValuedTextNoExt
 fails with 
{{http://localhost:41000/PropertyRenderingTest/1525143696194/this_is_a_test_15251/multiText
 expected:<403> but was:<404>}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7636) Some login ITs fail

[Robert Munteanu (JIRA)]

Robert Munteanu created SLING-7636:
--

 Summary: Some login ITs fail
 Key: SLING-7636
 URL: https://issues.apache.org/jira/browse/SLING-7636
 Project: Sling
  Issue Type: Bug
  Components: Testing
Reporter: Robert Munteanu


Some for the Login ITs fail

* 
org.apache.sling.launchpad.webapp.integrationtest.login.AuthRequestLoginTest.testForcedLogin
* 
org.apache.sling.launchpad.webapp.integrationtest.login.RedirectOnLoginErrorTest.testGetDefaultLoginPage
* 
org.apache.sling.launchpad.webapp.integrationtest.login.AnonymousAccessTest.testAnonymousContent

The common root cause seems to be not finding resources where expected:

* Expected 20x or 30x status, got 404
* http://localhost:41000/system/sling/login expected:<200> but was:<404>
* Expected status 200 for 
http://localhost:41000/AnonymousAccessTest/1525143663600/test_text_1525143663.txt



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-6313) Sling installer can duplicate factory configurations if an invalid RegisteredResourceList.ser is found

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460913#comment-16460913
 ] 

Carsten Ziegeler commented on SLING-6313:
-

Version 1.9.0 of Felix Config Admin supports the alias/named factory 
configurations

> Sling installer can duplicate factory configurations if an invalid 
> RegisteredResourceList.ser is found
> --
>
> Key: SLING-6313
> URL: https://issues.apache.org/jira/browse/SLING-6313
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Reporter: Robert Munteanu
>Priority: Major
> Attachments: SLING-6313-0.diff
>
>
> Steps to reproduce, inside `launchpad/builder`
> {noformat}
> mvn clean package
> java -jar target/org.apache.sling.launchpad-9-SNAPSHOT.jar
> # wait for Sling to start up properly, stop it with CTRL-C
> truncate --size=-1 sling/installer/RegisteredResourceList.ser
> java -jar target/org.apache.sling.launchpad-9-SNAPSHOT.jar
> # wait for Sling to start up properly, stop it with CTRL-C
> java -jar target/org.apache.sling.launchpad-9-SNAPSHOT.jar
> {noformat}
> The following exceptions are logged in the last run:
> {noformat}21.11.2016 14:32:26.538 *ERROR* [CM Configuration Updater 
> (ManagedServiceFactory Update: 
> factoryPid=[org.apache.sling.commons.log.LogManager.factory.config])] 
> org.apache.felix.configadmin Service 
> [org.apache.felix.cm.ConfigurationAdmin,28, 
> [org.osgi.service.cm.ConfigurationAdmin]] 
> [org.osgi.service.cm.ManagedServiceFactory, id=19, 
> bundle=8/slinginstall:org.apache.sling.commons.log-5.0.1-SNAPSHOT.jar]: 
> Updating property org.apache.sling.commons.log.names of configuration 
> org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9
>  caused a problem: Category log.request already defined by configuration 
> org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9
>  (org.osgi.service.cm.ConfigurationException: 
> org.apache.sling.commons.log.names : Category log.request already defined by 
> configuration 
> org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9)
> org.osgi.service.cm.ConfigurationException: 
> org.apache.sling.commons.log.names : Category log.request already defined by 
> configuration 
> org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9
>   at 
> org.apache.sling.commons.log.logback.internal.config.LoggerManagedServiceFactory.updated(LoggerManagedServiceFactory.java:36)
>   at 
> org.apache.felix.cm.impl.helper.ManagedServiceFactoryTracker.updated(ManagedServiceFactoryTracker.java:159)
>   at 
> org.apache.felix.cm.impl.helper.ManagedServiceFactoryTracker.provideConfiguration(ManagedServiceFactoryTracker.java:93)
>   at 
> org.apache.felix.cm.impl.ConfigurationManager$ManagedServiceFactoryUpdate.provide(ConfigurationManager.java:1611)
>   at 
> org.apache.felix.cm.impl.ConfigurationManager$ManagedServiceFactoryUpdate.run(ConfigurationManager.java:1554)
>   at org.apache.felix.cm.impl.UpdateThread.run0(UpdateThread.java:141)
>   at org.apache.felix.cm.impl.UpdateThread.run(UpdateThread.java:109)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: 
> org.apache.sling.commons.log.logback.internal.config.ConfigurationException: 
>   at 
> org.apache.sling.commons.log.logback.internal.LogConfigManager.updateLoggerConfiguration(LogConfigManager.java:533)
>   at 
> org.apache.sling.commons.log.logback.internal.config.LoggerManagedServiceFactory.updated(LoggerManagedServiceFactory.java:34)
>   ... 7 common frames omitted{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7635) UserPrivilegesInfoTest fails

[Robert Munteanu (JIRA)]

Robert Munteanu created SLING-7635:
--

 Summary: UserPrivilegesInfoTest fails
 Key: SLING-7635
 URL: https://issues.apache.org/jira/browse/SLING-7635
 Project: Sling
  Issue Type: Bug
  Components: Testing
Reporter: Robert Munteanu


The following tests consistently fail on Jenkins and locally:

* 
org.apache.sling.launchpad.webapp.integrationtest.userManager.UserPrivilegesInfoTest.testCanUpdateUserProperties
* 
org.apache.sling.launchpad.webapp.integrationtest.userManager.UserPrivilegesInfoTest.testCanUpdateGroupProperties
* 
org.apache.sling.launchpad.webapp.integrationtest.userManager.UserPrivilegesInfoTest.testCanRemoveGroup
* 
org.apache.sling.launchpad.webapp.integrationtest.userManager.UserPrivilegesInfoTest.testCanRemoveUser
* 
org.apache.sling.launchpad.webapp.integrationtest.userManager.UserPrivilegesInfoTest.testCanUpdateGroupMembers

The shared root error seems to be {{org.mozilla.javascript.EcmaError: 
TypeError: Cannot call method getID of undefined 
(/apps/sling/servlet/default/privileges-info.json.esp#27)}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-6313) Sling installer can duplicate factory configurations if an invalid RegisteredResourceList.ser is found

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460911#comment-16460911
 ] 

Konrad Windszus commented on SLING-6313:


Now that OSGi R7 has been released, can we take another stab at this? 
[~cziegeler] Which version of the configuration admin from Felix supports alias?

> Sling installer can duplicate factory configurations if an invalid 
> RegisteredResourceList.ser is found
> --
>
> Key: SLING-6313
> URL: https://issues.apache.org/jira/browse/SLING-6313
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Reporter: Robert Munteanu
>Priority: Major
> Attachments: SLING-6313-0.diff
>
>
> Steps to reproduce, inside `launchpad/builder`
> {noformat}
> mvn clean package
> java -jar target/org.apache.sling.launchpad-9-SNAPSHOT.jar
> # wait for Sling to start up properly, stop it with CTRL-C
> truncate --size=-1 sling/installer/RegisteredResourceList.ser
> java -jar target/org.apache.sling.launchpad-9-SNAPSHOT.jar
> # wait for Sling to start up properly, stop it with CTRL-C
> java -jar target/org.apache.sling.launchpad-9-SNAPSHOT.jar
> {noformat}
> The following exceptions are logged in the last run:
> {noformat}21.11.2016 14:32:26.538 *ERROR* [CM Configuration Updater 
> (ManagedServiceFactory Update: 
> factoryPid=[org.apache.sling.commons.log.LogManager.factory.config])] 
> org.apache.felix.configadmin Service 
> [org.apache.felix.cm.ConfigurationAdmin,28, 
> [org.osgi.service.cm.ConfigurationAdmin]] 
> [org.osgi.service.cm.ManagedServiceFactory, id=19, 
> bundle=8/slinginstall:org.apache.sling.commons.log-5.0.1-SNAPSHOT.jar]: 
> Updating property org.apache.sling.commons.log.names of configuration 
> org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9
>  caused a problem: Category log.request already defined by configuration 
> org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9
>  (org.osgi.service.cm.ConfigurationException: 
> org.apache.sling.commons.log.names : Category log.request already defined by 
> configuration 
> org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9)
> org.osgi.service.cm.ConfigurationException: 
> org.apache.sling.commons.log.names : Category log.request already defined by 
> configuration 
> org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9
>   at 
> org.apache.sling.commons.log.logback.internal.config.LoggerManagedServiceFactory.updated(LoggerManagedServiceFactory.java:36)
>   at 
> org.apache.felix.cm.impl.helper.ManagedServiceFactoryTracker.updated(ManagedServiceFactoryTracker.java:159)
>   at 
> org.apache.felix.cm.impl.helper.ManagedServiceFactoryTracker.provideConfiguration(ManagedServiceFactoryTracker.java:93)
>   at 
> org.apache.felix.cm.impl.ConfigurationManager$ManagedServiceFactoryUpdate.provide(ConfigurationManager.java:1611)
>   at 
> org.apache.felix.cm.impl.ConfigurationManager$ManagedServiceFactoryUpdate.run(ConfigurationManager.java:1554)
>   at org.apache.felix.cm.impl.UpdateThread.run0(UpdateThread.java:141)
>   at org.apache.felix.cm.impl.UpdateThread.run(UpdateThread.java:109)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: 
> org.apache.sling.commons.log.logback.internal.config.ConfigurationException: 
>   at 
> org.apache.sling.commons.log.logback.internal.LogConfigManager.updateLoggerConfiguration(LogConfigManager.java:533)
>   at 
> org.apache.sling.commons.log.logback.internal.config.LoggerManagedServiceFactory.updated(LoggerManagedServiceFactory.java:34)
>   ... 7 common frames omitted{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7634) Launchpad testing fails with Java 10

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-7634.

Resolution: Fixed

Fixed with [sling-org-apache-sling-launchpad-testing commit 
18e7c24|https://github.com/apache/sling-org-apache-sling-launchpad-testing/commit/18e7c24]


> Launchpad testing fails with Java 10
> 
>
> Key: SLING-7634
> URL: https://issues.apache.org/jira/browse/SLING-7634
> Project: Sling
>  Issue Type: Bug
>  Components: Build and Source Control
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Launchpad Testing 11
>
>
> It seems the version of the failsafe plugin we're using is not compatible 
> with Java 10:
> {noformat}[ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-failsafe-plugin:2.20.1:integration-test 
> (default) on project org.apache.sling.launchpad.testing: Execution default of 
> goal org.apache.maven.plugins:maven-failsafe-plugin:2.20.1:integration-test 
> failed. NullPointerException -> [Help 1]{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7634) Launchpad testing fails with Java 10

[Robert Munteanu (JIRA)]

Robert Munteanu created SLING-7634:
--

 Summary: Launchpad testing fails with Java 10
 Key: SLING-7634
 URL: https://issues.apache.org/jira/browse/SLING-7634
 Project: Sling
  Issue Type: Bug
  Components: Build and Source Control
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Launchpad Testing 11


It seems the version of the failsafe plugin we're using is not compatible with 
Java 10:

{noformat}[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-failsafe-plugin:2.20.1:integration-test 
(default) on project org.apache.sling.launchpad.testing: Execution default of 
goal org.apache.maven.plugins:maven-failsafe-plugin:2.20.1:integration-test 
failed. NullPointerException -> [Help 1]{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7544) Make optimized alias lookup non-blocking

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-7544:
---
Fix Version/s: Resource Resolver 1.6.2

> Make optimized alias lookup non-blocking
> 
>
> Key: SLING-7544
> URL: https://issues.apache.org/jira/browse/SLING-7544
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.5.36
>Reporter: Dominik Süß
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Resource Resolver 1.6.2
>
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> The implementation of optimized alias lookup as introduced with SLING-2521 
> blocks CommonResourceResolver activation while loading aliases to fillup the 
> aliasmap. In case a corresponding index is not present yet this can lead to 
> full tree traversal while indexing is doing the same in the background.
> The proposed improvements are:
> * making loading of the aliasmap happen asynchronously
> * only use optimized handling as soon as aliasmap is built
> * wait for non traversal index (optional - forced by default, can be turned 
> off for small datasets)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [GSOC2018] Project Idea : Provide an OpenID Connect Authentication Handler

[Robert Munteanu]

On Sun, 2018-04-29 at 01:05 +0530, Hasini Witharana wrote:
> Hi Robert,
> 
> I have done some changes to the estimated schedule and end
> deliverables
> sections, in the  proposal[1]. Please review and give your comments.
> 
> [1] -
> https://docs.google.com/document/d/1ki_mv_ngtMFsP2cqZkVfZfAYLAYle6M5S
> rs0WsgHXEs/edit?usp=sharing

Looks good overall. I would suggest moving the next iteration on the
Apache Sling Wiki at https://cwiki.apache.org/confluence/display/SLING/
 - please send me your username and I'll grant you the necessary
rights.

Also for the next iteration it would be good to understand what kind of
testing you had in mind ( unit tests based on Mocks, integration
testing based on 'live' servers, etc ).

Robert

> 
> Thank you.
> 
> On Fri, Apr 27, 2018 at 4:54 PM, Robert Munteanu 
> wrote:
> 
> > Hi Hasini,
> > 
> > On Fri, 2018-04-27 at 00:37 +0530, Hasini Witharana wrote:
> > > Hi all,
> > > 
> > > In OpenID Connect flow there are three main parties.
> > > 
> > >1. End-User - Resource owner
> > >2. OpenID Connect Provider - Authorization Server that is
> > > capable
> > > of
> > >authenticating the End-User and providing claims to a Relying
> > > Party about
> > >the Authentication event and the End-User
> > >3. Relying Party - A client requiring End-User Authentication
> > > and
> > > Claims
> > >from an OpenID Connect Provider.
> > > 
> > > When considering the OIDC flow, does sling act as an OpenID
> > > Connect
> > > provider or a relying party?
> > 
> > 
> > Sling IMO should act as a relying party.
> > 
> > Robert
> > 
> 
> 
> 

Re: [GSOC2018] Project Idea : Provide an OpenID Connect Authentication Handler

[Bertrand Delacretaz]

Hi,

On Sat, Apr 28, 2018 at 9:35 PM, Hasini Witharana
 wrote:
> ...I have done some changes to the estimated schedule and end deliverables
> sections,...

One small but important thing, the deliverables should include
contributing the implementation to Apache Sling.

Ideally (but I'll let Robert decide) the code should be developed in a
Sling code repository, maybe
https://github.com/apache/sling-whiteboard

-Bertrand

[jira] [Comment Edited] (SLING-7544) Make optimized alias lookup non-blocking

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460888#comment-16460888
 ] 

Robert Munteanu edited comment on SLING-7544 at 5/2/18 11:21 AM:
-

[~dsuess] - we get Jenkins failures after applying the patch, can you please 
look into it? I also get failures randomly when building the project locally - 
sometimes it works, sometimes it does not.


was (Author: rombert):
[~dsuess] - we get Jenkins failures after applying the patch, can you please 
look into it?

> Make optimized alias lookup non-blocking
> 
>
> Key: SLING-7544
> URL: https://issues.apache.org/jira/browse/SLING-7544
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.5.36
>Reporter: Dominik Süß
>Assignee: Robert Munteanu
>Priority: Major
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> The implementation of optimized alias lookup as introduced with SLING-2521 
> blocks CommonResourceResolver activation while loading aliases to fillup the 
> aliasmap. In case a corresponding index is not present yet this can lead to 
> full tree traversal while indexing is doing the same in the background.
> The proposed improvements are:
> * making loading of the aliasmap happen asynchronously
> * only use optimized handling as soon as aliasmap is built
> * wait for non traversal index (optional - forced by default, can be turned 
> off for small datasets)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SLING-7544) Make optimized alias lookup non-blocking

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-7544:
--

Assignee: Robert Munteanu

> Make optimized alias lookup non-blocking
> 
>
> Key: SLING-7544
> URL: https://issues.apache.org/jira/browse/SLING-7544
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.5.36
>Reporter: Dominik Süß
>Assignee: Robert Munteanu
>Priority: Major
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> The implementation of optimized alias lookup as introduced with SLING-2521 
> blocks CommonResourceResolver activation while loading aliases to fillup the 
> aliasmap. In case a corresponding index is not present yet this can lead to 
> full tree traversal while indexing is doing the same in the background.
> The proposed improvements are:
> * making loading of the aliasmap happen asynchronously
> * only use optimized handling as soon as aliasmap is built
> * wait for non traversal index (optional - forced by default, can be turned 
> off for small datasets)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7544) Make optimized alias lookup non-blocking

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460888#comment-16460888
 ] 

Robert Munteanu commented on SLING-7544:


[~dsuess] - we get Jenkins failures after applying the patch, can you please 
look into it?

> Make optimized alias lookup non-blocking
> 
>
> Key: SLING-7544
> URL: https://issues.apache.org/jira/browse/SLING-7544
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.5.36
>Reporter: Dominik Süß
>Assignee: Robert Munteanu
>Priority: Major
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> The implementation of optimized alias lookup as introduced with SLING-2521 
> blocks CommonResourceResolver activation while loading aliases to fillup the 
> aliasmap. In case a corresponding index is not present yet this can lead to 
> full tree traversal while indexing is doing the same in the background.
> The proposed improvements are:
> * making loading of the aliasmap happen asynchronously
> * only use optimized handling as soon as aliasmap is built
> * wait for non traversal index (optional - forced by default, can be turned 
> off for small datasets)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] rombert closed pull request #5: SLING-7544 - improving optimized alias lookup to not block during int…

[GitBox]

rombert closed pull request #5: SLING-7544 - improving optimized alias lookup 
to not block during int…
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/5
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/src/main/java/org/apache/sling/resourceresolver/impl/CommonResourceResolverFactoryImpl.java
 
b/src/main/java/org/apache/sling/resourceresolver/impl/CommonResourceResolverFactoryImpl.java
index 8cef27d..5db22d5 100644
--- 
a/src/main/java/org/apache/sling/resourceresolver/impl/CommonResourceResolverFactoryImpl.java
+++ 
b/src/main/java/org/apache/sling/resourceresolver/impl/CommonResourceResolverFactoryImpl.java
@@ -537,4 +537,14 @@ public void close() {
 }
 }
 }
+
+   @Override
+   public boolean isAliasMapInitialized() {
+   return mapEntries.isAliasMapInitialized();
+   }
+
+   @Override
+   public boolean isForceNoAliasTraversal() {
+   return this.activator.isForceNoAliasTraversal();
+   }
 }
\ No newline at end of file
diff --git 
a/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryActivator.java
 
b/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryActivator.java
index 5984363..03f6870 100644
--- 
a/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryActivator.java
+++ 
b/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryActivator.java
@@ -196,6 +196,10 @@ public boolean isVanityPathEnabled() {
 public boolean isOptimizeAliasResolutionEnabled() {
 return this.config.resource_resolver_optimize_alias_resolution();
 }
+
+   public boolean isForceNoAliasTraversal() {
+   return  this.config.force_no_alias_traversal();
+   }
 
 public boolean isLogUnclosedResourceResolvers() {
 return this.config.resource_resolver_log_unclosed();
diff --git 
a/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryConfig.java
 
b/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryConfig.java
index a0aa53f..360a864 100644
--- 
a/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryConfig.java
+++ 
b/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryConfig.java
@@ -148,6 +148,12 @@
  " the alias resolution by creating an internal cache of 
aliases. This might have an impact on the startup time"+
  " and on the alias update time if the number of aliases 
is huge (over 1).")
 boolean resource_resolver_optimize_alias_resolution() default true;
+
+
+@AttributeDefinition(name = "Force no traversal for optimized alias 
lookup",
+description = "When enabled the lookup of alias map for optimized 
resolution enforces retry until an index is present"+
+ "and does not traverse repository.")
+   boolean force_no_alias_traversal() default true;
 
 @AttributeDefinition(name = "Allowed Vanity Path Location",
 description ="This setting can contain a list of path prefixes, e.g. 
/libs/, /content/. If " +
diff --git 
a/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java
 
b/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java
index 66eba96..75d35ed 100644
--- 
a/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java
+++ 
b/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java
@@ -474,7 +474,7 @@ public String map(final HttpServletRequest request, final 
String resourcePath) {
 while (path != null) {
 String alias = null;
 if (current != null && !path.endsWith(JCR_CONTENT_LEAF)) {
-if (factory.isOptimizeAliasResolutionEnabled()) {
+if (factory.isOptimizeAliasResolutionEnabled() && 
factory.isAliasMapInitialized()) {
 logger.debug("map: Optimize Alias Resolution is 
Enabled");
 String parentPath = ResourceUtil.getParent(path);
 if (parentPath != null) {
@@ -987,7 +987,7 @@ private Resource getChildInternal(final Resource parent, 
final String childName)
 
 // we do not have a child with the exact name, so we look for
 // a child, whose alias matches the childName
-if (factory.isOptimizeAliasResolutionEnabled()){
+if (factory.isOptimizeAliasResolutionEnabled() && 
factory.isAliasMapInitialized()){
 logger.debug("getChildInternal: Optimize Alias Resolution is 
Enabled");
 //optimization made in SLING-2521
 final Map 

[GitHub] rombert commented on issue #5: SLING-7544 - improving optimized alias lookup to not block during int…

[GitBox]

rombert commented on issue #5: SLING-7544 - improving optimized alias lookup to 
not block during int…
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/5#issuecomment-385941792
 
 
   Applied, thanks for the contribution @DominikSuess !


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on a change in pull request #5: SLING-7544 - improving optimized alias lookup to not block during int…

[GitBox]

rombert commented on a change in pull request #5: SLING-7544 - improving 
optimized alias lookup to not block during int…
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/5#discussion_r185460563
 
 

 ##
 File path: 
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java
 ##
 @@ -189,10 +199,16 @@ protected void doInit() {
 
 final Map newResolveMapsMap = new 
ConcurrentHashMap<>();
 
+isAliasMapInitialized = false;
 //optimization made in SLING-2521
 if (this.factory.isOptimizeAliasResolutionEnabled()) {
-final Map> aliasMap = 
this.loadAliases(resolver);
-this.aliasMap = aliasMap;
+   aliasTraversal = new Thread(new Runnable(){
+   public void run() {
+   aliasMap = loadAliases(resolver);
+   isAliasMapInitialized = true;
+   }
+   });
+   aliasTraversal.start();
 
 Review comment:
   Ah right. Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DominikSuess commented on a change in pull request #5: SLING-7544 - improving optimized alias lookup to not block during int…

[GitBox]

DominikSuess commented on a change in pull request #5: SLING-7544 - improving 
optimized alias lookup to not block during int…
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/5#discussion_r185459377
 
 

 ##
 File path: 
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java
 ##
 @@ -189,10 +199,16 @@ protected void doInit() {
 
 final Map newResolveMapsMap = new 
ConcurrentHashMap<>();
 
+isAliasMapInitialized = false;
 //optimization made in SLING-2521
 if (this.factory.isOptimizeAliasResolutionEnabled()) {
-final Map> aliasMap = 
this.loadAliases(resolver);
-this.aliasMap = aliasMap;
+   aliasTraversal = new Thread(new Runnable(){
+   public void run() {
+   aliasMap = loadAliases(resolver);
+   isAliasMapInitialized = true;
+   }
+   });
+   aliasTraversal.start();
 
 Review comment:
   @rombert  - the patch only affects the if block - in the other case none of 
the query based caching happens and nothing needs to be loaded.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on issue #5: SLING-7544 - improving optimized alias lookup to not block during int…

[GitBox]

rombert commented on issue #5: SLING-7544 - improving optimized alias lookup to 
not block during int…
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/5#issuecomment-385938688
 
 
   @DominikSuess - there's still an open question at 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/5/files/51a0d36c39f1a59bbb99b8337ac99e727f8a6654#r184093639
 . Can you please answer?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [Feature Model] Moving the Feature Model out of sling-whiteboard

[David Bosschaert]

Hi Bertrand,

Good point. The original featuremodel component in the sling whiteboard had
a readme which went to sling-org-apache-sling-feature.
However the other repos don't have a readme yet.

Best regards,

David

On 2 May 2018 at 10:49, Bertrand Delacretaz  wrote:

> Hi,
>
> On Mon, Apr 30, 2018 at 12:32 PM, David Bosschaert
>  wrote:
> > With the Sling Feature Model now being outside of the Sling Whiteboard in
> > proper Git repositories, I'd like to do a an initial release of the
> > following components some time soon...
>
> Do we have any documentation about that?
>
> There's some of that at
> https://github.com/apache/sling-org-apache-sling-feature but unless I
> missed something most of the new repositories don't even have a
> README.
>
> I think we should have something before releasing, even if that's
> minimal - at least a mention at
> http://sling.apache.org/documentation/bundles.html which might link to
> an informative README.
>
> I'm happy to help review those docs - I'm not familiar with the whole
> thing so far so probably a good candidate ;-)
>
> -Bertrand
>

[GitHub] DominikSuess commented on a change in pull request #5: SLING-7544 - improving optimized alias lookup to not block during int…

[GitBox]

DominikSuess commented on a change in pull request #5: SLING-7544 - improving 
optimized alias lookup to not block during int…
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/5#discussion_r185453659
 
 

 ##
 File path: 
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java
 ##
 @@ -1027,16 +1052,51 @@ private boolean addEntry(final Map entryMap, final Strin
  */
 private Map> loadAliases(final 
ResourceResolver resolver) {
 final Map> map = new ConcurrentHashMap<>();
-final String queryString = "SELECT sling:alias FROM nt:base WHERE 
sling:alias IS NOT NULL";
-final Iterator i = resolver.findResources(queryString, 
"sql");
-while (i.hasNext()) {
-final Resource resource = i.next();
-loadAlias(resource, map);
-}
+String queryString = "SELECT sling:alias FROM nt:base WHERE 
sling:alias IS NOT NULL";
+   if (this.factory.isForceNoAliasTraversal()) {
+   queryString += " option(traversal fail)";
+   }
+   while (true){
+   try {
+   final Iterator i = 
resolver.findResources(queryString, "sql");
+   while (i.hasNext()) {
+   final Resource resource = i.next();
+   loadAlias(resource, map);
+   }
+   break;
+   } catch (QuerySyntaxException e) {
+   Throwable cause = unwrapThrowable(e);
+   if (cause instanceof IllegalArgumentException) {
 
 Review comment:
   @catholicon  ok I constrained it to check for the right query to be used so 
the retry behavior will only kick in when the corresponding query is active.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (SLING-7633) make Sling work without JCR locking

[Julian Reschke (JIRA)]

Julian Reschke created SLING-7633:
-

 Summary: make Sling work without JCR locking
 Key: SLING-7633
 URL: https://issues.apache.org/jira/browse/SLING-7633
 Project: Sling
  Issue Type: Improvement
  Components: JCR
Reporter: Julian Reschke


The Oak team is planning to phase out JCR locking (see 
). This means that at some 
point the repository will start to throw exceptions when trying to lock nodes, 
and the repository descriptors will say that locking is not supported.

As part of , we have added 
logging for lock related calls (see 
org.apache.jackrabbit.oak.jcr.lock.LockDeprecation) so that we can identify 
callers.

One early find was: 






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-3524) ResourceResolver.clone(null) should not share the same JCR session

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460809#comment-16460809
 ] 

Carsten Ziegeler commented on SLING-3524:
-

Thanks for picking this up, I haven't looked at the JCR part of the patch, but 
I agree that this needs adding something to the API for a provider to be picked 
up. I think the resource resolver implementation should also clear this new 
property from a user provided map if clone is not used. Just to avoid that a 
user accidentally is putting such a property in the map

> ResourceResolver.clone(null) should not share the same JCR session
> --
>
> Key: SLING-3524
> URL: https://issues.apache.org/jira/browse/SLING-3524
> Project: Sling
>  Issue Type: Improvement
>  Components: API, JCR, ResourceResolver
>Affects Versions: Resource Resolver 1.0.6
>Reporter: Alexander Klimetschek
>Priority: Major
> Fix For: API 2.18.2, JCR Resource 3.0.10, Resource Resolver 1.6.2
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> {{ResourceResolver.clone()}} will reuse the same JCR session in case it was 
> created by passing an existing session using 
> {{JcrResourceConstants.AUTHENTICATION_INFO_SESSION}}. If you need a clone of 
> the resource resolver to pass into a new, separate thread, and use 
> {{ResourceResolver.clone(null)}}, you will actually share the session, but 
> this is not obvious. The problem is that a JCR session cannot be shared 
> across threads.
> The javadocs of clone() say "the same credential data is used as was used to 
> create this instance".
> There are a few problems with this:
> - seeing the session object itself as "credential data" is unintuitive
> - in my code, I have no idea what the original credential data was, so I 
> don't know what kind of credential data it was to make the right decision
> - since sharing a JCR session is to be avoided at all times, the resource 
> resolver should prevent one from this
> A solution would be if a plain {{ResourceResolver.clone(null)}} would return 
> a session that impersonated itself, abstracting this from the resource 
> resolver user. Additionally, it might be worth looking that clone always 
> returns a new session, unless specifically stated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-3524) ResourceResolver.clone(null) should not share the same JCR session

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-3524:

Fix Version/s: Resource Resolver 1.6.2
   JCR Resource 3.0.10
   API 2.18.2

> ResourceResolver.clone(null) should not share the same JCR session
> --
>
> Key: SLING-3524
> URL: https://issues.apache.org/jira/browse/SLING-3524
> Project: Sling
>  Issue Type: Improvement
>  Components: API, JCR, ResourceResolver
>Affects Versions: Resource Resolver 1.0.6
>Reporter: Alexander Klimetschek
>Priority: Major
> Fix For: API 2.18.2, JCR Resource 3.0.10, Resource Resolver 1.6.2
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> {{ResourceResolver.clone()}} will reuse the same JCR session in case it was 
> created by passing an existing session using 
> {{JcrResourceConstants.AUTHENTICATION_INFO_SESSION}}. If you need a clone of 
> the resource resolver to pass into a new, separate thread, and use 
> {{ResourceResolver.clone(null)}}, you will actually share the session, but 
> this is not obvious. The problem is that a JCR session cannot be shared 
> across threads.
> The javadocs of clone() say "the same credential data is used as was used to 
> create this instance".
> There are a few problems with this:
> - seeing the session object itself as "credential data" is unintuitive
> - in my code, I have no idea what the original credential data was, so I 
> don't know what kind of credential data it was to make the right decision
> - since sharing a JCR session is to be avoided at all times, the resource 
> resolver should prevent one from this
> A solution would be if a plain {{ResourceResolver.clone(null)}} would return 
> a session that impersonated itself, abstracting this from the resource 
> resolver user. Additionally, it might be worth looking that clone always 
> returns a new session, unless specifically stated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-3524) ResourceResolver.clone(null) should not share the same JCR session

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-3524:

Component/s: API

> ResourceResolver.clone(null) should not share the same JCR session
> --
>
> Key: SLING-3524
> URL: https://issues.apache.org/jira/browse/SLING-3524
> Project: Sling
>  Issue Type: Improvement
>  Components: API, JCR, ResourceResolver
>Affects Versions: Resource Resolver 1.0.6
>Reporter: Alexander Klimetschek
>Priority: Major
> Fix For: API 2.18.2, JCR Resource 3.0.10, Resource Resolver 1.6.2
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> {{ResourceResolver.clone()}} will reuse the same JCR session in case it was 
> created by passing an existing session using 
> {{JcrResourceConstants.AUTHENTICATION_INFO_SESSION}}. If you need a clone of 
> the resource resolver to pass into a new, separate thread, and use 
> {{ResourceResolver.clone(null)}}, you will actually share the session, but 
> this is not obvious. The problem is that a JCR session cannot be shared 
> across threads.
> The javadocs of clone() say "the same credential data is used as was used to 
> create this instance".
> There are a few problems with this:
> - seeing the session object itself as "credential data" is unintuitive
> - in my code, I have no idea what the original credential data was, so I 
> don't know what kind of credential data it was to make the right decision
> - since sharing a JCR session is to be avoided at all times, the resource 
> resolver should prevent one from this
> A solution would be if a plain {{ResourceResolver.clone(null)}} would return 
> a session that impersonated itself, abstracting this from the resource 
> resolver user. Additionally, it might be worth looking that clone always 
> returns a new session, unless specifically stated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] DominikSuess commented on issue #5: SLING-7544 - improving optimized alias lookup to not block during int…

[GitBox]

DominikSuess commented on issue #5: SLING-7544 - improving optimized alias 
lookup to not block during int…
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/5#issuecomment-385928531
 
 
   @catholicon , @rombert  added corresponding logic to warn and automatically 
fall back to the query without traversal fail in case engine not capable of 
parsing the option (crosschecked with older versions - lowest cause always was 
ParseException  before the options got introduced).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [Feature Model] Moving the Feature Model out of sling-whiteboard

[Bertrand Delacretaz]

Hi,

On Mon, Apr 30, 2018 at 12:32 PM, David Bosschaert
 wrote:
> With the Sling Feature Model now being outside of the Sling Whiteboard in
> proper Git repositories, I'd like to do a an initial release of the
> following components some time soon...

Do we have any documentation about that?

There's some of that at
https://github.com/apache/sling-org-apache-sling-feature but unless I
missed something most of the new repositories don't even have a
README.

I think we should have something before releasing, even if that's
minimal - at least a mention at
http://sling.apache.org/documentation/bundles.html which might link to
an informative README.

I'm happy to help review those docs - I'm not familiar with the whole
thing so far so probably a good candidate ;-)

-Bertrand

[jira] [Created] (SLING-7632) Pipe Execution Result should show an error list

[Nicolas Peltier (JIRA)]

Nicolas Peltier created SLING-7632:
--

 Summary: Pipe Execution Result should show an error list
 Key: SLING-7632
 URL: https://issues.apache.org/jira/browse/SLING-7632
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: pipes 2.0.2
Reporter: Nicolas Peltier


While not breaking the pipe execution at the first issue encountered is 
important in a production world when a content exception should/could be 
handled separately. Errors happening are "only" happening on logs. 
They should be tracked in the execution result as well, with path excerpt, and 
total #, with same limit as for results. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7630) Sling IDE Tooling OSGi Component should provide Constructor for References

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460619#comment-16460619
 ] 

Robert Munteanu commented on SLING-7630:


Yes, would be great to ensure they are usable OOTB in non-OSGi environments. I 
would suggest setters rather than constructor injection since it keeps the same 
behaviour as the OSGi ones - for now we don't have constructor injection via 
SCR in Eclipse ( added via OSGi R7 IIRC ).


> Sling IDE Tooling OSGi Component should provide Constructor for References
> --
>
> Key: SLING-7630
> URL: https://issues.apache.org/jira/browse/SLING-7630
> Project: Sling
>  Issue Type: Bug
>  Components: Tooling
>Reporter: Andreas Schaefer
>Priority: Major
>
> OSGi Components / Services should provide a Constructor for all OSGi 
> References to make sure IntelliJ and other non-OSGi container IDEs can 
> instantiate them properly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Release Apache Sling Query version 4.0.2

[Robert Munteanu]

On Mon, 2018-04-30 at 12:03 -0400, Jason E Bailey wrote:
> Please vote to approve this release:

+1

It would also be good to fix the versioning to not rely on the
project's version for the next release

[WARNING] org.apache.sling.query: Excessive version increase; detected
4.0.2, suggested 4.0.0
[WARNING] org.apache.sling.query: Version has been increased but
analysis detected no changes; detected 4.0.2, suggested 4.0.0
[WARNING] org.apache.sling.query.api: Excessive version increase;
detected 4.0.2, suggested 4.0.0
[WARNING] org.apache.sling.query.api: Version has been increased but
analysis detected no changes; detected 4.0.2, suggested 4.0.0

Robert

signature.asc
Description: This is a digitally signed message part

Re: Subject: [VOTE] Release Apache Sling JCR Content Parser version 1.2.6

[Robert Munteanu]

On Tue, 2018-05-01 at 11:55 -0400, Jason E Bailey wrote:
> sh check_staged_release.sh 1897/tmp/sling-staging

That repo seems to be for a Sling Query release.

Robert

[jira] [Commented] (SLING-7626) disclosure vulnerability affecting Apache Sling Servlets Post 2.3.6 and earlier versions

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460584#comment-16460584
 ] 

Robert Munteanu commented on SLING-7626:


[~andylin767] - can you clarify how the vulnerabilities affect the listed Sling 
artifacts? Our product deployments happen through the [sling 
starter|https://github.com/apache/sling-org-apache-sling-starter] and that has 
already been upgraded. POM dependencies don't qualify as vulnerabilities for 
that reason.

> disclosure vulnerability affecting Apache Sling Servlets Post 2.3.6 and 
> earlier versions
> 
>
> Key: SLING-7626
> URL: https://issues.apache.org/jira/browse/SLING-7626
> Project: Sling
>  Issue Type: Task
>Affects Versions: Testing JCR Mock 1.3.2, Servlet Helpers 1.1.4, Testing 
> Sling Mock 2.2.18
>Reporter: Andy
>Priority: Blocker
>
> There is a high security vulnerability from OWASP dependencies check scan 
> affecting Apache Sling Servlets Post 2.3.6 and earlier versions. Please 
> update to Apache Sling Servlets Post 2.3.8.
> This is the Adobe fixes for reference, but the following modules need to 
> address this
> https://helpx.adobe.com/security/products/experience-manager/apsb16-05.html 
> org.apache.sling.servlet-helpers-1.1.4.jar
> org.apache.sling.testing.sling-mock-2.2.18.jar
> org.apache.sling.testing.jcr-mock-1.3.2.jar
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7631) Wrong log debug statement in ResourceResolverImpl

[Antonio Sanso (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Antonio Sanso updated SLING-7631:
-
Fix Version/s: (was: Resource Resolver 1.6.0)
   Resource Resolver 1.6.2

> Wrong log debug statement in ResourceResolverImpl
> -
>
> Key: SLING-7631
> URL: https://issues.apache.org/jira/browse/SLING-7631
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Reporter: Antonio Sanso
>Assignee: Antonio Sanso
>Priority: Minor
> Fix For: Resource Resolver 1.6.2
>
>
> There is a wrong log debug statement in {{ResourceResolverImpl#map}} in [0]
> {code:java}
> logger.debug("resolve: MapEntry {} matches, mapped path is {}", mapEntry, 
> mappedPath);{code}
> it should be 
> {code:java}
> logger.debug("map: MapEntry {} matches, mapped path is {}", mapEntry, 
> mappedPath);{code}
> [0] 
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java#L568



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7631) Wrong log debug statement in ResourceResolverImpl

[Antonio Sanso (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Antonio Sanso resolved SLING-7631.
--
   Resolution: Fixed
Fix Version/s: Resource Resolver 1.6.0

> Wrong log debug statement in ResourceResolverImpl
> -
>
> Key: SLING-7631
> URL: https://issues.apache.org/jira/browse/SLING-7631
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Reporter: Antonio Sanso
>Assignee: Antonio Sanso
>Priority: Minor
> Fix For: Resource Resolver 1.6.0
>
>
> There is a wrong log debug statement in {{ResourceResolverImpl#map}} in [0]
> {code:java}
> logger.debug("resolve: MapEntry {} matches, mapped path is {}", mapEntry, 
> mappedPath);{code}
> it should be 
> {code:java}
> logger.debug("map: MapEntry {} matches, mapped path is {}", mapEntry, 
> mappedPath);{code}
> [0] 
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java#L568



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7631) Wrong log debug statement in ResourceResolverImpl

[Antonio Sanso (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460578#comment-16460578
 ] 

Antonio Sanso commented on SLING-7631:
--

fixed in rev. 31d72ce..2a87d59

> Wrong log debug statement in ResourceResolverImpl
> -
>
> Key: SLING-7631
> URL: https://issues.apache.org/jira/browse/SLING-7631
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Reporter: Antonio Sanso
>Assignee: Antonio Sanso
>Priority: Minor
>
> There is a wrong log debug statement in {{ResourceResolverImpl#map}} in [0]
> {code:java}
> logger.debug("resolve: MapEntry {} matches, mapped path is {}", mapEntry, 
> mappedPath);{code}
> it should be 
> {code:java}
> logger.debug("map: MapEntry {} matches, mapped path is {}", mapEntry, 
> mappedPath);{code}
> [0] 
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java#L568



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7631) Wrong log debug statement in ResourceResolverImpl

[Antonio Sanso (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Antonio Sanso updated SLING-7631:
-
Component/s: ResourceResolver

> Wrong log debug statement in ResourceResolverImpl
> -
>
> Key: SLING-7631
> URL: https://issues.apache.org/jira/browse/SLING-7631
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Reporter: Antonio Sanso
>Assignee: Antonio Sanso
>Priority: Minor
>
> There is a wrong log debug statement in {{ResourceResolverImpl#map}} in [0]
> {code:java}
> logger.debug("resolve: MapEntry {} matches, mapped path is {}", mapEntry, 
> mappedPath);{code}
> it should be 
> {code:java}
> logger.debug("map: MapEntry {} matches, mapped path is {}", mapEntry, 
> mappedPath);{code}
> [0] 
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java#L568



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SLING-7631) Wrong log debug statement in ResourceResolverImpl

[Antonio Sanso (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Antonio Sanso reassigned SLING-7631:


Assignee: Antonio Sanso

> Wrong log debug statement in ResourceResolverImpl
> -
>
> Key: SLING-7631
> URL: https://issues.apache.org/jira/browse/SLING-7631
> Project: Sling
>  Issue Type: Bug
>Reporter: Antonio Sanso
>Assignee: Antonio Sanso
>Priority: Minor
>
> There is a wrong log debug statement in {{ResourceResolverImpl#map}} in [0]
> {code:java}
> logger.debug("resolve: MapEntry {} matches, mapped path is {}", mapEntry, 
> mappedPath);{code}
> it should be 
> {code:java}
> logger.debug("map: MapEntry {} matches, mapped path is {}", mapEntry, 
> mappedPath);{code}
> [0] 
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java#L568



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7631) Wrong log debug statement in ResourceResolverImpl

[Antonio Sanso (JIRA)]

Antonio Sanso created SLING-7631:


 Summary: Wrong log debug statement in ResourceResolverImpl
 Key: SLING-7631
 URL: https://issues.apache.org/jira/browse/SLING-7631
 Project: Sling
  Issue Type: Bug
Reporter: Antonio Sanso


There is a wrong log debug statement in {{ResourceResolverImpl#map}} in [0]
{code:java}
logger.debug("resolve: MapEntry {} matches, mapped path is {}", mapEntry, 
mappedPath);{code}
it should be 
{code:java}
logger.debug("map: MapEntry {} matches, mapped path is {}", mapEntry, 
mappedPath);{code}
[0] 
https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java#L568



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)