Re: [Dev] Requesting browser cookie from Sling Servlets.

2018-06-25 Thread Robert Munteanu
On Mon, 2018-06-25 at 15:56 +0530, Hasini Witharana wrote: > > > > So then you could set a third-party cookie from Sling, i.e. a > cookie > > that is set for a different domain, matching whathever the google > auth > > endpoint is. Would that work? > > > > I tested with the setCookie method and

[jira] [Commented] (SLING-7684) Add Badges to GitHub Repo Readmes

2018-06-25 Thread Dan Klco (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522318#comment-16522318 ] Dan Klco commented on SLING-7684: - [~bdelacretaz] Strange, it seems like this is something GitHub is

[jira] [Comment Edited] (SLING-7754) Implement passive DistributionQueue in JCR

2018-06-25 Thread Marius Petria (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522146#comment-16522146 ] Marius Petria edited comment on SLING-7754 at 6/25/18 11:12 AM:

[jira] [Commented] (SLING-7754) Implement passive DistributionQueue in JCR

2018-06-25 Thread Bertrand Delacretaz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522259#comment-16522259 ] Bertrand Delacretaz commented on SLING-7754: Thanks Tim, DistributionQueue looks ok at first

Re: New "capabilities" module, feedback welcome

2018-06-25 Thread Julian Sedding
Regarding securing the servlet: Registering a servlet in Sling creates resources. In the case of the capabilities servlet, that should be the resource "/libs/sling/capabilities.json.GET.servlet". Since the "Resource Access Security" module allows restricting read access to resources, this could

[jira] [Commented] (SLING-7684) Add Badges to GitHub Repo Readmes

2018-06-25 Thread Bertrand Delacretaz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522325#comment-16522325 ] Bertrand Delacretaz commented on SLING-7684: {quote} ...So I guess the question is, is it

[jira] [Commented] (SLING-7754) Implement passive DistributionQueue in JCR

2018-06-25 Thread Timothee Maret (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522247#comment-16522247 ] Timothee Maret commented on SLING-7754: --- [~bdelacretaz], [~mpetria] I think the

[jira] [Updated] (SLING-7751) Commons Html - Underlying parser implementation uses system charset

2018-06-25 Thread Jason E Bailey (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-7751: -- Priority: Minor (was: Major) Issue Type: Improvement (was: Bug) > Commons Html -

[jira] [Updated] (SLING-7754) Implement passive DistributionQueue in JCR

2018-06-25 Thread Marius Petria (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marius Petria updated SLING-7754: - Description: In order to minimize dependency on Sling Jobs and improve performance we should

[jira] [Commented] (SLING-7754) Implement passive DistributionQueue in JCR

2018-06-25 Thread Bertrand Delacretaz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522160#comment-16522160 ] Bertrand Delacretaz commented on SLING-7754: Ok, thanks for clarifying! I think we've been

[jira] [Updated] (SLING-7754) Implement passive DistributionQueue in JCR

2018-06-25 Thread Marius Petria (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marius Petria updated SLING-7754: - Summary: Implement passive DistributionQueue in JCR (was: Implement passive queues in JCR) >

[jira] [Commented] (SLING-7754) Implement passive queues in JCR

2018-06-25 Thread Marius Petria (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522146#comment-16522146 ] Marius Petria commented on SLING-7754: -- [~bdelacretaz] this is a feature for Sling Content

[GitHub] cschneider commented on issue #2: Sling 7612

2018-06-25 Thread GitBox
cschneider commented on issue #2: Sling 7612 URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/2#issuecomment-399951809 @bdelacretaz There was positive feedback on the mailing list. Can we go forward with this?

[jira] [Commented] (SLING-7751) Commons Html - Underlying parser implementation uses system charset

2018-06-25 Thread Jason E Bailey (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522389#comment-16522389 ] Jason E Bailey commented on SLING-7751: --- Issue only occurs if no char encoding is set on the

[jira] [Resolved] (SLING-7751) Commons Html - Underlying parser implementation uses system charset

2018-06-25 Thread Jason E Bailey (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey resolved SLING-7751. --- Resolution: Fixed > Commons Html - Underlying parser implementation uses system charset >

Re: New "capabilities" module, feedback welcome

2018-06-25 Thread Bertrand Delacretaz
Hi Radu, On Fri, Jun 22, 2018 at 3:03 PM Radu Cotescu wrote: > ...So what we could do is to combine the two ideas: > > Have > /sling/operations > resourceType1 > ACLs / CUG [0] > resourceType2 > ACLs / CUG

[jira] [Comment Edited] (SLING-7751) Commons Html - Underlying parser implementation uses system charset

2018-06-25 Thread Jason E Bailey (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522389#comment-16522389 ] Jason E Bailey edited comment on SLING-7751 at 6/25/18 2:57 PM: Issue

Re: New "capabilities" module, feedback welcome

2018-06-25 Thread Bertrand Delacretaz
Hi Julian, On Mon, Jun 25, 2018 at 3:38 PM Julian Sedding wrote: > Regarding securing the servlet: > Registering a servlet in Sling creates resources. In the case of the > capabilities servlet, that should be the resource > "/libs/sling/capabilities.json.GET.servlet". Since the "Resource >

Re: [VOTE] Release Apache Sling ContentLoader 2.2.6

2018-06-25 Thread Daniel Klco
Hey Jason, It doesn't look like the repository is closed: https://repository.apache.org/content/repositories/orgapachesling-1917/ Regards, Dan On Sun, Jun 24, 2018 at 2:35 PM Jason E Bailey wrote: > To: "Sling Developers List" > Subject: [VOTE] Release Apache Sling ABC version X.Y.Z > > Hi,

Re: [VOTE] Release Apache Sling ContentLoader 2.2.6

2018-06-25 Thread Jason E Bailey
Thanks for the catch, there was an error when it tried to close it the first time that I missed. This time the close attempt worked. - Jason On Mon, Jun 25, 2018, at 3:53 PM, Daniel Klco wrote: > Hey Jason, > > It doesn't look like the repository is closed: >

Re: [VOTE] Release Apache Sling ContentLoader 2.2.6

2018-06-25 Thread Daniel Klco
+1 On Mon, Jun 25, 2018 at 4:19 PM Jason E Bailey wrote: > Thanks for the catch, there was an error when it tried to close it the > first time that I missed. This time the close attempt worked. > > - Jason > > On Mon, Jun 25, 2018, at 3:53 PM, Daniel Klco wrote: > > Hey Jason, > > > > It

Re: [Dev] Requesting browser cookie from Sling Servlets.

2018-06-25 Thread Hasini Witharana
> > When the auth endpoint calls back to the relying party (authorization > code request) with a state parameter, we need to check that it is valid > against a particular user, right? But how do we identify that specific > user (in Apache Sling), since there is no authentication done? > We need

Re: [Dev] Requesting browser cookie from Sling Servlets.

2018-06-25 Thread Robert Munteanu
On Mon, 2018-06-25 at 15:30 +0530, Hasini Witharana wrote: > > > > When the auth endpoint calls back to the relying party > > (authorization > > code request) with a state parameter, we need to check that it is > > valid > > against a particular user, right? But how do we identify that > >

[jira] [Commented] (SLING-7754) Implement passive queues in JCR

2018-06-25 Thread Bertrand Delacretaz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522108#comment-16522108 ] Bertrand Delacretaz commented on SLING-7754: Could you clarify what you mean by "passive

Re: [Dev] Requesting browser cookie from Sling Servlets.

2018-06-25 Thread Hasini Witharana
> > 'Sent from the user' -> I assume that's sent from the user's browser, > but to whom? To the Authorization endpoint? And is that supposed to be > set by the Relying Party? > Sent from users's browser to Google's authorization endpoint. Relying party need to do the state validation hence I

Re: [Dev] Requesting browser cookie from Sling Servlets.

2018-06-25 Thread Robert Munteanu
On Mon, 2018-06-25 at 15:50 +0530, Hasini Witharana wrote: > > > > 'Sent from the user' -> I assume that's sent from the user's > browser, > > but to whom? To the Authorization endpoint? And is that supposed to > be > > set by the Relying Party? > > > > Sent from users's browser to Google's

Re: [Dev] Requesting browser cookie from Sling Servlets.

2018-06-25 Thread Hasini Witharana
> > So then you could set a third-party cookie from Sling, i.e. a cookie > that is set for a different domain, matching whathever the google auth > endpoint is. Would that work? > I tested with the setCookie method and the same cookie was returned from Google. So can I use that method? On Mon,

[jira] [Commented] (SLING-7752) Deserializing and serializing a feature model file suffles the configurations

2018-06-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521982#comment-16521982 ] ASF GitHub Bot commented on SLING-7752: --- rombert commented on issue #2: SLING-7752 - Deserializing

[GitHub] rombert commented on issue #2: SLING-7752 - Deserializing and serializing a feature model file suffles the configurations

2018-06-25 Thread GitBox
rombert commented on issue #2: SLING-7752 - Deserializing and serializing a feature model file suffles the configurations URL: https://github.com/apache/sling-org-apache-sling-feature/pull/2#issuecomment-399868731 > On the BW compatibility plugin and it not considering 0.x versions

[jira] [Commented] (SLING-7684) Add Badges to GitHub Repo Readmes

2018-06-25 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522007#comment-16522007 ] Julian Sedding commented on SLING-7684: --- Agree with Bertrand regarding readable image urls. It can

[GitHub] bosschaert commented on issue #2: SLING-7752 - Deserializing and serializing a feature model file suffles the configurations

2018-06-25 Thread GitBox
bosschaert commented on issue #2: SLING-7752 - Deserializing and serializing a feature model file suffles the configurations URL: https://github.com/apache/sling-org-apache-sling-feature/pull/2#issuecomment-399876857 Regarding the next version, I would increase the minor version to be

[jira] [Commented] (SLING-7752) Deserializing and serializing a feature model file suffles the configurations

2018-06-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522021#comment-16522021 ] ASF GitHub Bot commented on SLING-7752: --- bosschaert commented on issue #2: SLING-7752 -

[jira] [Created] (SLING-7754) Implement passive queues in JCR

2018-06-25 Thread Marius Petria (JIRA)
Marius Petria created SLING-7754: Summary: Implement passive queues in JCR Key: SLING-7754 URL: https://issues.apache.org/jira/browse/SLING-7754 Project: Sling Issue Type: Improvement

Re: [Dev] Requesting browser cookie from Sling Servlets.

2018-06-25 Thread Robert Munteanu
On Sat, 2018-06-23 at 00:28 +0530, Hasini Witharana wrote: > > > > The follow-up questions is what are you using it for? > > > > As I mentioned before the authorization request to Google, contains a > variable "state". After user is authenticated Google will send a > response > with attaching the