Re: rename sling-maven-sling-plugin git repo?

[Konrad Windszus]

This should be possible via INFRA. Compare e.g. with 
https://issues.apache.org/jira/browse/INFRA-16017?filter=-4=project%20%3D%20INFRA%20AND%20text%20~%20%22rename%20git%22%20order%20by%20created%20DESC

> Am 14.01.2019 um 20:53 schrieb Stefan Seifert :
> 
> should we rename the github repo as well to "sling-sling-maven-plugin"?
> 
> it would
> a) be more consistent and 
> b) fix auto-generated github links like on the download page [1] which is 
> currently broken
> 
> i'm not sure if renaming a github & gitbox is possible (at least there is no 
> self-service tool for it). another option would be to create a new repo, 
> clone the content and delete the old one. unfortunately it's not possible to 
> create a new gitbox repo named "sling-sling-maven-plugin" because the form 
> validation thinks the double prefix was not intended.
> 
> stefan
> 
> [1] https://sling.apache.org/downloads.cgi
> 
> 

rename sling-maven-sling-plugin git repo?

[Stefan Seifert]

should we rename the github repo as well to "sling-sling-maven-plugin"?

it would
a) be more consistent and 
b) fix auto-generated github links like on the download page [1] which is 
currently broken

i'm not sure if renaming a github & gitbox is possible (at least there is no 
self-service tool for it). another option would be to create a new repo, clone 
the content and delete the old one. unfortunately it's not possible to create a 
new gitbox repo named "sling-sling-maven-plugin" because the form validation 
thinks the double prefix was not intended.

stefan

[1] https://sling.apache.org/downloads.cgi

Re: [VOTE] Release Apache Sling Commons HTML 1.0.4

[Jason E Bailey]

I don't mind pushing the bundle versioning up. 

Although the argument, as expressed, would mean that the versioning is wrong in 
almost all of the bundles that Sling has released in the last year +


--
Jason

On Mon, Jan 14, 2019, at 11:54 AM, Konrad Windszus wrote:
> -1 due to incorrect semantic versioning. For details please check out 
> https://github.com/apache/sling-org-apache-sling-commons-html/pull/1#discussion_r247569311
>  
> .
> 
> > On 14. Jan 2019, at 15:49, Jason E Bailey  wrote:
> > 
> > Hi,
> > 
> > We solved 2 issues in this release:
> > https://issues.apache.org/jira/projects/SLING/versions/12343276
> > 
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2037/
> > 
> > You can use this UNIX script to download the release and verify the 
> > signatures:
> > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> > 
> > Usage:
> > sh check_staged_release.sh 2037 /tmp/sling-staging
> > 
> > Please vote to approve this release:
> > 
> >  [ ] +1 Approve the release
> >  [ ]  0 Don't care
> >  [ ] -1 Don't release, because ...
> > 
> > This majority vote is open for at least 72 hours.
> > - Jason
> 
>

[jira] [Commented] (SLING-8213) Not possible to specify wildcard handler property in Maven plugin

[David Bosschaert (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742354#comment-16742354
 ] 

David Bosschaert commented on SLING-8213:
-

Maybe we can chance the {{*}} wildcard to an underscore? {{_}}?

> Not possible to specify wildcard handler property in Maven plugin
> -
>
> Key: SLING-8213
> URL: https://issues.apache.org/jira/browse/SLING-8213
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: slingfeature-maven-plugin 0.8.0
>Reporter: David Bosschaert
>Priority: Major
>
> The custom merge handlers executed during aggregation can be configured using 
> {{handlerConfiguration}} tags in the slingfeature-maven-plugin configuration.
> They can be configured on a per-plugin basis (plugin-name needs to be 
> specified) or with a wildcard.
> Currently the way to specify configuration that needs to be passed to all 
> plugins is by specifying {{*}} as the name, in the case of the maven plugin, 
> the name is specify as an XML tag.
> However {code}<*>{code} is not a valid XML tag and the pom will not parse 
> with such a tag, so using {{*}} as the wildcard is an unfortunate choice.
> We need to fix this so that wildcards can be specified in the pom.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-8213) Not possible to specify wildcard handler property in Maven plugin

[David Bosschaert (JIRA)]

David Bosschaert created SLING-8213:
---

 Summary: Not possible to specify wildcard handler property in 
Maven plugin
 Key: SLING-8213
 URL: https://issues.apache.org/jira/browse/SLING-8213
 Project: Sling
  Issue Type: Bug
  Components: Feature Model
Affects Versions: slingfeature-maven-plugin 0.8.0
Reporter: David Bosschaert


The custom merge handlers executed during aggregation can be configured using 
{{handlerConfiguration}} tags in the slingfeature-maven-plugin configuration.
They can be configured on a per-plugin basis (plugin-name needs to be 
specified) or with a wildcard.
Currently the way to specify configuration that needs to be passed to all 
plugins is by specifying {{*}} as the name, in the case of the maven plugin, 
the name is specify as an XML tag.
However {{<*>}} is not a valid XML tag and the pom will not parse with such a 
tag, so using {{*}} as the wildcard is an unfortunate choice.

We need to fix this so that wildcards can be specified in the pom.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-8213) Not possible to specify wildcard handler property in Maven plugin

[David Bosschaert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Bosschaert updated SLING-8213:

Description: 
The custom merge handlers executed during aggregation can be configured using 
{{handlerConfiguration}} tags in the slingfeature-maven-plugin configuration.
They can be configured on a per-plugin basis (plugin-name needs to be 
specified) or with a wildcard.
Currently the way to specify configuration that needs to be passed to all 
plugins is by specifying {{*}} as the name, in the case of the maven plugin, 
the name is specify as an XML tag.
However {code}<*>{code} is not a valid XML tag and the pom will not parse with 
such a tag, so using {{*}} as the wildcard is an unfortunate choice.

We need to fix this so that wildcards can be specified in the pom.xml

  was:
The custom merge handlers executed during aggregation can be configured using 
{{handlerConfiguration}} tags in the slingfeature-maven-plugin configuration.
They can be configured on a per-plugin basis (plugin-name needs to be 
specified) or with a wildcard.
Currently the way to specify configuration that needs to be passed to all 
plugins is by specifying {{*}} as the name, in the case of the maven plugin, 
the name is specify as an XML tag.
However {{<*>}} is not a valid XML tag and the pom will not parse with such a 
tag, so using {{*}} as the wildcard is an unfortunate choice.

We need to fix this so that wildcards can be specified in the pom.xml


> Not possible to specify wildcard handler property in Maven plugin
> -
>
> Key: SLING-8213
> URL: https://issues.apache.org/jira/browse/SLING-8213
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: slingfeature-maven-plugin 0.8.0
>Reporter: David Bosschaert
>Priority: Major
>
> The custom merge handlers executed during aggregation can be configured using 
> {{handlerConfiguration}} tags in the slingfeature-maven-plugin configuration.
> They can be configured on a per-plugin basis (plugin-name needs to be 
> specified) or with a wildcard.
> Currently the way to specify configuration that needs to be passed to all 
> plugins is by specifying {{*}} as the name, in the case of the maven plugin, 
> the name is specify as an XML tag.
> However {code}<*>{code} is not a valid XML tag and the pom will not parse 
> with such a tag, so using {{*}} as the wildcard is an unfortunate choice.
> We need to fix this so that wildcards can be specified in the pom.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-8211) Update archetypes to reference sling-maven-plugin

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert updated SLING-8211:
--
Fix Version/s: (was: Bundle Parent 35)

> Update archetypes to reference sling-maven-plugin
> -
>
> Key: SLING-8211
> URL: https://issues.apache.org/jira/browse/SLING-8211
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Bundle Archetype 1.0.8, JCRInstall Bundle Archetype 1.0.8
>
>
> (Not sure if I got all the projects right)
> We should start using the sling-maven-plugin since this is now the preferred 
> name.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-8212) Parent: Replace maven-sling-plugin with sling-maven-plugin and ban old artifact id

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert updated SLING-8212:
--
Fix Version/s: Bundle Parent 35

> Parent: Replace maven-sling-plugin with sling-maven-plugin and ban old 
> artifact id
> --
>
> Key: SLING-8212
> URL: https://issues.apache.org/jira/browse/SLING-8212
> Project: Sling
>  Issue Type: Improvement
>  Components: Tooling
>Affects Versions: Parent 34
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Parent 35, Bundle Parent 35
>
>
> follow-up of SLING-8204



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-8212) Parent: Replace maven-sling-plugin with sling-maven-plugin and ban old artifact id

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-8212.
---
Resolution: Fixed

https://github.com/apache/sling-parent/commit/aa670cb74f9093da351e08942a50fdaca63fb0c2

> Parent: Replace maven-sling-plugin with sling-maven-plugin and ban old 
> artifact id
> --
>
> Key: SLING-8212
> URL: https://issues.apache.org/jira/browse/SLING-8212
> Project: Sling
>  Issue Type: Improvement
>  Components: Tooling
>Affects Versions: Parent 34
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Parent 35
>
>
> follow-up of SLING-8204



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-8212) Parent: Replace maven-sling-plugin with sling-maven-plugin and ban old artifact id

[Stefan Seifert (JIRA)]

Stefan Seifert created SLING-8212:
-

 Summary: Parent: Replace maven-sling-plugin with 
sling-maven-plugin and ban old artifact id
 Key: SLING-8212
 URL: https://issues.apache.org/jira/browse/SLING-8212
 Project: Sling
  Issue Type: Improvement
  Components: Tooling
Affects Versions: Parent 34
Reporter: Stefan Seifert
Assignee: Stefan Seifert
 Fix For: Parent 35


follow-up of SLING-8204



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[RESULT] [VOTE] Release Apache Sling Maven Plugin 2.4.0

[Stefan Seifert]

Hi,

The vote has passed with the following result :

+1 (binding): Stefan Seifert, Julian Sedding, Robert Munteanu, Daniel Klco

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

stefan

[jira] [Closed] (SLING-7916) Update documentation for WebDAV bundle deployment

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed SLING-7916.
-

> Update documentation for WebDAV bundle deployment
> -
>
> Key: SLING-7916
> URL: https://issues.apache.org/jira/browse/SLING-7916
> Project: Sling
>  Issue Type: Task
>  Components: Maven Plugins and Archetypes
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Maven Plugin 2.4.0
>
>
> I created a Sling module using the {{sling-jcrinstall-bundle-archetype}}. 
> Deployment using the {{maven-sling-plugin}} fails, with the following message:
> {noformat}Installation on http://localhost:8080/libs/sling/install failed, 
> cause: Could not find any intermediate path up until the root of 
> http://localhost:8080/libs/sling/install.{noformat}
> At least {{/libs}} is there, so that message is incorrect. Verifying the 
> Sling request log I see that redirects sent from Sling are followed using the 
> {{anonymous}} user:
> {noformat}127.0.0.1 - admin 12/Sep/2018:15:14:48 +0200 "PUT 
> /libs/sling/install/bundle-test-002-1.0-SNAPSHOT.jar HTTP/1.1" 409 2455 "-" 
> "Jakarta Commons-HttpClient/3.1"
> 127.0.0.1 - admin 12/Sep/2018:15:14:48 +0200 "HEAD /libs/sling/install 
> HTTP/1.1" 404 2524 "-" "Jakarta Commons-HttpClient/3.1"
> 127.0.0.1 - admin 12/Sep/2018:15:14:48 +0200 "HEAD /libs/sling HTTP/1.1" 302 
> - "-" "Jakarta Commons-HttpClient/3.1"
> 127.0.0.1 - anonymous 12/Sep/2018:15:14:48 +0200 "HEAD /libs/sling/ HTTP/1.1" 
> 404 2461 "-" "Jakarta Commons-HttpClient/3.1"
> 127.0.0.1 - admin 12/Sep/2018:15:14:48 +0200 "HEAD /libs HTTP/1.1" 302 - "-" 
> "Jakarta Commons-HttpClient/3.1"
> 127.0.0.1 - anonymous 12/Sep/2018:15:14:48 +0200 "HEAD /libs/ HTTP/1.1" 404 
> 2407 "-" "Jakarta Commons-HttpClient/3.1"
> {noformat}
> This is wrong, and we should always be accessing the repository using the 
> configured user and password.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (SLING-7445) Install bundle: "Failed getting intermediate path at http://localhost:4502/apps/project. Reason: Forbidden" when directory listings are turned off

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed SLING-7445.
-

> Install bundle: "Failed getting intermediate path at 
> http://localhost:4502/apps/project. Reason: Forbidden" when directory 
> listings are turned off
> --
>
> Key: SLING-7445
> URL: https://issues.apache.org/jira/browse/SLING-7445
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes, Tooling
>Affects Versions: Maven Sling Plugin 2.1.8, Maven Sling Plugin 2.3.4
>Reporter: Henry Kuijpers
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Sling Maven Plugin 2.4.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The maven-sling-plugin tries to deploy a bundle to a Sling system. In case it 
> deploys to a path that doesn't exist yet, it tries to create the intermediary 
> paths.
> In case of WebDAV deployment, it tries to figure out which paths exist and 
> which paths don't exist, to determine what work it needs to do to ensure all 
> intermediary paths.
> When determining which path is the first one to not exist, it relies on the 
> status code 404 to indicate this.
> However, when the "index"-property of 
> org.apache.sling.servlets.get.DefaultGetServlet is set to false (default 
> setting on Adobe AEM), the server will send a 403 Forbidden instead of a 404 
> Not Found. This causes the install-command to fail with the exception 
> mentioned in the title.
> *It would be nice if there is a fallback in case the index-property of 
> DefaultGetServlet is turned off.*
> [http://localhost:4502/apps/project/install/] gives 404 (correct, so it 
> should try the parent)
> [http://localhost:4502/apps/project/] gives 403 (problem, it expected 200, 
> because it exists)
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (SLING-8203) Introduce "skip" parameter for sling:fsmount and sling:fsunmount goals

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed SLING-8203.
-

> Introduce "skip" parameter for sling:fsmount and sling:fsunmount goals
> --
>
> Key: SLING-8203
> URL: https://issues.apache.org/jira/browse/SLING-8203
> Project: Sling
>  Issue Type: Improvement
>  Components: Tooling
>Affects Versions: Maven Sling Plugin 2.3.8
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Sling Maven Plugin 2.4.0
>
>
> it should be possible to configure a "skip" for some projects of a reactor of 
> maven projects to skip when executing "sling:fsmount" or "sling:fsunmount".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (SLING-8204) Rename maven-sling-plugin to sling-maven-plugin

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed SLING-8204.
-

> Rename maven-sling-plugin to sling-maven-plugin
> ---
>
> Key: SLING-8204
> URL: https://issues.apache.org/jira/browse/SLING-8204
> Project: Sling
>  Issue Type: New Feature
>  Components: Tooling
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Sling Maven Plugin 2.4.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> to avoid this maven build warning/error:
> {noformat}
> [ERROR]
> Artifact Ids of the format maven-___-plugin are reserved for
> plugins in the Group Id org.apache.maven.plugins
> Please change your artifactId to the format ___-maven-plugin
> In the future this error will break the build.
> {noformat}
> we need to rename the plugin from {{maven-sling-plugin}} to 
> {{sling-maven-plugin}}.
> to still support builds with the old coordinates and support things like 
> automatic dependency update checks we will publish a relocate pom using the 
> old coordinate pointing to the new ones.
> this relocate pom will be contained in the same git repository as the 
> sling-maven-plugin itself, and will be released with each new release.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Release Apache Sling Commons HTML 1.0.4

[Konrad Windszus]

-1 due to incorrect semantic versioning. For details please check out 
https://github.com/apache/sling-org-apache-sling-commons-html/pull/1#discussion_r247569311
 
.

> On 14. Jan 2019, at 15:49, Jason E Bailey  wrote:
> 
> Hi,
> 
> We solved 2 issues in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12343276
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2037/
> 
> You can use this UNIX script to download the release and verify the 
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 2037 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> - Jason

[GitHub] kwin commented on a change in pull request #1: Sling 3270

[GitBox]

kwin commented on a change in pull request #1: Sling 3270
URL: 
https://github.com/apache/sling-org-apache-sling-commons-html/pull/1#discussion_r247569311
 
 

 ##
 File path: pom.xml
 ##
 @@ -37,25 +37,36 @@
 
 
 8
-4.11.0
+4.12.0
+UTF-8
+
UTF-8
 
 
 
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-commons-html.git
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-commons-html.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-commons-html.git
-  HEAD
-  
+HEAD
+
 
 
 
 
-biz.aQute.bnd
-bnd-maven-plugin
 
 Review comment:
   Actually bnd-baseline-maven-plugin is more correct than maven-bundle-plugin. 
Please compare with 
https://www.osgi.org/wp-content/uploads/SemanticVersioning.pdf:
   
   > Requiring another bundle is similar to a short form of importing all the 
exported packages of that required
   bundle. The version of a bundle must therefore semantically aggregate the 
semantics of all its constituent
   packages. If any of these packages is incompatible with its providers then 
the bundle version must increment
   the minor version. If any of these packages is incompatible with consumers, 
the bundle version must
   increment the major version. It is clear, that on average, the version of a 
bundle will be much more volatile
   than the versions of its constituent packages, increasing the dependency 
problems.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

RE: [VOTE] Release Apache Sling Commons HTML 1.0.4

[Stefan Seifert]

+1

Re: [VOTE] Release Apache Sling Maven Plugin 2.4.0

[Daniel Klco]

+1

On Mon, Jan 14, 2019 at 5:00 AM Robert Munteanu  wrote:

> On Fri, 2019-01-11 at 16:47 +, Stefan Seifert wrote:
> > Please vote to approve this release:
>
> +1
>
> Robert
>

[GitHub] kwin commented on a change in pull request #1: Sling 3270

[GitBox]

kwin commented on a change in pull request #1: Sling 3270
URL: 
https://github.com/apache/sling-org-apache-sling-commons-html/pull/1#discussion_r247543378
 
 

 ##
 File path: pom.xml
 ##
 @@ -37,25 +37,36 @@
 
 
 8
-4.11.0
+4.12.0
+UTF-8
+
UTF-8
 
 
 
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-commons-html.git
 
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-commons-html.git
 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-commons-html.git
-  HEAD
-  
+HEAD
+
 
 
 
 
-biz.aQute.bnd
-bnd-maven-plugin
 
 Review comment:
   @JEBailey I don't know either what is wrong with bnd in that case, but 
thanks a lot for the dedicated test branch. I created the ticket 
https://github.com/bndtools/bnd/issues/2859 to follow-up on that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: SLING-7245 - Proposal for PR validation of all Sling modules

[Robert Munteanu]

Hi Radu,

On Mon, 2019-01-07 at 14:35 +0100, Radu Cotescu wrote:
> Hi Robert,
> 
> How far are we from being able to merge 
> https://github.com/apache/sling-tooling-jenkins/tree/feature/SLING-7245
> <
> https://github.com/apache/sling-tooling-jenkins/tree/feature/SLING-7245
> > back to master?
> 
> I really like the new approach of generating Jenkins jobs, after
> having migrated the 3 experimental scripting bundle tracker modules.

I need to add support for email notifications and then we should be
good to go.

Robert

Re: [VOTE] Release Apache Sling Commons HTML 1.0.4

[Nicolas Peltier]

+1

Le lun. 14 janv. 2019 à 16:09, Daniel Klco  a écrit :

> +1
>
> On Mon, Jan 14, 2019 at 9:56 AM Julian Sedding  wrote:
>
> > +1 - all checks ok
> >
> > Regards
> > Julian
> >
> > On Mon, Jan 14, 2019 at 3:49 PM Jason E Bailey  wrote:
> > >
> > > Hi,
> > >
> > > We solved 2 issues in this release:
> > > https://issues.apache.org/jira/projects/SLING/versions/12343276
> > >
> > > Staging repository:
> > >
> https://repository.apache.org/content/repositories/orgapachesling-2037/
> > >
> > > You can use this UNIX script to download the release and verify the
> > signatures:
> > >
> >
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> > >
> > > Usage:
> > > sh check_staged_release.sh 2037 /tmp/sling-staging
> > >
> > > Please vote to approve this release:
> > >
> > >   [ ] +1 Approve the release
> > >   [ ]  0 Don't care
> > >   [ ] -1 Don't release, because ...
> > >
> > > This majority vote is open for at least 72 hours.
> > > - Jason
> >
>

Re: [VOTE] Release Apache Sling Commons HTML 1.0.4

[Daniel Klco]

+1

On Mon, Jan 14, 2019 at 9:56 AM Julian Sedding  wrote:

> +1 - all checks ok
>
> Regards
> Julian
>
> On Mon, Jan 14, 2019 at 3:49 PM Jason E Bailey  wrote:
> >
> > Hi,
> >
> > We solved 2 issues in this release:
> > https://issues.apache.org/jira/projects/SLING/versions/12343276
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2037/
> >
> > You can use this UNIX script to download the release and verify the
> signatures:
> >
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >
> > Usage:
> > sh check_staged_release.sh 2037 /tmp/sling-staging
> >
> > Please vote to approve this release:
> >
> >   [ ] +1 Approve the release
> >   [ ]  0 Don't care
> >   [ ] -1 Don't release, because ...
> >
> > This majority vote is open for at least 72 hours.
> > - Jason
>

Re: [VOTE] Release Apache Sling Commons HTML 1.0.4

[Julian Sedding]

+1 - all checks ok

Regards
Julian

On Mon, Jan 14, 2019 at 3:49 PM Jason E Bailey  wrote:
>
> Hi,
>
> We solved 2 issues in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12343276
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2037/
>
> You can use this UNIX script to download the release and verify the 
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2037 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
> - Jason

[VOTE] Release Apache Sling Commons HTML 1.0.4

[Jason E Bailey]

Hi,

We solved 2 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12343276

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2037/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2037 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.
- Jason

[jira] [Updated] (SLING-7751) Commons Html - Underlying parser implementation may use system charset

[Jason E Bailey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason E Bailey updated SLING-7751:
--
Summary: Commons Html - Underlying parser implementation may use system 
charset  (was: Commons Html - Underlying parser implementation uses system 
charset)

> Commons Html - Underlying parser implementation may use system charset
> --
>
> Key: SLING-7751
> URL: https://issues.apache.org/jira/browse/SLING-7751
> Project: Sling
>  Issue Type: Improvement
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Minor
> Fix For: Commons HTML 1.0.4
>
>
> While re-writing the underlying tagsoup library I discovered that, by 
> default, the internal InputStreamReader is created with the system default 
> charset.
> This can be overridden with a custom AutoDetector.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-8211) Update archetypes to reference sling-maven-plugin

[Robert Munteanu (JIRA)]

Robert Munteanu created SLING-8211:
--

 Summary: Update archetypes to reference sling-maven-plugin
 Key: SLING-8211
 URL: https://issues.apache.org/jira/browse/SLING-8211
 Project: Sling
  Issue Type: Improvement
  Components: Maven Plugins and Archetypes
Reporter: Robert Munteanu
 Fix For: Bundle Archetype 1.0.8, JCRInstall Bundle Archetype 
1.0.8, Bundle Parent 35


(Not sure if I got all the projects right)

We should start using the sling-maven-plugin since this is now the preferred 
name.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (SLING-8198) Add an option to jspc-maven-plugin to drop sling dependency

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742084#comment-16742084
 ] 

Robert Munteanu edited comment on SLING-8198 at 1/14/19 1:56 PM:
-

[~romain.manni-bucau] - it would be great for our tooling to be reusable 
because the more eyes there are on it the better :-) I'm not sure if anyone has 
any short-term plans to work on this, but if you can submit a pull request I'd 
be more than happy to review and apply it.


was (Author: rombert):
[~romain.manni-bucau] - it would be great for our tooling to be reusable 
because the more eyes there are on the better :-) I'm not sure if anyone has 
any short-term plans to work on this, but if you can submit a pull request I'd 
be more than happy to review and apply it.

> Add an option to jspc-maven-plugin to drop sling dependency
> ---
>
> Key: SLING-8198
> URL: https://issues.apache.org/jira/browse/SLING-8198
> Project: Sling
>  Issue Type: New Feature
>  Components: Maven Plugins and Archetypes
>Affects Versions: Maven JSPC Plugin 2.1.0
>Reporter: Romain Manni-Bucau
>Priority: Major
>
> Hi guys,
> would be very nice to be able to generate JSP without any dependency on a 
> particular runtime (tomcat, sling etc).
> Having a portable=true|false flag in the plugin which would, when set to 
> true, avoid all org.apache.sling. usages would be awesome.
> Concretely, replacing HttpJspBase is quite trivial - methods can be generated 
> in the jsp directly without any issue. Dropping 
> org.apache.sling.scripting.jsp.jasper.runtime.AnnotationProcessor is 
> generally possible - it is not needed for all JSP. Note that the same applies 
> to _el_expressionfactory which can be looked up lazily.
> Not sure it is a goal for sling but there is no jsp compiler out there usable 
> to deploy the jsp in any servlet/jsp container, can be very valuable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-8198) Add an option to jspc-maven-plugin to drop sling dependency

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742084#comment-16742084
 ] 

Robert Munteanu commented on SLING-8198:


[~romain.manni-bucau] - it would be great for our tooling to be reusable 
because the more eyes there are on the better :-) I'm not sure if anyone has 
any short-term plans to work on this, but if you can submit a pull request I'd 
be more than happy to review and apply it.

> Add an option to jspc-maven-plugin to drop sling dependency
> ---
>
> Key: SLING-8198
> URL: https://issues.apache.org/jira/browse/SLING-8198
> Project: Sling
>  Issue Type: New Feature
>  Components: Maven Plugins and Archetypes
>Affects Versions: Maven JSPC Plugin 2.1.0
>Reporter: Romain Manni-Bucau
>Priority: Major
>
> Hi guys,
> would be very nice to be able to generate JSP without any dependency on a 
> particular runtime (tomcat, sling etc).
> Having a portable=true|false flag in the plugin which would, when set to 
> true, avoid all org.apache.sling. usages would be awesome.
> Concretely, replacing HttpJspBase is quite trivial - methods can be generated 
> in the jsp directly without any issue. Dropping 
> org.apache.sling.scripting.jsp.jasper.runtime.AnnotationProcessor is 
> generally possible - it is not needed for all JSP. Note that the same applies 
> to _el_expressionfactory which can be looked up lazily.
> Not sure it is a goal for sling but there is no jsp compiler out there usable 
> to deploy the jsp in any servlet/jsp container, can be very valuable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-8186) Moved node is deleted if @Delete parameter points to its name

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741954#comment-16741954
 ] 

Bertrand Delacretaz commented on SLING-8186:


The following sequence (executed with the attached patch applied) demonstrates 
how the attached patch does not solve the "unwanted delete" problem, it simply 
fixes it for the specific example of this ticket but moves it to other cases:
{code:java}
# create two test nodes
$ curl -u admin:admin -F title="To keep" http://localhost:8080/test/tokeep
$ curl -u admin:admin -F title="Other" http://localhost:8080/test/other

$ curl -s -u admin:admin -D - http://localhost:8080/test/other.json | head -1
HTTP/1.1 200 OK

$ curl -s -u admin:admin -D - http://localhost:8080/test/tokeep.json | head -1
HTTP/1.1 200 OK

# move /test/other to /test/moved/dest
curl -u admin:admin -F'./moved/dest@MoveFrom=/test/other' 
-F'./tokeep@Delete=true' http://localhost:8080/test

# now /test/moved/dest is fine but /test/tokeep is gone
$ curl -s -u admin:admin -D - http://localhost:8080/test/moved/dest.json | head 
-1
HTTP/1.1 200 OK

$ curl -s -u admin:admin -D - http://localhost:8080/test/tokeep.json | head -1
HTTP/1.1 404 Not Found
{code}

So I don't think changing the order of operations helps.

The only change that we _might_ make is to disable the "delete a Resource if a 
property is not found by @Delete" behavior, but that would not be backwards 
compatible.

At this point I think if any changes are desired we need to discuss on dl-dev 
so that people with various use cases can chime in.

My preference is to just update the docs at 
[https://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html]
 to warn about these potential unwanted deletes, without changing code.

> Moved node is deleted if @Delete parameter points to its name
> -
>
> Key: SLING-8186
> URL: https://issues.apache.org/jira/browse/SLING-8186
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Post 2.3.26
>Reporter: Burkhard Pauli
>Assignee: Bertrand Delacretaz
>Priority: Major
> Attachments: patch.diff
>
>
> If a file is moved to a new location with the @MoveFrom parameter and the 
> request contains the @Delete parameter at the same time, the file is dropped 
> and never saved to the new location.
> Step to reproduce the issue:
>  # Create a node of type nt:file at the location {{/content/file}}
>  # Execute the following curl command:
>  {{curl -u admin:admin -F './test/title=Hello World' -F 
> './test/file@MoveFrom=/content/file' -F './test@Delete=true' 
> [http://localhost:4502/content]}}
> Observed behaviour:
>  The file is not saved at the new location at {{/content/test/file}} and it 
> is not available anymore at the old location {{/content/file}}
> Expected:
>  The file is saved at the new location {{/content/test/file}} as long as 
> other properties are saved when the request contains the delete operation 
> (like the title property in the example above).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-8186) Moved node is deleted if @Delete parameter points to its name

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741926#comment-16741926
 ] 

Carsten Ziegeler commented on SLING-8186:
-

I'm still struggling to understand the example, what exactly is the purpose of 
"./test@Delete=true" ?

> Moved node is deleted if @Delete parameter points to its name
> -
>
> Key: SLING-8186
> URL: https://issues.apache.org/jira/browse/SLING-8186
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Post 2.3.26
>Reporter: Burkhard Pauli
>Assignee: Bertrand Delacretaz
>Priority: Major
> Attachments: patch.diff
>
>
> If a file is moved to a new location with the @MoveFrom parameter and the 
> request contains the @Delete parameter at the same time, the file is dropped 
> and never saved to the new location.
> Step to reproduce the issue:
>  # Create a node of type nt:file at the location {{/content/file}}
>  # Execute the following curl command:
>  {{curl -u admin:admin -F './test/title=Hello World' -F 
> './test/file@MoveFrom=/content/file' -F './test@Delete=true' 
> [http://localhost:4502/content]}}
> Observed behaviour:
>  The file is not saved at the new location at {{/content/test/file}} and it 
> is not available anymore at the old location {{/content/file}}
> Expected:
>  The file is saved at the new location {{/content/test/file}} as long as 
> other properties are saved when the request contains the delete operation 
> (like the title property in the example above).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (SLING-2534) Strings of zero length on update in post servlet delete the property

[Radu Cotescu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu closed SLING-2534.
---

> Strings of zero length on update in post servlet delete the property
> 
>
> Key: SLING-2534
> URL: https://issues.apache.org/jira/browse/SLING-2534
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Post 2.1.2
>Reporter: Endolf
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Servlets Post 2.3.28
>
> Attachments: SLING-2534-diff.txt, blankstrings.patch
>
>
> According to JCR specs, for string type properties, a blank string should be 
> a valid value. Currently the post servlet delets any property where 1 or less 
> values are specifed and the 1 value has a 0 length. I think string properties 
> with a zero length should be blanked instead of deleted.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[RESULT][VOTE] Release Apache Sling Servlets Post 2.3.28

[Radu Cotescu]

Hi,

The release was successful with 4 binding +1 votes from: Stefan Seifert, 
Carsten Ziegeler, Radu Cotescu and Daniel Klco.

I’ll start promoting the release ASAP.

Cheers,
Radu

Re: [VOTE] Release Apache Sling Maven Plugin 2.4.0

[Robert Munteanu]

On Fri, 2019-01-11 at 16:47 +, Stefan Seifert wrote:
> Please vote to approve this release:

+1

Robert


signature.asc
Description: This is a digitally signed message part

Re: [VOTE] Release Apache Sling Maven Plugin 2.4.0

[Julian Sedding]

+1 - all checks ok

Regards
Julian

On Fri, Jan 11, 2019 at 6:01 PM Stefan Seifert  wrote:
>
> +1
>
>