[GitHub] [sling-org-apache-sling-starter] rombert commented on issue #6: embed Composum configuration bundle in the provisioning script

2019-08-14 Thread GitBox
rombert commented on issue #6: embed Composum configuration bundle in the provisioning script URL: https://github.com/apache/sling-org-apache-sling-starter/pull/6#issuecomment-521138897 Merged, thanks @ist-rw ! This is an

Re: [Features] Merging Configurations

2019-08-14 Thread Radu Cotescu
+1 > On 14 Aug 2019, at 08:39, Konrad Windszus wrote: > > I would actually refuse to merge if the same PID occurs. It might be > unexpected (and incompatible) if you do transparent merging on the property > level. > It is just important that it is easy to resolve those conflict without >

[Features] Merging Configurations

2019-08-14 Thread Carsten Ziegeler
Hi, when two features are merged (aggregated), configurations are automatically merged. Meaning if both features have a configuration for the same PID, the properties from the second feature are put into the configuration of the first feature, adding and potentially overwriting values.

Re: [Features] Merging Configurations

2019-08-14 Thread Konrad Windszus
Hi, I would actually refuse to merge if the same PID occurs. It might be unexpected (and incompatible) if you do transparent merging on the property level. It is just important that it is easy to resolve those conflict without touching the feature, i.e. some force option which enforces merging

Re: [Features] Merging Configurations

2019-08-14 Thread Karl Pauls
On Wednesday, August 14, 2019, Konrad Windszus wrote: > Hi, > I would actually refuse to merge if the same PID occurs. It might be > unexpected (and incompatible) if you do transparent merging on the property > level. > It is just important that it is easy to resolve those conflict without >

[Jenkins] Sling » sling-org-apache-sling-launchpad-testing » master #272 is BROKEN

2019-08-14 Thread Apache Jenkins Server
/workspace/e-sling-launchpad-testing_master@tmp/withMavene868a416/maven-spy-20190814-080529-22612286762230037466162.log [ERROR] Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.21.0:verify (default) on project org.apache.sling.launchpad.testing: There are test failures. [ERROR

[jira] [Created] (SLING-8629) ConfigurationAdmin does not get registered without configurations

2019-08-14 Thread Carsten Ziegeler (JIRA)
Carsten Ziegeler created SLING-8629: --- Summary: ConfigurationAdmin does not get registered without configurations Key: SLING-8629 URL: https://issues.apache.org/jira/browse/SLING-8629 Project: Sling

[GitHub] [sling-org-apache-sling-starter] rombert merged pull request #6: embed Composum configuration bundle in the provisioning script

2019-08-14 Thread GitBox
rombert merged pull request #6: embed Composum configuration bundle in the provisioning script URL: https://github.com/apache/sling-org-apache-sling-starter/pull/6 This is an automated message from the Apache Git Service.

[RT] Support OSGi R7 Logging

2019-08-14 Thread Carsten Ziegeler
Hi, the OSGi R7 specification has an update to the Log Service which we should support in some way in Sling. Today, we have our own LogService implementation (org.apache.sling.commons.logservice). One way to implement R7 could be to simply update our implementation. However logging is not

Re: [DISCUSS] Switching o.a.s.starter-content to use scripts and resources?

2019-08-14 Thread Georg Henzler
Replying to myself here - the /content/startup/index.html file is different from the /content/starter/index.html one, so no change is required here. Sorry for the late reply - so fixed perfectly via SLING-8615. The file /content/startup/index.html used to be loaded from starter-startup [1],

Request for the Sling Feature Converter Maven Plugin to become a Sling Module

2019-08-14 Thread Andreas Schaefer
Hi I am aware that this is a long shot but this Maven Plugin can make life easier for User that want to convert Sling into a Feature as well as launching Sling FM with their Content Packages. The ticket for this request is: https://issues.apache.org/jira/browse/SLING-8490

[GitHub] [sling-org-apache-sling-feature-cpconverter] schaefa opened a new pull request #16: SLING-8630 - Prevent the Converter from overwritting an existing POM …

2019-08-14 Thread GitBox
schaefa opened a new pull request #16: SLING-8630 - Prevent the Converter from overwritting an existing POM … URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/16 …file This is an automated

[jira] [Created] (SLING-8631) Introduce state for extensions

2019-08-14 Thread Carsten Ziegeler (JIRA)
Carsten Ziegeler created SLING-8631: --- Summary: Introduce state for extensions Key: SLING-8631 URL: https://issues.apache.org/jira/browse/SLING-8631 Project: Sling Issue Type: New Feature

[jira] [Created] (SLING-8632) Add a method to get a JSON object from an extension

2019-08-14 Thread Carsten Ziegeler (JIRA)
Carsten Ziegeler created SLING-8632: --- Summary: Add a method to get a JSON object from an extension Key: SLING-8632 URL: https://issues.apache.org/jira/browse/SLING-8632 Project: Sling

[jira] [Resolved] (SLING-8629) ConfigurationAdmin does not get registered without configurations

2019-08-14 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-8629. - Resolution: Fixed Fixed in rev e9e01ee > ConfigurationAdmin does not get registered

[GitHub] [sling-org-apache-sling-feature-cpconverter] schaefa merged pull request #15: SLING-8626 - Added Maven Model Version to generated POM, replace any …

2019-08-14 Thread GitBox
schaefa merged pull request #15: SLING-8626 - Added Maven Model Version to generated POM, replace any … URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/15 This is an automated message from

[jira] [Resolved] (SLING-8626) Content Package Converter is taking Group from Package Group instead of from Maven Group

2019-08-14 Thread Andreas Schaefer (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer resolved SLING-8626. - Resolution: Fixed At the end it turned out that the issue was that group and artifact

SonarCloud review for Sling Whiteboard project / branch

2019-08-14 Thread Andreas Schaefer
Hi I wanted to check out the review of SonarCloud for my Sling Whiteboard module ‘sling-feature-converter-maven-plugin’ which is for now in its own branch but I created a PR for it. Even though I can find the PR in SonarCloud (https://sonarcloud.io/dashboard?id=apache_sling-whiteboard=48

[jira] [Commented] (SLING-8490) Create Maven Plugin for FM Content Package Converter

2019-08-14 Thread Andreas Schaefer (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907264#comment-16907264 ] Andreas Schaefer commented on SLING-8490: - Plugin is created as part of the Sling Whiteboard

[jira] [Created] (SLING-8630) Converter must not replace existing POM files

2019-08-14 Thread Andreas Schaefer (JIRA)
Andreas Schaefer created SLING-8630: --- Summary: Converter must not replace existing POM files Key: SLING-8630 URL: https://issues.apache.org/jira/browse/SLING-8630 Project: Sling Issue