[jira] [Updated] (SLING-9745) Introduce SlingUri API to simplify creation/manipulation of Sling URIs

2020-09-21 Thread Georg Henzler (Jira)
[ https://issues.apache.org/jira/browse/SLING-9745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georg Henzler updated SLING-9745: - Description: General purpose class to represent a SlingUri (like e.g. a link in an html tag).

[jira] [Updated] (SLING-9662) Introduce a Resource Mapping SPI

2020-09-21 Thread Georg Henzler (Jira)
[ https://issues.apache.org/jira/browse/SLING-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georg Henzler updated SLING-9662: - Description: SlingUriMapper   Introduce a simple SPI that allows to contribute to the resource

[jira] [Commented] (SLING-9662) Introduce an URI Mapping SPI

2020-09-21 Thread Georg Henzler (Jira)
[ https://issues.apache.org/jira/browse/SLING-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199708#comment-17199708 ] Georg Henzler commented on SLING-9662: -- See

[jira] [Updated] (SLING-9745) Introduce SlingUri API to simplify creation/manipulation of Sling URIs

2020-09-21 Thread Georg Henzler (Jira)
[ https://issues.apache.org/jira/browse/SLING-9745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georg Henzler updated SLING-9745: - Summary: Introduce SlingUri API to simplify creation/manipulation of Sling URIs (was: Introduce

[jira] [Updated] (SLING-9662) Introduce an URI Mapping SPI

2020-09-21 Thread Georg Henzler (Jira)
[ https://issues.apache.org/jira/browse/SLING-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georg Henzler updated SLING-9662: - Summary: Introduce an URI Mapping SPI (was: Introduce a Resource Mapping SPI) > Introduce an

[jira] [Updated] (SLING-9662) Introduce a Resource Mapping SPI

2020-09-21 Thread Georg Henzler (Jira)
[ https://issues.apache.org/jira/browse/SLING-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georg Henzler updated SLING-9662: - Description: _an earlier version used the terms ResourceUri/ResourceToUriMapper (updated this

[GitHub] [sling-org-apache-sling-api] ghenzler commented on a change in pull request #23: SLING-9745 Introduce ResourceUri (immutable) and ResourceUriBuilder

2020-09-21 Thread GitBox
ghenzler commented on a change in pull request #23: URL: https://github.com/apache/sling-org-apache-sling-api/pull/23#discussion_r491726353 ## File path: src/main/java/org/apache/sling/api/resource/uri/ResourceUri.java ## @@ -0,0 +1,181 @@ +/* + * Licensed to the Apache

[GitHub] [sling-org-apache-sling-feature] bosschaert merged pull request #21: SLING-9752 Concurrent Modification Exception when PostProcessor changes extensions

2020-09-21 Thread GitBox
bosschaert merged pull request #21: URL: https://github.com/apache/sling-org-apache-sling-feature/pull/21 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [sling-org-apache-sling-auth-core] sonarcloud[bot] commented on pull request #5: Cleanup unit test

2020-09-21 Thread GitBox
sonarcloud[bot] commented on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/5#issuecomment-695991263 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core=5=false=BUG)

[GitHub] [sling-tooling-jenkins] kwin merged pull request #5: SLING-9749 Enable profile "ci" during Jenkins build

2020-09-21 Thread GitBox
kwin merged pull request #5: URL: https://github.com/apache/sling-tooling-jenkins/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] commented on pull request #8: SLING-9491 generate bnd OSGi index

2020-09-21 Thread GitBox
sonarcloud[bot] commented on pull request #8: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/8#issuecomment-696219375 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=8=false=BUG)

[GitHub] [sling-org-apache-sling-engine] ghenzler closed pull request #9: SLING-9662 Use SlingUri as provided in request from auth.core

2020-09-21 Thread GitBox
ghenzler closed pull request #9: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [sling-org-apache-sling-engine] ghenzler opened a new pull request #9: SLING-9662 Use SlingUri as provided in request from auth.core

2020-09-21 Thread GitBox
ghenzler opened a new pull request #9: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [sling-org-apache-sling-starter] kwin commented on pull request #8: SLING-9491 generate bnd OSGi index

2020-09-21 Thread GitBox
kwin commented on pull request #8: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/8#issuecomment-696218376 @rombert Can you check again now? it should only have an effect now on CI/release builds. This

[GitHub] [sling-tooling-jenkins] kwin edited a comment on pull request #5: SLING-9749 Enable profile "ci" during Jenkins build

2020-09-21 Thread GitBox
kwin edited a comment on pull request #5: URL: https://github.com/apache/sling-tooling-jenkins/pull/5#issuecomment-695937689 I would like to decouple parent from a specific CI (like Jenkins). That profile id can also be easily set with Github Actions, Travis CI, ... and whatever we may

[GitHub] [sling-tooling-jenkins] kwin commented on pull request #5: SLING-9749 Enable profile "ci" during Jenkins build

2020-09-21 Thread GitBox
kwin commented on pull request #5: URL: https://github.com/apache/sling-tooling-jenkins/pull/5#issuecomment-695937689 I would like to decouple parent from a specific CI (like Jenkins). That profile id can also be easily set with Github Actions, Travis CI, ... and whatever we may use in

[GitHub] [sling-org-apache-sling-testing-clients] kwin commented on a change in pull request #18: SLING-9750 Fix read string as integer issue

2020-09-21 Thread GitBox
kwin commented on a change in pull request #18: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/18#discussion_r492156751 ## File path: src/main/java/org/apache/sling/testing/clients/osgi/ServiceInfo.java ## @@ -41,7 +41,7 @@ public

[GitHub] [sling-org-apache-sling-feature] sonarcloud[bot] commented on pull request #21: SLING-9752 Concurrent Modification Exception when PostProcessor changes extensions

2020-09-21 Thread GitBox
sonarcloud[bot] commented on pull request #21: URL: https://github.com/apache/sling-org-apache-sling-feature/pull/21#issuecomment-696110315 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature=21=false=BUG)

[GitHub] [sling-tooling-jenkins] rombert commented on pull request #5: SLING-9749 Enable profile "ci" during Jenkins build

2020-09-21 Thread GitBox
rombert commented on pull request #5: URL: https://github.com/apache/sling-tooling-jenkins/pull/5#issuecomment-695929929 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [sling-org-apache-sling-api] sonarcloud[bot] commented on pull request #23: SLING-9745 Introduce ResourceUri (immutable) and ResourceUriBuilder

2020-09-21 Thread GitBox
sonarcloud[bot] commented on pull request #23: URL: https://github.com/apache/sling-org-apache-sling-api/pull/23#issuecomment-695826452 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [sling-org-apache-sling-api] sonarcloud[bot] removed a comment on pull request #23: SLING-9745 Introduce ResourceUri (immutable) and ResourceUriBuilder

2020-09-21 Thread GitBox
sonarcloud[bot] removed a comment on pull request #23: URL: https://github.com/apache/sling-org-apache-sling-api/pull/23#issuecomment-694838914 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [sling-org-apache-sling-engine] ghenzler closed pull request #9: SLING-9662 Use SlingUri as provided in request from auth.core

2020-09-21 Thread GitBox
ghenzler closed pull request #9: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [sling-org-apache-sling-auth-core] ghenzler commented on a change in pull request #5: Cleanup unit test

2020-09-21 Thread GitBox
ghenzler commented on a change in pull request #5: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/5#discussion_r491888031 ## File path: src/test/java/org/apache/sling/auth/core/impl/SlingAuthenticatorTest.java ## @@ -373,19 +373,16 @@ public void

[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] removed a comment on pull request #8: SLING-9491 generate bnd OSGi index

2020-09-21 Thread GitBox
sonarcloud[bot] removed a comment on pull request #8: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/8#issuecomment-691706351 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=8=false=BUG)

[jira] [Comment Edited] (SLING-9735) Remove loginAdministrative() usage from org.apache.sling.jcr.contentloader

2020-09-21 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-9735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199601#comment-17199601 ] Eric Norman edited comment on SLING-9735 at 9/21/20, 7:05 PM: -- [~rombert] 

[jira] [Comment Edited] (SLING-9735) Remove loginAdministrative() usage from org.apache.sling.jcr.contentloader

2020-09-21 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-9735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199601#comment-17199601 ] Eric Norman edited comment on SLING-9735 at 9/21/20, 7:09 PM: -- [~rombert] 

[jira] [Commented] (SLING-9735) Remove loginAdministrative() usage from org.apache.sling.jcr.contentloader

2020-09-21 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-9735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199601#comment-17199601 ] Eric Norman commented on SLING-9735: [~rombert] I'm not aware of any scenarios where the

[GitHub] [sling-org-apache-sling-feature] bosschaert merged pull request #21: SLING-9752 Concurrent Modification Exception when PostProcessor changes extensions

2020-09-21 Thread GitBox
bosschaert merged pull request #21: URL: https://github.com/apache/sling-org-apache-sling-feature/pull/21 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Comment Edited] (SLING-2938) AdapterMethods annotation and adapter proxy service

2020-09-21 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199448#comment-17199448 ] Konrad Windszus edited comment on SLING-2938 at 9/21/20, 3:28 PM: --

[jira] [Commented] (SLING-2938) AdapterMethods annotation and adapter proxy service

2020-09-21 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199448#comment-17199448 ] Konrad Windszus commented on SLING-2938: [~Henry Kuijpers] Project looks good to me. I would

[GitHub] [sling-org-apache-sling-testing-clients] kwin commented on a change in pull request #18: SLING-9750 Fix read string as integer issue

2020-09-21 Thread GitBox
kwin commented on a change in pull request #18: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/18#discussion_r492156751 ## File path: src/main/java/org/apache/sling/testing/clients/osgi/ServiceInfo.java ## @@ -41,7 +41,7 @@ public

[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] removed a comment on pull request #8: SLING-9491 generate bnd OSGi index

2020-09-21 Thread GitBox
sonarcloud[bot] removed a comment on pull request #8: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/8#issuecomment-691706351 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=8=false=BUG)

[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] commented on pull request #8: SLING-9491 generate bnd OSGi index

2020-09-21 Thread GitBox
sonarcloud[bot] commented on pull request #8: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/8#issuecomment-696219375 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=8=false=BUG)

[GitHub] [sling-org-apache-sling-starter] kwin commented on pull request #8: SLING-9491 generate bnd OSGi index

2020-09-21 Thread GitBox
kwin commented on pull request #8: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/8#issuecomment-696218376 @rombert Can you check again now? it should only have an effect now on CI/release builds. This

[jira] [Resolved] (SLING-9752) Concurrent Modification Exception when PostProcessor changes extensions

2020-09-21 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert resolved SLING-9752. --- Resolution: Fixed > Concurrent Modification Exception when PostProcessor

[jira] [Resolved] (SLING-9744) Add metrics for the persisted queries

2020-09-21 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-9744. - Resolution: Fixed Implemented in [commit

[jira] [Created] (SLING-9753) Return a 500 status code if the persisted query cannot be stored in the cache

2020-09-21 Thread Radu Cotescu (Jira)
Radu Cotescu created SLING-9753: --- Summary: Return a 500 status code if the persisted query cannot be stored in the cache Key: SLING-9753 URL: https://issues.apache.org/jira/browse/SLING-9753 Project:

[jira] [Comment Edited] (SLING-2938) AdapterMethods annotation and adapter proxy service

2020-09-21 Thread Henry Kuijpers (Jira)
[ https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199671#comment-17199671 ] Henry Kuijpers edited comment on SLING-2938 at 9/21/20, 9:24 PM: -

[jira] [Comment Edited] (SLING-2938) AdapterMethods annotation and adapter proxy service

2020-09-21 Thread Henry Kuijpers (Jira)
[ https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199671#comment-17199671 ] Henry Kuijpers edited comment on SLING-2938 at 9/21/20, 9:32 PM: -

[jira] [Commented] (SLING-2938) AdapterMethods annotation and adapter proxy service

2020-09-21 Thread Henry Kuijpers (Jira)
[ https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199671#comment-17199671 ] Henry Kuijpers commented on SLING-2938: --- [~kwin], I don't 100% agree with that reasoning; I think

[GitHub] [sling-org-apache-sling-auth-core] sonarcloud[bot] commented on pull request #5: Cleanup unit test

2020-09-21 Thread GitBox
sonarcloud[bot] commented on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/5#issuecomment-695991263 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core=5=false=BUG)

[GitHub] [sling-org-apache-sling-api] ghenzler commented on a change in pull request #23: SLING-9745 Introduce ResourceUri (immutable) and ResourceUriBuilder

2020-09-21 Thread GitBox
ghenzler commented on a change in pull request #23: URL: https://github.com/apache/sling-org-apache-sling-api/pull/23#discussion_r491904832 ## File path: src/main/java/org/apache/sling/api/resource/uri/ResourceUri.java ## @@ -0,0 +1,181 @@ +/* + * Licensed to the Apache

[GitHub] [sling-org-apache-sling-auth-core] ghenzler commented on a change in pull request #5: Cleanup unit test

2020-09-21 Thread GitBox
ghenzler commented on a change in pull request #5: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/5#discussion_r491888031 ## File path: src/test/java/org/apache/sling/auth/core/impl/SlingAuthenticatorTest.java ## @@ -373,19 +373,16 @@ public void

[GitHub] [sling-org-apache-sling-auth-core] ghenzler opened a new pull request #5: Cleanup unit test

2020-09-21 Thread GitBox
ghenzler opened a new pull request #5: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/5 request.getAttribute("path") is not used anymore in main code and should not be mocked This is an automated

[GitHub] [sling-org-apache-sling-api] sonarcloud[bot] commented on pull request #23: SLING-9745 Introduce ResourceUri (immutable) and ResourceUriBuilder

2020-09-21 Thread GitBox
sonarcloud[bot] commented on pull request #23: URL: https://github.com/apache/sling-org-apache-sling-api/pull/23#issuecomment-696004668 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api=23=false=BUG)

[GitHub] [sling-org-apache-sling-api] sonarcloud[bot] removed a comment on pull request #23: SLING-9745 Introduce ResourceUri (immutable) and ResourceUriBuilder

2020-09-21 Thread GitBox
sonarcloud[bot] removed a comment on pull request #23: URL: https://github.com/apache/sling-org-apache-sling-api/pull/23#issuecomment-695826452 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api=23=false=BUG)

[GitHub] [sling-org-apache-sling-auth-core] ghenzler commented on a change in pull request #5: Cleanup unit test

2020-09-21 Thread GitBox
ghenzler commented on a change in pull request #5: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/5#discussion_r491888031 ## File path: src/test/java/org/apache/sling/auth/core/impl/SlingAuthenticatorTest.java ## @@ -373,19 +373,16 @@ public void

[GitHub] [sling-tooling-jenkins] kwin commented on pull request #5: SLING-9749 Enable profile "ci" during Jenkins build

2020-09-21 Thread GitBox
kwin commented on pull request #5: URL: https://github.com/apache/sling-tooling-jenkins/pull/5#issuecomment-695937689 I would like to decouple parent from a specific CI (like Jenkins). That profile id can also be easily set with Github Actions, Travis CI, ... and whatever we may use in

[GitHub] [sling-tooling-jenkins] kwin merged pull request #5: SLING-9749 Enable profile "ci" during Jenkins build

2020-09-21 Thread GitBox
kwin merged pull request #5: URL: https://github.com/apache/sling-tooling-jenkins/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [sling-tooling-jenkins] rombert commented on pull request #5: SLING-9749 Enable profile "ci" during Jenkins build

2020-09-21 Thread GitBox
rombert commented on pull request #5: URL: https://github.com/apache/sling-tooling-jenkins/pull/5#issuecomment-695954344 Can you also please add a note about this to https://cwiki.apache.org/confluence/display/SLING/Sling+Jenkins+Setup when you merge?

[jira] [Commented] (SLING-9735) Remove loginAdministrative() usage from org.apache.sling.jcr.contentloader

2020-09-21 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199197#comment-17199197 ] Robert Munteanu commented on SLING-9735: This is a great improvement, thanks [~enorman]! Do we

[jira] [Commented] (SLING-9749) Enabling profile with id "ci" when building with Jenkins

2020-09-21 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-9749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199226#comment-17199226 ] Konrad Windszus commented on SLING-9749: Fixed in

[jira] [Resolved] (SLING-9749) Enabling profile with id "ci" when building with Jenkins

2020-09-21 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-9749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-9749. Resolution: Fixed > Enabling profile with id "ci" when building with Jenkins >

[GitHub] [sling-tooling-jenkins] rombert commented on pull request #5: SLING-9749 Enable profile "ci" during Jenkins build

2020-09-21 Thread GitBox
rombert commented on pull request #5: URL: https://github.com/apache/sling-tooling-jenkins/pull/5#issuecomment-695929929 @kwin - wouldn't it be more obvious is the profile would be activated thorugh the parent pom by looking at an env variable that we know is always defined on Jenkins?

[GitHub] [sling-tooling-jenkins] kwin edited a comment on pull request #5: SLING-9749 Enable profile "ci" during Jenkins build

2020-09-21 Thread GitBox
kwin edited a comment on pull request #5: URL: https://github.com/apache/sling-tooling-jenkins/pull/5#issuecomment-695937689 I would like to decouple parent from a specific CI (like Jenkins). That profile id can also be easily set with Github Actions, Travis CI, ... and whatever we may

[GitHub] [sling-org-apache-sling-feature] sonarcloud[bot] commented on pull request #21: SLING-9752 Concurrent Modification Exception when PostProcessor changes extensions

2020-09-21 Thread GitBox
sonarcloud[bot] commented on pull request #21: URL: https://github.com/apache/sling-org-apache-sling-feature/pull/21#issuecomment-696110315 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature=21=false=BUG)

[GitHub] [sling-org-apache-sling-feature] bosschaert opened a new pull request #21: SLING-9752 Concurrent Modification Exception when PostProcessor changes extensions

2020-09-21 Thread GitBox
bosschaert opened a new pull request #21: URL: https://github.com/apache/sling-org-apache-sling-feature/pull/21 Create a defensive copy instead. Unit test included. This is an automated message from the Apache Git

[jira] [Created] (SLING-9752) Concurrent Modification Exception when PostProcessor changes extensions

2020-09-21 Thread A. J. David Bosschaert (Jira)
A. J. David Bosschaert created SLING-9752: - Summary: Concurrent Modification Exception when PostProcessor changes extensions Key: SLING-9752 URL: https://issues.apache.org/jira/browse/SLING-9752