enapps-enorman commented on a change in pull request #58:
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/58#discussion_r494540600
##
File path:
src/main/java/org/apache/sling/feature/maven/mojos/AggregateFeaturesMojo.java
##
@@ -65,6 +68,15 @@
[
https://issues.apache.org/jira/browse/SLING-9656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201912#comment-17201912
]
Carsten Ziegeler commented on SLING-9656:
-
[~enorman] Thanks for updating the PR, while this is
[
https://issues.apache.org/jira/browse/SLING-9656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201318#comment-17201318
]
Carsten Ziegeler commented on SLING-9656:
-
As noted in the PR it is totally legitimate to call
First of all, just to restate the intent: I don't suggest renaming the
Jira versions because of the tool limitations. I think it makes sense
to use something that is aligned with the module name and that problem
was exposed by the tooling.
We created Jira versions in the form of 'Artifact Name'
On 24. Sep 2020, at 11:58, Robert Munteanu wrote:
>
> We created Jira versions in the form of 'Artifact Name' 'Version' for
> quite some time, only one of them stands out by being different. Just a
> note, not something bad by itself.
I would very much appreciate consistency in the naming.
This
THanks Robert,
now if I get it right you're proposing to change
'slingfeature-maven-plugin-1.4.0'
to
'slingfeature-maven-plugin 1.4.0'
in Jira, correct?
And revert the renaming to "OSGi Feature Maven Plugin" ?
I'm fine with that
Regards
Carsten
Am 24.09.2020 um 11:58 schrieb Robert
[
https://issues.apache.org/jira/browse/SLING-9656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201367#comment-17201367
]
Carsten Ziegeler commented on SLING-9656:
-
I guess one solution - which requires a little bit of
[
https://issues.apache.org/jira/browse/SLING-9656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201365#comment-17201365
]
Robert Munteanu commented on SLING-9656:
[~enorman] - thanks for looking into this. Unfortunately
[
https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201319#comment-17201319
]
Carsten Ziegeler commented on SLING-2938:
-
Lgtm, thanks!
> AdapterMethods annotation and adapter
cziegeler commented on a change in pull request #58:
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/58#discussion_r494083414
##
File path:
src/main/java/org/apache/sling/feature/maven/mojos/AggregateFeaturesMojo.java
##
@@ -65,6 +68,15 @@
@Override
+1
Konrad
> On 23. Sep 2020, at 20:58, Georg Henzler wrote:
>
> Hi all,
>
> We solved 6 issues in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12346965
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2338
>
> You can use
On Wed, 2020-09-23 at 14:20 -0700, Eric Norman wrote:
> Please vote to approve this release:
+1
Robert
signature.asc
Description: This is a digitally signed message part
bdelacretaz opened a new pull request #5:
URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/5
As per https://issues.apache.org/jira/browse/SLING-9766
This is an automated message from the Apache Git
Bertrand Delacretaz created SLING-9766:
--
Summary: GraphQL query cache key does not take selectors into
account
Key: SLING-9766
URL: https://issues.apache.org/jira/browse/SLING-9766
Project:
bdelacretaz commented on pull request #5:
URL:
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/5#issuecomment-698340524
Invalid, sorry for the noise...our own cache only stores queries so it is
correct to omit selectors in the cache key. They will be taken into account
[
https://issues.apache.org/jira/browse/SLING-9656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201725#comment-17201725
]
Eric Norman commented on SLING-9656:
[~rombert] / [~cziegeler] - Thanks for reviewing and I see your
bdelacretaz closed pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
bdelacretaz commented on pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/1#issuecomment-698322216
I'm closing this due to no activity and as
https://issues.apache.org/jira/browse/SLING-9550 closed now. We can reopen or
create a new one if needed.
bdelacretaz commented on pull request #5:
URL:
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/5#issuecomment-698326457
...ah, wait, my patch breaks some other tests...
This is an automated message from
[
https://issues.apache.org/jira/browse/SLING-9766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz resolved SLING-9766.
Resolution: Invalid
Invalid, sorry for the noise...our own cache only stores
[
https://issues.apache.org/jira/browse/SLING-9766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz closed SLING-9766.
--
> GraphQL query cache key does not take selectors into account
>
bdelacretaz closed pull request #5:
URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/5
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
22 matches
Mail list logo
