Re: [VOTE] Release Apache Sling Repoinit Parser 1.1.0 and JCR Repoinit 1.1.0 (3rd and final take)

2016-11-09 Thread Oliver Lietz
On Wednesday 09 November 2016 10:28:28 Carsten Ziegeler wrote: > Hi, > > this is the 3rd and final attempt for releasing these modules. Sorry for > all the noise so far. > > We solved 3 issues in the JCR Repoinit release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12338580 We

[jira] [Issue Comment Deleted] (SLING-5135) Whitelist legit usages of loginAdministrative and administrative ResourceResolver

2016-11-09 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding updated SLING-5135: -- Comment: was deleted (was: GitHub user code-distillery reopened a pull request:

[jira] [Commented] (SLING-5135) Whitelist legit usages of loginAdministrative and administrative ResourceResolver

2016-11-09 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15653349#comment-15653349 ] Julian Sedding commented on SLING-5135: --- [~bdelacretaz], [~cziegeler] Could you take a look at the

[jira] [Issue Comment Deleted] (SLING-5135) Whitelist legit usages of loginAdministrative and administrative ResourceResolver

2016-11-09 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding updated SLING-5135: -- Comment: was deleted (was: Github user code-distillery closed the pull request at:

[jira] [Commented] (SLING-5135) Whitelist legit usages of loginAdministrative and administrative ResourceResolver

2016-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15653334#comment-15653334 ] ASF GitHub Bot commented on SLING-5135: --- GitHub user code-distillery reopened a pull request:

[GitHub] sling pull request #185: SLING-5135 - Whitelist legit usages of loginAdminis...

2016-11-09 Thread code-distillery
GitHub user code-distillery reopened a pull request: https://github.com/apache/sling/pull/185 SLING-5135 - Whitelist legit usages of loginAdministrative and administrative ResourceResolver This pull request includes the following refactorings: 1. Replace

[jira] [Commented] (SLING-5135) Whitelist legit usages of loginAdministrative and administrative ResourceResolver

2016-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15653321#comment-15653321 ] ASF GitHub Bot commented on SLING-5135: --- GitHub user code-distillery reopened a pull request:

[jira] [Commented] (SLING-5135) Whitelist legit usages of loginAdministrative and administrative ResourceResolver

2016-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15653325#comment-15653325 ] ASF GitHub Bot commented on SLING-5135: --- Github user code-distillery closed the pull request at:

[GitHub] sling pull request #185: SLING-5135 - Whitelist legit usages of loginAdminis...

2016-11-09 Thread code-distillery
Github user code-distillery closed the pull request at: https://github.com/apache/sling/pull/185 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] sling pull request #185: SLING-5135 - Whitelist legit usages of loginAdminis...

2016-11-09 Thread code-distillery
GitHub user code-distillery reopened a pull request: https://github.com/apache/sling/pull/185 SLING-5135 - Whitelist legit usages of loginAdministrative and administrative ResourceResolver This pull request includes the following refactorings: 1. Replace

[jira] [Commented] (SLING-5135) Whitelist legit usages of loginAdministrative and administrative ResourceResolver

2016-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15653319#comment-15653319 ] ASF GitHub Bot commented on SLING-5135: --- Github user code-distillery closed the pull request at:

[GitHub] sling pull request #185: SLING-5135 - Whitelist legit usages of loginAdminis...

2016-11-09 Thread code-distillery
Github user code-distillery closed the pull request at: https://github.com/apache/sling/pull/185 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[VOTE] Release Apache Sling Provisioning Model 1.7.0 and Slingstart Maven Plugin 1.6.0

2016-11-09 Thread Carsten Ziegeler
Hi, We solved 2 issues in this release for the Provisioning Model: https://issues.apache.org/jira/browse/SLING/fixforversion/12338628 We solved 1 issues in this release for the Slingstart Maven Plugin: https://issues.apache.org/jira/browse/SLING/fixforversion/12338616 Staging repository:

Re: [VOTE] Release Apache Sling Provisioning Model 1.7.0 and Slingstart Maven Plugin 1.6.0

2016-11-09 Thread Carsten Ziegeler
+1 -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org

[jira] [Updated] (SLING-5914) Provisioning model does not correctly handle floating-point configuration values

2016-11-09 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-5914: Fix Version/s: (was: Sling Provisioning Model 1.7.0) Sling

[jira] [Commented] (SLING-5135) Whitelist legit usages of loginAdministrative and administrative ResourceResolver

2016-11-09 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15652007#comment-15652007 ] Julian Sedding commented on SLING-5135: --- I think the {{DefaultWhitelist}} can be reduced to the

[jira] [Comment Edited] (SLING-5135) Whitelist legit usages of loginAdministrative and administrative ResourceResolver

2016-11-09 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651212#comment-15651212 ] Julian Sedding edited comment on SLING-5135 at 11/9/16 8:43 PM: We should

Re: Build test failures

2016-11-09 Thread Julian Sedding
Hi Robert Yes absolutely, that sounds great! Thanks for your prompt replies. Regards Julian On Wed, Nov 9, 2016 at 9:16 PM, Robert Munteanu wrote: > On Wed, 2016-11-09 at 20:49 +0100, Julian Sedding wrote: >> Hi Robert >> >> Thanks for the hints. >> >> I was wondering if

Re: Build test failures

2016-11-09 Thread Robert Munteanu
On Wed, 2016-11-09 at 20:49 +0100, Julian Sedding wrote: > Hi Robert > > Thanks for the hints. > > I was wondering if it is possible to trigger a build of each module > at > least once every 24h? Even if there are no changes in the module. > > Writing a Jenkins trigger, extracting dependencies

[jira] [Commented] (SLING-6135) ResourceEditor build failure on Jenkins

2016-11-09 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651919#comment-15651919 ] Robert Munteanu commented on SLING-6135: Anytime :-) Thanks for the fix > ResourceEditor build

Re: Build test failures

2016-11-09 Thread Julian Sedding
Hi Robert Thanks for the hints. I was wondering if it is possible to trigger a build of each module at least once every 24h? Even if there are no changes in the module. Writing a Jenkins trigger, extracting dependencies from PaxExam tests does not sound trivial. And that may be only one case of

[jira] [Resolved] (SLING-6135) ResourceEditor build failure on Jenkins

2016-11-09 Thread Sandro Boehme (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandro Boehme resolved SLING-6135. -- Resolution: Fixed Thanks for reporting [~rombert]! > ResourceEditor build failure on Jenkins >

[jira] [Resolved] (SLING-6252) Resource Editor :: Fix frontend build

2016-11-09 Thread Sandro Boehme (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandro Boehme resolved SLING-6252. -- Resolution: Fixed > Resource Editor :: Fix frontend build >

[jira] [Resolved] (SLING-6267) Support OSGi versions and provide accessor methods of version parts

2016-11-09 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-6267. - Resolution: Fixed The version class can now parse OSGi versions (up to four parts) as

[jira] [Created] (SLING-6267) Support OSGi versions and provide accessor methods of version parts

2016-11-09 Thread Carsten Ziegeler (JIRA)
Carsten Ziegeler created SLING-6267: --- Summary: Support OSGi versions and provide accessor methods of version parts Key: SLING-6267 URL: https://issues.apache.org/jira/browse/SLING-6267 Project:

[jira] [Resolved] (SLING-6266) Feature version should be converted to OSGi version

2016-11-09 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-6266. - Resolution: Fixed > Feature version should be converted to OSGi version >

[jira] [Created] (SLING-6266) Feature version should be converted to OSGi version

2016-11-09 Thread Carsten Ziegeler (JIRA)
Carsten Ziegeler created SLING-6266: --- Summary: Feature version should be converted to OSGi version Key: SLING-6266 URL: https://issues.apache.org/jira/browse/SLING-6266 Project: Sling

[jira] [Resolved] (SLING-6265) Effective model does not get feature versions

2016-11-09 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-6265. - Resolution: Fixed > Effective model does not get feature versions >

[jira] [Updated] (SLING-6265) Effective model does not get feature versions

2016-11-09 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-6265: Affects Version/s: Sling Provisioning Model 1.5.0 Sling Provisioning

[jira] [Created] (SLING-6265) Effective model does not get feature versions

2016-11-09 Thread Carsten Ziegeler (JIRA)
Carsten Ziegeler created SLING-6265: --- Summary: Effective model does not get feature versions Key: SLING-6265 URL: https://issues.apache.org/jira/browse/SLING-6265 Project: Sling Issue

Re: Build test failures

2016-11-09 Thread Robert Munteanu
Hi Julian, On Tue, 2016-11-08 at 22:29 +0100, Julian Sedding wrote: > Hi Robert > > I think the test failures in oak-server did not come up because of > the > modularised jenkins jobs we have now. > > The bundle's build seems to have run last after changes were applied > to it. However, a

Re: Launchpad stable and launchpad unstable

2016-11-09 Thread Robert Munteanu
On Wed, 2016-11-02 at 12:02 +0100, Carsten Ziegeler wrote: > Bertrand Delacretaz wrote > > On Wed, Nov 2, 2016 at 9:39 AM, Carsten Ziegeler > org> wrote: > > > Bertrand Delacretaz wrote > > > > On Wed, Nov 2, 2016 at 6:56 AM, Carsten Ziegeler > > > che.org>

[jira] [Assigned] (SLING-6137) Context-Aware Config: Configuration Manager - Support resource collection and property inheritance

2016-11-09 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert reassigned SLING-6137: - Assignee: Stefan Seifert > Context-Aware Config: Configuration Manager - Support

RE: [RESULT][VOTE] Release Apache Sling HTL Maven Plugin 1.0.2

2016-11-09 Thread Stefan Seifert
the release was not yet pushed to maven central, i did this now. stefan >-Original Message- >From: Radu Cotescu [mailto:r...@apache.org] >Sent: Tuesday, November 8, 2016 11:56 AM >To: Sling Dev >Subject: [RESULT][VOTE] Release Apache Sling HTL Maven Plugin 1.0.2 > >Hello, > >The vote

[jira] [Updated] (SLING-5135) Whitelist legit usages of loginAdministrative and administrative ResourceResolver

2016-11-09 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-5135: Fix Version/s: JCR Base 2.4.2 > Whitelist legit usages of loginAdministrative and

[jira] [Commented] (SLING-5135) Whitelist legit usages of loginAdministrative and administrative ResourceResolver

2016-11-09 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651212#comment-15651212 ] Carsten Ziegeler commented on SLING-5135: - We should also check whether the default whitelist is

[jira] [Updated] (SLING-6174) Use Jackrabbit/Oak globbing support

2016-11-09 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-6174: Attachment: jcresource-patch.txt Patch once Oak 1.5.13 is available > Use Jackrabbit/Oak

[jira] [Commented] (SLING-6163) Improve observation of files in JCR

2016-11-09 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651155#comment-15651155 ] Carsten Ziegeler commented on SLING-6163: - SLING-6174 contains a patch using the new Oak

[jira] [Commented] (SLING-6263) Dependency problem between RepositoryInitializer and AbstractSlingRepositoryManager

2016-11-09 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651136#comment-15651136 ] Carsten Ziegeler commented on SLING-6263: - But that is exactly happening, all active services are

[jira] [Commented] (SLING-6263) Dependency problem between RepositoryInitializer and AbstractSlingRepositoryManager

2016-11-09 Thread Bertrand Delacretaz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651105#comment-15651105 ] Bertrand Delacretaz commented on SLING-6263: I disagree with changing the javadocs or

[jira] [Commented] (SLING-6263) Dependency problem between RepositoryInitializer and AbstractSlingRepositoryManager

2016-11-09 Thread Oliver Lietz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651076#comment-15651076 ] Oliver Lietz commented on SLING-6263: - How about renaming {{SlingRepositoryInitializer}} to

[jira] [Commented] (SLING-6263) Dependency problem between RepositoryInitializer and AbstractSlingRepositoryManager

2016-11-09 Thread Oliver Lietz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651061#comment-15651061 ] Oliver Lietz commented on SLING-6263: - This changes the intended behavior of

Re: Dependency problem with Repoinit

2016-11-09 Thread Bertrand Delacretaz
On Wed, Nov 9, 2016 at 2:23 PM, Carsten Ziegeler wrote: > I've now changed the implementation to always execute the repository > initializer, even if they arrive after the repository has been started... Thanks, that's useful. -Bertrand

Re: Dependency problem with Repoinit

2016-11-09 Thread Bertrand Delacretaz
Hi, On Wed, Nov 9, 2016 at 11:50 AM, Carsten Ziegeler wrote: > ...We only have a single RepositoryInitializer service registered which is > configured to read the repoinit stuff from the embedded provisioning > model Right but Sling users can register more

Re: Dependency problem with Repoinit

2016-11-09 Thread Carsten Ziegeler
I've now changed the implementation to always execute the repository initializer, even if they arrive after the repository has been started. Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org

[jira] [Resolved] (SLING-6263) Dependency problem between RepositoryInitializer and AbstractSlingRepositoryManager

2016-11-09 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-6263. - Resolution: Fixed The RepositoryInitializer services are now executed, regardless when

[jira] [Assigned] (SLING-6263) Dependency problem between RepositoryInitializer and AbstractSlingRepositoryManager

2016-11-09 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler reassigned SLING-6263: --- Assignee: Carsten Ziegeler > Dependency problem between RepositoryInitializer and >

Re: sling attic / cleanup

2016-11-09 Thread Robert Munteanu
On Wed, 2016-09-28 at 22:37 +, Stefan Seifert wrote: > discussed at the Sling Committer Round Table @ adaptTo() 2016 > > before taking steps like migration sling svn to git we should check > if we have modules that are no longer relevant and maintained, and > moving them to the "attic"

[jira] [Resolved] (SLING-6264) Bulk move of modules to attic - November 2016

2016-11-09 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-6264. Resolution: Fixed Fixed in multiple revisions by: - removing attic projects from reactor

[jira] [Updated] (SLING-6264) Bulk move of modules to attic - November 2016

2016-11-09 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-6264: --- Issue Type: Task (was: Test) > Bulk move of modules to attic - November 2016 >

[jira] [Created] (SLING-6264) Bulk move of modules to attic - November 2016

2016-11-09 Thread Robert Munteanu (JIRA)
Robert Munteanu created SLING-6264: -- Summary: Bulk move of modules to attic - November 2016 Key: SLING-6264 URL: https://issues.apache.org/jira/browse/SLING-6264 Project: Sling Issue Type:

Re: [VOTE] Release Apache Sling Commons ClassLoader 1.3.4

2016-11-09 Thread Steven Walters
Is this just me or does this seem like its being done in haste? There was valid (from what I interpreted as rather severe) concerns raised about one of the fixes included here that were not seemingly addressed:

RE: sling releases - deploy to OBR?

2016-11-09 Thread Stefan Seifert
i've removed the OBR step from the list of mandatory steps of our release process [1], and marked the appendix as "obsolete". stefan [1] http://sling.apache.org/documentation/development/release-management.html >-Original Message- >From: Bertrand Delacretaz

[VOTE] Release Apache Sling Commons ClassLoader 1.3.4

2016-11-09 Thread Radu Cotescu
Hi, We solved 3 issues for this release, though 1 is a duplicate: https://issues.apache.org/jira/browse/SLING/fixforversion/12326769 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1570 You can use this UNIX script to download the releases and verify the

Re: Dependency problem with Repoinit

2016-11-09 Thread Carsten Ziegeler
We have one other option: whenever a repository initializer service arrives, it is used. if there are some before the repository is registered, great - if not, they are executing after that. I think we should do that anyways. Carsten -- Carsten Ziegeler Adobe Research Switzerland

Re: [VOTE] Release Apache Sling Repoinit Parser 1.1.0 and JCR Repoinit 1.1.0 (3rd and final take)

2016-11-09 Thread Robert Munteanu
On Wed, 2016-11-09 at 10:28 +0100, Carsten Ziegeler wrote: > Please vote to approve this release: +1 Robert

Re: Dependency problem with Repoinit

2016-11-09 Thread Carsten Ziegeler
Ok this thread gets a little longer than I expected. Let me recap: today there is zero guarantee that the RepositoryInitializer is used before the Repository is made available. We only have a single RepositoryInitializer service registered which is configured to read the repoinit stuff from the

Re: Dependency problem with Repoinit

2016-11-09 Thread Bertrand Delacretaz
On Wed, Nov 9, 2016 at 11:31 AM, Julian Sedding wrote: > I'm ok with a pragmatic approach for the moment. Let's see how long it > takes until that bites us ;) Huh, no. That's now how we create quality software. The "wait for N services" option is not ideal but at least

Re: Dependency problem with Repoinit

2016-11-09 Thread Bertrand Delacretaz
On Wed, Nov 9, 2016 at 11:27 AM, Carsten Ziegeler wrote: > ...the whole Sling code base has only one implementation of > RepositoryInitializer. So why should we check for N ? Do we really > expect atm that someone will register such a service atm?.. Yes, for the content

[jira] [Resolved] (SLING-6262) oak-server defines two dependencies to org.apache.sling.api

2016-11-09 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding resolved SLING-6262. --- Resolution: Fixed Fix Version/s: JCR Oak Server 1.1.2 > oak-server defines two

Re: Dependency problem with Repoinit

2016-11-09 Thread Oliver Lietz
On Wednesday 09 November 2016 11:31:11 Julian Sedding wrote: > I'm ok with a pragmatic approach for the moment. Let's see how long it > takes until that bites us ;) *sigh > I think however, that Betrand already mentioned a fair additional > use-case: content updates that can be executed *before*

Re: Dependency problem with Repoinit

2016-11-09 Thread Oliver Lietz
On Wednesday 09 November 2016 11:21:19 Carsten Ziegeler wrote: > Oliver Lietz wrote > > > On Wednesday 09 November 2016 10:58:04 Bertrand Delacretaz wrote: > >> Hi, > >> > >> On Wed, Nov 9, 2016 at 10:46 AM, Carsten Ziegeler > > > > wrote: > >>> ...if the same client does

Re: [VOTE] Release Apache Sling Repoinit Parser 1.1.0 and JCR Repoinit 1.1.0 (3rd and final take)

2016-11-09 Thread Julian Sedding
+1 (not binding) Regards Julian On Wed, Nov 9, 2016 at 10:34 AM, Carsten Ziegeler wrote: > +1 > > > > -- > Carsten Ziegeler > Adobe Research Switzerland > cziege...@apache.org >

Re: Dependency problem with Repoinit

2016-11-09 Thread Julian Sedding
I'm ok with a pragmatic approach for the moment. Let's see how long it takes until that bites us ;) I think however, that Betrand already mentioned a fair additional use-case: content updates that can be executed *before* the repository becomes visible to other services. Regards Julian On Wed,

Re: Dependency problem with Repoinit

2016-11-09 Thread Carsten Ziegeler
Bertrand Delacretaz wrote > On Wed, Nov 9, 2016 at 10:59 AM, Carsten Ziegeler > wrote: >> ...So what about going the pragmatic way atm and adding a configuration >> which simply says "requires initializer" and it's enabled by default?... > > The whole point of

Re: Dependency problem with Repoinit

2016-11-09 Thread Carsten Ziegeler
Oliver Lietz wrote > On Wednesday 09 November 2016 10:58:04 Bertrand Delacretaz wrote: >> Hi, >> >> On Wed, Nov 9, 2016 at 10:46 AM, Carsten Ziegeler > wrote: >>> ...if the same client does so without adjusting the list >>> of required names then the initializer might not

Re: Dependency problem with Repoinit

2016-11-09 Thread Bertrand Delacretaz
On Wed, Nov 9, 2016 at 10:59 AM, Carsten Ziegeler wrote: > ...So what about going the pragmatic way atm and adding a configuration > which simply says "requires initializer" and it's enabled by default?... The whole point of RepositoryInitializer is to allow things to run

[jira] [Commented] (SLING-6263) Dependency problem between RepositoryInitializer and AbstractSlingRepositoryManager

2016-11-09 Thread Oliver Lietz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650553#comment-15650553 ] Oliver Lietz commented on SLING-6263: - comment on

Re: oak-server defines two dependencies to o.a.sling.api

2016-11-09 Thread Julian Sedding
Hi Olli I had to leave the test scoped dependency, as it is required to compile OakServerTestSupport. Regards Julian On Wed, Nov 9, 2016 at 10:03 AM, Julian Sedding wrote: > Ok, I'll go ahead then and remove the dependencies from the pom. > > Regards > Julian > > On Wed,

Re: Dependency problem with Repoinit

2016-11-09 Thread Oliver Lietz
On Wednesday 09 November 2016 10:58:04 Bertrand Delacretaz wrote: > Hi, > > On Wed, Nov 9, 2016 at 10:46 AM, Carsten Ziegeler wrote: > > ...if the same client does so without adjusting the list > > of required names then the initializer might not be used either > > We

Re: Dependency problem with Repoinit

2016-11-09 Thread Carsten Ziegeler
Bertrand Delacretaz wrote > Hi, > > On Wed, Nov 9, 2016 at 10:46 AM, Carsten Ziegeler > wrote: >> ...if the same client does so without adjusting the list >> of required names then the initializer might not be used either > > We can make this robust by having an

Re: [VOTE] Release Apache Sling Repoinit Parser 1.1.0 and JCR Repoinit 1.1.0 (2nd take)

2016-11-09 Thread Robert Munteanu
On Wed, 2016-11-09 at 08:36 +0100, Carsten Ziegeler wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part

Re: Dependency problem with Repoinit

2016-11-09 Thread Carsten Ziegeler
Julian Sedding wrote > I would argue that in that case only the client's initializer is not > used. A situation that the client is more likely to notice and thus > may find the required configuration. It would not impact the product's > stability, however, only the client's additional feature. >

Re: Dependency problem with Repoinit

2016-11-09 Thread Bertrand Delacretaz
Hi, On Wed, Nov 9, 2016 at 10:46 AM, Carsten Ziegeler wrote: > ...if the same client does so without adjusting the list > of required names then the initializer might not be used either We can make this robust by having an explicit list of required services, waiting

[jira] [Commented] (SLING-6257) Sling IDE: Debugging: Thread interrupted for every uncaught exception

2016-11-09 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650505#comment-15650505 ] Robert Munteanu commented on SLING-6257: Nice catch! > Sling IDE: Debugging: Thread interrupted

Re: Dependency problem with Repoinit

2016-11-09 Thread Oliver Lietz
On Wednesday 09 November 2016 10:23:35 Carsten Ziegeler wrote: > Bertrand Delacretaz wrote > > > On Wed, Nov 9, 2016 at 10:11 AM, Carsten Ziegeler wrote: > >> ...When the RepositoryInitializer arrives later it is completely > >> ignored... > > > > Do you know why it

Re: Dependency problem with Repoinit

2016-11-09 Thread Julian Sedding
I would argue that in that case only the client's initializer is not used. A situation that the client is more likely to notice and thus may find the required configuration. It would not impact the product's stability, however, only the client's additional feature. Regards Julian On Wed, Nov 9,

[jira] [Commented] (SLING-6262) oak-server defines two dependencies to org.apache.sling.api

2016-11-09 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650489#comment-15650489 ] Julian Sedding commented on SLING-6262: --- Fixed in [r1768898|https://svn.apache.org/r1768898].

Re: Dependency problem with Repoinit

2016-11-09 Thread Carsten Ziegeler
Julian Sedding wrote > I'm in favour of using ids/names to configure a list of required > plugins. That seems more robust. > > Imagine a client application deploying its own RepositoryInitializer > without adjusting the required number of services. That could easily > lead to one of the "product"

Re: Dependency problem with Repoinit

2016-11-09 Thread Julian Sedding
I'm in favour of using ids/names to configure a list of required plugins. That seems more robust. Imagine a client application deploying its own RepositoryInitializer without adjusting the required number of services. That could easily lead to one of the "product" RepositoryInitializers to be

Re: [VOTE] Release Apache Sling Repoinit Parser 1.1.0 and JCR Repoinit 1.1.0 (3rd and final take)

2016-11-09 Thread Carsten Ziegeler
+1 -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org

Re: Dependency problem with Repoinit

2016-11-09 Thread Carsten Ziegeler
Julian Sedding wrote > Wouldn't it make sense in these "we have 0..N *mandatory* plugins, how > to wait on them problem" situations to explicitly configure all > required dependencies on the consuming service, e.g. by PID. This > would make it robust and allow for correct ordering. Of course the >

Re: [VOTE] Release Apache Sling Repoinit Parser 1.1.0 and JCR Repoinit 1.1.0 (3rd and final take)

2016-11-09 Thread Carsten Ziegeler
Sigh, and the artifact repo is orgapachesling-1569 (not orgapachesling-1568) Carsten Carsten Ziegeler wrote > Hi, > > this is the 3rd and final attempt for releasing these modules. Sorry for > all the noise so far. > > We solved 3 issues in the JCR Repoinit release: >

[VOTE] Release Apache Sling Repoinit Parser 1.1.0 and JCR Repoinit 1.1.0 (3rd and final take)

2016-11-09 Thread Carsten Ziegeler
Hi, this is the 3rd and final attempt for releasing these modules. Sorry for all the noise so far. We solved 3 issues in the JCR Repoinit release: https://issues.apache.org/jira/browse/SLING/fixforversion/12338580 and 1 issue for Repoinit Parser: https://issues.apache.org/jira/browse/SLING-6219

Re: Dependency problem with Repoinit

2016-11-09 Thread Julian Sedding
Wouldn't it make sense in these "we have 0..N *mandatory* plugins, how to wait on them problem" situations to explicitly configure all required dependencies on the consuming service, e.g. by PID. This would make it robust and allow for correct ordering. Of course the additional configuration

Re: Dependency problem with Repoinit

2016-11-09 Thread Carsten Ziegeler
Carsten Ziegeler wrote > Bertrand Delacretaz wrote >> On Wed, Nov 9, 2016 at 10:11 AM, Carsten Ziegeler >> wrote: >>> ...When the RepositoryInitializer arrives later it is completely ignored... >> >> Do you know why it arrives too late? That could be a wrong start level >>

Re: Dependency problem with Repoinit

2016-11-09 Thread Carsten Ziegeler
Bertrand Delacretaz wrote > On Wed, Nov 9, 2016 at 10:11 AM, Carsten Ziegeler > wrote: >> ...When the RepositoryInitializer arrives later it is completely ignored... > > Do you know why it arrives too late? That could be a wrong start level > of its bundle, or unwanted

[jira] [Created] (SLING-6263) Dependency problem between RepositoryInitializer and AbstractSlingRepositoryManager

2016-11-09 Thread Carsten Ziegeler (JIRA)
Carsten Ziegeler created SLING-6263: --- Summary: Dependency problem between RepositoryInitializer and AbstractSlingRepositoryManager Key: SLING-6263 URL: https://issues.apache.org/jira/browse/SLING-6263

Re: Dependency problem with Repoinit

2016-11-09 Thread Bertrand Delacretaz
On Wed, Nov 9, 2016 at 10:11 AM, Carsten Ziegeler wrote: > ...When the RepositoryInitializer arrives later it is completely ignored... Do you know why it arrives too late? That could be a wrong start level of its bundle, or unwanted dependencies that cause it to start too

Dependency problem with Repoinit

2016-11-09 Thread Carsten Ziegeler
As we can currently see on our Jenkins: https://builds.apache.org/job/sling-launchpad-builder-1.8/lastSuccessfulBuild/artifact/target/_-32861/sling/logs/error.log there is a dependency problem with the repository and repoinit. When the repository is started, there is no RepositoryInitializer

Re: oak-server defines two dependencies to o.a.sling.api

2016-11-09 Thread Julian Sedding
Ok, I'll go ahead then and remove the dependencies from the pom. Regards Julian On Wed, Nov 9, 2016 at 9:59 AM, Oliver Lietz wrote: > On Wednesday 09 November 2016 09:42:09 Julian Sedding wrote: >> Hi Olli > > hi Julian, > >> The dependency to o.a.sling.api is only used

Re: oak-server defines two dependencies to o.a.sling.api

2016-11-09 Thread Oliver Lietz
On Wednesday 09 November 2016 09:42:09 Julian Sedding wrote: > Hi Olli hi Julian, > The dependency to o.a.sling.api is only used for test, not for > compile. The package o.a.sling.api is also not present in the > oak-server bundle's import headers. So removing 2.3.0 (scope provided) > should be

[jira] [Comment Edited] (SLING-6261) ThreadExpiringThreadPool is relying on uncaught exceptions to kill threads

2016-11-09 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650346#comment-15650346 ] Konrad Windszus edited comment on SLING-6261 at 11/9/16 8:42 AM: - I think

Re: oak-server defines two dependencies to o.a.sling.api

2016-11-09 Thread Julian Sedding
Hi Olli The dependency to o.a.sling.api is only used for test, not for compile. The package o.a.sling.api is also not present in the oak-server bundle's import headers. So removing 2.3.0 (scope provided) should be safe IMHO. Of course we can remove both dependencies from the pom and instead set

[jira] [Commented] (SLING-6261) ThreadExpiringThreadPool is relying on uncaught exceptions to kill threads

2016-11-09 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650346#comment-15650346 ] Konrad Windszus commented on SLING-6261: I think the solution from

Re: oak-server defines two dependencies to o.a.sling.api

2016-11-09 Thread Oliver Lietz
On Wednesday 09 November 2016 09:16:40 Julian Sedding wrote: > Hi all hi Julian, > oak-server has a dependency to o.a.sling.api-2.3.0 and a test scoped > dependency to o.a.sling.api-2.15.0. IFAIK maven cannot handle two > different versions, even if in different scopes. > > Removing the 2.3.0

[jira] [Created] (SLING-6262) oak-server defines two dependencies to org.apache.sling.api

2016-11-09 Thread Julian Sedding (JIRA)
Julian Sedding created SLING-6262: - Summary: oak-server defines two dependencies to org.apache.sling.api Key: SLING-6262 URL: https://issues.apache.org/jira/browse/SLING-6262 Project: Sling

oak-server defines two dependencies to o.a.sling.api

2016-11-09 Thread Julian Sedding
Hi all oak-server has a dependency to o.a.sling.api-2.3.0 and a test scoped dependency to o.a.sling.api-2.15.0. IFAIK maven cannot handle two different versions, even if in different scopes. Removing the 2.3.0 dependency and leaving the to 2.15.0 test dependency allows the build to pass. Anyone

[VOTE CANCELLED] Release Apache Sling Repoinit Parser 1.1.0 and JCR Repoinit 1.1.0 (2nd take)

2016-11-09 Thread Carsten Ziegeler
It seems today is a bad day for me, I have to cancel the vote again, somehow a commit didn't make it through. Sorry for all the confusion Carsten Carsten Ziegeler wrote > Hi, > > We solved 3 issues in the JCR Repoinit release: >

[jira] [Commented] (SLING-6261) ThreadExpiringThreadPool is relying on uncaught exceptions to kill threads

2016-11-09 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650132#comment-15650132 ] Konrad Windszus commented on SLING-6261: A similar issue was once fixed in Tomcat:

  1   2   >