Re: What to do about cancelled releases in Jira?

+1 Regards Julian On Monday, November 28, 2016, Stefan Seifert wrote: > >My suggestion would be to: > > > >- move all issues from version N to version N+2 > >- delete Jira version N > > +1 >

[jira] [Commented] (SLING-6305) LoginAdminWhitelist configuration is applied too late

[ https://issues.apache.org/jira/browse/SLING-6305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15704473#comment-15704473 ] Stefan Seifert commented on SLING-6305: --- a good test object to test this problem seems to be this

Re: Launchpad stable and launchpad unstable

- the launchpad maintained in trunk should always be the "stable" launchpad, referencing only released dependencies of the sling bundles and oft the integration tests project If I checkout and build the latest trunk I would expect that the built projects are available at the runtime of the

[jira] [Created] (SLING-6338) Context-Aware Config: Properly support nested configuration classes in SPI and Mangement API

Stefan Seifert created SLING-6338: - Summary: Context-Aware Config: Properly support nested configuration classes in SPI and Mangement API Key: SLING-6338 URL: https://issues.apache.org/jira/browse/SLING-6338

Re: trunk build does not work // was: mountByFS does not work

On Fri, 2016-11-18 at 00:22 +0100, Sandro Boehme wrote: > Hi Julian, > > I like the idea of individual Jenkins jobs for the reasons you > pointed out! > If we would have a "nightly" build (whatever time that would be) we  > could link it at the Getting and building Sling page. We could write  >

Re: integration test fail due to LoginAdminWhitelist

On Mon, 2016-11-28 at 21:23 +, Stefan Seifert wrote: > perhaps there is a timing issue that loads the OSGi config for > LoginAdminWhitelist too late - and for some reasons only on unix > environments?! That would be SLING-6305 [1] I guess.  Any more data points about narrowing the cause down

RE: integration test fail due to LoginAdminWhitelist

thanks, great! unfortuantely the integration tests are now failing again. but your changes to org.apache.sling.junit.core do not seem to be the reason - even when rolling back to the latest snapshot before it's failing. same problem as before - "Bundle org.apache.sling.junit.core is NOT

RE: [VOTE] Release Apache Sling JCR Installer version 3.1.22

+1

Re: [VOTE] Release Apache Sling JCR Installer version 3.1.22

On Mon, 2016-11-28 at 22:32 +0200, Robert Munteanu wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part

[VOTE] Release Apache Sling JCR Installer version 3.1.22

Hi, We solved 6 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12338778 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1585 You can use this UNIX script to download the release and verify the signatures:

RE: What to do about cancelled releases in Jira?

>My suggestion would be to: > >- move all issues from version N to version N+2 >- delete Jira version N +1

What to do about cancelled releases in Jira?

Hi, We do not have anything written down about what happens to Jira issues fixed in version N, where N is cancelled. My suggestion would be to: - move all issues from version N to version N+2 - delete Jira version N Thoughts? Robert

[jira] [Updated] (SLING-5519) Extend default regexp for watched folders to include config

[ https://issues.apache.org/jira/browse/SLING-5519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-5519: --- Fix Version/s: (was: JCR Installer 3.1.20) JCR Installer 3.1.22 >

[jira] [Updated] (SLING-5228) Remove loginAdministrative() usage from org.apache.sling.installer.provider.jcr

[ https://issues.apache.org/jira/browse/SLING-5228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-5228: --- Fix Version/s: (was: JCR Installer 3.1.20) JCR Installer 3.1.22 >

[jira] [Updated] (SLING-6326) JcrInstaller.counters should be accessed in a thread-safe manner

[ https://issues.apache.org/jira/browse/SLING-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-6326: --- Fix Version/s: (was: JCR Installer 3.1.20) JCR Installer 3.1.22 >

[jira] [Updated] (SLING-6274) Busy loop in jcr installer

[ https://issues.apache.org/jira/browse/SLING-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-6274: --- Fix Version/s: (was: JCR Installer 3.1.20) JCR Installer 3.1.22 > Busy

[jira] [Updated] (SLING-6104) Improve handling to avoid Oak warning

[ https://issues.apache.org/jira/browse/SLING-6104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-6104: --- Fix Version/s: (was: JCR Installer 3.1.20) JCR Installer 3.1.22 >

[VOTE CANCELLED] Release Apache Sling JCR Installer version 3.1.20

Released cancelled to allow the fix for SLING-6337 [1] to be included in the release. Robert [1]: https://issues.apache.org/jira/browse/SLING-6337 On Fri, 2016-11-25 at 13:24 +0200, Robert Munteanu wrote: > Hi, > > We solved 5 issues in this release: >

[jira] [Commented] (SLING-6337) Fix default folder name regular expression

[ https://issues.apache.org/jira/browse/SLING-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15702954#comment-15702954 ] Robert Munteanu commented on SLING-6337: Thanks for the fix [~olli]. Note that since the vote for

[jira] [Updated] (SLING-6337) Fix default folder name regular expression

[ https://issues.apache.org/jira/browse/SLING-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-6337: --- Fix Version/s: (was: JCR Installer 3.1.20) JCR Installer 3.1.22 > Fix

[jira] [Updated] (SLING-6337) Fix default folder name regular expression

[ https://issues.apache.org/jira/browse/SLING-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-6337: --- Affects Version/s: JCR Installer 3.1.20 > Fix default folder name regular expression >

Re: svn commit: r1771782 - /sling/trunk/bundles/api/src/main/java/org/apache/sling/api/resource/ResourceResolverWrapper.java

Hi Julian, You're right, we should also wrap the returned resources. I've just replied on JIRA a couple of minutes ago. Thanks, Radu On Mon, 28 Nov 2016 at 19:15 Julian Sedding wrote: > Hi Radu > > I would argue that this implementation is incorrect. > > Consider that with

[jira] [Resolved] (SLING-6337) Fix default folder name regular expression

[ https://issues.apache.org/jira/browse/SLING-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-6337. - Resolution: Fixed Fix Version/s: JCR Installer 3.1.20

[jira] [Commented] (SLING-6336) Implement a ResourceResolverWrapper

[ https://issues.apache.org/jira/browse/SLING-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15702706#comment-15702706 ] Radu Cotescu commented on SLING-6336: - Thanks for the pointer! I guess I like your implementations

Re: [VOTE] Release Apache Sling JCR Installer version 3.1.20

On Monday 28 November 2016 10:59:11 Stefan Seifert wrote: > -1 > > i think there is an issue with this ticket, we should clarify it first: > https://issues.apache.org/jira/browse/SLING-5519?focusedCommentId=15701634#c > omment-15701634 Stefan is right. Didn't see this vote so opened SLING-6337

[jira] [Updated] (SLING-6337) Fix default folder name regular expression

[ https://issues.apache.org/jira/browse/SLING-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz updated SLING-6337: Affects Version/s: (was: JCR Installer 3.1.20) > Fix default folder name regular expression >

Re: svn commit: r1771782 - /sling/trunk/bundles/api/src/main/java/org/apache/sling/api/resource/ResourceResolverWrapper.java

Hi Radu I would argue that this implementation is incorrect. Consider that with this implementation resolver != resolver.getResource("/foo").getResourceResolver(), which should be the case IMHO. I commented on the issue with two tickets, where the same feature was previously discussed. The

[jira] [Created] (SLING-6337) Fix default folder name regular expression

Oliver Lietz created SLING-6337: --- Summary: Fix default folder name regular expression Key: SLING-6337 URL: https://issues.apache.org/jira/browse/SLING-6337 Project: Sling Issue Type: Bug

[jira] [Commented] (SLING-5519) Extend default regexp for watched folders to include config

[ https://issues.apache.org/jira/browse/SLING-5519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15702680#comment-15702680 ] Oliver Lietz commented on SLING-5519: - [~sseif...@pro-vision.de], you're absolutely right. Don't know

[jira] [Commented] (SLING-6336) Implement a ResourceResolverWrapper

[ https://issues.apache.org/jira/browse/SLING-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15702643#comment-15702643 ] Julian Sedding commented on SLING-6336: --- Please note that a {{ResourceResolverWrapper}} was already

Re: integration test fail due to LoginAdminWhitelist

Hi Stefan When analyzing the issue I noticed that the test was waiting for the ResourceResolverFactory service to become available. However, it is possible that the test starts before even all bundles in the repository are active (SLING-6334[0]). Thus, especially on slow systems, the likelihood

[jira] [Resolved] (SLING-6335) Server-Side Tests: Use ServiceTracker to wait for services rather than polling

[ https://issues.apache.org/jira/browse/SLING-6335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding resolved SLING-6335. --- Resolution: Fixed Fix Version/s: JUnit Core 1.0.20 Fixed in

[jira] [Updated] (SLING-6336) Implement a ResourceResolverWrapper

[ https://issues.apache.org/jira/browse/SLING-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-6336: Description: A {{ResourceResolverWrapper}} would help consumers who implement the

[jira] [Created] (SLING-6336) Implement a ResourceResolverWrapper

Radu Cotescu created SLING-6336: --- Summary: Implement a ResourceResolverWrapper Key: SLING-6336 URL: https://issues.apache.org/jira/browse/SLING-6336 Project: Sling Issue Type: Improvement

[jira] [Resolved] (SLING-6334) Server-Side Tests: Wait until all bundles are started before running tests

[ https://issues.apache.org/jira/browse/SLING-6334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding resolved SLING-6334. --- Resolution: Fixed Fix Version/s: JUnit Core 1.0.20 Fixed in

[jira] [Created] (SLING-6335) Server-Side Tests: Use ServiceTracker to wait for services rather than polling

Julian Sedding created SLING-6335: - Summary: Server-Side Tests: Use ServiceTracker to wait for services rather than polling Key: SLING-6335 URL: https://issues.apache.org/jira/browse/SLING-6335

[jira] [Created] (SLING-6334) Server-Side Tests: Wait until all bundles are started before running tests

Julian Sedding created SLING-6334: - Summary: Server-Side Tests: Wait until all bundles are started before running tests Key: SLING-6334 URL: https://issues.apache.org/jira/browse/SLING-6334 Project:

[jira] [Reopened] (SLING-6324) MonitoringDistributionPackageBuilder registering of same beans cause exception

[ https://issues.apache.org/jira/browse/SLING-6324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tommaso Teofili reopened SLING-6324: reopening as it seems the {{MonitoringDistributionPackageBuilder}} is actually registering

RE: integration test fail due to LoginAdminWhitelist

this fix of my problem was finally quite simple: i just had to double the backslashes to escape them [1], and then it works, and the generated slingstart.txt contains the same string as before. what is still strange that on my system (windows 10 machine with java 8) it worked without proper

Re: integration test fail due to LoginAdminWhitelist

One last addendum: Since quoted-string in RFC 2616 has some known bugs (http://stackoverflow.com/questions/7886782/what-is-the-exact-syntax-and-semantics-of-a-quoted-string-in-the-http1-1-rfc2616) we should only refer to https://tools.ietf.org/html/rfc7230#section-3.2.6 instead (in the

Re: integration test fail due to LoginAdminWhitelist

To figure out how the escaping exactly works, you can leverage the JCR Installer write back feature (which gives out .config files in the repository) > On 28 Nov 2016, at 12:54, Konrad Windszus wrote: > > Currently we have more or less the same documentation at >

Re: integration test fail due to LoginAdminWhitelist

Currently we have more or less the same documentation at https://sling.apache.org/documentation/bundles/configuration-installer-factory.html#configuration-files-config and https://sling.apache.org/documentation/development/slingstart.html#default-configuration-format. I would be in favor of

RE: integration test fail due to LoginAdminWhitelist

>Your current configuration looks like this: >whitelist.bundles.regexp="^org\.apache\.sling\.junit(\..*)?$" > >Inside target/slingstart.txt this becomes: >whitelist.bundles.regexp="^org.apache.sling.junit(..*)?$" > >Note: all slashes have disappeared. this is strange, yes. the same escaping

Re: integration test fail due to LoginAdminWhitelist

Sorry, forget the last bit about tests passing. I fooled my self when I only built the "package" phase. The tests also don't pass with regexp=junit. Regards Julian On Mon, Nov 28, 2016 at 12:36 PM, Julian Sedding wrote: > Hi Stefan > > I just had a look and noticed the

Re: integration test fail due to LoginAdminWhitelist

Hi Stefan I just had a look and noticed the following: Your current configuration looks like this: whitelist.bundles.regexp="^org\.apache\.sling\.junit(\..*)?$" Inside target/slingstart.txt this becomes: whitelist.bundles.regexp="^org.apache.sling.junit(..*)?$" Note: all slashes have

Re: How to handle minor version updates in API for provider bundles?

Yes, I did, just look at the mentioned commits in ticket https://issues.apache.org/jira/browse/SLING-6327. Konrad > On 28 Nov 2016, at 10:14, Bertrand Delacretaz wrote: > > On Mon, Nov 28, 2016 at 9:50 AM, Konrad Windszus wrote: >> ...There were no

[jira] [Updated] (SLING-6332) Configurations with same PID but different features/run modes in provisioning model are ignored

[ https://issues.apache.org/jira/browse/SLING-6332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-6332: --- Description: I have the following scenario: # {{launchpad/builder}} defines an OSGi config

[jira] [Commented] (SLING-6165) Expose a service for Sling Scripting that provides request-scoped Resource Resolvers for scripting dependencies

[ https://issues.apache.org/jira/browse/SLING-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15701663#comment-15701663 ] Felix Meschberger commented on SLING-6165: -- Note, that Sling indeed does not do that. This is the

RE: [VOTE] Release Apache Sling Commons Metrics 1.2.0

+1

RE: [VOTE] Release Apache Sling JCR Installer version 3.1.20

-1 i think there is an issue with this ticket, we should clarify it first: https://issues.apache.org/jira/browse/SLING-5519?focusedCommentId=15701634#comment-15701634 stefan >-Original Message- >From: Robert Munteanu [mailto:romb...@apache.org] >Sent: Friday, November 25, 2016 12:24 PM

[jira] [Commented] (SLING-5519) Extend default regexp for watched folders to include config

[ https://issues.apache.org/jira/browse/SLING-5519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15701634#comment-15701634 ] Stefan Seifert commented on SLING-5519: --- is the regex {{.*/install|config$}} correct? i suppose it

integration test fail due to LoginAdminWhitelist

for some time the caconfig integration tests are failing because the org.apache.sling.junit.core is not whitelisted in LoginAdminWhitelist (see [1]). but it is whitelisted via regexp (using the same merge-fix as robert for the launchpad tests - see [2]). the resulting slingstart.txt in the

[jira] [Updated] (SLING-6165) Expose a service for Sling Scripting that provides request-scoped Resource Resolvers for scripting dependencies

[ https://issues.apache.org/jira/browse/SLING-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-6165: Fix Version/s: (was: Scripting Core 2.0.42) (was: Scripting API 2.1.10)

[jira] [Updated] (SLING-6165) Expose a service for Sling Scripting that provides request-scoped Resource Resolvers for scripting dependencies

[ https://issues.apache.org/jira/browse/SLING-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-6165: Fix Version/s: Scripting Core 2.0.44 Scripting API 2.1.12 > Expose a service for

[CANCELLED][VOTE] Release Apache Sling Scripting API 2.1.10, Apache Sling Scripting Core 2.0.42

I've had to reopen SLING-6165 [0]. Will provide a fix and re-start the release. [0] - https://issues.apache.org/jira/browse/SLING-6165?focusedCommentId=15701545=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15701545 On Sat, 26 Nov 2016 at 13:55 Oliver Lietz

[jira] [Commented] (SLING-6165) Expose a service for Sling Scripting that provides request-scoped Resource Resolvers for scripting dependencies

[ https://issues.apache.org/jira/browse/SLING-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15701545#comment-15701545 ] Radu Cotescu commented on SLING-6165: - I've had to reopen this issue since Sling doesn't actually

[jira] [Reopened] (SLING-6165) Expose a service for Sling Scripting that provides request-scoped Resource Resolvers for scripting dependencies

[ https://issues.apache.org/jira/browse/SLING-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu reopened SLING-6165: - > Expose a service for Sling Scripting that provides request-scoped Resource > Resolvers for

Re: [VOTE] Release Apache Sling Commons Metrics 1.2.0

+1 Chetan Mehrotra On Mon, Nov 28, 2016 at 3:33 PM, Stefan Egli wrote: > +1 > > Cheers, > Stefan > > On 28/11/16 10:42, "Chetan Mehrotra" wrote: > >>Hi, >> >>We solved 5 issues in this release:

Re: [VOTE] Release Apache Sling Commons Metrics 1.2.0

+1 Cheers, Stefan On 28/11/16 10:42, "Chetan Mehrotra" wrote: >Hi, > >We solved 5 issues in this release: >https://issues.apache.org/jira/browse/SLING/fixforversion/12334646 > >Staging repository: >https://repository.apache.org/content/repositories/orgapachesling-1584 >

[VOTE] Release Apache Sling Commons Metrics 1.2.0

Hi, We solved 5 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12334646 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1584 You can use this UNIX script to download the release and verify the signatures:

[jira] [Resolved] (SLING-5966) Add Gauge support to metrics

[ https://issues.apache.org/jira/browse/SLING-5966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra resolved SLING-5966. Resolution: Fixed > Add Gauge support to metrics > > >

Re: How to handle minor version updates in API for provider bundles?

On Mon, Nov 28, 2016 at 9:50 AM, Konrad Windszus wrote: > ...There were no tests which had to be adjusted for the change, but in fact > there is a semantical change... hmm...hmm...hmm...that vague feeling that the test coverage is not what it should be ;-) Did you add tests

Re: How to handle minor version updates in API for provider bundles?

> Am 28.11.2016 um 09:50 schrieb Konrad Windszus : > @Felix: Regarding backwards compatibility: There were not tests which had to > be adjusted for the change, but in fact there is a semantical change. Please > look at https://issues.apache.org/jira/browse/SLING-6327 for

Re: How to handle minor version updates in API for provider bundles?

Thanks Konrad for moving the implementation. As I understand this issue, we *clarify* the semantics of RR.isResourceType and fix the implementation to be fully aligned with the fully defined semantics. AFAIU, Konrad reported the issue, because the impl didn't match his expectations. Bertrand and

[jira] [Comment Edited] (SLING-6327) ResourceResolverImpl.isResourceType() should compare relative resource types (and ignore any search path prefixes)

[ https://issues.apache.org/jira/browse/SLING-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15701332#comment-15701332 ] Konrad Windszus edited comment on SLING-6327 at 11/28/16 8:51 AM: -- After

Re: How to handle minor version updates in API for provider bundles?

I moved the new util methods regarding the resource type comparison to a private util class into the resource resolver bundle (in r1771688). The package version change still is necessary IMHO. @Felix: Regarding backwards compatibility: There were not tests which had to be adjusted for the

[jira] [Commented] (SLING-6327) ResourceResolverImpl.isResourceType() should compare relative resource types (and ignore any search path prefixes)

[ https://issues.apache.org/jira/browse/SLING-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15701332#comment-15701332 ] Konrad Windszus commented on SLING-6327: After some discussion in

Re: How to handle minor version updates in API for provider bundles?

Hi Konrad Hmm, are these changed semantics backwards compatible ? I.e. what do existing callers have to expect ? Regards Felix > Am 26.11.2016 um 17:18 schrieb Konrad Windszus : > > Moving the Util methods somewhere else (and even making that Util private) is > fine with me,

Re: trunk build does not work // was: mountByFS does not work

Hi Sandro, On Sun, Nov 27, 2016 at 11:39 PM, Sandro Boehme wrote: > ...Is there a launchpad version somewhere that compiles the latest > snapshots to the standalone jar?... We've been discussing generating that [1] along with a "stable" launchpad but that's not done yet.

Re: How to handle minor version updates in API for provider bundles?

On Sat, Nov 26, 2016 at 5:18 PM, Konrad Windszus wrote: > ...With the change in SLING-6327 the behaviour of Resource.isResourceType and > ResourceResolver.isResourceType > has been changed (semantically) and therefore requires at least a minor > version upgrade to allow