[jira] [Resolved] (SLING-8030) Scheduler should not depend on java.bean

[Karl Pauls (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls resolved SLING-8030.
---
Resolution: Fixed

Added a quartz org.quartz.simpl.PropertySettingJobFactory with an 
implementation that uses plain reflection instead of java.bean framework in 
3daa42a..d18f8b3. 

> Scheduler should not depend on java.bean
> 
>
> Key: SLING-8030
> URL: https://issues.apache.org/jira/browse/SLING-8030
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Affects Versions: Commons Scheduler 2.7.2
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Minor
> Fix For: Commons Scheduler 2.7.4
>
>
> The embedded quartz in the scheduler has a dependency on the java.bean 
> framework that is not really needed as it could just as well be using 
> reflection directly. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-8030) Scheduler should not depend on java.bean

[Karl Pauls (JIRA)]

Karl Pauls created SLING-8030:
-

 Summary: Scheduler should not depend on java.bean
 Key: SLING-8030
 URL: https://issues.apache.org/jira/browse/SLING-8030
 Project: Sling
  Issue Type: Improvement
  Components: Commons
Affects Versions: Commons Scheduler 2.7.2
Reporter: Karl Pauls
Assignee: Karl Pauls
 Fix For: Commons Scheduler 2.7.4


The embedded quartz in the scheduler has a dependency on the java.bean 
framework that is not really needed as it could just as well be using 
reflection directly. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-8027) Malformed JSON when serialising "include" elements

[David Bosschaert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Bosschaert resolved SLING-8027.
-
Resolution: Fixed

> Malformed JSON when serialising "include" elements
> --
>
> Key: SLING-8027
> URL: https://issues.apache.org/jira/browse/SLING-8027
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Maven Plugins and Archetypes
>Affects Versions: Feature Model IO 0.1.2
>Reporter: Simone Tripodi
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model 0.1.4
>
>
> Looks like object open in 
> [FeatureJSONWriter.java#L82|https://github.com/apache/sling-org-apache-sling-feature-io/blob/master/src/main/java/org/apache/sling/feature/io/json/FeatureJSONWriter.java#L82]
>  is not correctly closed, that causes 
> {{javax.json.stream.JsonGenerationException: Invalid json}} issues
> PR is coming



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-8027) Malformed JSON when serialising "include" elements

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652389#comment-16652389
 ] 

ASF GitHub Bot commented on SLING-8027:
---

bosschaert commented on issue #6: SLING-8027 - Malformed JSON when serialising 
"include" elements
URL: 
https://github.com/apache/sling-org-apache-sling-feature-io/pull/6#issuecomment-430387501
 
 
   Thanks for your pull request, @simonetripodi - it's merged!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Malformed JSON when serialising "include" elements
> --
>
> Key: SLING-8027
> URL: https://issues.apache.org/jira/browse/SLING-8027
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Maven Plugins and Archetypes
>Affects Versions: Feature Model IO 0.1.2
>Reporter: Simone Tripodi
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model 0.1.4
>
>
> Looks like object open in 
> [FeatureJSONWriter.java#L82|https://github.com/apache/sling-org-apache-sling-feature-io/blob/master/src/main/java/org/apache/sling/feature/io/json/FeatureJSONWriter.java#L82]
>  is not correctly closed, that causes 
> {{javax.json.stream.JsonGenerationException: Invalid json}} issues
> PR is coming



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-8027) Malformed JSON when serialising "include" elements

[David Bosschaert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Bosschaert updated SLING-8027:

Affects Version/s: Feature Model IO 0.1.2

> Malformed JSON when serialising "include" elements
> --
>
> Key: SLING-8027
> URL: https://issues.apache.org/jira/browse/SLING-8027
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Maven Plugins and Archetypes
>Affects Versions: Feature Model IO 0.1.2
>Reporter: Simone Tripodi
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model 0.1.4
>
>
> Looks like object open in 
> [FeatureJSONWriter.java#L82|https://github.com/apache/sling-org-apache-sling-feature-io/blob/master/src/main/java/org/apache/sling/feature/io/json/FeatureJSONWriter.java#L82]
>  is not correctly closed, that causes 
> {{javax.json.stream.JsonGenerationException: Invalid json}} issues
> PR is coming



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-8027) Malformed JSON when serialising "include" elements

[David Bosschaert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Bosschaert updated SLING-8027:

Fix Version/s: Feature Model 0.1.4

> Malformed JSON when serialising "include" elements
> --
>
> Key: SLING-8027
> URL: https://issues.apache.org/jira/browse/SLING-8027
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Maven Plugins and Archetypes
>Affects Versions: Feature Model IO 0.1.2
>Reporter: Simone Tripodi
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model 0.1.4
>
>
> Looks like object open in 
> [FeatureJSONWriter.java#L82|https://github.com/apache/sling-org-apache-sling-feature-io/blob/master/src/main/java/org/apache/sling/feature/io/json/FeatureJSONWriter.java#L82]
>  is not correctly closed, that causes 
> {{javax.json.stream.JsonGenerationException: Invalid json}} issues
> PR is coming



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-8025) Scheduler should not import javax.xml.bind

[Karl Pauls (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls resolved SLING-8025.
---
Resolution: Fixed

> Scheduler should not import javax.xml.bind
> --
>
> Key: SLING-8025
> URL: https://issues.apache.org/jira/browse/SLING-8025
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Affects Versions: Commons Scheduler 2.7.2
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Minor
> Fix For: Commons Scheduler 2.7.4
>
>
> The scheduler does currently import javax.xml.bind because the embedded 
> quartz does use it however, it isn't needed in the way we make use of quartz. 
> As jaxb isn't going to be around in java11 it shouldn't be imported.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-8027) Malformed JSON when serialising "include" elements

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652388#comment-16652388
 ] 

ASF GitHub Bot commented on SLING-8027:
---

bosschaert closed pull request #6: SLING-8027 - Malformed JSON when serialising 
"include" elements
URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/6
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Malformed JSON when serialising "include" elements
> --
>
> Key: SLING-8027
> URL: https://issues.apache.org/jira/browse/SLING-8027
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: Carsten Ziegeler
>Priority: Major
>
> Looks like object open in 
> [FeatureJSONWriter.java#L82|https://github.com/apache/sling-org-apache-sling-feature-io/blob/master/src/main/java/org/apache/sling/feature/io/json/FeatureJSONWriter.java#L82]
>  is not correctly closed, that causes 
> {{javax.json.stream.JsonGenerationException: Invalid json}} issues
> PR is coming



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] bosschaert closed pull request #6: SLING-8027 - Malformed JSON when serialising "include" elements

[GitBox]

bosschaert closed pull request #6: SLING-8027 - Malformed JSON when serialising 
"include" elements
URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/6
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [VOTE] Release Apache Sling Form Based Authentication Handler 1.0.12, Apache Sling Starter Content 1.0.2

[Georg Henzler]

+1

-Georg

P.S. Unrelated to release but worth improving: 
https://issues.apache.org/jira/browse/SLING-8029


On 2018-10-16 15:15, Carsten Ziegeler wrote:

+1

Am 16.10.2018 um 15:03 schrieb Robert Munteanu:


Hi,

We solved 5 issues in these release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12344132 (4)
https://issues.apache.org/jira/browse/SLING/fixforversion/12344305 (1)

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1995

You can use this UNIX script to download the release and verify the 
signatures:

https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 1995 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Thanks,

Robert

[jira] [Updated] (SLING-8029) Improve check_staged_release.sh to automatically receive the relevant gpg key

[Georg Henzler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Georg Henzler updated SLING-8029:
-
Description: 
When trying to validate the recent release for "Apache Sling Form Based 
Authentication Handler 1.0.12, Apache Sling Starter Content 1.0.2", I 
encountered the following problem:

{code}
$ sh check_staged_release.sh 1995 /tmp/sling-staging

   DOWNLOAD STAGED REPOSITORY   

2018-10-16 15:22:42 
URL:https://repository.apache.org/content/repositories/orgapachesling-1995/org/apache/sling/
 [1711] -> "/tmp/sling-staging/1995/org/apache/sling/index.html.tmp" [1]
2018-10-16 15:22:44 
URL:https://repository.apache.org/content/repositories/orgapachesling-1995/org/apache/sling/org.apache.sling.auth.form/
 [2554] -> 
"/tmp/sling-staging/1995/org/apache/sling/org.apache.sling.auth.form/index.html.tmp"
 [1]
2018-10-16 15:22:45 
URL:https://repository.apache.org/content/repositories/orgapachesling-1995/org/apache/sling/org.apache.sling.starter.content/
 [2588] -> 
"/tmp/sling-staging/1995/org/apache/sling/org.apache.sling.starter.content/index.html.tmp"
 [1]
.
.
FINISHED --2018-10-16 15:23:34--
Total wall clock time: 52s
Downloaded: 47 files, 579K in 0.5s (1.25 MB/s)

  CHECK SIGNATURES AND DIGESTS  

/tmp/sling-staging/1995/org/apache/sling/org.apache.sling.auth.form/maven-metadata.xml
gpg:  
md5 : GOOD (f165e0092858ee6f6b2301e0d17b1bf3)
sha1 : GOOD (2625d5c75b4b4efd0c43258a6c0dfeef3049d6f1)
/tmp/sling-staging/1995/org/apache/sling/org.apache.sling.auth.form/1.0.12/org.apache.sling.auth.form-1.0.12.jar
gpg:  BAD
md5 : GOOD (101ab3cee4ba891e9c6441e55a1166a0)
sha1 : GOOD (e1e9a32459688ff2e5d9fb6effc561eba708334d)
/tmp/sling-staging/1995/org/apache/sling/org.apache.sling.auth.form/1.0.12/org.apache.sling.auth.form-1.0.12-sources.jar
gpg:  BAD
md5 : GOOD (b8c81df2190741f3b0af50db369fa397)
sha1 : GOOD (6cd5ca4fb9ca64dd363846513502716d7aa8f0ae)
/tmp/sling-staging/1995/org/apache/sling/org.apache.sling.auth.form/1.0.12/org.apache.sling.auth.form-1.0.12-javadoc.jar
.
.

{code}
Taking out the piping to /dev/null in { gpg --verify $f.asc 2>/dev/null}} I got 
the root cause:
{code}
md5 : GOOD (21db726f5e7241cf619ca1ccb2105ab8)
sha1 : GOOD (003bedc98bde6c4673241413c8cbe4e910364be3)
/tmp/sling-staging/1995/org/apache/sling/org.apache.sling.auth.form/1.0.12/org.apache.sling.auth.form-1.0.12.pom
gpg: assuming signed data in 
'/tmp/sling-staging/1995/org/apache/sling/org.apache.sling.auth.form/1.0.12/org.apache.sling.auth.form-1.0.12.pom'
gpg: Signature made Tue Oct 16 08:57:50 2018 EDT
gpg:using RSA key 0A665C4670B478BF12235CCD339508654F63EC54
gpg: Can't check signature: No public key
gpg:  BAD
{code}

Now the key can be imported using {{gpg --keyserver pool.sks-keyservers.net 
--recv-keys }}. This should happen automatically. 


> Improve check_staged_release.sh to automatically receive the relevant gpg key
> -
>
> Key: SLING-8029
> URL: https://issues.apache.org/jira/browse/SLING-8029
> Project: Sling
>  Issue Type: Task
>Reporter: Georg Henzler
>Assignee: Georg Henzler
>Priority: Major
>
> When trying to validate the recent release for "Apache Sling Form Based 
> Authentication Handler 1.0.12, Apache Sling Starter Content 1.0.2", I 
> encountered the following problem:
> {code}
> $ sh check_staged_release.sh 1995 /tmp/sling-staging
> 
>DOWNLOAD STAGED REPOSITORY 
>   
> 
> 2018-10-16 15:22:42 
> URL:https://repository.apache.org/content/repositories/orgapachesling-1995/org/apache/sling/
>  [1711] -> "/tmp/sling-staging/1995/org/apache/sling/index.html.tmp" [1]
> 2018-10-16 15:22:44 
> URL:https://repository.apache.org/content/repositories/orgapachesling-1995/org/apache/sling/org.apache.sling.auth.form/
>  [2554] -> 
> "/tmp/sling-staging/1995/org/apache/sling/org.apache.sling.auth.form/index.html.tmp"
>  [1]
> 2018-10-16 15:22:45 
> URL:https://repository.apache.org/content/repositories/orgapachesling-1995/org/apache/sling/org.apache.sling.starter.content/
>  [2588] -> 
> 

[jira] [Created] (SLING-8029) Improve check_staged_release.sh to automatically receive the relevant gpg key

[Georg Henzler (JIRA)]

Georg Henzler created SLING-8029:


 Summary: Improve check_staged_release.sh to automatically receive 
the relevant gpg key
 Key: SLING-8029
 URL: https://issues.apache.org/jira/browse/SLING-8029
 Project: Sling
  Issue Type: Task
Reporter: Georg Henzler
Assignee: Georg Henzler






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] paul-bjorkstrand opened a new pull request #9: Fix SLING-7586 using SoftReferences and WeakHashMap

[GitBox]

paul-bjorkstrand opened a new pull request #9: Fix SLING-7586 using 
SoftReferences and WeakHashMap
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/9
 
 
   Allows the GC to collect cached model instances, even when self-referenced 
to the original adaptable (e.g. via @Self)
   
   This is slightly different than #6, as it allows the models to be cached, 
and not collected until the GC needs memory. The original fix in #6 would allow 
the GC to indiscriminately remove cached models, as soon as they were no longer 
strongly referenced, which can have a negative performance impact. Using 
SoftReference instead of WeakReference mitigates this impact, to some degree. 
There is still a risk of a model being created then suddenly garbage collected 
when no longer strongly referenced, but this implementation allows the model to 
live for as long as it can.
   
   A test has been included that fails before this patch (with a JVM killing 
OOM), but passes after.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [VOTE] Release Apache Sling Oak Restrictions 1.0.2

[Georg Henzler]

+1

On 2018-10-16 15:21, Georg Henzler wrote:

Hi,

We solved 2 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12338357

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1996

You can use this UNIX script to download the release and verify the 
signatures:

https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 1996 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

-Georg

[VOTE] Release Apache Sling Oak Restrictions 1.0.2

[Georg Henzler]

Hi,

We solved 2 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12338357

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1996

You can use this UNIX script to download the release and verify the 
signatures:

https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 1996 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

-Georg

[jira] [Closed] (SLING-7790) Allow for synchronous installation of bundles and configurations via install hook

[Georg Henzler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Georg Henzler closed SLING-7790.


> Allow for synchronous installation of bundles and configurations via install 
> hook
> -
>
> Key: SLING-7790
> URL: https://issues.apache.org/jira/browse/SLING-7790
> Project: Sling
>  Issue Type: New Feature
>  Components: Installer
>Reporter: Georg Henzler
>Assignee: Georg Henzler
>Priority: Major
> Fix For: Installer Vault Package Install Hook 1.0.2
>
>
> Normally bundles configurations are installed asynchronously after a bundle 
> is saved to the JCR during package installation (vault packages). This is due 
> to the backgroundThread that the OsgiInstallerImpl is using. Since the 
> introduction of the pauseInstallation signal node via SLING-3747, the 
> installation of bundles and configurations is even forced to after the 
> completed vault package installation. This behaviour also means that the 
> package dependency can be declared, but it is not effective on "contained 
> bundle level" but only on JCR content level. The following is not possible 
> today:
> Complete Package with sub packages:
> * Package A (containing Bundle A)
> * Package B (containing Bundle B) with dependency to Bundle A
> If it is just a OSGi package dependency from Bundle B to Bundle A the 
> installation order does not matter (the OSGi framework will sort it out). 
> However if the content of Package B has a dependency to bundle A (think 
> custom oak restrictions [1] or install hooks referenced) there will be an 
> error. 
> To allow for those cases and to avoid manual steps (not providing a complete 
> package often means exactly that), it would be good to have a means to 
> install contained bundles of a package synchronously. This can be achieved by 
> a fairly simple install hook that "pre-installs" the contained 
> InstallableResources with the correct digest to the OsgiInstaller. The 
> subsequent call of sling-org-apache-sling-installer-provider-jcr will just 
> update the already installed resource again with the same digest (which will 
> not cause any action in the system). 
> Obviously this mechanism should only be used where needed and only for 
> configurations and bundles that are safe to install (bundles/configs that 
> will never restart any of the base services). Using the install hook makes 
> the mechanism "opt-in". 
> [1] 
> https://sling.apache.org/documentation/bundles/sling-oak-restrictions.html
> https://jackrabbit.apache.org/oak/docs/security/authorization/restriction.html#pluggability



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Release Apache Sling Form Based Authentication Handler 1.0.12, Apache Sling Starter Content 1.0.2

[Carsten Ziegeler]

+1

Am 16.10.2018 um 15:03 schrieb Robert Munteanu:


Hi,

We solved 5 issues in these release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12344132 (4)
https://issues.apache.org/jira/browse/SLING/fixforversion/12344305 (1)

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1995

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 1995 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Thanks,

Robert



--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[GitHub] JEBailey opened a new pull request #13: example of sling resource filter usage

[GitBox]

JEBailey opened a new pull request #13: example of sling resource filter usage
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/13
 
 
   Examples of reusing existing resource traversal functions rather than 
writing yet another traversal.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (SLING-7922) Update to latest available releases for Sling 11

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652069#comment-16652069
 ] 

Carsten Ziegeler commented on SLING-7922:
-

[~rombert] Yes, they are new and there are currently two new versions under 
vote, so we can update them when those new ones are available

> Update to latest available releases for Sling 11
> 
>
> Key: SLING-7922
> URL: https://issues.apache.org/jira/browse/SLING-7922
> Project: Sling
>  Issue Type: Sub-task
>  Components: Starter
>Reporter: Robert Munteanu
>Priority: Major
>
> Should look into:
> - Sling modules that are released but not included
> - Felix bundles
> - Oak 1.8
> - Other misc dependencies



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-8028) Split FeatureExtensionHandler into MergeHandler and PostProcessor

[David Bosschaert (JIRA)]

David Bosschaert created SLING-8028:
---

 Summary: Split FeatureExtensionHandler into MergeHandler and 
PostProcessor
 Key: SLING-8028
 URL: https://issues.apache.org/jira/browse/SLING-8028
 Project: Sling
  Issue Type: New Feature
  Components: Feature Model
Affects Versions: Feature Model 0.1.2
Reporter: David Bosschaert
Assignee: David Bosschaert
 Fix For: Feature Model 0.1.4


The FeatureExtensionHandler class currently performs two tasks: merging and 
postprocessing. This should be split into two interfaces each with a clear 
purpose.

The APIs should also be provided with a context object so that it will be 
possible to perform certain tasks that require plugins. For example mapping an 
Artifact ID to a file.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-8026) Sling Oak Restrictions not compatible with oak 1.8.x

[Georg Henzler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Georg Henzler resolved SLING-8026.
--
Resolution: Fixed

> Sling Oak Restrictions not compatible with oak 1.8.x
> 
>
> Key: SLING-8026
> URL: https://issues.apache.org/jira/browse/SLING-8026
> Project: Sling
>  Issue Type: Task
>  Components: Oak
>Reporter: Georg Henzler
>Assignee: Georg Henzler
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The Sling oak restrictions [1] are not compatible to oak 1.8.x since it 
> imports TreeUtil [2] that is not part of the SPI (and the location has 
> changed). To maintain compatibility to older oak versions, it would be best 
> to get rid of the TreeUtil.getString(treeToCheck, SLING_RESOURCE_TYPE) call 
> altogether (TreeUtils provides a simple type conversion and null check that 
> can be directly part of ResourceTypePattern to minimise package dependencies).
> [1] https://sling.apache.org/documentation/bundles/sling-oak-restrictions.html
> [2] 
> https://github.com/apache/sling-org-apache-sling-oak-restrictions/blob/master/src/main/java/org/apache/sling/oak/restrictions/impl/ResourceTypePattern.java#L28



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] ghenzler closed pull request #1: SLING-8026: remove TreeUtil to be compatible with oax 1.8.x

[GitBox]

ghenzler closed pull request #1: SLING-8026: remove TreeUtil to be compatible 
with oax 1.8.x
URL: https://github.com/apache/sling-org-apache-sling-oak-restrictions/pull/1
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pom.xml b/pom.xml
index 1614995..f3793c0 100644
--- a/pom.xml
+++ b/pom.xml
@@ -53,7 +53,6 @@
 -->
 
 org.apache.jackrabbit.oak.api;version="[1.0,4)",
-org.apache.jackrabbit.oak.util;version="0.0.0",
 *
 
 
diff --git 
a/src/main/java/org/apache/sling/oak/restrictions/impl/ResourceTypePattern.java 
b/src/main/java/org/apache/sling/oak/restrictions/impl/ResourceTypePattern.java
index e2dd109..432f554 100644
--- 
a/src/main/java/org/apache/sling/oak/restrictions/impl/ResourceTypePattern.java
+++ 
b/src/main/java/org/apache/sling/oak/restrictions/impl/ResourceTypePattern.java
@@ -24,8 +24,8 @@
 
 import org.apache.jackrabbit.oak.api.PropertyState;
 import org.apache.jackrabbit.oak.api.Tree;
+import org.apache.jackrabbit.oak.api.Type;
 import 
org.apache.jackrabbit.oak.spi.security.authorization.restriction.RestrictionPattern;
-import org.apache.jackrabbit.oak.util.TreeUtil;
 import org.apache.sling.api.SlingConstants;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
@@ -126,7 +126,7 @@ private boolean matchesAtTree(Tree tree) {
 }
 
 Set resourceTypesForPath = 
resourceTypesByPath.get(path);
-String actualResourceType = TreeUtil.getString(treeToCheck, 
SLING_RESOURCE_TYPE);
+String actualResourceType = 
getResourceTypeFromTree(treeToCheck);
 isResourceTypeMatch = 
resourceTypesForPath.contains(actualResourceType);
 
 if(LOG.isTraceEnabled()) {
@@ -140,6 +140,10 @@ private boolean matchesAtTree(Tree tree) {
 return isResourceTypeMatch;
 }
 
+public String getResourceTypeFromTree(Tree treeToCheck) {
+PropertyState property = treeToCheck.getProperty(SLING_RESOURCE_TYPE);
+return property != null && !property.isArray() ? 
property.getValue(Type.STRING) : null;
+}
 
 @Override
 public boolean matches(@NotNull String path) {


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ghenzler commented on issue #1: SLING-8026: remove TreeUtil to be compatible with oax 1.8.x

[GitBox]

ghenzler commented on issue #1: SLING-8026: remove TreeUtil to be compatible 
with oax 1.8.x
URL: 
https://github.com/apache/sling-org-apache-sling-oak-restrictions/pull/1#issuecomment-430301570
 
 
   PR looks good, thanks @felizo for your contribution.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] felizo opened a new pull request #1: SLING-8026: remove TreeUtil to be compatible with oax 1.8.x

[GitBox]

felizo opened a new pull request #1: SLING-8026: remove TreeUtil to be 
compatible with oax 1.8.x
URL: https://github.com/apache/sling-org-apache-sling-oak-restrictions/pull/1
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [VOTE] Release Apache Sling Form Based Authentication Handler 1.0.12, Apache Sling Starter Content 1.0.2

[Robert Munteanu]

On Tue, 2018-10-16 at 15:03 +0200, Robert Munteanu wrote:
> Please vote to approve this release:

+1

Robert


signature.asc
Description: This is a digitally signed message part

Please review Sling 11 release notes

[Robert Munteanu]

Hi,

I wrote a draft of the Sling 11 release notes (not yet linked from the
front page).

  https://sling.apache.org/news/sling-11-released.html

It would be great if you would give it a quick look and reply or
directly modify if things are missing/incorrect/etc.

Thanks!

Robert

[jira] [Commented] (SLING-8027) Malformed JSON when serialising "include" elements

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651968#comment-16651968
 ] 

ASF GitHub Bot commented on SLING-8027:
---

simonetripodi opened a new pull request #6: SLING-8027 - Malformed JSON when 
serialising "include" elements
URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/6
 
 
   close the open JSONConstants.FEATURE_INCLUDE element


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Malformed JSON when serialising "include" elements
> --
>
> Key: SLING-8027
> URL: https://issues.apache.org/jira/browse/SLING-8027
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: Carsten Ziegeler
>Priority: Major
>
> Looks like object open in 
> [FeatureJSONWriter.java#L82|https://github.com/apache/sling-org-apache-sling-feature-io/blob/master/src/main/java/org/apache/sling/feature/io/json/FeatureJSONWriter.java#L82]
>  is not correctly closed, that causes 
> {{javax.json.stream.JsonGenerationException: Invalid json}} issues
> PR is coming



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] simonetripodi opened a new pull request #6: SLING-8027 - Malformed JSON when serialising "include" elements

[GitBox]

simonetripodi opened a new pull request #6: SLING-8027 - Malformed JSON when 
serialising "include" elements
URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/6
 
 
   close the open JSONConstants.FEATURE_INCLUDE element


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Resolved] (SLING-7910) Create 'New and Noteworthy' page for Sling 11

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-7910.

Resolution: Fixed

> Create 'New and Noteworthy' page for Sling 11
> -
>
> Key: SLING-7910
> URL: https://issues.apache.org/jira/browse/SLING-7910
> Project: Sling
>  Issue Type: Sub-task
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-8027) Malformed JSON when serialising "include" elements

[Simone Tripodi (JIRA)]

Simone Tripodi created SLING-8027:
-

 Summary: Malformed JSON when serialising "include" elements
 Key: SLING-8027
 URL: https://issues.apache.org/jira/browse/SLING-8027
 Project: Sling
  Issue Type: Improvement
  Components: Feature Model, Maven Plugins and Archetypes
Reporter: Simone Tripodi
Assignee: Carsten Ziegeler


Looks like object open in 
[FeatureJSONWriter.java#L82|https://github.com/apache/sling-org-apache-sling-feature-io/blob/master/src/main/java/org/apache/sling/feature/io/json/FeatureJSONWriter.java#L82]
 is not correctly closed, that causes 
{{javax.json.stream.JsonGenerationException: Invalid json}} issues

PR is coming



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-8026) Sling Oak Restrictions not compatible with oak 1.8.x

[Georg Henzler (JIRA)]

Georg Henzler created SLING-8026:


 Summary: Sling Oak Restrictions not compatible with oak 1.8.x
 Key: SLING-8026
 URL: https://issues.apache.org/jira/browse/SLING-8026
 Project: Sling
  Issue Type: Task
  Components: Oak
Reporter: Georg Henzler
Assignee: Georg Henzler


The Sling oak restrictions [1] are not compatible to oak 1.8.x since it imports 
TreeUtil [2] that is not part of the SPI (and the location has changed). To 
maintain compatibility to older oak versions, it would be best to get rid of 
the TreeUtil.getString(treeToCheck, SLING_RESOURCE_TYPE) call altogether 
(TreeUtils provides a simple type conversion and null check that can be 
directly part of ResourceTypePattern to minimise package dependencies).


[1] https://sling.apache.org/documentation/bundles/sling-oak-restrictions.html
[2] 
https://github.com/apache/sling-org-apache-sling-oak-restrictions/blob/master/src/main/java/org/apache/sling/oak/restrictions/impl/ResourceTypePattern.java#L28



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] klcodanr commented on issue #6: SLING-7586 - using weak references as cache values to avoid memory leak

[GitBox]

klcodanr commented on issue #6: SLING-7586 - using weak references as cache 
values to avoid memory leak
URL: 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/6#issuecomment-430243124
 
 
   @paul-bjorkstrand I have some cycles to help with this. Let's work together 
on coming up with some way to test the efficacy of this change.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Assigned] (SLING-7910) Create 'New and Noteworthy' page for Sling 11

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-7910:
--

Assignee: Robert Munteanu

> Create 'New and Noteworthy' page for Sling 11
> -
>
> Key: SLING-7910
> URL: https://issues.apache.org/jira/browse/SLING-7910
> Project: Sling
>  Issue Type: Sub-task
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7922) Update to latest available releases for Sling 11

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651674#comment-16651674
 ] 

Robert Munteanu commented on SLING-7922:


I think configadmin and scr are brand new ones, and I'll update them now. The 
web console stuff needs a new auth.form release, which is underway. The ant and 
doxia stuff comes in from plugin management and plugin dependencies so not 
directly applicable to us.

> Update to latest available releases for Sling 11
> 
>
> Key: SLING-7922
> URL: https://issues.apache.org/jira/browse/SLING-7922
> Project: Sling
>  Issue Type: Sub-task
>  Components: Starter
>Reporter: Robert Munteanu
>Priority: Major
>
> Should look into:
> - Sling modules that are released but not included
> - Felix bundles
> - Oak 1.8
> - Other misc dependencies



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Release Apache Sling Form Based Authentication Handler 1.0.12, Apache Sling Starter Content 1.0.2

[Bertrand Delacretaz]

On Tue, Oct 16, 2018 at 3:03 PM Robert Munteanu  wrote:
> ...Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-1995
...

+1 for the release of

org.apache.sling.auth.form-1.0.12-source-release.zip
sha1 : 152160dad7479556e73a10f23c7b913214bf3c91

org.apache.sling.starter.content-1.0.2-source-release.zip
sha1 : 30d4a87e9f88704d2c201f5a658891da5b6f9022

Checked signatures, digests and build.

-Bertrand

[jira] [Commented] (SLING-7922) Update to latest available releases for Sling 11

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651646#comment-16651646
 ] 

Bertrand Delacretaz commented on SLING-7922:


FWIW, {{versions:display-dependency-updates | grep org.apache}} shows a few 
updates that I suppose have happened in the meantime, not sure if we want to 
update those as well:

{code}
   org.apache.felix:org.apache.felix.configadmin . 1.9.6 -> 1.9.8
   org.apache.felix:org.apache.felix.scr  2.1.8 -> 2.1.10
   org.apache.sling:org.apache.sling.extensions.webconsolesecurityprovider ...
   org.apache.ant:ant-apache-regexp . 1.7.1 -> 1.10.5
   org.apache.maven.doxia:doxia-core . 1.2 -> 1.8
   org.apache.maven.doxia:doxia-core . 1.2 -> 1.8
{code}

I suppose the last 3 can be ignored.

> Update to latest available releases for Sling 11
> 
>
> Key: SLING-7922
> URL: https://issues.apache.org/jira/browse/SLING-7922
> Project: Sling
>  Issue Type: Sub-task
>  Components: Starter
>Reporter: Robert Munteanu
>Priority: Major
>
> Should look into:
> - Sling modules that are released but not included
> - Felix bundles
> - Oak 1.8
> - Other misc dependencies



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7953) Switch from legacy commons lang 2 to commons lang 3

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651622#comment-16651622
 ] 

Robert Munteanu commented on SLING-7953:


We can't drop commons-lang 2.x from the starter until Tika drops it as well.

> Switch from legacy commons lang 2 to commons lang 3
> ---
>
> Key: SLING-7953
> URL: https://issues.apache.org/jira/browse/SLING-7953
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Priority: Major
> Fix For: XSS Protection API 2.1.0, Scripting JSP Taglib 2.3.2
>
>
> The following bundles still use the legacy commons lang 2 version
>  They should be updated to use commons lang 3
>  org.apache.sling.auth.form (/)
>  org.apache.sling.installer.hc (/)
>  org.apache.sling.scripting.jsp.taglib 
>  org.apache.sling.xss 
>  org.apache.tika.parsers



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-8025) Scheduler should not import javax.xml.bind

[Karl Pauls (JIRA)]

Karl Pauls created SLING-8025:
-

 Summary: Scheduler should not import javax.xml.bind
 Key: SLING-8025
 URL: https://issues.apache.org/jira/browse/SLING-8025
 Project: Sling
  Issue Type: Improvement
  Components: Commons
Affects Versions: Commons Scheduler 2.7.2
Reporter: Karl Pauls
Assignee: Karl Pauls
 Fix For: Commons Scheduler 2.7.4


The scheduler does currently import javax.xml.bind because the embedded quartz 
does use it however, it isn't needed in the way we make use of quartz. As jaxb 
isn't going to be around in java11 it shouldn't be imported.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-8024) Switch to commons-lang 3

[Robert Munteanu (JIRA)]

Robert Munteanu created SLING-8024:
--

 Summary: Switch to commons-lang 3
 Key: SLING-8024
 URL: https://issues.apache.org/jira/browse/SLING-8024
 Project: Sling
  Issue Type: Improvement
Reporter: Robert Munteanu


Tika 1.9.1 is using the legacy commons-lang 2.x series. This series is not 
going to receive updates anymore and is completely superseded by commons-lang 
3.x .

Projects that use Tika are blocked from dropping commons-lang 2.x due to this 
dependency.

The link that I found was from tika-parsers to jackcess and then to 
commons-lang 2.6

{noformat}
[INFO] +- com.healthmarketscience.jackcess:jackcess:jar:2.1.12:compile
[INFO] |  \- commons-lang:commons-lang:jar:2.6:compile
{noformat}

If I understand correctly, this is the only commons-lang 2.x dependency from 
the Tika runtime and it would be great to remove it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7922) Update to latest available releases for Sling 11

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651613#comment-16651613
 ] 

Robert Munteanu commented on SLING-7922:


Remaining updates for Sling 11:

* {{org.apache.sling.auth.form}} - pending release
* {{org.apache.sling.starter.content}} - pending release
* {{org.apache.sling.extensions.webconsolesecurityprovider}} - needs latest 
auth.form release

I guess we can call it a day after this.

> Update to latest available releases for Sling 11
> 
>
> Key: SLING-7922
> URL: https://issues.apache.org/jira/browse/SLING-7922
> Project: Sling
>  Issue Type: Sub-task
>  Components: Starter
>Reporter: Robert Munteanu
>Priority: Major
>
> Should look into:
> - Sling modules that are released but not included
> - Felix bundles
> - Oak 1.8
> - Other misc dependencies



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7970) Add Feature Model introspection service

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651591#comment-16651591
 ] 

ASF GitHub Bot commented on SLING-7970:
---

bosschaert commented on issue #4: SLING-7970 Add Feature Model introspection 
Service API
URL: 
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/4#issuecomment-430215509
 
 
   Closing pull request, trying an alternative approach that would not require 
an API.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add Feature Model introspection service
> ---
>
> Key: SLING-7970
> URL: https://issues.apache.org/jira/browse/SLING-7970
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model
>Reporter: David Bosschaert
>Assignee: David Bosschaert
>Priority: Major
>
> We need a service that can report on the feature model that is launched by 
> the launcher, for introspection purposes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7970) Add Feature Model introspection service

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651592#comment-16651592
 ] 

ASF GitHub Bot commented on SLING-7970:
---

bosschaert closed pull request #4: SLING-7970 Add Feature Model introspection 
Service API
URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/4
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pom.xml b/pom.xml
index 9debaf3..67dfb97 100644
--- a/pom.xml
+++ b/pom.xml
@@ -93,6 +93,11 @@
 2.6
 provided
 
+
+org.osgi
+org.osgi.annotation.versioning
+provided
+
 
 org.osgi
 osgi.core
diff --git 
a/src/main/java/org/apache/sling/feature/launcher/impl/FeatureProcessor.java 
b/src/main/java/org/apache/sling/feature/launcher/impl/FeatureProcessor.java
index dd5c2bb..018f1ea 100644
--- a/src/main/java/org/apache/sling/feature/launcher/impl/FeatureProcessor.java
+++ b/src/main/java/org/apache/sling/feature/launcher/impl/FeatureProcessor.java
@@ -19,6 +19,7 @@
 import java.io.File;
 import java.io.FileReader;
 import java.io.IOException;
+import java.io.StringWriter;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.HashMap;
@@ -42,6 +43,7 @@
 import org.apache.sling.feature.io.file.ArtifactHandler;
 import org.apache.sling.feature.io.file.ArtifactManager;
 import org.apache.sling.feature.io.json.FeatureJSONReader;
+import org.apache.sling.feature.io.json.FeatureJSONWriter;
 import org.apache.sling.feature.launcher.spi.LauncherPrepareContext;
 import org.apache.sling.feature.launcher.spi.extensions.ExtensionHandler;
 
@@ -120,7 +122,7 @@ public static void prepareLauncher(final 
LauncherPrepareContext ctx, final Launc
 for(final Artifact a : entry.getValue()) {
 final File artifactFile = ctx.getArtifactFile(a.getId());
 
-config.getInstallation().addBundle(entry.getKey(), 
artifactFile);
+config.getInstallation().addBundle(entry.getKey(), 
a.getId().toMvnId(), artifactFile);
 }
 }
 
@@ -138,6 +140,10 @@ public static void prepareLauncher(final 
LauncherPrepareContext ctx, final Launc
 }
 }
 
+StringWriter featureStringWriter = new StringWriter();
+FeatureJSONWriter.write(featureStringWriter, app);
+
config.getInstallation().setEffectiveFeature(featureStringWriter.toString());
+
 extensions: for(final Extension ext : app.getExtensions()) {
 for (ExtensionHandler handler : 
ServiceLoader.load(ExtensionHandler.class,  
FeatureProcessor.class.getClassLoader()))
 {
diff --git 
a/src/main/java/org/apache/sling/feature/launcher/impl/Installation.java 
b/src/main/java/org/apache/sling/feature/launcher/impl/Installation.java
index 3f08856..3fa11d3 100644
--- a/src/main/java/org/apache/sling/feature/launcher/impl/Installation.java
+++ b/src/main/java/org/apache/sling/feature/launcher/impl/Installation.java
@@ -23,6 +23,7 @@
 import java.util.ArrayList;
 import java.util.Dictionary;
 import java.util.HashMap;
+import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
 
@@ -35,7 +36,7 @@
 private final Map fwkProperties = new HashMap<>();
 
 /** Bundle map */
-private final Map> bundleMap = new HashMap<>();
+private final Map> bundleMap = new HashMap<>();
 
 /** Artifacts to be installed */
 private final List installables = new ArrayList<>();
@@ -46,6 +47,9 @@
 /** The list of app jars. */
 private final List appJars = new ArrayList<>();
 
+/** The effective, merged feature used to launch. */
+private String effectiveFeature;
+
 /**
  * Add an application jar.
  * @param jar The application jar
@@ -65,15 +69,17 @@ public void addAppJar(final File jar) {
 /**
  * Add a bundle with the given start level
  * @param startLevel The start level
+ * @param id The artifact ID for the bundle
  * @param file The bundle file
  */
-public void addBundle(final Integer startLevel, final File file) {
-List files = bundleMap.get(startLevel);
+@Override
+public void addBundle(final Integer startLevel, final String id, final 
File file) {
+Map files = bundleMap.get(startLevel);
 if ( files == null ) {
-files = new ArrayList<>();
+files = new LinkedHashMap<>();
 bundleMap.put(startLevel, files);
 }
-files.add(file);
+files.put(id, file);
 }
 
 /**
@@ -112,7 +118,7 @@ public void addFrameworkProperty(String key, String value)
  * @see 

[GitHub] bosschaert closed pull request #4: SLING-7970 Add Feature Model introspection Service API

[GitBox]

bosschaert closed pull request #4: SLING-7970 Add Feature Model introspection 
Service API
URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/4
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pom.xml b/pom.xml
index 9debaf3..67dfb97 100644
--- a/pom.xml
+++ b/pom.xml
@@ -93,6 +93,11 @@
 2.6
 provided
 
+
+org.osgi
+org.osgi.annotation.versioning
+provided
+
 
 org.osgi
 osgi.core
diff --git 
a/src/main/java/org/apache/sling/feature/launcher/impl/FeatureProcessor.java 
b/src/main/java/org/apache/sling/feature/launcher/impl/FeatureProcessor.java
index dd5c2bb..018f1ea 100644
--- a/src/main/java/org/apache/sling/feature/launcher/impl/FeatureProcessor.java
+++ b/src/main/java/org/apache/sling/feature/launcher/impl/FeatureProcessor.java
@@ -19,6 +19,7 @@
 import java.io.File;
 import java.io.FileReader;
 import java.io.IOException;
+import java.io.StringWriter;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.HashMap;
@@ -42,6 +43,7 @@
 import org.apache.sling.feature.io.file.ArtifactHandler;
 import org.apache.sling.feature.io.file.ArtifactManager;
 import org.apache.sling.feature.io.json.FeatureJSONReader;
+import org.apache.sling.feature.io.json.FeatureJSONWriter;
 import org.apache.sling.feature.launcher.spi.LauncherPrepareContext;
 import org.apache.sling.feature.launcher.spi.extensions.ExtensionHandler;
 
@@ -120,7 +122,7 @@ public static void prepareLauncher(final 
LauncherPrepareContext ctx, final Launc
 for(final Artifact a : entry.getValue()) {
 final File artifactFile = ctx.getArtifactFile(a.getId());
 
-config.getInstallation().addBundle(entry.getKey(), 
artifactFile);
+config.getInstallation().addBundle(entry.getKey(), 
a.getId().toMvnId(), artifactFile);
 }
 }
 
@@ -138,6 +140,10 @@ public static void prepareLauncher(final 
LauncherPrepareContext ctx, final Launc
 }
 }
 
+StringWriter featureStringWriter = new StringWriter();
+FeatureJSONWriter.write(featureStringWriter, app);
+
config.getInstallation().setEffectiveFeature(featureStringWriter.toString());
+
 extensions: for(final Extension ext : app.getExtensions()) {
 for (ExtensionHandler handler : 
ServiceLoader.load(ExtensionHandler.class,  
FeatureProcessor.class.getClassLoader()))
 {
diff --git 
a/src/main/java/org/apache/sling/feature/launcher/impl/Installation.java 
b/src/main/java/org/apache/sling/feature/launcher/impl/Installation.java
index 3f08856..3fa11d3 100644
--- a/src/main/java/org/apache/sling/feature/launcher/impl/Installation.java
+++ b/src/main/java/org/apache/sling/feature/launcher/impl/Installation.java
@@ -23,6 +23,7 @@
 import java.util.ArrayList;
 import java.util.Dictionary;
 import java.util.HashMap;
+import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
 
@@ -35,7 +36,7 @@
 private final Map fwkProperties = new HashMap<>();
 
 /** Bundle map */
-private final Map> bundleMap = new HashMap<>();
+private final Map> bundleMap = new HashMap<>();
 
 /** Artifacts to be installed */
 private final List installables = new ArrayList<>();
@@ -46,6 +47,9 @@
 /** The list of app jars. */
 private final List appJars = new ArrayList<>();
 
+/** The effective, merged feature used to launch. */
+private String effectiveFeature;
+
 /**
  * Add an application jar.
  * @param jar The application jar
@@ -65,15 +69,17 @@ public void addAppJar(final File jar) {
 /**
  * Add a bundle with the given start level
  * @param startLevel The start level
+ * @param id The artifact ID for the bundle
  * @param file The bundle file
  */
-public void addBundle(final Integer startLevel, final File file) {
-List files = bundleMap.get(startLevel);
+@Override
+public void addBundle(final Integer startLevel, final String id, final 
File file) {
+Map files = bundleMap.get(startLevel);
 if ( files == null ) {
-files = new ArrayList<>();
+files = new LinkedHashMap<>();
 bundleMap.put(startLevel, files);
 }
-files.add(file);
+files.put(id, file);
 }
 
 /**
@@ -112,7 +118,7 @@ public void addFrameworkProperty(String key, String value)
  * @see 
org.apache.sling.feature.launcher.spi.LauncherRunContext#getBundleMap()
  */
 @Override
-public Map> getBundleMap() {
+public Map> getBundleMap() {
 return this.bundleMap;
 }
 
@@ -132,6 +138,22 @@ public void 

[GitHub] bosschaert commented on issue #4: SLING-7970 Add Feature Model introspection Service API

[GitBox]

bosschaert commented on issue #4: SLING-7970 Add Feature Model introspection 
Service API
URL: 
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/4#issuecomment-430215509
 
 
   Closing pull request, trying an alternative approach that would not require 
an API.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Resolved] (SLING-7950) Fix ITs with Oak 1.8

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-7950.

Resolution: Fixed

Fixed in [sling-org-apache-sling-launchpad-integration-tests commit 
632f569|https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/commit/632f569].

> Fix ITs with Oak 1.8
> 
>
> Key: SLING-7950
> URL: https://issues.apache.org/jira/browse/SLING-7950
> Project: Sling
>  Issue Type: Sub-task
>  Components: Launchpad, Oak, Testing
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Launchpad Integration Tests 1.0.8
>
>
> Updating to Oak 1.8.7 results in the following failures:
> {noformat}[ERROR] Failures: 
> [ERROR]   AnonymousAccessTest.testAnonymousContent:99->assertContent:85 
> Expected status 200 for 
> http://localhost:41000/ANON_CAN_READ/AnonymousAccessTest/789235c4-d3b2-43b3-a163-aadb95cdd56b/test_text_789235c4_d.txt
>  (content=) expected:<200> but was:<401>
> [ERROR]   AnonymousAccessTest.testAnonymousContent:101 Expecting status 404 
> when testing outside of anonymous access subtree expected:<404> but was:<401>
> [ERROR]   
> AuthRequestLoginTest.testForcedLogin:40->HttpTestBase.getContent:419->HttpTestBase.getContent:424->HttpTestBase.getContent:432->HttpTestBase.getContent:457
>  Expected status 200 for 
> http://localhost:41000/system/sling/info.sessionInfo.json (content=) 
> expected:<200> but was:<401>
> [ERROR]   RedirectOnLogoutTest.testRedirectToResourceAfterLogout:70 Expected 
> redirect expected:<302> but was:<401>
> [ERROR] Errors: 
> [ERROR]   DavExDisabledAnonAccessTest>DavExIntegrationTest.setUp:47 » 
> NoClassDefFound or...
> [ERROR]   DavExDisabledAnonAccessTest>DavExIntegrationTest.setUp:47 » 
> NoClassDefFound or...
> [ERROR]   DavExIntegrationTest.setUp:47 » NoClassDefFound 
> org/apache/jackrabbit/webdav/c...
> [ERROR]   DavExIntegrationTest.setUp:47 » NoClassDefFound 
> org/apache/jackrabbit/webdav/c...
> [INFO] 
> [ERROR] Tests run: 655, Failures: 4, Errors: 4, Skipped: 1{noformat}
> The changes that support this are at 
> https://github.com/apache/sling-org-apache-sling-starter/tree/feature/oak-1.8



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] rombert closed pull request #2: Upgraded oak to 1.8.3 + minor version bumps

[GitBox]

rombert closed pull request #2: Upgraded oak to 1.8.3 + minor version bumps
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/2
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/main/provisioning/oak.txt b/src/main/provisioning/oak.txt
index 5d2675c..4d6a6a0 100644
--- a/src/main/provisioning/oak.txt
+++ b/src/main/provisioning/oak.txt
@@ -20,17 +20,25 @@
 [feature name=oak]
 
 [variables]
-oak.version=1.6.8
+oak.version=1.8.3
 
 # The segment node store is used via a configuration
 [artifacts startLevel=10]
 org.apache.felix/org.apache.felix.jaas/1.0.2
 
 [artifacts startLevel=15]
-org.apache.jackrabbit/oak-core/${oak.version}
+org.apache.jackrabbit/oak-api/${oak.version}
 org.apache.jackrabbit/oak-commons/${oak.version}
+org.apache.jackrabbit/oak-core/${oak.version}
+org.apache.jackrabbit/oak-core-spi/${oak.version}
+org.apache.jackrabbit/oak-store-spi/${oak.version}
+org.apache.jackrabbit/oak-store-document/${oak.version}
+org.apache.jackrabbit/oak-store-composite/${oak.version}
+org.apache.jackrabbit/oak-query-spi/${oak.version}
+org.apache.jackrabbit/oak-security-spi/${oak.version}
 org.apache.jackrabbit/oak-lucene/${oak.version}
 org.apache.jackrabbit/oak-blob/${oak.version}
+org.apache.jackrabbit/oak-blob-plugins/${oak.version}
 org.apache.jackrabbit/oak-jcr/${oak.version}
 
 [artifacts startLevel=15 runModes=oak_tar]
@@ -43,7 +51,7 @@
 # start the Oak server instance after all components have been configured
 # and started to avoid restarting that component ( see SLING-4556 )
 [artifacts startLevel=16]
-org.apache.sling/org.apache.sling.jcr.oak.server/1.1.4
+org.apache.sling/org.apache.sling.jcr.oak.server/1.2.0
 
 [configurations]
   org.apache.felix.jaas.Configuration.factory-GuestLoginModule
diff --git a/src/main/provisioning/sling.txt b/src/main/provisioning/sling.txt
index 49de475..874a027 100644
--- a/src/main/provisioning/sling.txt
+++ b/src/main/provisioning/sling.txt
@@ -20,7 +20,7 @@
 [feature name=sling]
 
 [variables]
-jackrabbit.version=2.14.4
+jackrabbit.version=2.16.1
 
 [artifacts]
 # Add the Slingshot Sample provisioning model


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (SLING-7950) Fix ITs with Oak 1.8

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-7950:
---
Fix Version/s: (was: Starter 11)
   Launchpad Integration Tests 1.0.8

> Fix ITs with Oak 1.8
> 
>
> Key: SLING-7950
> URL: https://issues.apache.org/jira/browse/SLING-7950
> Project: Sling
>  Issue Type: Sub-task
>  Components: Launchpad, Oak, Testing
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Launchpad Integration Tests 1.0.8
>
>
> Updating to Oak 1.8.7 results in the following failures:
> {noformat}[ERROR] Failures: 
> [ERROR]   AnonymousAccessTest.testAnonymousContent:99->assertContent:85 
> Expected status 200 for 
> http://localhost:41000/ANON_CAN_READ/AnonymousAccessTest/789235c4-d3b2-43b3-a163-aadb95cdd56b/test_text_789235c4_d.txt
>  (content=) expected:<200> but was:<401>
> [ERROR]   AnonymousAccessTest.testAnonymousContent:101 Expecting status 404 
> when testing outside of anonymous access subtree expected:<404> but was:<401>
> [ERROR]   
> AuthRequestLoginTest.testForcedLogin:40->HttpTestBase.getContent:419->HttpTestBase.getContent:424->HttpTestBase.getContent:432->HttpTestBase.getContent:457
>  Expected status 200 for 
> http://localhost:41000/system/sling/info.sessionInfo.json (content=) 
> expected:<200> but was:<401>
> [ERROR]   RedirectOnLogoutTest.testRedirectToResourceAfterLogout:70 Expected 
> redirect expected:<302> but was:<401>
> [ERROR] Errors: 
> [ERROR]   DavExDisabledAnonAccessTest>DavExIntegrationTest.setUp:47 » 
> NoClassDefFound or...
> [ERROR]   DavExDisabledAnonAccessTest>DavExIntegrationTest.setUp:47 » 
> NoClassDefFound or...
> [ERROR]   DavExIntegrationTest.setUp:47 » NoClassDefFound 
> org/apache/jackrabbit/webdav/c...
> [ERROR]   DavExIntegrationTest.setUp:47 » NoClassDefFound 
> org/apache/jackrabbit/webdav/c...
> [INFO] 
> [ERROR] Tests run: 655, Failures: 4, Errors: 4, Skipped: 1{noformat}
> The changes that support this are at 
> https://github.com/apache/sling-org-apache-sling-starter/tree/feature/oak-1.8



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7950) Fix ITs with Oak 1.8

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651472#comment-16651472
 ] 

Robert Munteanu commented on SLING-7950:


[~jebailey] - sorry for the noise, I was somehow using an older version of the 
integration tests. All is fine now with the rendering tests.

> Fix ITs with Oak 1.8
> 
>
> Key: SLING-7950
> URL: https://issues.apache.org/jira/browse/SLING-7950
> Project: Sling
>  Issue Type: Sub-task
>  Components: Launchpad, Oak, Testing
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter 11
>
>
> Updating to Oak 1.8.7 results in the following failures:
> {noformat}[ERROR] Failures: 
> [ERROR]   AnonymousAccessTest.testAnonymousContent:99->assertContent:85 
> Expected status 200 for 
> http://localhost:41000/ANON_CAN_READ/AnonymousAccessTest/789235c4-d3b2-43b3-a163-aadb95cdd56b/test_text_789235c4_d.txt
>  (content=) expected:<200> but was:<401>
> [ERROR]   AnonymousAccessTest.testAnonymousContent:101 Expecting status 404 
> when testing outside of anonymous access subtree expected:<404> but was:<401>
> [ERROR]   
> AuthRequestLoginTest.testForcedLogin:40->HttpTestBase.getContent:419->HttpTestBase.getContent:424->HttpTestBase.getContent:432->HttpTestBase.getContent:457
>  Expected status 200 for 
> http://localhost:41000/system/sling/info.sessionInfo.json (content=) 
> expected:<200> but was:<401>
> [ERROR]   RedirectOnLogoutTest.testRedirectToResourceAfterLogout:70 Expected 
> redirect expected:<302> but was:<401>
> [ERROR] Errors: 
> [ERROR]   DavExDisabledAnonAccessTest>DavExIntegrationTest.setUp:47 » 
> NoClassDefFound or...
> [ERROR]   DavExDisabledAnonAccessTest>DavExIntegrationTest.setUp:47 » 
> NoClassDefFound or...
> [ERROR]   DavExIntegrationTest.setUp:47 » NoClassDefFound 
> org/apache/jackrabbit/webdav/c...
> [ERROR]   DavExIntegrationTest.setUp:47 » NoClassDefFound 
> org/apache/jackrabbit/webdav/c...
> [INFO] 
> [ERROR] Tests run: 655, Failures: 4, Errors: 4, Skipped: 1{noformat}
> The changes that support this are at 
> https://github.com/apache/sling-org-apache-sling-starter/tree/feature/oak-1.8



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[notifications][github] can we send them to commits@s.a.o?

[Radu Cotescu]

Hi,

Before I start creating yet another email filter, do you you think we could 
send the GitHub notifications for PRs and comments to commits@s.a.o 
?

Thanks,
Radu

Re: Disable most of the Jenkins bulid notifications?

[Bertrand Delacretaz]

On Tue, Oct 16, 2018 at 10:59 AM Robert Munteanu  wrote:
> ...The
> others will not broadcast to comm...@sling.apache.org and will only be
> sent to the ones that last changes the build...

Works for me and we also have
https://builds.apache.org/view/S-Z/view/Sling-Dashboard/ listing the
problematic builds.

-Bertrand

Re: How to manage repoinit language + implementation evolutions?

[Karl Pauls]

On Tuesday, October 16, 2018, Bertrand Delacretaz 
wrote:

> Hi,
>
> On Sun, Oct 14, 2018 at 7:47 PM Jörg Hoh 
> wrote:
> > ...ok, so do we continue here?...
>
> I suggest mostly going with Karl's idea but fixing one obvious bug:
>
> 1) Introduce a new DELETE REAL USER  command that only deletes real
> users.
>
> 2) Keep DELETE USER  as is, deleting both types of users. Document
> these commands better to avoid confusion here.
>
> 3) Fix DELETE SERVICE USER  so that it only deletes service users.
>
> 4) None of these commands fail if  is not of the expected type or
> does not exist, they just log INFO messages in such cases.
>
> I think that's a reasonable way to fix things while staying
> compatible, except for 3) but the current behavior there is clearly a
> bug which needs fixing.
>
> WDYT?


+1

regards,

Karl


> -Bertrand
>


-- 
Karl Pauls
karlpa...@gmail.com

Disable most of the Jenkins bulid notifications?

[Robert Munteanu]

Hi,

I get a feeling that we have too many Jenkins notifications and no one
is paying attention to them. I think we should reduce them to the
'important' projects, e.g.

- starter
- launchpad-testing
- launchpad-testing-war

which in the end should be something everyone is interested in. The
others will not broadcast to comm...@sling.apache.org and will only be
sent to the ones that last changes the build.

Thoughts?

Robert

Re: How to manage repoinit language + implementation evolutions?

[Bertrand Delacretaz]

Hi,

On Sun, Oct 14, 2018 at 7:47 PM Jörg Hoh  wrote:
> ...ok, so do we continue here?...

I suggest mostly going with Karl's idea but fixing one obvious bug:

1) Introduce a new DELETE REAL USER  command that only deletes real users.

2) Keep DELETE USER  as is, deleting both types of users. Document
these commands better to avoid confusion here.

3) Fix DELETE SERVICE USER  so that it only deletes service users.

4) None of these commands fail if  is not of the expected type or
does not exist, they just log INFO messages in such cases.

I think that's a reasonable way to fix things while staying
compatible, except for 3) but the current behavior there is clearly a
bug which needs fixing.

WDYT?

-Bertrand

Failed Pipeline: sling-ide-tooling » master #50

[Apache Jenkins Server]

See https://builds.apache.org/job/sling-ide-tooling/job/master/50/

[jira] [Commented] (SLING-6313) Sling installer can duplicate factory configurations if an invalid RegisteredResourceList.ser is found

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651304#comment-16651304
 ] 

Konrad Windszus commented on SLING-6313:


Just for the record: With SLING-7786 named factory configurations are supported 
now.

> Sling installer can duplicate factory configurations if an invalid 
> RegisteredResourceList.ser is found
> --
>
> Key: SLING-6313
> URL: https://issues.apache.org/jira/browse/SLING-6313
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Reporter: Robert Munteanu
>Priority: Major
> Attachments: SLING-6313-0.diff
>
>
> Steps to reproduce, inside `launchpad/builder`
> {noformat}
> mvn clean package
> java -jar target/org.apache.sling.launchpad-9-SNAPSHOT.jar
> # wait for Sling to start up properly, stop it with CTRL-C
> truncate --size=-1 sling/installer/RegisteredResourceList.ser
> java -jar target/org.apache.sling.launchpad-9-SNAPSHOT.jar
> # wait for Sling to start up properly, stop it with CTRL-C
> java -jar target/org.apache.sling.launchpad-9-SNAPSHOT.jar
> {noformat}
> The following exceptions are logged in the last run:
> {noformat}21.11.2016 14:32:26.538 *ERROR* [CM Configuration Updater 
> (ManagedServiceFactory Update: 
> factoryPid=[org.apache.sling.commons.log.LogManager.factory.config])] 
> org.apache.felix.configadmin Service 
> [org.apache.felix.cm.ConfigurationAdmin,28, 
> [org.osgi.service.cm.ConfigurationAdmin]] 
> [org.osgi.service.cm.ManagedServiceFactory, id=19, 
> bundle=8/slinginstall:org.apache.sling.commons.log-5.0.1-SNAPSHOT.jar]: 
> Updating property org.apache.sling.commons.log.names of configuration 
> org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9
>  caused a problem: Category log.request already defined by configuration 
> org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9
>  (org.osgi.service.cm.ConfigurationException: 
> org.apache.sling.commons.log.names : Category log.request already defined by 
> configuration 
> org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9)
> org.osgi.service.cm.ConfigurationException: 
> org.apache.sling.commons.log.names : Category log.request already defined by 
> configuration 
> org.apache.sling.commons.log.LogManager.factory.config.b4cf7982-9af0-40a1-b720-3e83a9f9e7f9
>   at 
> org.apache.sling.commons.log.logback.internal.config.LoggerManagedServiceFactory.updated(LoggerManagedServiceFactory.java:36)
>   at 
> org.apache.felix.cm.impl.helper.ManagedServiceFactoryTracker.updated(ManagedServiceFactoryTracker.java:159)
>   at 
> org.apache.felix.cm.impl.helper.ManagedServiceFactoryTracker.provideConfiguration(ManagedServiceFactoryTracker.java:93)
>   at 
> org.apache.felix.cm.impl.ConfigurationManager$ManagedServiceFactoryUpdate.provide(ConfigurationManager.java:1611)
>   at 
> org.apache.felix.cm.impl.ConfigurationManager$ManagedServiceFactoryUpdate.run(ConfigurationManager.java:1554)
>   at org.apache.felix.cm.impl.UpdateThread.run0(UpdateThread.java:141)
>   at org.apache.felix.cm.impl.UpdateThread.run(UpdateThread.java:109)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: 
> org.apache.sling.commons.log.logback.internal.config.ConfigurationException: 
>   at 
> org.apache.sling.commons.log.logback.internal.LogConfigManager.updateLoggerConfiguration(LogConfigManager.java:533)
>   at 
> org.apache.sling.commons.log.logback.internal.config.LoggerManagedServiceFactory.updated(LoggerManagedServiceFactory.java:34)
>   ... 7 common frames omitted{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-8020) AttachFeaturesMojo should allow user to set title, description, vendor and license fields to the attached Feature, taking data from the POM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651186#comment-16651186
 ] 

ASF GitHub Bot commented on SLING-8020:
---

simonetripodi commented on issue #10: SLING-8020 - AttachFeaturesMojo should 
allow user to set title, description, vendor and license fields to the attached 
Feature, taking data from the POM
URL: 
https://github.com/apache/sling-slingfeature-maven-plugin/pull/10#issuecomment-430115570
 
 
   awesome! :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> AttachFeaturesMojo should allow user to set title, description, vendor and 
> license fields to the attached Feature, taking data from the POM
> ---
>
> Key: SLING-8020
> URL: https://issues.apache.org/jira/browse/SLING-8020
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: David Bosschaert
>Priority: Minor
>
> As per subject, it would be useful if the {{AttachFeaturesMojo}} could expose 
> a flag that, if enabled, ({{false}} by default) would set {{title}}, 
> {{description}}, {{vendor}} and {{license}} fields taking related values from 
> the POM.
> PR is coming



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] simonetripodi commented on issue #10: SLING-8020 - AttachFeaturesMojo should allow user to set title, description, vendor and license fields to the attached Feature, taking data from the POM

[GitBox]

simonetripodi commented on issue #10: SLING-8020 - AttachFeaturesMojo should 
allow user to set title, description, vendor and license fields to the attached 
Feature, taking data from the POM
URL: 
https://github.com/apache/sling-slingfeature-maven-plugin/pull/10#issuecomment-430115570
 
 
   awesome! :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services