[GitHub] [sling-org-apache-sling-caconfig-api] kwin commented on a change in pull request #2: [SLING-8272] Check if Caconfig Node Exists in JCR

2019-03-08 Thread GitBox
kwin commented on a change in pull request #2: [SLING-8272] Check if Caconfig Node Exists in JCR URL: https://github.com/apache/sling-org-apache-sling-caconfig-api/pull/2#discussion_r263987685 ## File path: src/main/java/org/apache/sling/caconfig/ConfigurationBuilder.java

[GitHub] [sling-org-apache-sling-caconfig-api] kwin commented on a change in pull request #2: [SLING-8272] Check if Caconfig Node Exists in JCR

2019-03-08 Thread GitBox
kwin commented on a change in pull request #2: [SLING-8272] Check if Caconfig Node Exists in JCR URL: https://github.com/apache/sling-org-apache-sling-caconfig-api/pull/2#discussion_r263987734 ## File path: src/main/java/org/apache/sling/caconfig/ConfigurationBuilder.java

[GitHub] [sling-whiteboard] rombert commented on issue #26: SLING-8311 - Investigate creating a Sling CLI tool for development task automation

2019-03-08 Thread GitBox
rombert commented on issue #26: SLING-8311 - Investigate creating a Sling CLI tool for development task automation URL: https://github.com/apache/sling-whiteboard/pull/26#issuecomment-471133056 A SonarQube report for the changes added _only by this pull request_ was generated. Please

[GitHub] [sling-org-apache-sling-caconfig-api] rombert commented on issue #2: [SLING-8272] Check if Caconfig Node Exists in JCR

2019-03-08 Thread GitBox
rombert commented on issue #2: [SLING-8272] Check if Caconfig Node Exists in JCR URL: https://github.com/apache/sling-org-apache-sling-caconfig-api/pull/2#issuecomment-470977460 A SonarQube report for the changes added _only by this pull request_ was generated. Please review it at

[GitHub] [sling-org-apache-sling-commons-mime] bdelacretaz merged pull request #3: SLING-8310 mimetypes Web Console Printer broken

2019-03-08 Thread GitBox
bdelacretaz merged pull request #3: SLING-8310 mimetypes Web Console Printer broken URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/3 This is an automated message from the Apache Git Service. To

[GitHub] [sling-org-apache-sling-commons-mime] bdelacretaz commented on issue #3: SLING-8310 mimetypes Web Console Printer broken

2019-03-08 Thread GitBox
bdelacretaz commented on issue #3: SLING-8310 mimetypes Web Console Printer broken URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/3#issuecomment-470972704 Thank you very much for this fix @actinium15, merging now.

[GitHub] [sling-org-apache-sling-commons-mime] actinium15 commented on issue #3: SLING-8310 mimetypes Web Console Printer broken

2019-03-08 Thread GitBox
actinium15 commented on issue #3: SLING-8310 mimetypes Web Console Printer broken URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/3#issuecomment-470967109 Hi @rombert, the SQ report [0] you shared doesn't show any issues. Can you please let me know if there's

[GitHub] [sling-org-apache-sling-starter-content] klcodanr merged pull request #1: SLING-8278 improve chrome audit score

2019-03-08 Thread GitBox
klcodanr merged pull request #1: SLING-8278 improve chrome audit score URL: https://github.com/apache/sling-org-apache-sling-starter-content/pull/1 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [sling-org-apache-sling-commons-mime] rombert commented on issue #3: SLING-8310 mimetypes Web Console Printer broken

2019-03-08 Thread GitBox
rombert commented on issue #3: SLING-8310 mimetypes Web Console Printer broken URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/3#issuecomment-470920181 A SonarQube report for the changes added _only by this pull request_ was generated. Please review it at

Re: [VOTE] Release Apache Sling Testing OSGi Mock 2.4.8

2019-03-08 Thread Robert Munteanu
On Thu, 2019-03-07 at 16:22 +, Stefan Seifert wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part

[jira] [Created] (SLING-8311) Investigate creating a Sling CLI tool for development task automation

2019-03-08 Thread Robert Munteanu (JIRA)
Robert Munteanu created SLING-8311: -- Summary: Investigate creating a Sling CLI tool for development task automation Key: SLING-8311 URL: https://issues.apache.org/jira/browse/SLING-8311 Project:

[GitHub] [sling-whiteboard] rombert opened a new pull request #26: SLING-8311 - Investigate creating a Sling CLI tool for development task automation

2019-03-08 Thread GitBox
rombert opened a new pull request #26: SLING-8311 - Investigate creating a Sling CLI tool for development task automation URL: https://github.com/apache/sling-whiteboard/pull/26 Initial prototype, very much work in progress.

[jira] [Commented] (SLING-8272) ConfigurationBuilder: Add method to check for the existence of the config

2019-03-08 Thread Om Prakash Pandey (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787808#comment-16787808 ] Om Prakash Pandey commented on SLING-8272: -- I have raised a PR for this:

[GitHub] [sling-org-apache-sling-caconfig-api] ompandeyy opened a new pull request #2: [SLING-8272] Check if Caconfig Node Exists in JCR

2019-03-08 Thread GitBox
ompandeyy opened a new pull request #2: [SLING-8272] Check if Caconfig Node Exists in JCR URL: https://github.com/apache/sling-org-apache-sling-caconfig-api/pull/2 This is an automated message from the Apache Git Service.

[jira] [Updated] (SLING-8310) mimetypes Web Console Printer broken

2019-03-08 Thread Ashish Chopra (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Chopra updated SLING-8310: - Fix Version/s: Commons Mime 2.2.2 > mimetypes Web Console Printer broken >

[jira] [Commented] (SLING-8310) mimetypes Web Console Printer broken

2019-03-08 Thread Ashish Chopra (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787675#comment-16787675 ] Ashish Chopra commented on SLING-8310: -- Raised PR [0] corresponding to

[GitHub] [sling-org-apache-sling-commons-mime] actinium15 opened a new pull request #3: SLING-8310 mimetypes Web Console Printer broken

2019-03-08 Thread GitBox
actinium15 opened a new pull request #3: SLING-8310 mimetypes Web Console Printer broken URL: https://github.com/apache/sling-org-apache-sling-commons-mime/pull/3 * class was made an OSGi `@Component` via SLING-7612 [0], but wasn't made * `public`, thus SCR wasn't able to instantiate it

[jira] [Commented] (SLING-8310) mimetypes Web Console Printer broken

2019-03-08 Thread Ashish Chopra (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787660#comment-16787660 ] Ashish Chopra commented on SLING-8310: -- The problem was that the class was made an OSGi

[jira] [Updated] (SLING-8310) mimetypes Web Console Printer broken

2019-03-08 Thread Ashish Chopra (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Chopra updated SLING-8310: - Attachment: 0001-SLING-8310-mimetypes-Web-Console-Printer-broken.patch > mimetypes Web Console