Re: [VOTE] Release Apache Sling Web Console Security Provider 1.2.4
+1 On Fri, Aug 16, 2019 at 2:37 PM wrote: > Here's my +1 > > David > > On Fri, 16 Aug 2019 at 13:09, wrote: > > > Hi all, > > > > I would like to call the 1.2.4 release of the > > org.apache.sling.extensions.webconsolesecurityprovider > > > > The following issue was fixed: > > https://issues.apache.org/jira/projects/SLING/versions/12346017 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2114/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > > > > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2114 /tmp/sling-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Best regards, > > > > David Bosschaert > > >
Re: [VOTE] Release Apache Sling Web Console Security Provider 1.2.4
Here's my +1 David On Fri, 16 Aug 2019 at 13:09, wrote: > Hi all, > > I would like to call the 1.2.4 release of the > org.apache.sling.extensions.webconsolesecurityprovider > > The following issue was fixed: > https://issues.apache.org/jira/projects/SLING/versions/12346017 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2114/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2114 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Best regards, > > David Bosschaert >
Re: [VOTE] Release Apache Sling Context-Aware Configuration API 1.2.0, Context-Aware Configuration Impl 1.5.0
+1 (non-binding) - Andy > On Aug 15, 2019, at 1:46 PM, Stefan Seifert wrote: > > Hi, > > Context-Aware Configuration API 1.2.0 (2 issues) > https://issues.apache.org/jira/browse/SLING/fixforversion/12344000 > > Context-Aware Configuration Impl 1.5.0 (3 issues) > https://issues.apache.org/jira/browse/SLING/fixforversion/12345451 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2113/ > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2113 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > stefan >
Re: Sling Feature Launcher: Issue with Content Packages
Hi Robert
I added that bundle to my FM that also contains the packageinit bundle:
{
"id":"${project.groupId}:${project.artifactId}:slingfeature:sling_packageinit:${project.version}",
"variables":{
},
"bundles":[
{
"id":"org.apache.sling:org.apache.sling.jcr.packageinit:0.0.1-SNAPSHOT",
"start-level":"10"
},
{
"id":"org.apache.sling:org.apache.sling.installer.factory.packages:0.1.0-SNAPSHOT",
"start-level":"10"
}
]
}
That said the CPs are still listed as Unresolved Resources.
I updated my test project:
https://github.com/schaefa/cpconverter-ssue-fm-starter/tree/issue/cp-not-launching
You can launch it with:
mvn clean install -P launch
And the open Sling OSGi Installer:
http://localhost:8080/system/console/osgi-installer
Cheers - Andy
> On Aug 16, 2019, at 2:10 AM, Robert Munteanu wrote:
>
> Hi Andy,
>
> On Thu, 2019-08-15 at 16:02 -0700, Andreas Schaefer wrote:
>> Hi
>>
>> When I convert and Launch the Peregrine CMS then I see that all
>> converted Content Packages remain in ‘Untransformed Resources’ state
>> when I look at the /system/console/osgi-installer page.
>>
>> Is there a way to figure out why they remain in that state?
>>
>> I set the launcher to verbose but I do not see anything showing up
>> nor do I see any issues in the error.log.
>
> IIRC it means that there is no installer that claimed and processed the
> resources.
>
> Can you try adding
>
> https://github.com/apache/sling-org-apache-sling-installer-factory-packages
>
> to your app and see if that fixes the issue?
>
> Thanks,
> Robert
>
[jira] [Created] (SLING-8641) Onboard sling-feature-converter-maven-plugin to SonarCloud
Andreas Schaefer created SLING-8641: --- Summary: Onboard sling-feature-converter-maven-plugin to SonarCloud Key: SLING-8641 URL: https://issues.apache.org/jira/browse/SLING-8641 Project: Sling Issue Type: Task Components: Feature Model Reporter: Andreas Schaefer [~bellingard] Can you onboard the new module sling-maven-converter-maven-plugin? -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [sling-slingfeature-maven-plugin] rombert commented on issue #35: Created a Feature Launcher Mojo (launch-features)
rombert commented on issue #35: Created a Feature Launcher Mojo (launch-features) URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/35#issuecomment-522035131 @schaefa - I am going to defer to @cziegeler on this one - he already knows the code base and has started reviewing This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[VOTE] Release Apache Sling Web Console Security Provider 1.2.4
Hi all, I would like to call the 1.2.4 release of the org.apache.sling.extensions.webconsolesecurityprovider The following issue was fixed: https://issues.apache.org/jira/projects/SLING/versions/12346017 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2114/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2114 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Best regards, David Bosschaert
Re: SonarCloud review for Sling Whiteboard project / branch
Hi Andy, On Wed, 2019-08-14 at 06:50 -0700, Andreas Schaefer wrote: > Hi > > I wanted to check out the review of SonarCloud for my Sling > Whiteboard module ‘sling-feature-converter-maven-plugin’ which is for > now in its own branch but I created a PR for it. Even though I can > find the PR in SonarCloud ( > https://sonarcloud.io/dashboard?id=apache_sling-whiteboard=48 > < > https://sonarcloud.io/dashboard?id=apache_sling-whiteboard=48> > ;) it does not have any review in it. > > How can I run a review? Do I need to merge the changes into master? The PRs to the sling whiteboard do not run on all projects automatically. The top-level pom.xml file [1] contains the modules which should be run. If you want your modules analysed add them to that pom.xml and they will be built and analysed during PRs and regular builds as well. Thanks, Robert [1]: https://github.com/apache/sling-whiteboard/blob/master/pom.xml
Re: Request for the Sling Feature Converter Maven Plugin to become a Sling Module
I've created the repo https://github.com/apache/sling-feature-converter-maven-plugin It should become writable in one hour or so. Thanks, Robert On Thu, 2019-08-15 at 10:55 -0700, Andreas Schaefer wrote: > Hi Robert > > I merged the branch into master and so it should show there. > > I will do some more testing today but as soon as the git repo is > created I will move the code over. > > Thanks - Andy > > > On Aug 15, 2019, at 2:25 AM, Robert Munteanu > > wrote: > > > > Hi Andy, > > > > On Wed, 2019-08-14 at 18:47 -0700, Andreas Schaefer wrote: > > > Hi > > > > > > I am aware that this is a long shot but this Maven Plugin can > > > make > > > life easier for User that want to convert Sling into a Feature as > > > well as launching Sling FM with their Content Packages. > > > > If you think this is useful it's reason enough to create a new > > repository :-) > > > > Unless someone objects, I will create > > > > sling-feature-converter-maven-plugin > > > > as a new git repository tomorrow. > > > > See also > > > > > > https://cwiki.apache.org/confluence/display/SLING/Using+Git+with+Sling > > > > especially the part about importing projects from the whiteboard. I > > would also suggest that you don't use branches for the whiteboard, > > adding changes directly to master makes them more visible and has > > zero > > chance of breaking anything. > > > > Thanks, > > > > Robert > > > > > The ticket for this request is: > > > https://issues.apache.org/jira/browse/SLING-8490 < > > > https://issues.apache.org/jira/browse/SLING-8490> > > > > > > The project right now is in the Sling Whitespace under branch > > > ‘sling- > > > feature-converter-maven-plugin’ but I will merge this into the > > > ‘master’ branch today or tomorrow. > > > > > > I use this Plugin to evaluate issues with Content Packages (see > > > https://github.com/schaefa/cpconverter-ssue-fm-starter/tree/issue/package-group > > > < > > > https://github.com/schaefa/cpconverter-ssue-fm-starter/tree/issue/package-group> > > > ;) which allows me to easily take a Content Package and spin up a > > > Sling FM instance. > > > > > > This is also used for the Peregrine CMS where we create a > > > Peregrine > > > CMS instance that is started with all content packages installed > > > when > > > the Sling FM instances starts. > > > > > > There is one sticky point: > > > - In order to get an End-2-End scenario working the FM instance > > > needs > > > to be launched. I am not sure where to place it. From my point of > > > view it is better off in the Sling Feature Maven Plugin as this > > > is > > > the final stage and it not really related to converting anything > > > but > > > I am not sure where you want to place it. > > > > > > Cheers - Andy Schaefer
Re: [RT] Support OSGi R7 Logging
On Thu, 2019-08-15 at 11:38 +0200, Carsten Ziegeler wrote: > Am 15.08.2019 um 11:21 schrieb Robert Munteanu: > > On Thu, 2019-08-15 at 11:12 +0200, Carsten Ziegeler wrote: > > > Hi Roy, > > > > > > I guess my mail is a little bit misleading :) > > > > > > It's totally fine to use SLF4J directly and we should keep doing > > > this. > > > Under the covers, everything you log to slf4j is routed through > > > the > > > LogService so other components in the system can listen to log > > > entries etc. > > > > > > So this is about keeping everything as is for clients doing > > > logging > > > but > > > just replace the LogService implementation with the Apache Felix > > > one > > > - > > > and make sure that we still have todays features in place. > > > > +1 from me. I also asked about this a year ago :-) > > > > > > https://lists.apache.org/thread.html/581b9ac69bfa6a8692e6bffc98fe5fdd6f5b4c35989d6b53841f7f10@%3Cdev.sling.apache.org%3E > > > That's actually a different ask :) > > We have o.a.s.commons.logservice which is an OSGi R6 LogService > implementation *and* a log listener logging everything to slf4j. My > suggestion is to replace the LogService impl with Apache Felix Log > and > keep the listener. Re-reading the email makes it clear now :-) And yes, your suggestion makes sense to me. > > Our logback integration is o.a.s.commons.log which I think is similar > to > the logback stuff in Apache Felix. > > Now maybe we can replace all of our stuff with the things from Felix? Ideally yes. As Karl pointed out, we need to ensure we have feature compatibility before switching, and that is going to take some effort. But small steps first, if we can rip out some of our stuff and use the Felix ones, I'm all for it. Thanks, Robert
Re: Sling Feature Launcher: Issue with Content Packages
Hi Andy, On Thu, 2019-08-15 at 16:02 -0700, Andreas Schaefer wrote: > Hi > > When I convert and Launch the Peregrine CMS then I see that all > converted Content Packages remain in ‘Untransformed Resources’ state > when I look at the /system/console/osgi-installer page. > > Is there a way to figure out why they remain in that state? > > I set the launcher to verbose but I do not see anything showing up > nor do I see any issues in the error.log. IIRC it means that there is no installer that claimed and processed the resources. Can you try adding https://github.com/apache/sling-org-apache-sling-installer-factory-packages to your app and see if that fixes the issue? Thanks, Robert
Re: [DISCUSS] Switching o.a.s.starter-content to use scripts and resources?
On Fri, 2019-08-16 at 08:05 +0200, Georg Henzler wrote: > > Do you mean /content/startup/index.html here? > > > yes - sorry (copy & paste error) Perfect. So all clear, and we should be good to. Thanks, Robert
Re: [VOTE] Release Apache Sling Context-Aware Configuration API 1.2.0, Context-Aware Configuration Impl 1.5.0
On Thu, 2019-08-15 at 20:46 +, Stefan Seifert wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
Re: [VOTE] Release Apache Sling Context-Aware Configuration API 1.2.0, Context-Aware Configuration Impl 1.5.0
+1 Carsten Am 15.08.2019 um 22:46 schrieb Stefan Seifert: Hi, Context-Aware Configuration API 1.2.0 (2 issues) https://issues.apache.org/jira/browse/SLING/fixforversion/12344000 Context-Aware Configuration Impl 1.5.0 (3 issues) https://issues.apache.org/jira/browse/SLING/fixforversion/12345451 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2113/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2113 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. stefan -- -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[jira] [Commented] (SLING-8640) Add a Feature Launcher Mojo to Sling Feature Maven Plugin
[ https://issues.apache.org/jira/browse/SLING-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908837#comment-16908837 ] Carsten Ziegeler commented on SLING-8640: - Thanks [~schaefa] . That's a nice addition. I already commented on the PR but repeat the comment here: When it comes to feature selection, I think this mojo should support the same options as all the other mojos: you can either select a file, a maven dependency, classifiers etc. As a parameter you can simply use a FeatureSelectionConfig and inherit from AbstractIncludingFeatureMojo to get most of the logic you need for this. This way we maintain a consistent way of configuring the mojos. We could also think about making it possible to launch several instances, probably based on different features. In that case a configuration style like the analyser or aggregate mojo use is more appropriate. But again, that's based on a subclass of FeatureSelectionConfig and extending AbstractIncludingFeatureMojo as well In addition, we should probably make it possible to configure the launcher version. Otherwise we have to release the slingfeature plugin with every launcher release > Add a Feature Launcher Mojo to Sling Feature Maven Plugin > - > > Key: SLING-8640 > URL: https://issues.apache.org/jira/browse/SLING-8640 > Project: Sling > Issue Type: New Feature > Components: Feature Model >Affects Versions: slingfeature-maven-plugin 1.0.6 >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > Fix For: slingfeature-maven-plugin 1.0.8 > > > The final step of creating a Feature Model is to launch it. As this is part > of that process the launching should be added to this plugin so that a > project can be launched from a profile or so. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [sling-slingfeature-maven-plugin] cziegeler commented on issue #35: Created a Feature Launcher Mojo (launch-features)
cziegeler commented on issue #35: Created a Feature Launcher Mojo (launch-features) URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/35#issuecomment-521925894 When it comes to feature selection, I think this mojo should support the same options as all the other mojos: you can either select a file, a maven dependency, classifiers etc. As a parameter you can simply use a FeatureSelectionConfig and inherit from AbstractIncludingFeatureMojo to get most of the logic you need for this. This way we maintain a consistent way of configuring the mojos. We could also think about making it possible to launch several instances, probably based on different features. In that case a configuration style like the analyser or aggregate mojo use is more appropriate. But again, that's based on a subclass of FeatureSelectionConfig and extending AbstractIncludingFeatureMojo as well This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [DISCUSS] Switching o.a.s.starter-content to use scripts and resources?
Do you mean /content/startup/index.html here? yes - sorry (copy & paste error)
