Re: Why get rid of the rewriter?

2019-09-09 Thread Daniel Klco
What is the solution for rewriting URLs contained within the output of a rich text editor? Similar to https://wcm.io/handler/richtext/? I hope that downstream implementers of Sling will provide a pathway for replacing the rewriter if it is removed. I would speculate this would result in a

RE: [VOTE] Release Apache Sling File Optimization version 0.9.4

2019-09-09 Thread Stefan Seifert
+1 stefan p.s. please add the JIRA ticket numbers in your commit messages, that makes reviewing commit logs much easier.

RE: Why get rid of the rewriter?

2019-09-09 Thread Stefan Seifert
yes, that's what we roughly outlined at [1]. of course that's still a lot of work to do to get rid of the rewriter, and when it's time it maybe still deprecated kept in in-place for more exotic use cases (like PDF generation). why / for what use cases do we want to get rid of it - my view: -

[jira] [Commented] (SLING-6203) Create a Maven archetype for content packages

2019-09-09 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-6203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925994#comment-16925994 ] Robert Munteanu commented on SLING-6203: For the feature model I was thinking of setting up a

Re: Release Validator Docker Image

2019-09-09 Thread Carsten Ziegeler
Can we maybe also remove the md5 files and create sha512 files, when the checksum is correct? Carsten Am 09.09.2019 um 19:25 schrieb Daniel Klco: Thanks Radu for doing the hard work. As predicted, once that was in place, the CI check was relatively straightforward. I added the code to check

Re: Release Validator Docker Image

2019-09-09 Thread Daniel Klco
Thanks Radu for doing the hard work. As predicted, once that was in place, the CI check was relatively straightforward. I added the code to check the CI status from GitHub, updated the GPG check to download the Sling key file and added a summary message letting the user know if all of the checks

[jira] [Resolved] (SLING-8691) Add Check for CI Build Status

2019-09-09 Thread Dan Klco (Jira)
[ https://issues.apache.org/jira/browse/SLING-8691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-8691. - Resolution: Fixed Added in 

Re: [VOTE] Release Apache Sling File Optimization version 0.9.4

2019-09-09 Thread Radu Cotescu
+1 > On 9 Sep 2019, at 15:18, Daniel Klco wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ...

Re: [DISCUSS] cutting the first cp2fm-0.0.2 release

2019-09-09 Thread Andreas Schaefer
+1 Headwire’s Peregrine CMS converts w/o any issues and deploys successfully into an FM Sling. - Andy > On Sep 9, 2019, at 9:47 AM, Simone Tripodi wrote: > > Hi all, > > I would like to start the process to release the first version of the > cp2fm tool - is there any blocker you know that

[jira] [Resolved] (SLING-8682) IT apis-jar-wrapped-flattened-classes fails

2019-09-09 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-8682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-8682. - Assignee: Simone Tripodi Resolution: Fixed > IT apis-jar-wrapped-flattened-classes

[jira] [Commented] (SLING-8682) IT apis-jar-wrapped-flattened-classes fails

2019-09-09 Thread Krystian Nowak (Jira)
[ https://issues.apache.org/jira/browse/SLING-8682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925919#comment-16925919 ] Krystian Nowak commented on SLING-8682: --- [~cziegeler]: PR is merge by [~simone.tripodi] - thanks!

[DISCUSS] cutting the first cp2fm-0.0.2 release

2019-09-09 Thread Simone Tripodi
Hi all, I would like to start the process to release the first version of the cp2fm tool - is there any blocker you know that would prevent it? TIA! ~Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/

[GitHub] [sling-slingfeature-maven-plugin] krystiannowak commented on issue #38: SLING-8682 - preventing javadoc jar generation when sources dir is empty

2019-09-09 Thread GitBox
krystiannowak commented on issue #38: SLING-8682 - preventing javadoc jar generation when sources dir is empty URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/38#issuecomment-529567308 @simonetripodi you're welcome - any time & thanks for the merge!

[jira] [Commented] (SLING-6203) Create a Maven archetype for content packages

2019-09-09 Thread Andreas Schaefer (Jira)
[ https://issues.apache.org/jira/browse/SLING-6203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925886#comment-16925886 ] Andreas Schaefer commented on SLING-6203: - Adding support for FM is not difficult but it gets

Re: [VOTE] Release Apache Sling File Optimization version 0.9.4

2019-09-09 Thread Robert Munteanu
On Mon, 2019-09-09 at 09:18 -0400, Daniel Klco wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part

Re: [VOTE] Release Apache Sling File Optimization version 0.9.4

2019-09-09 Thread Daniel Klco
+1 On Mon, Sep 9, 2019 at 11:33 AM Andreas Schaefer wrote: > +1 (non-binding) > > - Andy > > > On Sep 9, 2019, at 6:18 AM, Daniel Klco wrote: > > > > Hi, > > > > We solved 1 issue in this release: > > https://issues.apache.org/jira/projects/SLING/versions/12346145 > > > > Staging repository: >

Re: [hackathon] switch to feature model

2019-09-09 Thread Andreas Schaefer
Hi I am not sure about this but my question was the other way around. Do we want in the future that Content Package are writing in a Feature Model way (Content ZIP file separate from Bundles connected though a FM configuration)? As far as I am concerned I do not see any issues where a

Re: [VOTE] Release Apache Sling File Optimization version 0.9.4

2019-09-09 Thread Andreas Schaefer
+1 (non-binding) - Andy > On Sep 9, 2019, at 6:18 AM, Daniel Klco wrote: > > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/projects/SLING/versions/12346145 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2126 > > You

[GitHub] [sling-slingfeature-maven-plugin] simonetripodi merged pull request #38: SLING-8682 - preventing javadoc jar generation when sources dir is empty

2019-09-09 Thread GitBox
simonetripodi merged pull request #38: SLING-8682 - preventing javadoc jar generation when sources dir is empty URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/38 This is an automated message from the

[GitHub] [sling-slingfeature-maven-plugin] simonetripodi commented on issue #38: SLING-8682 - preventing javadoc jar generation when sources dir is empty

2019-09-09 Thread GitBox
simonetripodi commented on issue #38: SLING-8682 - preventing javadoc jar generation when sources dir is empty URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/38#issuecomment-529515871 LGTM, thanks a lot @krystiannowak for your priceless contribution!

[jira] [Created] (SLING-8691) Add Check for CI Build Status

2019-09-09 Thread Dan Klco (Jira)
Dan Klco created SLING-8691: --- Summary: Add Check for CI Build Status Key: SLING-8691 URL: https://issues.apache.org/jira/browse/SLING-8691 Project: Sling Issue Type: Sub-task Reporter:

[VOTE] Release Apache Sling File Optimization version 0.9.4

2019-09-09 Thread Daniel Klco
Hi, We solved 1 issue in this release: https://issues.apache.org/jira/projects/SLING/versions/12346145 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2126 You can use this UNIX script to download the release and verify the signatures:

Re: Release Validator Docker Image

2019-09-09 Thread Daniel Klco
Nice! The approach using the Lucene search of the repo contents is much cleaner than what I was thinking. On Sun, Sep 8, 2019 at 1:00 PM Radu Cotescu wrote: > Hi Daniel, > > > On 6 Sep 2019, at 18:01, Daniel Klco wrote: > > > > Thanks Radu, > > > > I've been looking into this on and off over

Why get rid of the rewriter?

2019-09-09 Thread Jason E Bailey
I obviously missed the chat at the adaptTo() meetup. Can anyone summarize why we are getting rid of it? And the thought process on replacing it? - Jason

[jira] [Commented] (SLING-8682) IT apis-jar-wrapped-flattened-classes fails

2019-09-09 Thread Krystian Nowak (Jira)
[ https://issues.apache.org/jira/browse/SLING-8682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925635#comment-16925635 ] Krystian Nowak commented on SLING-8682: --- [~cziegeler], [~simone.tripodi] - it turned out that the

[GitHub] [sling-slingfeature-maven-plugin] krystiannowak opened a new pull request #38: SLING-8682 - preventing javadoc jar generation when sources dir is empty

2019-09-09 Thread GitBox
krystiannowak opened a new pull request #38: SLING-8682 - preventing javadoc jar generation when sources dir is empty URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/38 * preventing javadoc jar generation when sources dir is empty * using a correct Java package

[jira] [Resolved] (SLING-8675) Update tooling support install bundle version to be compatible with Starter 11

2019-09-09 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-8675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-8675. Resolution: Fixed Fixed with [sling-ide-tooling commit

[jira] [Assigned] (SLING-8675) Update tooling support install bundle version to be compatible with Starter 11

2019-09-09 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-8675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-8675: -- Assignee: Robert Munteanu > Update tooling support install bundle version to be

[RESULT] [VOTE] Release Apache Sling Tooling Support Install 1.0.6

2019-09-09 Thread Robert Munteanu
Hi, The vote has passed with the following result: +1 (binding): Robert Munteanu, Stefan Seifert, Konrad Windszus +1 (non-binding): Andreas Schaefer I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards, Robert Munteanu

[jira] [Commented] (SLING-8682) IT apis-jar-wrapped-flattened-classes fails

2019-09-09 Thread Simone Tripodi (Jira)
[ https://issues.apache.org/jira/browse/SLING-8682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925559#comment-16925559 ] Simone Tripodi commented on SLING-8682: --- Theoretically, there shouldn't be cases where sources

Re: [VOTE] Release Apache Sling Tooling Support Install 1.0.6

2019-09-09 Thread Konrad Windszus
+1 (checked signatures and build) Konrad > On 9. Sep 2019, at 11:04, Robert Munteanu wrote: > > On Thu, 2019-09-05 at 10:50 +, Robert Munteanu wrote: >> This majority vote is open for at least 72 hours. > > We are missing two binding votes, can anyone else please check+vote? > > Thanks, >

Re: [hackathon] switch to feature model

2019-09-09 Thread Robert Munteanu
On Fri, 2019-09-06 at 14:57 -0700, Andreas Schaefer wrote: > Hi > > We for sure can look into that but I am wondering if we keep CP as > they are right now and then convert them or if we move CPs to be FM > based? Can we convert them if they have content that is not manageable via repoinit

[jira] [Commented] (SLING-8687) Enable integration tests with Docker

2019-09-09 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-8687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925513#comment-16925513 ] Oliver Lietz commented on SLING-8687: - Yes, it's described in the

[jira] [Commented] (SLING-8672) Missing Constraint: Require-Capability: osgi.service; filter="(objectClass=com.codahale.metrics.MetricRegistry)"

2019-09-09 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-8672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925510#comment-16925510 ] Oliver Lietz commented on SLING-8672: - [~lnthai2002], Have a look at the

[jira] [Resolved] (SLING-8690) Servlet Helpers: MockSlingHttpServletRequest.getContextPath should return "" by default

2019-09-09 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-8690. --- Resolution: Fixed

[jira] [Created] (SLING-8690) Servlet Helpers: MockSlingHttpServletRequest.getContextPath should return "" by default

2019-09-09 Thread Stefan Seifert (Jira)
Stefan Seifert created SLING-8690: - Summary: Servlet Helpers: MockSlingHttpServletRequest.getContextPath should return "" by default Key: SLING-8690 URL: https://issues.apache.org/jira/browse/SLING-8690

RE: [VOTE] Release Apache Sling Tooling Support Install 1.0.6

2019-09-09 Thread Stefan Seifert
+1

[jira] [Comment Edited] (SLING-8682) IT apis-jar-wrapped-flattened-classes fails

2019-09-09 Thread Krystian Nowak (Jira)
[ https://issues.apache.org/jira/browse/SLING-8682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925470#comment-16925470 ] Krystian Nowak edited comment on SLING-8682 at 9/9/19 9:05 AM: ---

Re: [VOTE] Release Apache Sling Tooling Support Install 1.0.6

2019-09-09 Thread Robert Munteanu
On Thu, 2019-09-05 at 10:50 +, Robert Munteanu wrote: > This majority vote is open for at least 72 hours. We are missing two binding votes, can anyone else please check+vote? Thanks, Robert

Re: [VOTE] Release Apache Sling Tooling Support Install 1.0.6

2019-09-09 Thread Robert Munteanu
On Thu, 2019-09-05 at 10:50 +, Robert Munteanu wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part

Re: htl-maven-plugin - default value for sourceDirectory

2019-09-09 Thread Konrad Windszus
Hi, The logic in the filevault-package-maven-plugin is as follows: It looks for the first found directory below any of the following:

[jira] [Commented] (SLING-8672) Missing Constraint: Require-Capability: osgi.service; filter="(objectClass=com.codahale.metrics.MetricRegistry)"

2019-09-09 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-8672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925478#comment-16925478 ] Robert Munteanu commented on SLING-8672: [~lnthai2002] - we provide this capability out of our

[jira] [Commented] (SLING-8687) Enable integration tests with Docker

2019-09-09 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-8687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925477#comment-16925477 ] Bertrand Delacretaz commented on SLING-8687: Ok got it, it's the

[jira] [Commented] (SLING-6203) Create a Maven archetype for content packages

2019-09-09 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-6203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925474#comment-16925474 ] Robert Munteanu commented on SLING-6203: [~schaefa] - your points make sense. I am wondering

Re: htl-maven-plugin - default value for sourceDirectory

2019-09-09 Thread Radu Cotescu
Hi Robert, On Fri, 6 Sep 2019 at 17:49, Robert Munteanu wrote: > Hi, > > I have added the htl-maven-plugin for validation to a content package > project. I noticed initially that the validation did process anything, > because of looking by default in ${project.build.sourceDirectory}, > which is

[jira] [Commented] (SLING-8615) Move to a resource-centric setup

2019-09-09 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-8615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925472#comment-16925472 ] Robert Munteanu commented on SLING-8615: [~olli] - I had not considered that the scripting HTL

[jira] [Commented] (SLING-8682) IT apis-jar-wrapped-flattened-classes fails

2019-09-09 Thread Krystian Nowak (Jira)
[ https://issues.apache.org/jira/browse/SLING-8682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925470#comment-16925470 ] Krystian Nowak commented on SLING-8682: --- [~cziegeler]: Isn't it the case that when sourcesDir is

[jira] [Commented] (SLING-8686) Example code variable name wrong in Sling API CRUD, updating a property

2019-09-09 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-8686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925468#comment-16925468 ] Robert Munteanu commented on SLING-8686: Good catch [~thomasmorf]. Can you send a PR so we can

[jira] [Resolved] (SLING-8688) Enable integration tests with Docker

2019-09-09 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-8688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-8688. - Resolution: Done > Enable integration tests with Docker > >

[jira] [Resolved] (SLING-8685) Rename feature sling-scripting-sightly to sling-scripting-htl

2019-09-09 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-8685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-8685. - Resolution: Done > Rename feature sling-scripting-sightly to sling-scripting-htl >

[jira] [Commented] (SLING-8687) Enable integration tests with Docker

2019-09-09 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-8687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925463#comment-16925463 ] Oliver Lietz commented on SLING-8687: - I just moved the tests out of the profile {{it}} to default

[jira] [Commented] (SLING-8683) Slingfeature maven plugin should be usable to wrap project artifacts in feature.

2019-09-09 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-8683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925438#comment-16925438 ] Carsten Ziegeler commented on SLING-8683: - This needs a configuration of a mojo inside the

[jira] [Commented] (SLING-8687) Enable integration tests with Docker

2019-09-09 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-8687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925431#comment-16925431 ] Bertrand Delacretaz commented on SLING-8687: Could you provide a short summary of how you got

[jira] [Resolved] (SLING-8687) Enable integration tests with Docker

2019-09-09 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-8687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-8687. - Resolution: Done > Enable integration tests with Docker > >

[jira] [Resolved] (SLING-8689) Improve version handling

2019-09-09 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-8689. - Resolution: Fixed Updated in rev 1bdba86 It's now possible to define the versionScope

[jira] [Created] (SLING-8689) Improve version handling

2019-09-09 Thread Carsten Ziegeler (Jira)
Carsten Ziegeler created SLING-8689: --- Summary: Improve version handling Key: SLING-8689 URL: https://issues.apache.org/jira/browse/SLING-8689 Project: Sling Issue Type: Improvement