[GitHub] [sling-org-apache-sling-junit-core] sonarcloud[bot] commented on pull request #4: SLING-9795 - JUnit 5 support for server-side tests

2020-10-07 Thread GitBox
sonarcloud[bot] commented on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/4#issuecomment-705186049 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core=4=false=BUG)

[GitHub] [sling-org-apache-sling-junit-core] sonarcloud[bot] removed a comment on pull request #4: SLING-9795 - JUnit 5 support for server-side tests

2020-10-07 Thread GitBox
sonarcloud[bot] removed a comment on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/4#issuecomment-704261005 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core=4=false=BUG)

Re: [VOTE] Release slingfeature-maven-plugin 1.4.2

2020-10-07 Thread Eric Norman
+1 On Wed, Oct 7, 2020 at 7:22 AM Carsten Ziegeler wrote: > Hi, > > We solved 6 issues in this release: > > https://issues.apache.org/jira/browse/SLING-9779?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22OSGi%20Feature%20Maven%20Plugin%201.4.2%22 > > Staging repository: >

Re: [VOTE] Release slingfeature-maven-plugin 1.4.2

2020-10-07 Thread davidb
+1 David On Wed, 7 Oct 2020 at 17:58, Andreas Schaefer wrote: > +1 (non-binding) > > - Andy > > > On Oct 7, 2020, at 7:22 AM, Carsten Ziegeler > wrote: > > > > Hi, > > > > We solved 6 issues in this release: > > >

Re: [VOTE] Release slingfeature-maven-plugin 1.4.2

2020-10-07 Thread Andreas Schaefer
+1 (non-binding) - Andy > On Oct 7, 2020, at 7:22 AM, Carsten Ziegeler wrote: > > Hi, > > We solved 6 issues in this release: > https://issues.apache.org/jira/browse/SLING-9779?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22OSGi%20Feature%20Maven%20Plugin%201.4.2%22 > > Staging

Re: [VOTE] Release slingfeature-maven-plugin 1.4.2

2020-10-07 Thread Karl Pauls
+1 regards, Karl On Wed, Oct 7, 2020 at 5:59 PM Daniel Klco wrote: > > +1 > > On Wed, Oct 7, 2020 at 11:48 AM Carsten Ziegeler > wrote: > > > +1 > > > > Carsten > > > > Am 07.10.2020 um 16:22 schrieb Carsten Ziegeler: > > > Hi, > > > > > > We solved 6 issues in this release: > > > > >

Re: [VOTE] Release slingfeature-maven-plugin 1.4.2

2020-10-07 Thread Daniel Klco
+1 On Wed, Oct 7, 2020 at 11:48 AM Carsten Ziegeler wrote: > +1 > > Carsten > > Am 07.10.2020 um 16:22 schrieb Carsten Ziegeler: > > Hi, > > > > We solved 6 issues in this release: > > >

Re: [VOTE] Release slingfeature-maven-plugin 1.4.2

2020-10-07 Thread Carsten Ziegeler
+1 Carsten Am 07.10.2020 um 16:22 schrieb Carsten Ziegeler: Hi, We solved 6 issues in this release: https://issues.apache.org/jira/browse/SLING-9779?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22OSGi%20Feature%20Maven%20Plugin%201.4.2%22 Staging repository:

[jira] [Resolved] (SLING-9798) Don't expose OSGi / Apache Felix JMX MBeans from the feature launcher

2020-10-07 Thread Karl Pauls (Jira)
[ https://issues.apache.org/jira/browse/SLING-9798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved SLING-9798. --- Resolution: Fixed Thanks [~dklco]. Revert done in

SLING-9795 - JUnit 5 support for server-side tests

2020-10-07 Thread Julian Sedding
Hi all I prepared some changes to add JUnit 5 support for server-side tests via Apache Sling JUnit Core. I would appreciate a review of the changes by anyone who's interested and who can spare the time. Issue: https://issues.apache.org/jira/browse/SLING-9795 Code changes:

[jira] [Comment Edited] (SLING-9795) JUnit 5 support for server-side tests

2020-10-07 Thread Julian Sedding (Jira)
[ https://issues.apache.org/jira/browse/SLING-9795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209434#comment-17209434 ] Julian Sedding edited comment on SLING-9795 at 10/7/20, 2:22 PM: - Code

[VOTE] Release slingfeature-maven-plugin 1.4.2

2020-10-07 Thread Carsten Ziegeler
Hi, We solved 6 issues in this release: https://issues.apache.org/jira/browse/SLING-9779?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22OSGi%20Feature%20Maven%20Plugin%201.4.2%22 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2349/ You can use

[GitHub] [sling-site] jsedding opened a new pull request #50: SLING-9795 - JUnit 5 support for server-side tests

2020-10-07 Thread GitBox
jsedding opened a new pull request #50: URL: https://github.com/apache/sling-site/pull/50 - documentation update This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Resolved] (SLING-9801) Add option to continue build with analyser errors

2020-10-07 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-9801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-9801. - Resolution: Fixed Implemented in

[jira] [Created] (SLING-9801) Add option to continue build with analyser errors

2020-10-07 Thread Carsten Ziegeler (Jira)
Carsten Ziegeler created SLING-9801: --- Summary: Add option to continue build with analyser errors Key: SLING-9801 URL: https://issues.apache.org/jira/browse/SLING-9801 Project: Sling Issue

[jira] [Commented] (SLING-9798) Don't expose OSGi / Apache Felix JMX MBeans from the feature launcher

2020-10-07 Thread Dan Klco (Jira)
[ https://issues.apache.org/jira/browse/SLING-9798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209502#comment-17209502 ] Dan Klco commented on SLING-9798: - [~karlpauls] The explanation makes sense, no issues from my end. I'll

[jira] [Updated] (SLING-9796) Add support for using Unions

2020-10-07 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-9796: Fix Version/s: GraphQL Core 0.0.8 > Add support for using Unions > >

[jira] [Updated] (SLING-9796) Add support for using Unions

2020-10-07 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-9796: Affects Version/s: (was: GraphQL Core 0.0.8) > Add support for using Unions >

[jira] [Updated] (SLING-9796) Add support for using Unions

2020-10-07 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-9796: Summary: Add support for using Unions (was: GraphQL add support for using Unions) > Add support

[GitHub] [sling-org-apache-sling-graphql-core] raducotescu commented on a change in pull request #6: SLING-9796 [early review] Adds support for using Unions.

2020-10-07 Thread GitBox
raducotescu commented on a change in pull request #6: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/6#discussion_r500949572 ## File path: src/main/java/org/apache/sling/graphql/core/engine/SlingTypeResolverSelector.java ## @@ -0,0 +1,109 @@ +/* + *

[GitHub] [sling-org-apache-sling-graphql-core] raducotescu commented on a change in pull request #6: SLING-9796 [early review] Adds support for using Unions.

2020-10-07 Thread GitBox
raducotescu commented on a change in pull request #6: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/6#discussion_r500949572 ## File path: src/main/java/org/apache/sling/graphql/core/engine/SlingTypeResolverSelector.java ## @@ -0,0 +1,109 @@ +/* + *

[jira] [Created] (SLING-9800) Extract a service to be able to execute GraphQL queries directly

2020-10-07 Thread Radu Cotescu (Jira)
Radu Cotescu created SLING-9800: --- Summary: Extract a service to be able to execute GraphQL queries directly Key: SLING-9800 URL: https://issues.apache.org/jira/browse/SLING-9800 Project: Sling

[jira] [Resolved] (SLING-9799) Make logger available to Processor

2020-10-07 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-9799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-9799. - Resolution: Fixed Make logger available through ProcessorContext

[jira] [Created] (SLING-9799) Make logger available to Processor

2020-10-07 Thread Carsten Ziegeler (Jira)
Carsten Ziegeler created SLING-9799: --- Summary: Make logger available to Processor Key: SLING-9799 URL: https://issues.apache.org/jira/browse/SLING-9799 Project: Sling Issue Type:

[jira] [Commented] (SLING-2938) AdapterMethods annotation and adapter proxy service

2020-10-07 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209468#comment-17209468 ] Konrad Windszus commented on SLING-2938: [~Henry Kuijpers] The IT is failing on Jenkins:

[jira] [Resolved] (SLING-9794) Content package artifacts found by maven plugin don't always have their 'file' attribute set

2020-10-07 Thread David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Bosschaert resolved SLING-9794. - Resolution: Fixed > Content package artifacts found by maven plugin don't always have

[jira] [Commented] (SLING-9795) JUnit 5 support for server-side tests

2020-10-07 Thread Julian Sedding (Jira)
[ https://issues.apache.org/jira/browse/SLING-9795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209434#comment-17209434 ] Julian Sedding commented on SLING-9795: --- [PR

[GitHub] [sling-org-apache-sling-graphql-core] kozmaadrian commented on a change in pull request #6: SLING-9796 [early review] Adds support for using Unions.

2020-10-07 Thread GitBox
kozmaadrian commented on a change in pull request #6: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/6#discussion_r500453330 ## File path: src/main/java/org/apache/sling/graphql/core/engine/SlingTypeResolverSelector.java ## @@ -0,0 +1,109 @@ +/* + *

[GitHub] [sling-org-apache-sling-graphql-core] kozmaadrian commented on a change in pull request #6: SLING-9796 [early review] Adds support for using Unions.

2020-10-07 Thread GitBox
kozmaadrian commented on a change in pull request #6: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/6#discussion_r500833581 ## File path: src/main/java/org/apache/sling/graphql/core/engine/ScriptedTypeResolverProvider.java ## @@ -0,0 +1,91 @@ + +/*

[GitHub] [sling-org-apache-sling-graphql-core] bdelacretaz commented on a change in pull request #6: SLING-9796 [early review] Adds support for using Unions.

2020-10-07 Thread GitBox
bdelacretaz commented on a change in pull request #6: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/6#discussion_r500833543 ## File path: src/main/java/org/apache/sling/graphql/core/engine/SlingTypeResolverSelector.java ## @@ -0,0 +1,109 @@ +/* + *

[GitHub] [sling-org-apache-sling-graphql-core] kozmaadrian commented on a change in pull request #6: SLING-9796 [early review] Adds support for using Unions.

2020-10-07 Thread GitBox
kozmaadrian commented on a change in pull request #6: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/6#discussion_r500833581 ## File path: src/main/java/org/apache/sling/graphql/core/engine/ScriptedTypeResolverProvider.java ## @@ -0,0 +1,91 @@ + +/*

[GitHub] [sling-org-apache-sling-graphql-core] bdelacretaz commented on a change in pull request #6: SLING-9796 [early review] Adds support for using Unions.

2020-10-07 Thread GitBox
bdelacretaz commented on a change in pull request #6: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/6#discussion_r500832606 ## File path: src/main/java/org/apache/sling/graphql/core/engine/ScriptedTypeResolverProvider.java ## @@ -0,0 +1,91 @@ + +/*

[GitHub] [sling-org-apache-sling-graphql-core] bdelacretaz commented on a change in pull request #6: SLING-9796 [early review] Adds support for using Unions.

2020-10-07 Thread GitBox
bdelacretaz commented on a change in pull request #6: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/6#discussion_r500831138 ## File path: src/main/java/org/apache/sling/graphql/core/engine/ScriptedTypeResolverProvider.java ## @@ -0,0 +1,91 @@ + +/*

[jira] [Created] (SLING-9798) Don't expose OSGi / Apache Felix JMX MBeans from the feature launcher

2020-10-07 Thread Karl Pauls (Jira)
Karl Pauls created SLING-9798: - Summary: Don't expose OSGi / Apache Felix JMX MBeans from the feature launcher Key: SLING-9798 URL: https://issues.apache.org/jira/browse/SLING-9798 Project: Sling

[jira] [Created] (SLING-9797) move pipe should accept relative paths

2020-10-07 Thread Nicolas Peltier (Jira)
Nicolas Peltier created SLING-9797: -- Summary: move pipe should accept relative paths Key: SLING-9797 URL: https://issues.apache.org/jira/browse/SLING-9797 Project: Sling Issue Type: