[jira] [Assigned] (SLING-12053) Upgrade Sling GraphQL Core to Graphql-Java 21.x
[ https://issues.apache.org/jira/browse/SLING-12053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer reassigned SLING-12053: Assignee: Andreas Schaefer > Upgrade Sling GraphQL Core to Graphql-Java 21.x > --- > > Key: SLING-12053 > URL: https://issues.apache.org/jira/browse/SLING-12053 > Project: Sling > Issue Type: Improvement >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > > There is an upgrade from graphql-java of 21.x and that has (according to > them) breaking changes. As upgrading takes time I wanted to start the process > early with this ticket. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12053) Upgrade Sling GraphQL Core to Graphql-Java 21.x
[ https://issues.apache.org/jira/browse/SLING-12053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770495#comment-17770495 ] Andreas Schaefer commented on SLING-12053: -- I suggested a version check in the garaphql-java grade.build: Import-Package: !android.os.*,!com.google.*,!org.checkerframework.*,!javax.annotation.*,!graphql.com.google.*,!org.antlr.*,!graphql.org.antlr.*,!sun.misc.*,org.slf4j;version="[1.7,3.0)",* That would allow to use SLF4J version 1.7 and newer and would allow us to keep using it. This is my discussion with graphs-java: [https://github.com/graphql-java/graphql-java/issues/3339] > Upgrade Sling GraphQL Core to Graphql-Java 21.x > --- > > Key: SLING-12053 > URL: https://issues.apache.org/jira/browse/SLING-12053 > Project: Sling > Issue Type: Improvement >Reporter: Andreas Schaefer >Priority: Major > > There is an upgrade from graphql-java of 21.x and that has (according to > them) breaking changes. As upgrading takes time I wanted to start the process > early with this ticket. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12053) Upgrade Sling GraphQL Core to Graphql-Java 21.x
[ https://issues.apache.org/jira/browse/SLING-12053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770244#comment-17770244 ] Andreas Schaefer commented on SLING-12053: -- When I took Sling GraphQL Core 0.0.25-SNAPSHOT and upgraded to graphql-java 21.1 it broke the build. There are several issues with it: * It introduced a dependency to android.os (was fixed in the meantime) * upgraded to SLF4J to 2.0.x which breaks our build (I tested it by downgrading to 1.7.25 and that still works) I will check if graphql-java can contain a dependency range of SLF4J of 1.7 to 3.0 instead of 2.0 to 3.0 to allow use to upgrade. > Upgrade Sling GraphQL Core to Graphql-Java 21.x > --- > > Key: SLING-12053 > URL: https://issues.apache.org/jira/browse/SLING-12053 > Project: Sling > Issue Type: Improvement >Reporter: Andreas Schaefer >Priority: Major > > There is an upgrade from graphql-java of 21.x and that has (according to > them) breaking changes. As upgrading takes time I wanted to start the process > early with this ticket. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12053) Upgrade Sling GraphQL Core to Graphql-Java 21.x
Andreas Schaefer created SLING-12053: Summary: Upgrade Sling GraphQL Core to Graphql-Java 21.x Key: SLING-12053 URL: https://issues.apache.org/jira/browse/SLING-12053 Project: Sling Issue Type: Improvement Reporter: Andreas Schaefer There is an upgrade from graphql-java of 21.x and that has (according to them) breaking changes. As upgrading takes time I wanted to start the process early with this ticket. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12027) GraphQL core fails to build with Java 17
[ https://issues.apache.org/jira/browse/SLING-12027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768921#comment-17768921 ] Andreas Schaefer commented on SLING-12027: -- [~radu] Does not do the trick. I upgraded to the latest Engine, Servlets Resolver and some more and it still breaks the same way. It actually makes it even rose because now additional IT tests fail. > GraphQL core fails to build with Java 17 > > > Key: SLING-12027 > URL: https://issues.apache.org/jira/browse/SLING-12027 > Project: Sling > Issue Type: Bug > Components: GraphQL >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: GraphQL Core 0.0.26 > > > 1. Mockito fails to create mocks, probably due to old version > 2. Pax-Exam tests time out -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12027) GraphQL core fails to build with Java 17
[ https://issues.apache.org/jira/browse/SLING-12027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17767252#comment-17767252 ] Andreas Schaefer commented on SLING-12027: -- I found the cause of the issue. During the handling of the error the DefaultErrorHandlerServlet.service() (line 70) is trying to find the error code but it is not found. So it seems there is a disconnect between when that error code is set in SlingServletResolver.handleError() line 387 and when it is looked up. > GraphQL core fails to build with Java 17 > > > Key: SLING-12027 > URL: https://issues.apache.org/jira/browse/SLING-12027 > Project: Sling > Issue Type: Bug > Components: GraphQL >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: GraphQL Core 0.0.26 > > > 1. Mockito fails to create mocks, probably due to old version > 2. Pax-Exam tests time out -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12027) GraphQL core fails to build with Java 17
[
https://issues.apache.org/jira/browse/SLING-12027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17767199#comment-17767199
]
Andreas Schaefer commented on SLING-12027:
--
Here are some excerpts of the output:
a) Where the invalid query is discovered:
Caused by: org.apache.sling.api.resource.ResourceNotFoundException: Resource at
'/graphql/two.gql/persisted' not found: No resource found
at
org.apache.sling.servlets.get.impl.DefaultGetServlet.doGet(DefaultGetServlet.java:288)
at
org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
at
org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
at
org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
at
org.apache.sling.graphql.core.schema.DefaultSchemaProvider.getSchema(DefaultSchemaProvider.java:67)
at
org.apache.sling.graphql.core.schema.RankedSchemaProviders.getSchema(RankedSchemaProviders.java:58)
at
org.apache.sling.graphql.core.engine.DefaultQueryExecutor.prepareSchemaDefinition(DefaultQueryExecutor.java:339)
... 61 more
org.apache.sling.graphql.core[org.apache.sling.graphql.core.servlet.GraphQLServlet]
: Is Query Valid: 'false'
org.apache.sling.graphql.core[org.apache.sling.graphql.core.servlet.GraphQLServlet]
: Invalid GraphQL query: Schema provider failed
b) Looking for sling/nonexisting
org.apache.sling.jcr.resource[org.apache.sling.jcr.resource.internal.helper.jcr.JcrItemResourceFactory]
: createResource: No JCR Item exists at path '/apps/sling/nonexisting'
org.apache.sling.resourceresolver[org.apache.sling.resourceresolver.impl.helper.ResourceResolverControl]
: Resource null /apps/sling/nonexisting
org.apache.sling.resourceresolver[org.apache.sling.resourceresolver.impl.ResourceResolverImpl]
: getResourceInternal: Cannot resolve path '/apps/sling/nonexisting' to a
resource
c) Looking for sling/servlet/errorhandler
org.apache.sling.jcr.resource[org.apache.sling.jcr.resource.internal.helper.jcr.JcrItemResourceFactory]
: createResource: No JCR Item exists at path '/apps/sling/servlet/errorhandler'
org.apache.sling.resourceresolver[org.apache.sling.resourceresolver.impl.helper.ResourceResolverControl]
: Resource null /apps/sling/servlet/errorhandler
org.apache.sling.resourceresolver[org.apache.sling.resourceresolver.impl.ResourceResolverImpl]
: getResourceInternal: Cannot resolve path '/apps/sling/servlet/errorhandler'
to a resource
org.apache.sling.jcr.resource[org.apache.sling.jcr.resource.internal.helper.jcr.JcrItemResourceFactory]
: createResource: No JCR Item exists at path '/apps/sling/servlet/errorhandler'
org.apache.sling.servlets.resolver[org.apache.sling.servlets.resolver.internal.SlingServletResolver]
: Accepting servlet at '/apps/sling/servlet/errorhandler.servlet' as there are
no configured execution paths.
org.apache.sling.jcr.resource[org.apache.sling.jcr.resource.internal.helper.jcr.JcrItemResourceFactory]
: createResource: No JCR Item exists at path
'/apps/sling/servlet/errorhandler.servlet'
org.apache.sling.resourceresolver[org.apache.sling.resourceresolver.impl.helper.ResourceResolverControl]
: Resource null /apps/sling/servlet/errorhandler.servlet
org.apache.sling.resourceresolver[org.apache.sling.resourceresolver.impl.ResourceResolverImpl]
: getResourceInternal: Cannot resolve path
'/apps/sling/servlet/errorhandler.servlet' to a resource
org.apache.sling.jcr.resource[org.apache.sling.jcr.resource.internal.helper.jcr.JcrItemResourceFactory]
: createResource: No JCR Item exists at path '/libs/sling/servlet/errorhandler'
org.apache.sling.resourceresolver[org.apache.sling.resourceresolver.impl.helper.ResourceResolverControl]
: Resolved Synthetic /libs/sling/servlet/errorhandler
d) Writing out the Internal Server Error:
org.apache.felix.http.jetty[org.eclipse.jetty.server.HttpOutput] : write(array
HeapByteBuffer@5a63afc1[p=0,l=50,c=512,r=50]=\{<<<>>>\x00\x00\x00\x00\x00\x00\x00\x00\x00...\x00\x00\x00\x00\x00\x00\x00})
org.apache.felix.http.jetty[org.eclipse.jetty.server.HttpOutput] : write(array)
s=OPEN,api=BLOCKING,sc=false,e=null aggregated !flush
DirectByteBuffer@fd5949f[p=0,l=50,c=32768,r=50]=\{<<<>>>\x00\x00\x00\x00\x00\x00\x00\x00\x00...\x00\x00\x00\x00\x00\x00\x00}
org.apache.felix.http.jetty[org.eclipse.jetty.server.HttpOutput] : write(array
HeapByteBuffer@fd4c2d3[p=0,l=1,c=512,r=1]=\{<<<\n>>>!DOCTYPE
...\x00\x00\x00\x00\x00\x00\x00})
...
org.apache.felix.http.jetty[org.eclipse.jetty.server.HttpOutput] : write(array
HeapByteBuffer@516d7550[p=0,l=1,c=512,r=1]=\{<<< >>>00tle>PE
...\x00\x00\x00\x00\x00\x00\x00})
org.apache.felix.http.jetty[org.eclipse.jetty.server.HttpOutput] : write(array)
s=OPEN,api=BLOCKING,sc=false,e=null aggregated !flush
DirectByteBuffer@fd5949f[p=0,l=76,c=32768,r=76]=\{<<<\n\n500
>>>\x00\x00\x00\x00\x00\x00\x00\x00\x00...\x00\x00\x00\x00\x00\x00\x00}
[jira] [Commented] (SLING-12027) GraphQL core fails to build with Java 17
[ https://issues.apache.org/jira/browse/SLING-12027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17767174#comment-17767174 ] Andreas Schaefer commented on SLING-12027: -- The current PR for this ticket is: [https://github.com/apache/sling-org-apache-sling-graphql-core/pull/38] Looking at the failure in the GraphQLServletIT.testPersistingInvalidQueries() is that the GraphQLServlet.doPostPersistedQuery() is failing the query validation and sets the Response Error Code to SC_BAD_REQUEST. That said in the output I see that after looking for 'sling/nonexisting' and then 'sling/servlet/errorhandler' is failing. After that I see that the org.apache.felix.http.jetty[org.eclipse.jetty.server.HttpOutput] is writing an Internal Server Error which is then returned to the client. So this is not a GraphQL issue but rather a testing setup issue. > GraphQL core fails to build with Java 17 > > > Key: SLING-12027 > URL: https://issues.apache.org/jira/browse/SLING-12027 > Project: Sling > Issue Type: Bug > Components: GraphQL >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: GraphQL Core 0.0.26 > > > 1. Mockito fails to create mocks, probably due to old version > 2. Pax-Exam tests time out -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-10901) Allow terminating a GraphQL query after a configured timeout
[ https://issues.apache.org/jira/browse/SLING-10901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-10901: - Fix Version/s: GraphQL Core 0.0.26 (was: GraphQL Core 0.0.24) > Allow terminating a GraphQL query after a configured timeout > > > Key: SLING-10901 > URL: https://issues.apache.org/jira/browse/SLING-10901 > Project: Sling > Issue Type: Improvement > Components: GraphQL >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: GraphQL Core 0.0.26 > > > Since expensive GraphQL queries could lead to a DoS attack, it would be worth > allowing a system administrator to configure the maximum execution time of a > query. When a long running query is interrupted, the returned error should be > transparent for the GraphQL engine, so that the client knows exactly why the > query failed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12014) GraphQL Core needs to support additional fields from GraphQL Java
[ https://issues.apache.org/jira/browse/SLING-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-12014: - Fix Version/s: GraphQL Core 0.0.24 > GraphQL Core needs to support additional fields from GraphQL Java > - > > Key: SLING-12014 > URL: https://issues.apache.org/jira/browse/SLING-12014 > Project: Sling > Issue Type: Improvement >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > Fix For: GraphQL Core 0.0.24 > > > There is a need to have additional fields from the GraphQL Java's Selected > Field. For example there is a need to separate fields with the same name but > different parent through the Fully Qualified Name. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12014) GraphQL Core needs to support additional fields from GraphQL Java
[ https://issues.apache.org/jira/browse/SLING-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer resolved SLING-12014. -- Resolution: Fixed PR was merged into master > GraphQL Core needs to support additional fields from GraphQL Java > - > > Key: SLING-12014 > URL: https://issues.apache.org/jira/browse/SLING-12014 > Project: Sling > Issue Type: Improvement >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > > There is a need to have additional fields from the GraphQL Java's Selected > Field. For example there is a need to separate fields with the same name but > different parent through the Fully Qualified Name. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12014) GraphQL Core needs to support additional fields from GraphQL Java
[ https://issues.apache.org/jira/browse/SLING-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer closed SLING-12014. > GraphQL Core needs to support additional fields from GraphQL Java > - > > Key: SLING-12014 > URL: https://issues.apache.org/jira/browse/SLING-12014 > Project: Sling > Issue Type: Improvement >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > > There is a need to have additional fields from the GraphQL Java's Selected > Field. For example there is a need to separate fields with the same name but > different parent through the Fully Qualified Name. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12014) GraphQL Core needs to Support Addition Fields from GraphQL Java
[ https://issues.apache.org/jira/browse/SLING-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760638#comment-17760638 ] Andreas Schaefer commented on SLING-12014: -- Create a PR for this enhancements: [https://github.com/apache/sling-org-apache-sling-graphql-core/pull/37] > GraphQL Core needs to Support Addition Fields from GraphQL Java > --- > > Key: SLING-12014 > URL: https://issues.apache.org/jira/browse/SLING-12014 > Project: Sling > Issue Type: Improvement >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > > There is a need to have additional fields from the GraphQL Java's Selected > Field. For example there is a need to separate fields with the same name but > different parent through the Fully Qualified Name. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12014) GraphQL Core needs to Support Addition Fields from GraphQL Java
[ https://issues.apache.org/jira/browse/SLING-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer reassigned SLING-12014: Assignee: Andreas Schaefer > GraphQL Core needs to Support Addition Fields from GraphQL Java > --- > > Key: SLING-12014 > URL: https://issues.apache.org/jira/browse/SLING-12014 > Project: Sling > Issue Type: Improvement >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > > There is a need to have additional fields from the GraphQL Java's Selected > Field. For example there is a need to separate fields with the same name but > different parent through the Fully Qualified Name. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-11458) Regress - "Writer has already been closed" exception in GraphQLServlet
[
https://issues.apache.org/jira/browse/SLING-11458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Schaefer reassigned SLING-11458:
Assignee: Andreas Schaefer (was: Radu Cotescu)
> Regress - "Writer has already been closed" exception in GraphQLServlet
> --
>
> Key: SLING-11458
> URL: https://issues.apache.org/jira/browse/SLING-11458
> Project: Sling
> Issue Type: Bug
> Components: GraphQL
>Affects Versions: GraphQL Core 0.0.4
>Reporter: Evgeny Tugarev
>Assignee: Andreas Schaefer
>Priority: Major
>
> The GraphQLServlet shouldn't call {{response.getWriter().flush()}} as the
> {{JsonWriter}} used by the {{JsonSerializer}} implements {{Closeable}} and as
> such [closes the
> Writer|https://github.com/jdereg/json-io/blob/cf849f15460decf10a8a320390de11965bb5996b/src/main/java/com/cedarsoftware/util/io/JsonWriter.java#L2413].
> This causes a "Writer has already been closed" Exception when {{flush()}} is
> called.
> This was fixed in commit d27f4bb7 but then this commit: 11c7e389 did undo the
> fix as now the JsonWriter is closed when existing the try-catch block.
> I will undo it and prevent the premature closure as this is causing issues
> like when the call to this servlet is made through a dispatcher.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12014) GraphQL Core needs to Support Addition Fields from GraphQL Java
Andreas Schaefer created SLING-12014: Summary: GraphQL Core needs to Support Addition Fields from GraphQL Java Key: SLING-12014 URL: https://issues.apache.org/jira/browse/SLING-12014 Project: Sling Issue Type: Improvement Reporter: Andreas Schaefer There is a need to have additional fields from the GraphQL Java's Selected Field. For example there is a need to separate fields with the same name but different parent through the Fully Qualified Name. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11458) Regress - "Writer has already been closed" exception in GraphQLServlet
[
https://issues.apache.org/jira/browse/SLING-11458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17754179#comment-17754179
]
Andreas Schaefer commented on SLING-11458:
--
The Servlet Writer should not be closed inside the GraphQL Servlet as it was
originally.
Because the GraphQL Servlet is used with a redirect and when it is closed
prematurely the calling servlet is causing an exception (as mentioned in the
ticket) that the writer was already closed. The fix could also be that there is
not exception raised when the writer is closed again which it should if you
asked me but that is not how it works right now.
> Regress - "Writer has already been closed" exception in GraphQLServlet
> --
>
> Key: SLING-11458
> URL: https://issues.apache.org/jira/browse/SLING-11458
> Project: Sling
> Issue Type: Bug
> Components: GraphQL
>Affects Versions: GraphQL Core 0.0.4
>Reporter: Evgeny Tugarev
>Assignee: Andreas Schaefer
>Priority: Major
>
> The GraphQLServlet shouldn't call {{response.getWriter().flush()}} as the
> {{JsonWriter}} used by the {{JsonSerializer}} implements {{Closeable}} and as
> such [closes the
> Writer|https://github.com/jdereg/json-io/blob/cf849f15460decf10a8a320390de11965bb5996b/src/main/java/com/cedarsoftware/util/io/JsonWriter.java#L2413].
> This causes a "Writer has already been closed" Exception when {{flush()}} is
> called.
> This was fixed in commit d27f4bb7 but then this commit: 11c7e389 did undo the
> fix as now the JsonWriter is closed when existing the try-catch block.
> I will undo it and prevent the premature closure as this is causing issues
> like when the call to this servlet is made through a dispatcher.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11920) Expose Object Type Names in Selected Field
[
https://issues.apache.org/jira/browse/SLING-11920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741219#comment-17741219
]
Andreas Schaefer commented on SLING-11920:
--
I created a PR
[https://github.com/apache/sling-org-apache-sling-graphql-core/pull/36] that
exposed the Object Type Names to the User.
There is also some cleanup and additional tests to verify the proper handling
of Object Type Names.
> Expose Object Type Names in Selected Field
> --
>
> Key: SLING-11920
> URL: https://issues.apache.org/jira/browse/SLING-11920
> Project: Sling
> Issue Type: Bug
>Affects Versions: GraphQL Core 0.0.20
>Reporter: Andreas Schaefer
>Assignee: Andreas Schaefer
>Priority: Critical
> Fix For: GraphQL Core 0.0.22
>
>
> Intermediary fields are not exposed as Selected Fields in Graphql-java and so
> it was added as list of Object Type Name.
> Now for handling '... on ' we need to expose these Object Type
> Names so that a client can deal with them.
> If we have a query where we have a inline fragments
> ([https://graphql.org/learn/queries/#inline-fragments]) like:
> {code:java}
> {
>image {
> ... on ImageRef {
> type{code}
> Then in the graphql-java 15.0 there is an inlined field called *ImageRef* but
> that is now gone in 20.1. Instead we have a list of Object Type Names in a
> field and in our example *type* would have Objet Type Names:
> {*}["ImageRef"]{*}. So for a client to obtain the type of the inlined
> fragments this data must be exposed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11920) Expose Object Type Names in Selected Field
[
https://issues.apache.org/jira/browse/SLING-11920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Schaefer updated SLING-11920:
-
Description:
Intermediary fields are not exposed as Selected Fields in Graphql-java and so
it was added as list of Object Type Name.
Now for handling '... on ' we need to expose these Object Type
Names so that a client can deal with them.
If we have a query where we have a inline fragments
([https://graphql.org/learn/queries/#inline-fragments]) like:
{code:java}
{
image {
... on ImageRef {
type{code}
Then in the graphql-java 15.0 there is an inlined field called *ImageRef* but
that is now gone in 20.1. Instead we have a list of Object Type Names in a
field and in our example *type* would have Objet Type Names:
{*}["ImageRef"]{*}. So for a client to obtain the type of the inlined fragments
this data must be exposed.
was:
Intermediary fields are not exposed as Selected Fields in Graphql-java and so
it was added as list of Object Type Name.
Now for handling '... on ' we need to expose these Object Type
Names so that a client can deal with them.
> Expose Object Type Names in Selected Field
> --
>
> Key: SLING-11920
> URL: https://issues.apache.org/jira/browse/SLING-11920
> Project: Sling
> Issue Type: Bug
>Affects Versions: GraphQL Core 0.0.20
>Reporter: Andreas Schaefer
>Assignee: Andreas Schaefer
>Priority: Critical
> Fix For: GraphQL Core 0.0.22
>
>
> Intermediary fields are not exposed as Selected Fields in Graphql-java and so
> it was added as list of Object Type Name.
> Now for handling '... on ' we need to expose these Object Type
> Names so that a client can deal with them.
> If we have a query where we have a inline fragments
> ([https://graphql.org/learn/queries/#inline-fragments]) like:
> {code:java}
> {
>image {
> ... on ImageRef {
> type{code}
> Then in the graphql-java 15.0 there is an inlined field called *ImageRef* but
> that is now gone in 20.1. Instead we have a list of Object Type Names in a
> field and in our example *type* would have Objet Type Names:
> {*}["ImageRef"]{*}. So for a client to obtain the type of the inlined
> fragments this data must be exposed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11920) Expose Object Type Names in Selected Field
[ https://issues.apache.org/jira/browse/SLING-11920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738806#comment-17738806 ] Andreas Schaefer commented on SLING-11920: -- This is a follow up of SLING-10900 and the release of Sling GraphQL Core 0.0.20 > Expose Object Type Names in Selected Field > -- > > Key: SLING-11920 > URL: https://issues.apache.org/jira/browse/SLING-11920 > Project: Sling > Issue Type: Bug >Affects Versions: GraphQL Core 0.0.20 >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Critical > Fix For: GraphQL Core 0.0.22 > > > Intermediary fields are not exposed as Selected Fields in Graphql-java and so > it was added as list of Object Type Name. > Now for handling '... on ' we need to expose these Object Type > Names so that a client can deal with them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11920) Expose Object Type Names in Selected Field
Andreas Schaefer created SLING-11920: Summary: Expose Object Type Names in Selected Field Key: SLING-11920 URL: https://issues.apache.org/jira/browse/SLING-11920 Project: Sling Issue Type: Bug Affects Versions: GraphQL Core 0.0.20 Reporter: Andreas Schaefer Assignee: Andreas Schaefer Fix For: GraphQL Core 0.0.22 Intermediary fields are not exposed as Selected Fields in Graphql-java and so it was added as list of Object Type Name. Now for handling '... on ' we need to expose these Object Type Names so that a client can deal with them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-10901) Allow terminating a GraphQL query after a configured timeout
[ https://issues.apache.org/jira/browse/SLING-10901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-10901: - Fix Version/s: GraphQL Core 0.0.22 (was: GraphQL Core 0.0.20) > Allow terminating a GraphQL query after a configured timeout > > > Key: SLING-10901 > URL: https://issues.apache.org/jira/browse/SLING-10901 > Project: Sling > Issue Type: Improvement > Components: GraphQL >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: GraphQL Core 0.0.22 > > > Since expensive GraphQL queries could lead to a DoS attack, it would be worth > allowing a system administrator to configure the maximum execution time of a > query. When a long running query is interrupted, the returned error should be > transparent for the GraphQL engine, so that the client knows exactly why the > query failed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-10900) Update graphql-java to version 17
[
https://issues.apache.org/jira/browse/SLING-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Schaefer updated SLING-10900:
-
Fix Version/s: GraphQL Core 0.0.20
(was: GraphQL Core 0.0.18)
> Update graphql-java to version 17
> -
>
> Key: SLING-10900
> URL: https://issues.apache.org/jira/browse/SLING-10900
> Project: Sling
> Issue Type: Improvement
> Components: GraphQL
>Reporter: Radu Cotescu
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: GraphQL Core 0.0.20
>
>
> {{graphql-java}} 17 brings a set of performance improvements [0] which could
> benefit the GraphQL Core bundle:
> * [2067|https://github.com/graphql-java/graphql-java/pull/2067] Support for
> Streams and Iterators
> * Dramatic performance improvements in GraphQLSchema building
> * Dramatic performance improvements in DataFetchingFieldSelectionSet
> * Dramatic performance improvements in large query validation
> [0] - https://github.com/graphql-java/graphql-java/releases/tag/v17.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-10900) Update graphl-java to version 17
[
https://issues.apache.org/jira/browse/SLING-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Schaefer updated SLING-10900:
-
Fix Version/s: GraphQL Core 0.0.18
(was: GraphQL Core 0.0.16)
> Update graphl-java to version 17
>
>
> Key: SLING-10900
> URL: https://issues.apache.org/jira/browse/SLING-10900
> Project: Sling
> Issue Type: Improvement
> Components: GraphQL
>Reporter: Radu Cotescu
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: GraphQL Core 0.0.18
>
>
> {{graphql-java}} 17 brings a set of performance improvements [0] which could
> benefit the GraphQL Core bundle:
> * [2067|https://github.com/graphql-java/graphql-java/pull/2067] Support for
> Streams and Iterators
> * Dramatic performance improvements in GraphQLSchema building
> * Dramatic performance improvements in DataFetchingFieldSelectionSet
> * Dramatic performance improvements in large query validation
> [0] - https://github.com/graphql-java/graphql-java/releases/tag/v17.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-10901) Allow terminating a GraphQL query after a configured timeout
[ https://issues.apache.org/jira/browse/SLING-10901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-10901: - Fix Version/s: GraphQL Core 0.0.20 (was: GraphQL Core 0.0.18) > Allow terminating a GraphQL query after a configured timeout > > > Key: SLING-10901 > URL: https://issues.apache.org/jira/browse/SLING-10901 > Project: Sling > Issue Type: Improvement > Components: GraphQL >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: GraphQL Core 0.0.20 > > > Since expensive GraphQL queries could lead to a DoS attack, it would be worth > allowing a system administrator to configure the maximum execution time of a > query. When a long running query is interrupted, the returned error should be > transparent for the GraphQL engine, so that the client knows exactly why the > query failed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-10901) Allow terminating a GraphQL query after a configured timeout
[ https://issues.apache.org/jira/browse/SLING-10901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-10901: - Fix Version/s: GraphQL Core 0.0.18 (was: GraphQL Core 0.0.16) > Allow terminating a GraphQL query after a configured timeout > > > Key: SLING-10901 > URL: https://issues.apache.org/jira/browse/SLING-10901 > Project: Sling > Issue Type: Improvement > Components: GraphQL >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: GraphQL Core 0.0.18 > > > Since expensive GraphQL queries could lead to a DoS attack, it would be worth > allowing a system administrator to configure the maximum execution time of a > query. When a long running query is interrupted, the returned error should be > transparent for the GraphQL engine, so that the client knows exactly why the > query failed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-10900) Update graphl-java to version 17
[
https://issues.apache.org/jira/browse/SLING-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Schaefer resolved SLING-10900.
--
Resolution: Fixed
Upgraded to graphql-java 20.1 (latest release) as there are nearly no changes
needed from 17 to 20
> Update graphl-java to version 17
>
>
> Key: SLING-10900
> URL: https://issues.apache.org/jira/browse/SLING-10900
> Project: Sling
> Issue Type: Improvement
> Components: GraphQL
>Reporter: Radu Cotescu
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: GraphQL Core 0.0.16
>
>
> {{graphql-java}} 17 brings a set of performance improvements [0] which could
> benefit the GraphQL Core bundle:
> * [2067|https://github.com/graphql-java/graphql-java/pull/2067] Support for
> Streams and Iterators
> * Dramatic performance improvements in GraphQLSchema building
> * Dramatic performance improvements in DataFetchingFieldSelectionSet
> * Dramatic performance improvements in large query validation
> [0] - https://github.com/graphql-java/graphql-java/releases/tag/v17.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-10900) Update graphl-java to version 17
[
https://issues.apache.org/jira/browse/SLING-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705660#comment-17705660
]
Andreas Schaefer commented on SLING-10900:
--
After graphql-java released 20.1 with the necessary fixes to make it work in an
OSGi environment I updated the code to move to version 20.1 and start the
release process.
> Update graphl-java to version 17
>
>
> Key: SLING-10900
> URL: https://issues.apache.org/jira/browse/SLING-10900
> Project: Sling
> Issue Type: Improvement
> Components: GraphQL
>Reporter: Radu Cotescu
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: GraphQL Core 0.0.16
>
>
> {{graphql-java}} 17 brings a set of performance improvements [0] which could
> benefit the GraphQL Core bundle:
> * [2067|https://github.com/graphql-java/graphql-java/pull/2067] Support for
> Streams and Iterators
> * Dramatic performance improvements in GraphQLSchema building
> * Dramatic performance improvements in DataFetchingFieldSelectionSet
> * Dramatic performance improvements in large query validation
> [0] - https://github.com/graphql-java/graphql-java/releases/tag/v17.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (SLING-10900) Update graphl-java to version 17
[
https://issues.apache.org/jira/browse/SLING-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695824#comment-17695824
]
Andreas Schaefer edited comment on SLING-10900 at 3/2/23 5:06 PM:
--
After some help from the graphql-java team I was able to find a solution to
prevent the class loading issue by reverting back to the original class
loading. Branch
[https://github.com/apache/sling-org-apache-sling-graphql-core/tree/issue/SLING-10900-200]
does contain that fix.
That said this will still fail the Jenkins test as the graphql-java 20.0 is not
a valid Feature Model bundle. I hope that somewhere in April graphql-java team
will release 20.1 which should have all the fixes in place.
I also closed the PR 3099 as all the Jenkins test failed and there is no reason
anymore to go with 19.x.
was (Author: schaefa):
After some help from the graphql-java team I was able to find a solution to
prevent the class loading issue by reverting back to the original class
loading. Branch
[https://github.com/apache/sling-org-apache-sling-graphql-core/tree/issue/SLING-10900-200]
does contain that fix.
That said this will still fail the Jenkins test as the graphql-java 20.0 is not
a valid Feature Model bundle. I hope that somewhere in April graphql-java team
will release 20.1 which should have all the fixes in place.
> Update graphl-java to version 17
>
>
> Key: SLING-10900
> URL: https://issues.apache.org/jira/browse/SLING-10900
> Project: Sling
> Issue Type: Improvement
> Components: GraphQL
>Reporter: Radu Cotescu
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: GraphQL Core 0.0.16
>
>
> {{graphql-java}} 17 brings a set of performance improvements [0] which could
> benefit the GraphQL Core bundle:
> * [2067|https://github.com/graphql-java/graphql-java/pull/2067] Support for
> Streams and Iterators
> * Dramatic performance improvements in GraphQLSchema building
> * Dramatic performance improvements in DataFetchingFieldSelectionSet
> * Dramatic performance improvements in large query validation
> [0] - https://github.com/graphql-java/graphql-java/releases/tag/v17.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-10900) Update graphl-java to version 17
[
https://issues.apache.org/jira/browse/SLING-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695824#comment-17695824
]
Andreas Schaefer commented on SLING-10900:
--
After some help from the graphql-java team I was able to find a solution to
prevent the class loading issue by reverting back to the original class
loading. Branch
[https://github.com/apache/sling-org-apache-sling-graphql-core/tree/issue/SLING-10900-200]
does contain that fix.
That said this will still fail the Jenkins test as the graphql-java 20.0 is not
a valid Feature Model bundle. I hope that somewhere in April graphql-java team
will release 20.1 which should have all the fixes in place.
> Update graphl-java to version 17
>
>
> Key: SLING-10900
> URL: https://issues.apache.org/jira/browse/SLING-10900
> Project: Sling
> Issue Type: Improvement
> Components: GraphQL
>Reporter: Radu Cotescu
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: GraphQL Core 0.0.16
>
>
> {{graphql-java}} 17 brings a set of performance improvements [0] which could
> benefit the GraphQL Core bundle:
> * [2067|https://github.com/graphql-java/graphql-java/pull/2067] Support for
> Streams and Iterators
> * Dramatic performance improvements in GraphQLSchema building
> * Dramatic performance improvements in DataFetchingFieldSelectionSet
> * Dramatic performance improvements in large query validation
> [0] - https://github.com/graphql-java/graphql-java/releases/tag/v17.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-10900) Update graphl-java to version 17
[
https://issues.apache.org/jira/browse/SLING-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694235#comment-17694235
]
Andreas Schaefer commented on SLING-10900:
--
After testing with AEM this is the current state:
# graphql-java 20.0 leads to class loading issues with GenericConnection
(pagination) which is not only a Sling issue
# graphql-java 17.4, 18.3, 19.3 and 20.0 all contained an import of sun.misc
and the MANIFEST.MF is not the first entry
## Both of these issues are fixed and accepted on 20.x
## There is a pending PR for 19.x with the back port of these fixes
([https://github.com/graphql-java/graphql-java/pull/3099])
# graphql-java 19.3 works just fine with Sling Graphql Core but not when used
in a Feature Model environment
As the issue with class loading seems to be bigger issue so as of now 19.3
seems to be the best target to upgrade to.
I created a PR:
[https://github.com/apache/sling-org-apache-sling-graphql-core/pull/34] that
contains the fixes for the upgrade as well as the adjustments to the tests.
That anyone who wants to use this version inside any Feature Model systems need
to use the fixed version which can be found in here:
[https://github.com/schaefa/graphql-java/tree/issue/manifest-mf.order.19x]. Use
the mentioned above process on created the Graphql-java bundle but with
RELEASE_VERISON of 19.4 or 19.4-SNAPSHOT and then use that then.
> Update graphl-java to version 17
>
>
> Key: SLING-10900
> URL: https://issues.apache.org/jira/browse/SLING-10900
> Project: Sling
> Issue Type: Improvement
> Components: GraphQL
>Reporter: Radu Cotescu
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: GraphQL Core 0.0.16
>
>
> {{graphql-java}} 17 brings a set of performance improvements [0] which could
> benefit the GraphQL Core bundle:
> * [2067|https://github.com/graphql-java/graphql-java/pull/2067] Support for
> Streams and Iterators
> * Dramatic performance improvements in GraphQLSchema building
> * Dramatic performance improvements in DataFetchingFieldSelectionSet
> * Dramatic performance improvements in large query validation
> [0] - https://github.com/graphql-java/graphql-java/releases/tag/v17.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-10900) Update graphl-java to version 17
[
https://issues.apache.org/jira/browse/SLING-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691777#comment-17691777
]
Andreas Schaefer commented on SLING-10900:
--
All graphql-java version newer that 17.4 have an issue with the released JAR
file as the MANIFEST.MF entry is not the first one in the JAR file making it
not deploy when using a Feature Model.
I create a branch on Sling Graphql Core *issue/SLING-10900-201* that allows to
test it with the latest fixes in graphql-java. These are the instructions.
# Checkout my branch: **issue/manifest-mf.order** from Github:
https://github.com/schaefa/graphql-java/tree/issue/manifest-mf.order
# Go to its folder
# Change to Java 11
# Set release version with: `export RELEASE_VERSION="20.1-SNAPSHOT"`
# Build with: `./gradlew clean publishToMavenLocal -x
signGraphqlJavaPublication`
# Copy the folder **com/graphql-java/graphql-java/20.1-SNAPSHOT** from your
local .m2 repository to a folder **respository** inside the Sling Graphql Core
## Make sure all the sub folders are created or copied to there to (this is
the path to the JAR file:
`respository/com/graphql-java/graphql-java/20.1-SNAPSHOT/graphql-java-20.1-SNAPSHOT.jar`)
> Update graphl-java to version 17
>
>
> Key: SLING-10900
> URL: https://issues.apache.org/jira/browse/SLING-10900
> Project: Sling
> Issue Type: Improvement
> Components: GraphQL
>Reporter: Radu Cotescu
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: GraphQL Core 0.0.16
>
>
> {{graphql-java}} 17 brings a set of performance improvements [0] which could
> benefit the GraphQL Core bundle:
> * [2067|https://github.com/graphql-java/graphql-java/pull/2067] Support for
> Streams and Iterators
> * Dramatic performance improvements in GraphQLSchema building
> * Dramatic performance improvements in DataFetchingFieldSelectionSet
> * Dramatic performance improvements in large query validation
> [0] - https://github.com/graphql-java/graphql-java/releases/tag/v17.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (SLING-10900) Update graphl-java to version 17
[
https://issues.apache.org/jira/browse/SLING-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Schaefer reassigned SLING-10900:
Assignee: Andreas Schaefer (was: Radu Cotescu)
> Update graphl-java to version 17
>
>
> Key: SLING-10900
> URL: https://issues.apache.org/jira/browse/SLING-10900
> Project: Sling
> Issue Type: Improvement
> Components: GraphQL
>Reporter: Radu Cotescu
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: GraphQL Core 0.0.16
>
>
> {{graphql-java}} 17 brings a set of performance improvements [0] which could
> benefit the GraphQL Core bundle:
> * [2067|https://github.com/graphql-java/graphql-java/pull/2067] Support for
> Streams and Iterators
> * Dramatic performance improvements in GraphQLSchema building
> * Dramatic performance improvements in DataFetchingFieldSelectionSet
> * Dramatic performance improvements in large query validation
> [0] - https://github.com/graphql-java/graphql-java/releases/tag/v17.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11458) Regress - "Writer has already been closed" exception in GraphQLServlet
[
https://issues.apache.org/jira/browse/SLING-11458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637398#comment-17637398
]
Andreas Schaefer commented on SLING-11458:
--
[~radu] I don't mind fixing the issue upstream or does not throw an exception
when someone calls flush / close on an already closed writer. That said I don't
understand why the writer needs to be closed in the GraphQLServlet? This was
not happening before.
Is there a reason why the Servlet Writer needs to be closed? Otherwise we
should keep the Writer open.
> Regress - "Writer has already been closed" exception in GraphQLServlet
> --
>
> Key: SLING-11458
> URL: https://issues.apache.org/jira/browse/SLING-11458
> Project: Sling
> Issue Type: Bug
> Components: GraphQL
>Affects Versions: GraphQL Core 0.0.4
>Reporter: Evgeny Tugarev
>Assignee: Andreas Schaefer
>Priority: Major
>
> The GraphQLServlet shouldn't call {{response.getWriter().flush()}} as the
> {{JsonWriter}} used by the {{JsonSerializer}} implements {{Closeable}} and as
> such [closes the
> Writer|https://github.com/jdereg/json-io/blob/cf849f15460decf10a8a320390de11965bb5996b/src/main/java/com/cedarsoftware/util/io/JsonWriter.java#L2413].
> This causes a "Writer has already been closed" Exception when {{flush()}} is
> called.
> This was fixed in commit d27f4bb7 but then this commit: 11c7e389 did undo the
> fix as now the JsonWriter is closed when existing the try-catch block.
> I will undo it and prevent the premature closure as this is causing issues
> like when the call to this servlet is made through a dispatcher.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (SLING-11458) Regress - "Writer has already been closed" exception in GraphQLServlet
[
https://issues.apache.org/jira/browse/SLING-11458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634573#comment-17634573
]
Andreas Schaefer edited comment on SLING-11458 at 11/16/22 10:02 PM:
-
The problem here is that the Johnzon's JsonWriter is closing the enclosed
Servlet Print Writer which then will cause the WriterAlreadyClosedException
when the Rewriter Response wants to flush the Print Writer.
If we would not use the JsonWriter we would not have this issue because the
PrintWriter is not bound to the try-block.
was (Author: schaefa):
The problem here is that the Johnson's JsonWriter is closing the enclosed
Servlet Print Writer which then will cause the WriterAlreadyClosedException
when the Rewriter Response wants to flush the Print Writer.
If we would not use the JsonWriter we would not have this issue because the
PrintWriter is not bound to the try-block.
> Regress - "Writer has already been closed" exception in GraphQLServlet
> --
>
> Key: SLING-11458
> URL: https://issues.apache.org/jira/browse/SLING-11458
> Project: Sling
> Issue Type: Bug
> Components: GraphQL
>Affects Versions: GraphQL Core 0.0.4
>Reporter: Evgeny Tugarev
>Assignee: Andreas Schaefer
>Priority: Major
>
> The GraphQLServlet shouldn't call {{response.getWriter().flush()}} as the
> {{JsonWriter}} used by the {{JsonSerializer}} implements {{Closeable}} and as
> such [closes the
> Writer|https://github.com/jdereg/json-io/blob/cf849f15460decf10a8a320390de11965bb5996b/src/main/java/com/cedarsoftware/util/io/JsonWriter.java#L2413].
> This causes a "Writer has already been closed" Exception when {{flush()}} is
> called.
> This was fixed in commit d27f4bb7 but then this commit: 11c7e389 did undo the
> fix as now the JsonWriter is closed when existing the try-catch block.
> I will undo it and prevent the premature closure as this is causing issues
> like when the call to this servlet is made through a dispatcher.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11458) Regress - "Writer has already been closed" exception in GraphQLServlet
[
https://issues.apache.org/jira/browse/SLING-11458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634573#comment-17634573
]
Andreas Schaefer commented on SLING-11458:
--
The problem here is that the Johnson's JsonWriter is closing the enclosed
Servlet Print Writer which then will cause the WriterAlreadyClosedException
when the Rewriter Response wants to flush the Print Writer.
If we would not use the JsonWriter we would not have this issue because the
PrintWriter is not bound to the try-block.
> Regress - "Writer has already been closed" exception in GraphQLServlet
> --
>
> Key: SLING-11458
> URL: https://issues.apache.org/jira/browse/SLING-11458
> Project: Sling
> Issue Type: Bug
> Components: GraphQL
>Affects Versions: GraphQL Core 0.0.4
>Reporter: Evgeny Tugarev
>Assignee: Andreas Schaefer
>Priority: Major
>
> The GraphQLServlet shouldn't call {{response.getWriter().flush()}} as the
> {{JsonWriter}} used by the {{JsonSerializer}} implements {{Closeable}} and as
> such [closes the
> Writer|https://github.com/jdereg/json-io/blob/cf849f15460decf10a8a320390de11965bb5996b/src/main/java/com/cedarsoftware/util/io/JsonWriter.java#L2413].
> This causes a "Writer has already been closed" Exception when {{flush()}} is
> called.
> This was fixed in commit d27f4bb7 but then this commit: 11c7e389 did undo the
> fix as now the JsonWriter is closed when existing the try-catch block.
> I will undo it and prevent the premature closure as this is causing issues
> like when the call to this servlet is made through a dispatcher.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11458) Regress - "Writer has already been closed" exception in GraphQLServlet
[
https://issues.apache.org/jira/browse/SLING-11458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634524#comment-17634524
]
Andreas Schaefer commented on SLING-11458:
--
[~radu] Do you know if anything was done regarding this issue?
I think the discussion you mentioned is not related to this issue as this is a
problem because the Servlet Writer is closed because of the Json Writer leaving
the try block and so specific to the GraphQL Servlet.
> Regress - "Writer has already been closed" exception in GraphQLServlet
> --
>
> Key: SLING-11458
> URL: https://issues.apache.org/jira/browse/SLING-11458
> Project: Sling
> Issue Type: Bug
> Components: GraphQL
>Affects Versions: GraphQL Core 0.0.4
>Reporter: Evgeny Tugarev
>Assignee: Andreas Schaefer
>Priority: Major
>
> The GraphQLServlet shouldn't call {{response.getWriter().flush()}} as the
> {{JsonWriter}} used by the {{JsonSerializer}} implements {{Closeable}} and as
> such [closes the
> Writer|https://github.com/jdereg/json-io/blob/cf849f15460decf10a8a320390de11965bb5996b/src/main/java/com/cedarsoftware/util/io/JsonWriter.java#L2413].
> This causes a "Writer has already been closed" Exception when {{flush()}} is
> called.
> This was fixed in commit d27f4bb7 but then this commit: 11c7e389 did undo the
> fix as now the JsonWriter is closed when existing the try-catch block.
> I will undo it and prevent the premature closure as this is causing issues
> like when the call to this servlet is made through a dispatcher.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11486) Allow to use a Writer that check for close as used in Response Context Support
[ https://issues.apache.org/jira/browse/SLING-11486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569618#comment-17569618 ] Andreas Schaefer commented on SLING-11486: -- PR for this ticket can be found here: https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/8 > Allow to use a Writer that check for close as used in Response Context Support > -- > > Key: SLING-11486 > URL: https://issues.apache.org/jira/browse/SLING-11486 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Servlet Helpers 1.4.2 >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > Fix For: Servlet Helpers 1.4.4 > > Time Spent: 10m > Remaining Estimate: 0h > > A problem with testing GraphQL is that the Unit test does not fail when the > Writer was closed during the invocation. So the Mock Servlet Http Response > should provide a Writer that checks if the writer was already closed to mimic > the actual behavior. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11486) Allow to use a Writer that check for close as used in Response Context Support
Andreas Schaefer created SLING-11486: Summary: Allow to use a Writer that check for close as used in Response Context Support Key: SLING-11486 URL: https://issues.apache.org/jira/browse/SLING-11486 Project: Sling Issue Type: Improvement Components: Testing Affects Versions: Servlet Helpers 1.4.2 Reporter: Andreas Schaefer Assignee: Andreas Schaefer Fix For: Servlet Helpers 1.4.4 A problem with testing GraphQL is that the Unit test does not fail when the Writer was closed during the invocation. So the Mock Servlet Http Response should provide a Writer that checks if the writer was already closed to mimic the actual behavior. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11458) Regress - "Writer has already been closed" exception in GraphQLServlet
[
https://issues.apache.org/jira/browse/SLING-11458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567402#comment-17567402
]
Andreas Schaefer commented on SLING-11458:
--
I encountered that issue in AEM when using the AEM GraphiQL UI:
15.07.2022 13:36:29.907 *ERROR* [127.0.0.1 [1657917208499] POST
/content/cq:graphql/as-conf-1/endpoint.json HTTP/1.1]
org.apache.sling.engine.impl.SlingRequestProcessorImpl Writer has already been
closed.
org.apache.sling.engine.impl.SlingHttpServletResponseImpl$WriterAlreadyClosedException:
null
at
org.apache.sling.engine.impl.SlingHttpServletResponseImpl$1.checkClosed(SlingHttpServletResponseImpl.java:191)
[org.apache.sling.engine:2.9.0]
at
org.apache.sling.engine.impl.SlingHttpServletResponseImpl$1.flush(SlingHttpServletResponseImpl.java:228)
[org.apache.sling.engine:2.9.0]
at
org.apache.sling.rewriter.impl.RewriterResponse.flushBuffer(RewriterResponse.java:126)
[org.apache.sling.rewriter:1.3.2]
at
org.apache.sling.engine.impl.request.SlingRequestDispatcher.forward(SlingRequestDispatcher.java:151)
[org.apache.sling.engine:2.9.0]
at
com.day.cq.wcm.core.impl.WCMComponentFilter$ForwardRequestDispatcher.forward(WCMComponentFilter.java:503)
[com.day.cq.wcm.cq-wcm-core:5.14.46]
at
com.adobe.aem.graphql.sites.adapters.sling.SlingGraphQLForwardingServlet.forwardRequest(SlingGraphQLForwardingServlet.java:80)
[com.adobe.aem.graphql.sling-adapter:0.1.42]
at
com.adobe.aem.graphql.sites.adapters.sling.SlingGraphQLForwardingServlet.doPost(SlingGraphQLForwardingServlet.java:67)
[com.adobe.aem.graphql.sling-adapter:0.1.42]
It does not affect the output but it is pretty noisy.
> Regress - "Writer has already been closed" exception in GraphQLServlet
> --
>
> Key: SLING-11458
> URL: https://issues.apache.org/jira/browse/SLING-11458
> Project: Sling
> Issue Type: Bug
> Components: GraphQL
>Affects Versions: GraphQL Core 0.0.4
>Reporter: Evgeny Tugarev
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: GraphQL Core 0.0.6
>
>
> The GraphQLServlet shouldn't call {{response.getWriter().flush()}} as the
> {{JsonWriter}} used by the {{JsonSerializer}} implements {{Closeable}} and as
> such [closes the
> Writer|https://github.com/jdereg/json-io/blob/cf849f15460decf10a8a320390de11965bb5996b/src/main/java/com/cedarsoftware/util/io/JsonWriter.java#L2413].
> This causes a "Writer has already been closed" Exception when {{flush()}} is
> called.
> This was fixed in commit d27f4bb7 but then this commit: 11c7e389 did undo the
> fix as now the JsonWriter is closed when existing the try-catch block.
> I will undo it and prevent the premature closure as this is causing issues
> like when the call to this servlet is made through a dispatcher.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11458) Regress - "Writer has already been closed" exception in GraphQLServlet
[
https://issues.apache.org/jira/browse/SLING-11458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Schaefer updated SLING-11458:
-
Description:
The GraphQLServlet shouldn't call {{response.getWriter().flush()}} as the
{{JsonWriter}} used by the {{JsonSerializer}} implements {{Closeable}} and as
such [closes the
Writer|https://github.com/jdereg/json-io/blob/cf849f15460decf10a8a320390de11965bb5996b/src/main/java/com/cedarsoftware/util/io/JsonWriter.java#L2413].
This causes a "Writer has already been closed" Exception when {{flush()}} is
called.
This was fixed in commit d27f4bb7 but then this commit: 11c7e389 did undo the
fix as now the JsonWriter is closed when existing the try-catch block.
I will undo it and prevent the premature closure as this is causing issues like
when the call to this servlet is made through a dispatcher.
was:
The GraphQLServlet shouldn't call {{response.getWriter().flush()}} as the
{{JsonWriter}} used by the {{JsonSerializer}} implements {{Closeable}} and as
such [closes the
Writer|https://github.com/jdereg/json-io/blob/cf849f15460decf10a8a320390de11965bb5996b/src/main/java/com/cedarsoftware/util/io/JsonWriter.java#L2413].
This causes a "Writer has already been closed" Exception when {{flush()}} is
called.
> Regress - "Writer has already been closed" exception in GraphQLServlet
> --
>
> Key: SLING-11458
> URL: https://issues.apache.org/jira/browse/SLING-11458
> Project: Sling
> Issue Type: Bug
> Components: GraphQL
>Affects Versions: GraphQL Core 0.0.4
>Reporter: Evgeny Tugarev
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: GraphQL Core 0.0.6
>
>
> The GraphQLServlet shouldn't call {{response.getWriter().flush()}} as the
> {{JsonWriter}} used by the {{JsonSerializer}} implements {{Closeable}} and as
> such [closes the
> Writer|https://github.com/jdereg/json-io/blob/cf849f15460decf10a8a320390de11965bb5996b/src/main/java/com/cedarsoftware/util/io/JsonWriter.java#L2413].
> This causes a "Writer has already been closed" Exception when {{flush()}} is
> called.
> This was fixed in commit d27f4bb7 but then this commit: 11c7e389 did undo the
> fix as now the JsonWriter is closed when existing the try-catch block.
> I will undo it and prevent the premature closure as this is causing issues
> like when the call to this servlet is made through a dispatcher.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (SLING-11458) Regress - "Writer has already been closed" exception in GraphQLServlet
[
https://issues.apache.org/jira/browse/SLING-11458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Schaefer reassigned SLING-11458:
Assignee: Andreas Schaefer (was: Bertrand Delacretaz)
> Regress - "Writer has already been closed" exception in GraphQLServlet
> --
>
> Key: SLING-11458
> URL: https://issues.apache.org/jira/browse/SLING-11458
> Project: Sling
> Issue Type: Bug
> Components: GraphQL
>Affects Versions: GraphQL Core 0.0.4
>Reporter: Evgeny Tugarev
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: GraphQL Core 0.0.6
>
>
> The GraphQLServlet shouldn't call {{response.getWriter().flush()}} as the
> {{JsonWriter}} used by the {{JsonSerializer}} implements {{Closeable}} and as
> such [closes the
> Writer|https://github.com/jdereg/json-io/blob/cf849f15460decf10a8a320390de11965bb5996b/src/main/java/com/cedarsoftware/util/io/JsonWriter.java#L2413].
> This causes a "Writer has already been closed" Exception when {{flush()}} is
> called.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-11458) Regress - "Writer has already been closed" exception in GraphQLServlet
Andreas Schaefer created SLING-11458:
Summary: Regress - "Writer has already been closed" exception in
GraphQLServlet
Key: SLING-11458
URL: https://issues.apache.org/jira/browse/SLING-11458
Project: Sling
Issue Type: Bug
Components: GraphQL
Affects Versions: GraphQL Core 0.0.4
Reporter: Evgeny Tugarev
Assignee: Bertrand Delacretaz
Fix For: GraphQL Core 0.0.6
The GraphQLServlet shouldn't call {{response.getWriter().flush()}} as the
{{JsonWriter}} used by the {{JsonSerializer}} implements {{Closeable}} and as
such [closes the
Writer|https://github.com/jdereg/json-io/blob/cf849f15460decf10a8a320390de11965bb5996b/src/main/java/com/cedarsoftware/util/io/JsonWriter.java#L2413].
This causes a "Writer has already been closed" Exception when {{flush()}} is
called.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-11427) Registering a Namespace does not allow Hashtag in the URI
[ https://issues.apache.org/jira/browse/SLING-11427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer resolved SLING-11427. -- Resolution: Fixed A fix was created in PR #24, approved and merged into master > Registering a Namespace does not allow Hashtag in the URI > - > > Key: SLING-11427 > URL: https://issues.apache.org/jira/browse/SLING-11427 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit Parser 1.6.4 >Reporter: Andreas Schaefer >Priority: Major > Fix For: Repoinit Parser 1.6.16 > > Time Spent: 2.5h > Remaining Estimate: 0h > > Registering a Namespace in the repoinit fails when the URI contains a hashtag: > Example: > register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] > This should work or support an escape of the hashtag (#): > register namespace (stDim) > [http://ns.adobe.com/xap/1.0/sType/Dimensions\\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11427) Registering a Namespace does not allow Hashtag in the URI
[ https://issues.apache.org/jira/browse/SLING-11427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17560684#comment-17560684 ] Andreas Schaefer commented on SLING-11427: -- I created a simple 'fix' for that on this PR: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24 > Registering a Namespace does not allow Hashtag in the URI > - > > Key: SLING-11427 > URL: https://issues.apache.org/jira/browse/SLING-11427 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit Parser 1.6.4 >Reporter: Andreas Schaefer >Priority: Major > Fix For: Repoinit Parser 1.6.16 > > > Registering a Namespace in the repoinit fails when the URI contains a hashtag: > Example: > register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] > This should work or support an escape of the hashtag (#): > register namespace (stDim) > [http://ns.adobe.com/xap/1.0/sType/Dimensions\\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11427) Registering a Namespace does not allow Hashtag in the URI
[ https://issues.apache.org/jira/browse/SLING-11427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17560672#comment-17560672 ] Andreas Schaefer commented on SLING-11427: -- Adding this line to the end of test-40.txt: register namespace (foo2) uri:some-uri/V/1.0/test# Is missing the output: RegisterNamespace (foo2) uri:some-uri/V/1.0/test# Adding this: register namespace (foo2) uri:some-uri/V/1.0/test\# is yielding a parser exception: Caused by: org.apache.sling.repoinit.parser.impl.TokenMgrError: Lexical error at line 4, column 50. Encountered: "\\" (92), after : "" at org.apache.sling.repoinit.parser.impl.RepoInitParserImplTokenManager.getNextToken(RepoInitParserImplTokenManager.java:1200) I am not a Javacc expert and so my attempts to rectify this issue failed. > Registering a Namespace does not allow Hashtag in the URI > - > > Key: SLING-11427 > URL: https://issues.apache.org/jira/browse/SLING-11427 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit Parser 1.6.4 >Reporter: Andreas Schaefer >Priority: Major > Fix For: Repoinit Parser 1.6.16 > > > Registering a Namespace in the repoinit fails when the URI contains a hashtag: > Example: > register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] > This should work or support an escape of the hashtag (#): > register namespace (stDim) > [http://ns.adobe.com/xap/1.0/sType/Dimensions\\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11427) Registering a Namespace does not allow Hashtag in the URI
[ https://issues.apache.org/jira/browse/SLING-11427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-11427: - Description: Registering a Namespace in the repoinit fails when the URI contains a hashtag: Example: register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] This should work or support an escape of the hashtag (#): register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions\\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] was: Registering a Namespace in the repoinit fails when the URI contains a hashtag: Example: register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] This should work or support an escape of the hashtag (\#): register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] > Registering a Namespace does not allow Hashtag in the URI > - > > Key: SLING-11427 > URL: https://issues.apache.org/jira/browse/SLING-11427 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit Parser 1.6.4 >Reporter: Andreas Schaefer >Priority: Major > Fix For: Repoinit Parser 1.6.16 > > > Registering a Namespace in the repoinit fails when the URI contains a hashtag: > Example: > register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] > This should work or support an escape of the hashtag (#): > register namespace (stDim) > [http://ns.adobe.com/xap/1.0/sType/Dimensions\\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11427) Registering a Namespace does not allow Hashtag in the URI
[ https://issues.apache.org/jira/browse/SLING-11427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-11427: - Description: Registering a Namespace in the repoinit fails when the URI contains a hashtag: Example: register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] This should work or support an escape of the hashtag (\\#): register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions\\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] was: Registering a Namespace in the repoinit fails when the URI contains a hashtag: Example: register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] This should work or support an escape of the hashtag (#): register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions\\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] > Registering a Namespace does not allow Hashtag in the URI > - > > Key: SLING-11427 > URL: https://issues.apache.org/jira/browse/SLING-11427 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit Parser 1.6.4 >Reporter: Andreas Schaefer >Priority: Major > Fix For: Repoinit Parser 1.6.16 > > > Registering a Namespace in the repoinit fails when the URI contains a hashtag: > Example: > register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] > This should work or support an escape of the hashtag (\\#): > register namespace (stDim) > [http://ns.adobe.com/xap/1.0/sType/Dimensions\\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11427) Registering a Namespace does not allow Hashtag in the URI
[ https://issues.apache.org/jira/browse/SLING-11427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-11427: - Description: Registering a Namespace in the repoinit fails when the URI contains a hashtag: Example: register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] This should work or support an escape of the hashtag (#): register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions\\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] was: Registering a Namespace in the repoinit fails when the URI contains a hashtag: Example: register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] This should work or support an escape of the hashtag (\\#): register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions\\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] > Registering a Namespace does not allow Hashtag in the URI > - > > Key: SLING-11427 > URL: https://issues.apache.org/jira/browse/SLING-11427 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit Parser 1.6.4 >Reporter: Andreas Schaefer >Priority: Major > Fix For: Repoinit Parser 1.6.16 > > > Registering a Namespace in the repoinit fails when the URI contains a hashtag: > Example: > register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] > This should work or support an escape of the hashtag (#): > register namespace (stDim) > [http://ns.adobe.com/xap/1.0/sType/Dimensions\\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11427) Registering a Namespace does not allow Hashtag in the URI
[ https://issues.apache.org/jira/browse/SLING-11427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-11427: - Description: Registering a Namespace in the repoinit fails when the URI contains a hashtag: Example: register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] This should work or support an escape of the hashtag (\#): register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] was: Registering a Namespace in the repoinit fails when the URI contains a hashtag: Example: register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] This should work or support an escape of the hashtag: register namespace (stDim) http://ns.adobe.com/xap/1.0/sType/Dimensions\# > Registering a Namespace does not allow Hashtag in the URI > - > > Key: SLING-11427 > URL: https://issues.apache.org/jira/browse/SLING-11427 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit Parser 1.6.4 >Reporter: Andreas Schaefer >Priority: Major > Fix For: Repoinit Parser 1.6.16 > > > Registering a Namespace in the repoinit fails when the URI contains a hashtag: > Example: > register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] > This should work or support an escape of the hashtag (\#): > register namespace (stDim) > [http://ns.adobe.com/xap/1.0/sType/Dimensions\#|http://ns.adobe.com/xap/1.0/sType/Dimensions#] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11427) Registering a Namespace does not allow Hashtag in the URI
Andreas Schaefer created SLING-11427: Summary: Registering a Namespace does not allow Hashtag in the URI Key: SLING-11427 URL: https://issues.apache.org/jira/browse/SLING-11427 Project: Sling Issue Type: Bug Components: Repoinit Affects Versions: Repoinit Parser 1.6.4 Reporter: Andreas Schaefer Fix For: Repoinit Parser 1.6.16 Registering a Namespace in the repoinit fails when the URI contains a hashtag: Example: register namespace (stDim) [http://ns.adobe.com/xap/1.0/sType/Dimensions#] This should work or support an escape of the hashtag: register namespace (stDim) http://ns.adobe.com/xap/1.0/sType/Dimensions\# -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-10157) Converter fails with duplicate configuration PIDs
[ https://issues.apache.org/jira/browse/SLING-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293813#comment-17293813 ] Andreas Schaefer commented on SLING-10157: -- [~cziegeler] Yes, that fixed my problems. > Converter fails with duplicate configuration PIDs > - > > Key: SLING-10157 > URL: https://issues.apache.org/jira/browse/SLING-10157 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.0.24 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.0.26 > > > If there is a configuration for the same PID multiple times, either in the > same or different content packages, the converter fails with an error. > We should handle this similar to how the OSGi installer does it, and pick the > right configuration based on the repository path. > A warning should be logged for these cases as well. > We could add a strict option, throwing an exception in this case like today -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (SLING-10157) Converter fails with duplicate configuration PIDs
[
https://issues.apache.org/jira/browse/SLING-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293125#comment-17293125
]
Andreas Schaefer edited comment on SLING-10157 at 3/1/21, 7:31 PM:
---
It works but I ran into a few issues:
- in AbstractJcrNodeParser this line failed:
this.primaryTypes = ImmutableSet.of(primaryTypes);
and I had to replace it with:
this.primaryTypes = new HashSet(java.util.Arrays.asList(primaryTypes));
In DefaultFeaturesManager when I only have two configurations it did not work
well because the first configuration is not added to the map. So I had to add
this line (233):
if (configuration == null) {
configuration = new Configuration(pid);
feature.getConfigurations().add(configuration);
// Add this so that the first configuration is considered in an Ordered
configuration
this.pidToPathMapping.put(pid, path);
was (Author: schaefa):
It works but I ran into a few issues:
- in AbstractJcrNodeParser this line failed:
this.primaryTypes = ImmutableSet.of(primaryTypes);
and I had to replace it with:
this.primaryTypes = new HashSet(java.util.Arrays.asList(primaryTypes));
In DefaultFeaturesManager when I only have two configurations it did not work
well because the first configuration is not added to the map. So I had to add
this line:
if (configuration == null) {
configuration = new Configuration(pid);
feature.getConfigurations().add(configuration);
// Add this so that the first configuration is considered in an Ordered
configuration
this.pidToPathMapping.put(pid, path);
> Converter fails with duplicate configuration PIDs
> -
>
> Key: SLING-10157
> URL: https://issues.apache.org/jira/browse/SLING-10157
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.0.24
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.0.26
>
>
> If there is a configuration for the same PID multiple times, either in the
> same or different content packages, the converter fails with an error.
> We should handle this similar to how the OSGi installer does it, and pick the
> right configuration based on the repository path.
> A warning should be logged for these cases as well.
> We could add a strict option, throwing an exception in this case like today
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10157) Converter fails with duplicate configuration PIDs
[
https://issues.apache.org/jira/browse/SLING-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293125#comment-17293125
]
Andreas Schaefer commented on SLING-10157:
--
It works but I ran into a few issues:
- in AbstractJcrNodeParser this line failed:
this.primaryTypes = ImmutableSet.of(primaryTypes);
and I had to replace it with:
this.primaryTypes = new HashSet(java.util.Arrays.asList(primaryTypes));
In DefaultFeaturesManager when I only have two configurations it did not work
well because the first configuration is not added to the map. So I had to add
this line:
if (configuration == null) {
configuration = new Configuration(pid);
feature.getConfigurations().add(configuration);
// Add this so that the first configuration is considered in an Ordered
configuration
this.pidToPathMapping.put(pid, path);
> Converter fails with duplicate configuration PIDs
> -
>
> Key: SLING-10157
> URL: https://issues.apache.org/jira/browse/SLING-10157
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.0.24
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.0.26
>
>
> If there is a configuration for the same PID multiple times, either in the
> same or different content packages, the converter fails with an error.
> We should handle this similar to how the OSGi installer does it, and pick the
> right configuration based on the repository path.
> A warning should be logged for these cases as well.
> We could add a strict option, throwing an exception in this case like today
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10157) Converter fails with duplicate configuration PIDs
[ https://issues.apache.org/jira/browse/SLING-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290504#comment-17290504 ] Andreas Schaefer commented on SLING-10157: -- The issue I encounter is a little bit more delicate as it is forced by the way Feature Models are handled. Traditionally I would install (external) package into Sling that may contain OSGi configurations (assume here it does). Then I would install the client's custom project package which its custom configuration which in turn overrides the default configuration of the external package. Because this happens at different times (two separate installation tasks) the order is defined by that. In the Feature Model world the customer might combine both packages into one package (required by Skyline) together with the configurations and here we need to provide a strategy to resolve it. For now we can rely on an alphabetical order meaning that the overriding configuration but that might getting ugly when the configuration is in the /libs folder. > Converter fails with duplicate configuration PIDs > - > > Key: SLING-10157 > URL: https://issues.apache.org/jira/browse/SLING-10157 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.0.24 >Reporter: Carsten Ziegeler >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.0.26 > > > If there is a configuration for the same PID multiple times, either in the > same or different content packages, the converter fails with an error. > We should handle this similar to how the OSGi installer does it, and pick the > right configuration based on the repository path. > A warning should be logged for these cases as well. > We could add a strict option, throwing an exception in this case like today -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10157) Converter fails with duplicate configuration PIDs
[ https://issues.apache.org/jira/browse/SLING-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17289419#comment-17289419 ] Andreas Schaefer commented on SLING-10157: -- The CP Converter has a mergeConfiguration flag that enables to deal with multiple configurations. That said I takes the configuration is order it finds it in the ZIP file and that is, I assume, alphabetically ordered. I would prefer to have a way of setting a precedence based on the content-package but as far as I can tell this is not available to the FeaturesManager so I guess we should have something along the lines of the Sling Feature Model Plugin (USE_FIRST / USE_LATEST). > Converter fails with duplicate configuration PIDs > - > > Key: SLING-10157 > URL: https://issues.apache.org/jira/browse/SLING-10157 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.0.24 >Reporter: Carsten Ziegeler >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.0.26 > > > If there is a configuration for the same PID multiple times, either in the > same or different content packages, the converter fails with an error. > We should handle this similar to how the OSGi installer does it, and pick the > right configuration based on the repository path. > A warning should be logged for these cases as well. > We could add a strict option, throwing an exception in this case like today -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10126) Repository Initializer should support Empty or Single Value Lists
[
https://issues.apache.org/jira/browse/SLING-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17279838#comment-17279838
]
Andreas Schaefer commented on SLING-10126:
--
Created a PR for a potential fix:
[https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/6.]
This will allow to configure an single multi-value with:
set singleMultiValue\{String[]} to "single"
and an empty multi-value with:
set emptyMultiValue\{String[]} to
> Repository Initializer should support Empty or Single Value Lists
> -
>
> Key: SLING-10126
> URL: https://issues.apache.org/jira/browse/SLING-10126
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Affects Versions: Repoinit Parser 1.6.2
>Reporter: Andreas Schaefer
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: Repoinit Parser 1.6.4
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In the current implementation it is not possible to create an empty or single
> multi-value entry for JCR Node properties.
> I would suggest to allow a '[]' postfix to the type like \{String[]} to
> indicate a multi-value and then allow for an empty or single value.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (SLING-10126) Repository Initializer should support Empty or Single Value Lists
[
https://issues.apache.org/jira/browse/SLING-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Schaefer reassigned SLING-10126:
Assignee: Andreas Schaefer
> Repository Initializer should support Empty or Single Value Lists
> -
>
> Key: SLING-10126
> URL: https://issues.apache.org/jira/browse/SLING-10126
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Affects Versions: Repoinit Parser 1.6.2
>Reporter: Andreas Schaefer
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: Repoinit Parser 1.6.4
>
>
> In the current implementation it is not possible to create an empty or single
> multi-value entry for JCR Node properties.
> I would suggest to allow a '[]' postfix to the type like \{String[]} to
> indicate a multi-value and then allow for an empty or single value.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-10126) Repository Initializer should support Empty or Single Value Lists
Andreas Schaefer created SLING-10126:
Summary: Repository Initializer should support Empty or Single
Value Lists
Key: SLING-10126
URL: https://issues.apache.org/jira/browse/SLING-10126
Project: Sling
Issue Type: Improvement
Components: Repoinit
Affects Versions: Repoinit Parser 1.6.2
Reporter: Andreas Schaefer
Fix For: Repoinit Parser 1.6.4
In the current implementation it is not possible to create an empty or single
multi-value entry for JCR Node properties.
I would suggest to allow a '[]' postfix to the type like \{String[]} to
indicate a multi-value and then allow for an empty or single value.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10122) A Equal Sign (=) in a set properties instruction makes the Converter fail
[ https://issues.apache.org/jira/browse/SLING-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278939#comment-17278939 ] Andreas Schaefer commented on SLING-10122: -- As stated this is not an issue so I closed it. > A Equal Sign (=) in a set properties instruction makes the Converter fail > - > > Key: SLING-10122 > URL: https://issues.apache.org/jira/browse/SLING-10122 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: Content-Package to Feature Model Converter 1.0.22 >Reporter: Andreas Schaefer >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.0.28 > > > An entry in a Repository Initializer like this: > "create path /test > set properties on /test > set testprop to \"one=two\" > end"\ > will make the ConfigurationEntryHandler fail with: > Tests run: 48, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.036 s <<< > FAILURE! - in > org.apache.sling.feature.cpconverter.handlers.ConfigurationEntryHandlerTest > org.apache.sling.feature.cpconverter.handlers.ConfigurationEntryHandlerTest.parseConfiguration[13] > Time elapsed: 0.005 s <<< ERROR! > java.io.IOException: Unexpected token 34; expected: 61 (line=24, pos=9) > at > org.apache.felix.cm.file.ConfigurationHandler.readFailure(ConfigurationHandler.java:700) > at > org.apache.felix.cm.file.ConfigurationHandler.readInternal(ConfigurationHandler.java:304) > at > org.apache.felix.cm.file.ConfigurationHandler.read(ConfigurationHandler.java:267) > at > org.apache.sling.feature.cpconverter.handlers.ConfigurationEntryHandler.parseConfiguration(ConfigurationEntryHandler.java:33) > at > org.apache.sling.feature.cpconverter.handlers.AbstractConfigurationEntryHandler.handle(AbstractConfigurationEntryHandler.java:66) > at > org.apache.sling.feature.cpconverter.handlers.ConfigurationEntryHandlerTest.parseConfiguration(ConfigurationEntryHandlerTest.java:132) > > I can fix that by escaping with a backslash but that is not a valid > Repository Initializer content. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10122) A Equal Sign (=) in a set properties instruction makes the Converter fail
[ https://issues.apache.org/jira/browse/SLING-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer resolved SLING-10122. -- Resolution: Invalid > A Equal Sign (=) in a set properties instruction makes the Converter fail > - > > Key: SLING-10122 > URL: https://issues.apache.org/jira/browse/SLING-10122 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: Content-Package to Feature Model Converter 1.0.22 >Reporter: Andreas Schaefer >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.0.28 > > > An entry in a Repository Initializer like this: > "create path /test > set properties on /test > set testprop to \"one=two\" > end"\ > will make the ConfigurationEntryHandler fail with: > Tests run: 48, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.036 s <<< > FAILURE! - in > org.apache.sling.feature.cpconverter.handlers.ConfigurationEntryHandlerTest > org.apache.sling.feature.cpconverter.handlers.ConfigurationEntryHandlerTest.parseConfiguration[13] > Time elapsed: 0.005 s <<< ERROR! > java.io.IOException: Unexpected token 34; expected: 61 (line=24, pos=9) > at > org.apache.felix.cm.file.ConfigurationHandler.readFailure(ConfigurationHandler.java:700) > at > org.apache.felix.cm.file.ConfigurationHandler.readInternal(ConfigurationHandler.java:304) > at > org.apache.felix.cm.file.ConfigurationHandler.read(ConfigurationHandler.java:267) > at > org.apache.sling.feature.cpconverter.handlers.ConfigurationEntryHandler.parseConfiguration(ConfigurationEntryHandler.java:33) > at > org.apache.sling.feature.cpconverter.handlers.AbstractConfigurationEntryHandler.handle(AbstractConfigurationEntryHandler.java:66) > at > org.apache.sling.feature.cpconverter.handlers.ConfigurationEntryHandlerTest.parseConfiguration(ConfigurationEntryHandlerTest.java:132) > > I can fix that by escaping with a backslash but that is not a valid > Repository Initializer content. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10122) A Equal Sign (=) in a set properties instruction makes the Converter fail
[ https://issues.apache.org/jira/browse/SLING-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278339#comment-17278339 ] Andreas Schaefer commented on SLING-10122: -- Enhanced the Repository Initializer test to showcase this issue. If the '\=\ is replaced by '=' it will fail the test: set properties on /test set testprop to \"one\=two\" end"\ > A Equal Sign (=) in a set properties instruction makes the Converter fail > - > > Key: SLING-10122 > URL: https://issues.apache.org/jira/browse/SLING-10122 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: Content-Package to Feature Model Converter 1.0.22 >Reporter: Andreas Schaefer >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.0.28 > > > An entry in a Repository Initializer like this: > "create path /test > set properties on /test > set testprop to \"one=two\" > end"\ > will make the ConfigurationEntryHandler fail with: > Tests run: 48, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.036 s <<< > FAILURE! - in > org.apache.sling.feature.cpconverter.handlers.ConfigurationEntryHandlerTest > org.apache.sling.feature.cpconverter.handlers.ConfigurationEntryHandlerTest.parseConfiguration[13] > Time elapsed: 0.005 s <<< ERROR! > java.io.IOException: Unexpected token 34; expected: 61 (line=24, pos=9) > at > org.apache.felix.cm.file.ConfigurationHandler.readFailure(ConfigurationHandler.java:700) > at > org.apache.felix.cm.file.ConfigurationHandler.readInternal(ConfigurationHandler.java:304) > at > org.apache.felix.cm.file.ConfigurationHandler.read(ConfigurationHandler.java:267) > at > org.apache.sling.feature.cpconverter.handlers.ConfigurationEntryHandler.parseConfiguration(ConfigurationEntryHandler.java:33) > at > org.apache.sling.feature.cpconverter.handlers.AbstractConfigurationEntryHandler.handle(AbstractConfigurationEntryHandler.java:66) > at > org.apache.sling.feature.cpconverter.handlers.ConfigurationEntryHandlerTest.parseConfiguration(ConfigurationEntryHandlerTest.java:132) > > I can fix that by escaping with a backslash but that is not a valid > Repository Initializer content. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10122) A Equal Sign (=) in a set properties instruction makes the Converter fail
Andreas Schaefer created SLING-10122: Summary: A Equal Sign (=) in a set properties instruction makes the Converter fail Key: SLING-10122 URL: https://issues.apache.org/jira/browse/SLING-10122 Project: Sling Issue Type: Bug Components: Feature Model Affects Versions: Content-Package to Feature Model Converter 1.0.22 Reporter: Andreas Schaefer Fix For: Content-Package to Feature Model Converter 1.0.28 An entry in a Repository Initializer like this: "create path /test set properties on /test set testprop to \"one=two\" end"\ will make the ConfigurationEntryHandler fail with: Tests run: 48, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.036 s <<< FAILURE! - in org.apache.sling.feature.cpconverter.handlers.ConfigurationEntryHandlerTest org.apache.sling.feature.cpconverter.handlers.ConfigurationEntryHandlerTest.parseConfiguration[13] Time elapsed: 0.005 s <<< ERROR! java.io.IOException: Unexpected token 34; expected: 61 (line=24, pos=9) at org.apache.felix.cm.file.ConfigurationHandler.readFailure(ConfigurationHandler.java:700) at org.apache.felix.cm.file.ConfigurationHandler.readInternal(ConfigurationHandler.java:304) at org.apache.felix.cm.file.ConfigurationHandler.read(ConfigurationHandler.java:267) at org.apache.sling.feature.cpconverter.handlers.ConfigurationEntryHandler.parseConfiguration(ConfigurationEntryHandler.java:33) at org.apache.sling.feature.cpconverter.handlers.AbstractConfigurationEntryHandler.handle(AbstractConfigurationEntryHandler.java:66) at org.apache.sling.feature.cpconverter.handlers.ConfigurationEntryHandlerTest.parseConfiguration(ConfigurationEntryHandlerTest.java:132) I can fix that by escaping with a backslash but that is not a valid Repository Initializer content. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10069) The generated features target dir is created in the wrong place
[
https://issues.apache.org/jira/browse/SLING-10069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267971#comment-17267971
]
Andreas Schaefer commented on SLING-10069:
--
I ran this against the project that caused the issue I tried to resolve in
SLING-10035 and it works fine.
> The generated features target dir is created in the wrong place
> ---
>
> Key: SLING-10069
> URL: https://issues.apache.org/jira/browse/SLING-10069
> Project: Sling
> Issue Type: Bug
>Affects Versions: slingfeature-maven-plugin 1.4.22
>Reporter: Eric Norman
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.4.24
>
>
> After switching to the 1.4.22 release version of the plugin, I noticed that
> the change for SLING-10035 appears to be creating a set of empty folders in
> the wrong place in my linux environment.
> Using a debugger, I see that the targetDir File object is constructed at
> AbstractFeatureMojo line 244 with the "child" second argument already
> resolved to be an absolute path. This appears to append the absolute child
> path to the parent path rather than checking if "child" is relative or
> absolute to resolve it.
> [https://github.com/apache/sling-slingfeature-maven-plugin/blob/master/src/main/java/org/apache/sling/feature/maven/mojos/AbstractFeatureMojo.java#L244]
>
> Expect the targetDir resolution to properly resolve the path with something
> like this:
> {code:java}
> final File targetDir =
> this.project.getBasedir().toPath().resolve(this.project.getBuild().getDirectory()).toFile();
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10035) Sling Feature fails when Generated Features Directory is missing
[ https://issues.apache.org/jira/browse/SLING-10035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257077#comment-17257077 ] Andreas Schaefer commented on SLING-10035: -- Created a PR for this: https://github.com/apache/sling-slingfeature-maven-plugin/pull/63 > Sling Feature fails when Generated Features Directory is missing > > > Key: SLING-10035 > URL: https://issues.apache.org/jira/browse/SLING-10035 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: slingfeature-maven-plugin 1.4.20 >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > Fix For: slingfeature-maven-plugin 1.4.22 > > > When I want to aggregate a Feature Model in another module like 'all' and > there is not attachment or other FM generation task beforehand the Sling > Feature Maven Plugin fails in handleGeneratedFeatures() method. This can be > fixed by copying the target folder from the resources but that is a lot of > unnecessary work. > > I added code to that method that tries to create the folder if it does not > exist. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10035) Sling Feature fails when Generated Features Directory is missing
Andreas Schaefer created SLING-10035: Summary: Sling Feature fails when Generated Features Directory is missing Key: SLING-10035 URL: https://issues.apache.org/jira/browse/SLING-10035 Project: Sling Issue Type: Bug Components: Feature Model Affects Versions: slingfeature-maven-plugin 1.4.20 Reporter: Andreas Schaefer Assignee: Andreas Schaefer Fix For: slingfeature-maven-plugin 1.4.22 When I want to aggregate a Feature Model in another module like 'all' and there is not attachment or other FM generation task beforehand the Sling Feature Maven Plugin fails in handleGeneratedFeatures() method. This can be fixed by copying the target folder from the resources but that is a lot of unnecessary work. I added code to that method that tries to create the folder if it does not exist. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9800) Extract a service to be able to execute GraphQL queries directly
[
https://issues.apache.org/jira/browse/SLING-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221811#comment-17221811
]
Andreas Schaefer commented on SLING-9800:
-
[~bdelacretaz] I am working on the AEM GraphQL Persisted Queries and a client
is calling the PQ servlet instead of an GraphiQL endpoint. So the resource of
the request is the Servlet and using that resource is not working out
(DefaultSchemaProvider.getSchema() returns an empty string). When using a Mock
Resource with these values:
new MockResource(
"/apps/graphql-enablement/content/endpoint", /* path */
"graphql-enablement/components/endpoint", /* resourceType */
null, /* resourceSuperType */
null, /* metadata */
resourceResolver,
new ValueMapDecorator(new HashMap() {{
put("", "");
}}), /* properties */
null /* parent */
);
- Andy
> Extract a service to be able to execute GraphQL queries directly
>
>
> Key: SLING-9800
> URL: https://issues.apache.org/jira/browse/SLING-9800
> Project: Sling
> Issue Type: Improvement
> Components: GraphQL
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: GraphQL Core 0.0.8
>
>
> In the current implementation of the GraphQL Core bundle queries can only be
> executed via a GraphQL Servlet that needs to be configured or via server-side
> scripts. It would be good if the queries could also be executed directly,
> without the need for a request.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-9761) Properties (-D) is not supported in Kickstart Project
[ https://issues.apache.org/jira/browse/SLING-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-9761: Fix Version/s: (was: Feature Model Sling Kickstart Project 0.0.10) Feature Model Sling Kickstart Project 0.0.12 > Properties (-D) is not supported in Kickstart Project > - > > Key: SLING-9761 > URL: https://issues.apache.org/jira/browse/SLING-9761 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: Feature Model Sling Kickstart Project 0.0.8 >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > Fix For: Feature Model Sling Kickstart Project 0.0.12 > > > The properties provided by '-D' is not supported and for example sling run > modes cannot be set. > This is a simple fix by adding them as -D property to the Feature Launcher. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9581) Reduce implementation duplication between kickstart and feature-launcher maven plugin
[ https://issues.apache.org/jira/browse/SLING-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-9581: Fix Version/s: (was: Feature Model Sling Kickstart Project 0.0.12) Feature Model Sling Kickstart Project 0.0.14 > Reduce implementation duplication between kickstart and feature-launcher > maven plugin > - > > Key: SLING-9581 > URL: https://issues.apache.org/jira/browse/SLING-9581 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Feature Launcher Maven Plugin 0.1.2, Feature Model Sling > Maven Kickstart Plugin 0.0.10, Feature Model Sling Kickstart Project 0.0.14 > > > There is an implementation overlap between the kickstart tooling and the > feature-launcher maven plugin. We should remove it to ensure our tooling > behaves consistently. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9581) Reduce implementation duplication between kickstart and feature-launcher maven plugin
[ https://issues.apache.org/jira/browse/SLING-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-9581: Fix Version/s: (was: Feature Model Sling Kickstart Project 0.0.10) Feature Model Sling Kickstart Project 0.0.12 > Reduce implementation duplication between kickstart and feature-launcher > maven plugin > - > > Key: SLING-9581 > URL: https://issues.apache.org/jira/browse/SLING-9581 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Feature Launcher Maven Plugin 0.1.2, Feature Model Sling > Maven Kickstart Plugin 0.0.10, Feature Model Sling Kickstart Project 0.0.12 > > > There is an implementation overlap between the kickstart tooling and the > feature-launcher maven plugin. We should remove it to ensure our tooling > behaves consistently. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9581) Reduce implementation duplication between kickstart and feature-launcher maven plugin
[ https://issues.apache.org/jira/browse/SLING-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217127#comment-17217127 ] Andreas Schaefer commented on SLING-9581: - I started to look into the two Maven Plugin. The Kickstart Maven Plugin is tied to the Kickstart module (Sling) and does start that Sling in the process together with the Feature Model from the Maven project. It can keep the launched system alive after the Maven build ends. The Feature Launcher Maven Plugin just start the given Feature Model from the Maven project but it allows to start multiple instances (not sure what this is intended to do). To unify the two I could add a property that allows to run the Kickstart system would just run with the Feature Model of the Maven project. > Reduce implementation duplication between kickstart and feature-launcher > maven plugin > - > > Key: SLING-9581 > URL: https://issues.apache.org/jira/browse/SLING-9581 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Feature Launcher Maven Plugin 0.1.2, Feature Model Sling > Kickstart Project 0.0.10, Feature Model Sling Maven Kickstart Plugin 0.0.10 > > > There is an implementation overlap between the kickstart tooling and the > feature-launcher maven plugin. We should remove it to ensure our tooling > behaves consistently. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (SLING-9800) Extract a service to be able to execute GraphQL queries directly
[ https://issues.apache.org/jira/browse/SLING-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer reopened SLING-9800: - The QueryExecutor.execute() and .validate() is requiring a Resource (queryResource) which must be a resource that points to the Endpoint DefaultQueryExecutor.execute() -> prepareSchemaDefinition() -> DefaultSchemaProvider. getSchema() I would suggest to the user provides the path to the GraphQL Endpoint as a string and the DefaultSchemaProvider is creating an internal resource. So the method would look like this: Map execute(String query, Map variables, String queryEndpoint, String[] selectors); > Extract a service to be able to execute GraphQL queries directly > > > Key: SLING-9800 > URL: https://issues.apache.org/jira/browse/SLING-9800 > Project: Sling > Issue Type: Improvement > Components: GraphQL >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: GraphQL Core 0.0.8 > > > In the current implementation of the GraphQL Core bundle queries can only be > executed via a GraphQL Servlet that needs to be configured or via server-side > scripts. It would be good if the queries could also be executed directly, > without the need for a request. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9800) Extract a service to be able to execute GraphQL queries directly
[ https://issues.apache.org/jira/browse/SLING-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17211452#comment-17211452 ] Andreas Schaefer commented on SLING-9800: - The isValid() is ok but as a caller I would need to have the ability to figure out what is wrong. Either the checker returns validation report, provide such an object as argument or have a method that provides feedback. > Extract a service to be able to execute GraphQL queries directly > > > Key: SLING-9800 > URL: https://issues.apache.org/jira/browse/SLING-9800 > Project: Sling > Issue Type: Improvement > Components: GraphQL >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: GraphQL Core 0.0.8 > > > In the current implementation of the GraphQL Core bundle queries can only be > executed via a GraphQL Servlet that needs to be configured or via server-side > scripts. It would be good if the queries could also be executed directly, > without the need for a request. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9761) Properties (-D) is not supported in Kickstart Project
[ https://issues.apache.org/jira/browse/SLING-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer resolved SLING-9761. - Resolution: Fixed Simple fix added to the current snapshot > Properties (-D) is not supported in Kickstart Project > - > > Key: SLING-9761 > URL: https://issues.apache.org/jira/browse/SLING-9761 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: Feature Model Sling Kickstart Project 0.0.8 >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > Fix For: Feature Model Sling Kickstart Project 0.0.10 > > > The properties provided by '-D' is not supported and for example sling run > modes cannot be set. > This is a simple fix by adding them as -D property to the Feature Launcher. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9761) Properties (-D) is not supported in Kickstart Project
Andreas Schaefer created SLING-9761: --- Summary: Properties (-D) is not supported in Kickstart Project Key: SLING-9761 URL: https://issues.apache.org/jira/browse/SLING-9761 Project: Sling Issue Type: Bug Components: Feature Model Affects Versions: Feature Model Sling Kickstart Project 0.0.8 Reporter: Andreas Schaefer Assignee: Andreas Schaefer Fix For: Feature Model Sling Kickstart Project 0.0.10 The properties provided by '-D' is not supported and for example sling run modes cannot be set. This is a simple fix by adding them as -D property to the Feature Launcher. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9581) Reduce implementation duplication between kickstart and feature-launcher maven plugin
[ https://issues.apache.org/jira/browse/SLING-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-9581: Fix Version/s: (was: Feature Model Sling Kickstart Project 0.0.8) (was: Feature Model Sling Maven Kickstart Plugin 0.0.8) Feature Model Sling Maven Kickstart Plugin 0.0.10 Feature Model Sling Kickstart Project 0.0.10 > Reduce implementation duplication between kickstart and feature-launcher > maven plugin > - > > Key: SLING-9581 > URL: https://issues.apache.org/jira/browse/SLING-9581 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Feature Launcher Maven Plugin 0.1.2, Feature Model Sling > Kickstart Project 0.0.10, Feature Model Sling Maven Kickstart Plugin 0.0.10 > > > There is an implementation overlap between the kickstart tooling and the > feature-launcher maven plugin. We should remove it to ensure our tooling > behaves consistently. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9635) Create a kickstart jar during the Sling Starter build
[ https://issues.apache.org/jira/browse/SLING-9635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173210#comment-17173210 ] Andreas Schaefer commented on SLING-9635: - The Kickstart Maven Plugin is OOTB just starting / stopping Sling. That said it is able to start other feature models / archives but I am not 100% sure if that is exposed as of now. I will have a look into this this weekend. The Kickstart Project for sure can launch any FM / FAR with or without Sling. > Create a kickstart jar during the Sling Starter build > - > > Key: SLING-9635 > URL: https://issues.apache.org/jira/browse/SLING-9635 > Project: Sling > Issue Type: Sub-task > Components: Starter >Reporter: Robert Munteanu >Priority: Major > Fix For: Starter 12 > > > Separate from SLING-9595, see > https://issues.apache.org/jira/browse/SLING-9595?focusedCommentId=17161943=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17161943 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9507) Add an option to Kickstart to prevent the use of the bundled Sling FM
[ https://issues.apache.org/jira/browse/SLING-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer resolved SLING-9507. - Resolution: Fixed Added a flag '-S' that will not use provided Sling Feature Archive or Model file. If no feature file is provided either as main feature file or as additional feature file then kickstart will abort. > Add an option to Kickstart to prevent the use of the bundled Sling FM > - > > Key: SLING-9507 > URL: https://issues.apache.org/jira/browse/SLING-9507 > Project: Sling > Issue Type: New Feature > Components: Feature Model >Affects Versions: Feature Model Sling Kickstart Project 0.0.2 >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > Fix For: Feature Model Sling Kickstart Project 0.0.6 > > > To make it easier and more expressive the Kickstart should provide a flag > (-ns) to disregard the bundled Sling FM so that an application can be > launched that is not tied to Sling and w/o having to misuse the -s option. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9543) Add Support for Feature Archives and Provide the ability to use a custom Kickstart
[ https://issues.apache.org/jira/browse/SLING-9543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-9543: Fix Version/s: (was: Feature Model Sling Kickstart Plugin 0.0.6) Feature Model Sling Maven Kickstart Plugin 0.0.6 > Add Support for Feature Archives and Provide the ability to use a custom > Kickstart > -- > > Key: SLING-9543 > URL: https://issues.apache.org/jira/browse/SLING-9543 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: Feature Model Sling Maven Kickstart Plugin 0.0.2 >Reporter: Andreas Schaefer >Priority: Major > Fix For: Feature Model Sling Maven Kickstart Plugin 0.0.6 > > > Add the support for Feature Archives (done through the Kickstart Project) and > the ability to use a custom Kickstart Project as a JAR file or Maven > Dependency -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9452) Log Configuration does not work on Kickstart
[ https://issues.apache.org/jira/browse/SLING-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-9452: Fix Version/s: (was: Feature Model Sling Kickstart Project 0.0.4) > Log Configuration does not work on Kickstart > > > Key: SLING-9452 > URL: https://issues.apache.org/jira/browse/SLING-9452 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: Feature Model Sling Kickstart Project 0.0.2 >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > Fix For: Feature Model Sling Kickstart Project 0.0.6 > > > Setting Sling Log Settings in Kickstart does not work as the Log Manager > configuration is provided by the Feature Model and is not overwritten by the > settings. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9543) Add Support for Feature Archives and Provide the ability to use a custom Kickstart
[ https://issues.apache.org/jira/browse/SLING-9543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-9543: Fix Version/s: (was: Feature Model Sling Kickstart Project 0.0.6) Feature Model Sling Kickstart Plugin 0.0.6 > Add Support for Feature Archives and Provide the ability to use a custom > Kickstart > -- > > Key: SLING-9543 > URL: https://issues.apache.org/jira/browse/SLING-9543 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: Feature Model Sling Maven Kickstart Plugin 0.0.2 >Reporter: Andreas Schaefer >Priority: Major > Fix For: Feature Model Sling Kickstart Plugin 0.0.6 > > > Add the support for Feature Archives (done through the Kickstart Project) and > the ability to use a custom Kickstart Project as a JAR file or Maven > Dependency -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9452) Log Configuration does not work on Kickstart
[ https://issues.apache.org/jira/browse/SLING-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-9452: Fix Version/s: Feature Model Sling Kickstart Project 0.0.6 > Log Configuration does not work on Kickstart > > > Key: SLING-9452 > URL: https://issues.apache.org/jira/browse/SLING-9452 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: Feature Model Sling Kickstart Project 0.0.2 >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > Fix For: Feature Model Sling Kickstart Project 0.0.4, Feature > Model Sling Kickstart Project 0.0.6 > > > Setting Sling Log Settings in Kickstart does not work as the Log Manager > configuration is provided by the Feature Model and is not overwritten by the > settings. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9543) Add Support for Feature Archives and Provide the ability to use a custom Kickstart
[ https://issues.apache.org/jira/browse/SLING-9543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-9543: Fix Version/s: (was: Feature Model Sling Maven Kickstart Plugin 0.0.4) > Add Support for Feature Archives and Provide the ability to use a custom > Kickstart > -- > > Key: SLING-9543 > URL: https://issues.apache.org/jira/browse/SLING-9543 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: Feature Model Sling Maven Kickstart Plugin 0.0.2 >Reporter: Andreas Schaefer >Priority: Major > Fix For: Feature Model Sling Kickstart Project 0.0.6 > > > Add the support for Feature Archives (done through the Kickstart Project) and > the ability to use a custom Kickstart Project as a JAR file or Maven > Dependency -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9543) Add Support for Feature Archives and Provide the ability to use a custom Kickstart
[ https://issues.apache.org/jira/browse/SLING-9543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-9543: Fix Version/s: Feature Model Sling Kickstart Project 0.0.6 > Add Support for Feature Archives and Provide the ability to use a custom > Kickstart > -- > > Key: SLING-9543 > URL: https://issues.apache.org/jira/browse/SLING-9543 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: Feature Model Sling Maven Kickstart Plugin 0.0.2 >Reporter: Andreas Schaefer >Priority: Major > Fix For: Feature Model Sling Kickstart Project 0.0.6, Feature > Model Sling Maven Kickstart Plugin 0.0.4 > > > Add the support for Feature Archives (done through the Kickstart Project) and > the ability to use a custom Kickstart Project as a JAR file or Maven > Dependency -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9543) Add Support for Feature Archives and Provide the ability to use a custom Kickstart
[ https://issues.apache.org/jira/browse/SLING-9543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-9543: Fix Version/s: Feature Model Sling Kickstart Project 0.0.6 > Add Support for Feature Archives and Provide the ability to use a custom > Kickstart > -- > > Key: SLING-9543 > URL: https://issues.apache.org/jira/browse/SLING-9543 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: Feature Model Sling Maven Kickstart Plugin 0.0.2 >Reporter: Andreas Schaefer >Priority: Major > Fix For: Feature Model Sling Kickstart Project 0.0.6, Feature > Model Sling Maven Kickstart Plugin 0.0.4 > > > Add the support for Feature Archives (done through the Kickstart Project) and > the ability to use a custom Kickstart Project as a JAR file or Maven > Dependency -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9543) Add Support for Feature Archives and Provide the ability to use a custom Kickstart
[ https://issues.apache.org/jira/browse/SLING-9543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-9543: Fix Version/s: (was: Feature Model Sling Kickstart Project 0.0.6) > Add Support for Feature Archives and Provide the ability to use a custom > Kickstart > -- > > Key: SLING-9543 > URL: https://issues.apache.org/jira/browse/SLING-9543 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: Feature Model Sling Maven Kickstart Plugin 0.0.2 >Reporter: Andreas Schaefer >Priority: Major > Fix For: Feature Model Sling Maven Kickstart Plugin 0.0.4 > > > Add the support for Feature Archives (done through the Kickstart Project) and > the ability to use a custom Kickstart Project as a JAR file or Maven > Dependency -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9543) Add Support for Feature Archives and Provide the ability to use a custom Kickstart
[ https://issues.apache.org/jira/browse/SLING-9543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer resolved SLING-9543. - Resolution: Fixed Fixed and committed > Add Support for Feature Archives and Provide the ability to use a custom > Kickstart > -- > > Key: SLING-9543 > URL: https://issues.apache.org/jira/browse/SLING-9543 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: Feature Model Sling Maven Kickstart Plugin 0.0.2 >Reporter: Andreas Schaefer >Priority: Major > Fix For: Feature Model Sling Maven Kickstart Plugin 0.0.4 > > > Add the support for Feature Archives (done through the Kickstart Project) and > the ability to use a custom Kickstart Project as a JAR file or Maven > Dependency -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9543) Add Support for Feature Archives and Provide the ability to use a custom Kickstart
Andreas Schaefer created SLING-9543: --- Summary: Add Support for Feature Archives and Provide the ability to use a custom Kickstart Key: SLING-9543 URL: https://issues.apache.org/jira/browse/SLING-9543 Project: Sling Issue Type: Improvement Components: Feature Model Affects Versions: Feature Model Sling Maven Kickstart Plugin 0.0.2 Reporter: Andreas Schaefer Fix For: Feature Model Sling Maven Kickstart Plugin 0.0.4 Add the support for Feature Archives (done through the Kickstart Project) and the ability to use a custom Kickstart Project as a JAR file or Maven Dependency -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9507) Add an option to Kickstart to prevent the use of the bundled Sling FM
[ https://issues.apache.org/jira/browse/SLING-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer updated SLING-9507: Fix Version/s: (was: Feature Model Sling Kickstart Project 0.0.4) Feature Model Sling Kickstart Project 0.0.6 > Add an option to Kickstart to prevent the use of the bundled Sling FM > - > > Key: SLING-9507 > URL: https://issues.apache.org/jira/browse/SLING-9507 > Project: Sling > Issue Type: New Feature > Components: Feature Model >Affects Versions: Feature Model Sling Kickstart Project 0.0.2 >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > Fix For: Feature Model Sling Kickstart Project 0.0.6 > > > To make it easier and more expressive the Kickstart should provide a flag > (-ns) to disregard the bundled Sling FM so that an application can be > launched that is not tied to Sling and w/o having to misuse the -s option. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (SLING-9516) Allow to specify execution environment as part of the feature model
[
https://issues.apache.org/jira/browse/SLING-9516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Schaefer reopened SLING-9516:
-
I using the Feature Launcher in Kickstart and w/o this is breaking now. If I
reverse the changes in Bootstrap line 154 with the original code it works
otherwise I get an NPE because Bootstrap.
getFrameworkArtifactId() returns null.
> Allow to specify execution environment as part of the feature model
> ---
>
> Key: SLING-9516
> URL: https://issues.apache.org/jira/browse/SLING-9516
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model Launcher 1.1.4, Feature Model Analyser
> 1.2.8, Feature Model 1.2.2, slingfeature-maven-plugin 1.3.6
>
>
> It is currently not possible to specify in the feature model which framework
> is used to launch the application. This results in repeatedly configuring
> this information - in the launcher, for the analyser, in the slingfeature
> maven plugin.
> We should add an extension capturing this information - this information can
> then also be used if the requirements are met at launch time.
> Extension could look like this:
> {noformat}
> "execution-environment": {
> "kind": "optional",
> "type": "json",
> "json": {
> "environment-capabilities”: [“osgi.ee(version=1.11)”,”...java
> packages...”],
> "framework": {
> "id" : "org.osgi:core:6.0.0"
> },
> "provided-bundles": ["org.osgi:logging:1.1“]
> }
> }
> {noformat}
> We could start with a first implementation, just supporting the "framework"
> property - and then enhance over time
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-9512) InternalRequest helper
[ https://issues.apache.org/jira/browse/SLING-9512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17132636#comment-17132636 ] Andreas Schaefer commented on SLING-9512: - Works for me. There are a few things to consider: * streaming the response to a caller instead to reduce memory overhead on big files or images in the response * check multiple status codes * support multipart forms (like for uploads). I had a requirement for that but now solved it otherwise > InternalRequest helper > -- > > Key: SLING-9512 > URL: https://issues.apache.org/jira/browse/SLING-9512 > Project: Sling > Issue Type: New Feature > Components: Servlets >Affects Versions: Servlet Helpers 1.3.0 >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > Fix For: Servlet Helpers 1.4.2 > > > I'm using internal requests in the GraphQL core and example modules, and > having a simpler way to set them up would be useful. > I have created a first version that I will commit soon - feedback is welcome > as usual. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9507) Add an option to Kickstart to prevent the use of the bundled Sling FM
Andreas Schaefer created SLING-9507: --- Summary: Add an option to Kickstart to prevent the use of the bundled Sling FM Key: SLING-9507 URL: https://issues.apache.org/jira/browse/SLING-9507 Project: Sling Issue Type: New Feature Components: Feature Model Affects Versions: Feature Model Sling Kickstart Project 0.0.2 Reporter: Andreas Schaefer Assignee: Andreas Schaefer Fix For: Feature Model Sling Kickstart Project 0.0.4 To make it easier and more expressive the Kickstart should provide a flag (-ns) to disregard the bundled Sling FM so that an application can be launched that is not tied to Sling and w/o having to misuse the -s option. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9498) Create feature model aggregates on the fly from the Sling Starter build
[ https://issues.apache.org/jira/browse/SLING-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126058#comment-17126058 ] Andreas Schaefer commented on SLING-9498: - [~rombert] I fixed that issue > Create feature model aggregates on the fly from the Sling Starter build > --- > > Key: SLING-9498 > URL: https://issues.apache.org/jira/browse/SLING-9498 > Project: Sling > Issue Type: Sub-task > Components: Starter >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Starter 12 > > Time Spent: 10m > Remaining Estimate: 0h > > Create feature model aggregates on the fly from the build - oak_tar and > oak_mongo. This should use the feature-converter-maven-plugin to create the > feature files. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9498) Create feature model aggregates on the fly from the Sling Starter build
[ https://issues.apache.org/jira/browse/SLING-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124506#comment-17124506 ] Andreas Schaefer commented on SLING-9498: - [~rombert] BTW if you want to see how I convert the Sling Starter PMs to a Feature Model have a look at the sling-org-apache-sling-kickstart/sling-fm-pom.xml file. This one requires a path to the Sling Starter folder but you don't need that inside the Sling Starter. > Create feature model aggregates on the fly from the Sling Starter build > --- > > Key: SLING-9498 > URL: https://issues.apache.org/jira/browse/SLING-9498 > Project: Sling > Issue Type: Sub-task > Components: Starter >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Starter 12 > > Time Spent: 10m > Remaining Estimate: 0h > > Create feature model aggregates on the fly from the build - oak_tar and > oak_mongo. This should use the feature-converter-maven-plugin to create the > feature files. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9497) Announce + discuss intention to drop WAR file support to users
[ https://issues.apache.org/jira/browse/SLING-9497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124456#comment-17124456 ] Andreas Schaefer commented on SLING-9497: - >From my point of view a WAR file becomes obsolete for a Feature Model based >Sling as it needs a Feature Launcher. I am sure we could create an embedded Feature Launcher that could integrate the FMs into an existing WAR container but might be quite difficult if this container is not OSGi based. > Announce + discuss intention to drop WAR file support to users > -- > > Key: SLING-9497 > URL: https://issues.apache.org/jira/browse/SLING-9497 > Project: Sling > Issue Type: Sub-task > Components: Starter >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > > We will annnounce our intention to switch and drop WAR support on user@sling > (also Twitter and other channels). This will allow us to understand how > important WAR support is for our consumers and maybe find parties interested > in contributing and maintaining it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9498) Create feature model aggregates on the fly from the Sling Starter build
[ https://issues.apache.org/jira/browse/SLING-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124453#comment-17124453 ] Andreas Schaefer commented on SLING-9498: - In the long run Sling Starter will be retired, I assume, and will be replaced by a native Feature Model solution. For now I envision that in a POM there is a Slingfeature Maven Plugin that assembles the Sling FM from the list of Feature Bundles (maybe through Feature Reference files) and probably with some overarching configuration FMs. Also the creation of a assembled Sling FM from the Starter would only work nicely if such an FM is released as a Maven Artifact so that other tools like the Kickstart could use them w/o having to build it locally first. > Create feature model aggregates on the fly from the Sling Starter build > --- > > Key: SLING-9498 > URL: https://issues.apache.org/jira/browse/SLING-9498 > Project: Sling > Issue Type: Sub-task > Components: Starter >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Starter 12 > > Time Spent: 10m > Remaining Estimate: 0h > > Create feature model aggregates on the fly from the build - oak_tar and > oak_mongo. This should use the feature-converter-maven-plugin to create the > feature files. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9483) Sling Feature is not supporting jar:file URLs on Windows
[ https://issues.apache.org/jira/browse/SLING-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer resolved SLING-9483. - Resolution: Fixed Added the check for a Windows drive letter to the path and then removed it before creating the cache folder path. > Sling Feature is not supporting jar:file URLs on Windows > > > Key: SLING-9483 > URL: https://issues.apache.org/jira/browse/SLING-9483 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: Feature Model 1.2.0 >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > Fix For: Feature Model 1.2.2 > > > When using a jar:file url to launch a feature in the feature launcher it will > fail because the folder to export the Feature Model file contains the drive > name (c:/) which fails when the folder is created. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9483) Sling Feature is not supporting jar:file URLs on Windows
Andreas Schaefer created SLING-9483: --- Summary: Sling Feature is not supporting jar:file URLs on Windows Key: SLING-9483 URL: https://issues.apache.org/jira/browse/SLING-9483 Project: Sling Issue Type: Bug Components: Feature Model Affects Versions: Feature Model 1.2.0 Reporter: Andreas Schaefer Assignee: Andreas Schaefer Fix For: Feature Model 1.2.2 When using a jar:file url to launch a feature in the feature launcher it will fail because the folder to export the Feature Model file contains the drive name (c:/) which fails when the folder is created. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9462) Sub Maven Project fails in Check Preprocessor Run
Andreas Schaefer created SLING-9462: --- Summary: Sub Maven Project fails in Check Preprocessor Run Key: SLING-9462 URL: https://issues.apache.org/jira/browse/SLING-9462 Project: Sling Issue Type: Bug Components: Feature Model Affects Versions: slingfeature-maven-plugin 1.3.2 Reporter: Andreas Schaefer Fix For: slingfeature-maven-plugin 1.3.4 When I have a parent POM (package 'pom') and only have sub modules in there and then a submodule wants to create a Feature Model using 'include-artifact' then the build fails with the message: 'The slingfeature preprocessor did not run'. Running the build from the child does just fine. Debugging this yields a strange issue where the ProjectHelper.storeProjectInfo() is using another Maven Project instance (info.project) than the one given to the ProjectHelper.checkProcessorRun() - hence the failure. This is very irritating because the suggested fix is not fixing it (extensions = true). My guess is that this is a problem with sub modules where the testing is not done with the same Maven Project instance and hence the stored Context Value is then not found. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-9458) Support Feature Model files inside a JAR File
[ https://issues.apache.org/jira/browse/SLING-9458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer reassigned SLING-9458: --- Assignee: Andreas Schaefer > Support Feature Model files inside a JAR File > - > > Key: SLING-9458 > URL: https://issues.apache.org/jira/browse/SLING-9458 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: Feature Model 1.2.0 >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > Fix For: Feature Model 1.2.2 > > > A Feature Model file cannot be passed to the Feature Model when inside a JAR > file (jar:file:/...!/feature-model-file.json). > As we already have Feature Archive that needs to obtain the Feature Model > file from within its FAR (JAR) file this might be useful there as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
