Re: Sling Oak Restrictions - Release 1.0.0 now?

Hi, this makes sense, so I updated SLING-6045 and created a PR [1]. If everyone is happy with this version, maybe we can merge and create a first release? Regards Georg [1] https://github.com/apache/sling/pull/173 On 2016-09-09 15:08, Konrad Windszus wrote: I am also in favour of putting

Re: Sling Oak Restrictions - Release 1.0.0 now?

I am also in favour of putting it in contrib/extensions and name the package/artifact id org.apache.sling.oak.restriction. Konrad > Am 08.09.2016 um 22:32 schrieb Oliver Lietz : > > On Thursday 08 September 2016 17:48:24 Georg Henzler wrote: >> Hi Oliver, > > Hi Georg, >

Re: Sling Oak Restrictions - Release 1.0.0 now?

On Thursday 08 September 2016 17:48:24 Georg Henzler wrote: > Hi Oliver, Hi Georg, > if we call it "oak", we probably would have to also create a sub folder > contrib/oak (as all modules in contrib/jcr have the group id > org.apache.sling.jcr)... that's probably more confusing than just >

Re: Sling Oak Restrictions - Release 1.0.0 now?

Hi Oliver, if we call it "oak", we probably would have to also create a sub folder contrib/oak (as all modules in contrib/jcr have the group id org.apache.sling.jcr)... that's probably more confusing than just leaving it in contrib/jcr (having jcr and oak side by side when oak also provides

Re: Sling Oak Restrictions - Release 1.0.0 now?

On Monday 01 August 2016 13:37:26 Robert Munteanu wrote: > Hi Georg, Hi, > On Sat, 2016-07-30 at 10:14 +0200, Georg Henzler wrote: > > Hi all, > > > > with SLING-5768/SLING-5891 fixed and the documentation in > > https://sling.apache.org/documentation/bundles/sling-oak-restrictions > > .html

Re: Sling Oak Restrictions - Release 1.0.0 now?

Hi Robert, thanks for merging SLING-6042. For your comment regarding the better location contrib/jcr I created SLING-6045 including a PR. So if everyone is happy with this version then, it would be great to have a first release! Regards Georg On 2016-08-01 12:37, Robert Munteanu wrote:

Re: Sling Oak Restrictions - Release 1.0.0 now?

Hi Robert, I updated SLING-5768 and SLING-5890 (markdown docu) for using sling:resourceTypesWithDescendants. If everyone is reasonably happy with it, I think we should just go with that :) Regards Georg On 2016-08-01 13:56, Georg Henzler wrote: Hi Julian, good point that "descendants" is

Re: Sling Oak Restrictions - Release 1.0.0 now?

On 2016-08-02 09:41, Konrad Windszus wrote: I think sling:resourceTypesWithChildren is the clearest suggestion up to now ([1] gives an example). From a pure user point of view, the terms "parent" or "ancestry" would be rather misleading, because what is matched by the restriction in the end

Re: Sling Oak Restrictions - Release 1.0.0 now?

> On 01 Aug 2016, at 13:32, Georg Henzler wrote: > > Hi Robert, > >> ... I would rather see it named org.apache.sling.jcr.oak-restrictions >> and placed under contrib/jcr . > > That sounds like a better location, +1 to move > >> There was some discussion related to the

Re: Sling Oak Restrictions - Release 1.0.0 now?

Hi Julian, good point that "descendants" is actually clearer than "children"... that gives two options IMHO: - sling:resourceTypesDeep <-- less descriptive but also shorter - sling:resourceTypesWithDescendants <-- I think clearer, but longer For the simple match, I would stick with the short

Re: Sling Oak Restrictions - Release 1.0.0 now?

Hi Georg I think "...WithChildren" is misleading, because, per my understanding of the documentation, it means "with descendants". Maybe restriction names with "shallow" and/or "deep" would be more self-documenting? E.g. "sling:resourceTypesShallow" and "sling:resourceTypesDeep". WDYT?

Re: Sling Oak Restrictions - Release 1.0.0 now?

Hi Robert, ... I would rather see it named org.apache.sling.jcr.oak-restrictions and placed under contrib/jcr . That sounds like a better location, +1 to move There was some discussion related to the name of the 'sling:resourceTypesWithChildren' restriction [1]. I want to make sure that we

Re: Sling Oak Restrictions - Release 1.0.0 now?

Hi Georg, On Sat, 2016-07-30 at 10:14 +0200, Georg Henzler wrote: > Hi all, > > with SLING-5768/SLING-5891 fixed and the documentation in  > https://sling.apache.org/documentation/bundles/sling-oak-restrictions > .html  > we have everything needed to cut a first release IMHO - could > someone  >

Sling Oak Restrictions - Release 1.0.0 now?

Hi all, with SLING-5768/SLING-5891 fixed and the documentation in https://sling.apache.org/documentation/bundles/sling-oak-restrictions.html we have everything needed to cut a first release IMHO - could someone take care of it? Thanks & Regards Georg