Re: Alias property deletion confusion

Thank you Gus and David for the very prompt replies! I was planning on updating the test with some assertions (that is how I ran into this). It seems that today setting to null will be a no-op, the property will not be changed. I'm not 100% sure what component handles this, it may be Zk. In my

Re: Result Grouping on alias collection

I think I recall past experience that if the ID is duplicated, you get one or the other, and the one you get is non-deterministic, but as this is an unsupported and untested configuration, I would expect other things like facet counts etc to be thrown off. Also if the schemas use different fields

Re: Alias property deletion confusion

Yeah it does look like that test should be improved. I would expect that null and "" should be treated equivalently, but I don't recall what the code actually does. We should get some asserts in there and decide if we like the results of what we find. If not, fix it. On Wed, Mar 15, 2023 at 4:49 

Re: Result Grouping on alias collection

When aliasing across collections, it's up to you/the-user to ensure that they don't contain the same document (by ID). I don't believe this is supported at all. If you find information to the contrary, let us know. I could imagine some small code details to _do something_ if it could be detected

Re: Alias property deletion confusion

Interestingly, the part of that test which you commented on doesn't appear to assert/validate anything; it just does stuff. I suspect Gus may know the answer to your question. ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Wed, Mar 15, 2023 at 2:13 

Re: Google Java Style: shall we declare intent to follow?

+1 Could also be useful to link common IDE plugins in the dev docs to help: https://github.com/google/google-java-format#eclipse https://plugins.jetbrains.com/plugin/8527-google-java-format On Wed, Mar 15, 2023 at 3:55 PM Jan Høydahl wrote: > +1 to David's proposal. > > > > 15. mar. 2023 kl.

Re: Google Java Style: shall we declare intent to follow?

+1 to David's proposal. > 15. mar. 2023 kl. 19:07 skrev David Smiley : > > Let's record this somewhere then. I took a look in dev-docs/ and found the > FAQ with an entry "How do we ensure coding standards and quality?" This > seems like a natural place to put this. WDYT? > > For the wording

Re: Proposal of an encryption module in solr-sandbox

There's a catch-22 here. Enterprises that require encryption at rest likely won't tolerate enabling a package manager that lets you download executable code from the internet during runtime, especially when that package manager is both home-grown, and largely unused and neglected. So we need

Re: Proposal of an encryption module in solr-sandbox

I would love to see such a support be available to users by way of the package manager, irrespective of whether it is a first or third party package. On Thu, 16 Mar, 2023, 12:33 am David Smiley, wrote: > On Wed, Mar 15, 2023 at 5:23 AM Ishan Chattopadhyaya < > ichattopadhy...@gmail.com> wrote:

Re: Proposal of an encryption module in solr-sandbox

On Wed, Mar 15, 2023 at 5:23 AM Ishan Chattopadhyaya < ichattopadhy...@gmail.com> wrote: > Does it need to be a first party project? > If there is a maintainer then, I think yes. When there isn't, then it's a difficult question.

Re: Proposal of an encryption module in solr-sandbox

Does anything at all need to be in Solr? :-). Food for thought. I think of this capability as being valuable, particularly for some "enterprise-y" users, and thus keeping Solr competitive. It has no dependencies other than annotations. Bruno proposes adding it to the sandbox. My only concern

Re: Proposal of an encryption module in solr-sandbox

I've also observed that HDFS supports client provided encryption... or so I recall when I looked many months ago. Someone ought to do a blog/write-up on that. ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Wed, Mar 15, 2023 at 5:28 AM Ishan

Re: Proposal of an encryption module in solr-sandbox

Important notice: currently the encryption module does not encrypt TLogs yet. Le mer. 15 mars 2023 à 10:28, Ishan Chattopadhyaya < ichattopadhy...@gmail.com> a écrit : > HDFS* > > On Wed, 15 Mar, 2023, 2:56 pm Ishan Chattopadhyaya, < > ichattopadhy...@gmail.com> wrote: > > > Btw, +1 to the

Re: Caffeine - ISE: Recursive update Re: [JENKINS] Solr-main-Linux (64bit/hotspot/jdk-16.0.2) - Build # 10777 - Unstable!

I've been able to trigger this locally using `-Ptests.iters=20` (or whatever). Still not sure what the issue is, but here's the request that's triggering this for me: 2> 176445 INFO (TEST-TestFiltering.testRandomFiltering-seed#[8C523D43388C3411]) [] o.a.s.c.S.Request webapp=null path=null

Alias property deletion confusion

Hi, I am working on v2 apis for managing alias properties as part of SOLR-16393. I have a confusion I would love to clarify with the community related to an existing test (AliasIntegrationTest) that deletes an alias property. My understanding is that setting a property to 'empty string' will

Re: Google Java Style: shall we declare intent to follow?

Let's record this somewhere then. I took a look in dev-docs/ and found the FAQ with an entry "How do we ensure coding standards and quality?" This seems like a natural place to put this. WDYT? For the wording text, I want to keep it simple. Like the following: > Please follow the Google Java

Re: [DISCUSS] Solr 9.2 Release

I checked internally with my colleagues and it seems that the only issue that is near the merge point is this one: https://github.com/apache/solr/pull/1435 Definitely nice to have (also to show progress in the neural search side of things) but I wouldn't say it's a blocker. I assume it will be

Re: Caffeine - ISE: Recursive update Re: [JENKINS] Solr-main-Linux (64bit/hotspot/jdk-16.0.2) - Build # 10777 - Unstable!

>From first glance this reminded me of https://github.com/apache/solr/pull/1118 but doesn't look completely related. This section of code just seems questionable: https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/search/CaffeineCache.java#L254 We are doing a get inside

Re: [DISCUSS] Solr 9.2 Release

I am super close on SOLR-10466, barring any issues being raised on review. Going to keep pushing this afternoon to get it to done. Only thirteen more uses of the deprecated method in the test code, and honestly, since we aren’t deleting this method in 9.2, if I don’t get the remaining test

Re: [DISCUSS] Solr 9.2 Release

Hey everyone, Trying to get organized around the release. From my point of view, this is the state of unfinished work: Looking at the Solr 9.2 blockers ( https://issues.apache.org/jira/projects/SOLR/versions/12352353), we currently have two: - SOLR-9168

Re: Caffeine - ISE: Recursive update Re: [JENKINS] Solr-main-Linux (64bit/hotspot/jdk-16.0.2) - Build # 10777 - Unstable!

Should we just set solr.filterCache.async=true? On Wed, Mar 15, 2023 at 4:57 PM Mikhail Khludnev wrote: > Hi, devs. > I see in my inbox it fails from time to time. > It seems the cause is .. caffeine >

Caffeine - ISE: Recursive update Re: [JENKINS] Solr-main-Linux (64bit/hotspot/jdk-16.0.2) - Build # 10777 - Unstable!

Hi, devs. I see in my inbox it fails from time to time. It seems the cause is .. caffeine https://jenkins.thetaphi.de/job/Solr-main-Linux/10777/testReport/junit/org.apache.solr.search/TestFiltering/testRandomFiltering/ => java.lang.IllegalStateException: Recursive update at

Re: Google Java Style: shall we declare intent to follow?

So what happens next? I’d love to see some of these topics get to decided ;-) > On Mar 8, 2023, at 3:22 PM, David Smiley wrote: > > BTW, I believe a rename of a file/class should *not* appear to git blame as > happening on every line. Not something you said but maybe implied and not >

Re: Proposal of an encryption module in solr-sandbox

HDFS* On Wed, 15 Mar, 2023, 2:56 pm Ishan Chattopadhyaya, < ichattopadhy...@gmail.com> wrote: > Btw, +1 to the initiative. I've heard of clients used encrypted HDFC for > these usecases. Direct support at Lucene/Solr level is much better. > > On Wed, 15 Mar, 2023, 2:52 pm Ishan Chattopadhyaya, <

Re: Proposal of an encryption module in solr-sandbox

Btw, +1 to the initiative. I've heard of clients used encrypted HDFC for these usecases. Direct support at Lucene/Solr level is much better. On Wed, 15 Mar, 2023, 2:52 pm Ishan Chattopadhyaya, < ichattopadhy...@gmail.com> wrote: > Does it need to be a first party project? > > On Wed, 15 Mar,

Re: Proposal of an encryption module in solr-sandbox

Does it need to be a first party project? On Wed, 15 Mar, 2023, 2:46 pm Bruno Roustant, wrote: > Hi, > > I pushed a PR in > solr-sandbox to propose a > Java-level encryption for Solr. > This work is the

Proposal of an encryption module in solr-sandbox

Hi, I pushed a PR in solr-sandbox to propose a Java-level encryption for Solr. This work is the follow up of LUCENE-9379 . To give some