Re: [RESULT] [VOTE] Release Solr 9.0.0 RC4

Looks like the blockers are all in. Anyone planning to commit more bug fixes? I'll aim for spinning RC5 tomorrow, Thursday. Jan > 3. mai 2022 kl. 16:42 skrev Michael Gibney : > > I'll be backporting SOLR-16176 shortly (today) to fix the distributed > faceting issue Gus pointed out. > Michael

Re: [RESULT] [VOTE] Release Solr 9.0.0 RC4

I'll be backporting SOLR-16176 shortly (today) to fix the distributed faceting issue Gus pointed out. Michael On Tue, May 3, 2022 at 10:26 AM Mike Drob wrote: > I created SOLR-16177 for > the license header issue. > > I am backporting

Re: [RESULT] [VOTE] Release Solr 9.0.0 RC4

I created SOLR-16177 for the license header issue. I am backporting SOLR-16133 as a minor smoke tester improvement. Mike On Tue, May 3, 2022 at 8:35 AM Kevin Risden wrote: > I'm backporting https://issues.apache.org/jira/browse/SOLR-16164 - >

Re: [RESULT] [VOTE] Release Solr 9.0.0 RC4

I'm backporting https://issues.apache.org/jira/browse/SOLR-16164 - ConfigSet API returns error if untrusted user creates from _default configset I am NOT backporting SOLR-16174 TestBulkSchemaConcurrent - its still baking on master/9x. Saw a new Jenkins failure in last ~24hrs about thread leak I

Re: [RESULT] [VOTE] Release Solr 9.0.0 RC4

It's been >72h since the vote was initiated and the result is: +1 5 (5 binding) 0 0 -1 3 The conclusion is that the vote has FAILED due to lack of clear consensus. We'll prepare for RC5. I added these as blockers for 9.0 RC5: https://issues.apache.org/jira/browse/SOLR-16164

Re: [VOTE] Release Solr 9.0.0 RC4

I'll change my vote to a -1. Two reasons, #1 is based on the license header issue that I mentioned, and will work on getting that sorted out this week. #2 is that while I personally don't see the severity of the latest identified issues as blocking, if we're going to immediately turn around and

Re: [VOTE] Release Solr 9.0.0 RC4

I went through the vote thread again, and it seems like there are issues that folks aren't comfortable releasing with. Jan, as you've been driving this, I'll leave it to you but I think if we are certain about doing another follow up release with the fixes, we might as well just do that one

Re: [VOTE] Release Solr 9.0.0 RC4

Even though the votes are not decisive, here's my report and vote for Solr 9.0 RC4. 1. Smoke Tester passed in a single run! SUCCESS! [0:58:24.657506] 2. Manual testing of basic index/search capability using sample code. 3. Tested out some issues that were fixed in 8.11 and 9.0 to work correctly

Re: [VOTE] Release Solr 9.0.0 RC4

FWIW I believe both issues have patches now... I haven't tested anything yet though. On Mon, May 2, 2022 at 4:03 PM Jan Høydahl wrote: > Hi. > > With the current five +1's and two -1's I'm not seeing the kind of > consensus we traditionally want for a release. > It's understandable due the

Re: [VOTE] Release Solr 9.0.0 RC4

Hi. With the current five +1's and two -1's I'm not seeing the kind of consensus we traditionally want for a release. It's understandable due the uncertainty caused by the two bugs uncovered during the vote. The important question is whether the majority of us deem any of these bugs as release

Re: [VOTE] Release Solr 9.0.0 RC4

It would be a pretty odd edge case. The enum method would typically not be used in high cardinality cases and limit:-1 means an overrequest is not needed. I personally don't think this is a blocker. Joel Bernstein http://joelsolr.blogspot.com/ On Mon, May 2, 2022 at 12:43 PM Michael Gibney

Re: [VOTE] Release Solr 9.0.0 RC4

Gus said most of what I have to say -- this affects an odd edge case: explicit positive overrequest _and_ method:enum _and_ limit:-1. This would be a pretty pathological combination; but even so, the consequence would be to turn an unlimited (limit:-1) request into a limited one (limit:n, n>=0) --

Re: [VOTE] Release Solr 9.0.0 RC4

Also this changes my vote to -1 On Mon, May 2, 2022 at 11:44 AM Gus Heck wrote: > Some offline discussion indicates that this is more than just SKG and it > looks like Michael will look into it, so I've filed > https://issues.apache.org/jira/browse/SOLR-16176 as a blocker and > assigned to him.

Re: [VOTE] Release Solr 9.0.0 RC4

Some offline discussion indicates that this is more than just SKG and it looks like Michael will look into it, so I've filed https://issues.apache.org/jira/browse/SOLR-16176 as a blocker and assigned to him. On Mon, May 2, 2022 at 11:03 AM Jan Høydahl wrote: > Tried some seeds from Jenkins

Re: [VOTE] Release Solr 9.0.0 RC4

Tried some seeds from Jenkins failures for this same test, and found another reproducible seed: 19DF63E9537FFBA3 On the face of it, it seems like a corner case bug, but could of course be a generic enum JSON Facet bug that has lived with us for some time? I'll wait a bit more to gather more

Re: [VOTE] Release Solr 9.0.0 RC4

Gus, re: the SKG failure: I was able to reproduce it, but haven't dug in enough to say exactly what's going on. (off-the-cuff response: this test is quite robust, and has uncovered edge-case issues before that are more about "distributed faceting" generally than about "SKG" per se). I'd be

Re: [VOTE] Release Solr 9.0.0 RC4

Noble and I just came across a bug in master concerning restarting of Solr, where it was observed that registering live_nodes upon restart was failing with NodeExistsException. We haven't looked further and don't know if it affects 9.0. In case it is a problem, and 9.0 has already released, we

Re: [VOTE] Release Solr 9.0.0 RC4

I was hoping someone more familiar with SKG's test/code that I found a failure for might chime in. It looks like it's a case where enum facets are not producing all results produced for default faceting, which seems possibly bad, but I am not familiar with this code at all. This probably is

Re: [VOTE] Release Solr 9.0.0 RC4

> > I would too like to understand the severity of the configsets bug, and > whether it is serious enough to stop the release. > As I understand the issue, it ONLY affects those creating a new configset > based on another one in ZK. > I.e. there are many workarounds for this bug > - Use an

Re: [VOTE] Release Solr 9.0.0 RC4

Hi, If I close the vote now, it will technically pass with four +1s, one -1 and one -0. A bit too fragile result IMO. I would too like to understand the severity of the configsets bug, and whether it is serious enough to stop the release. As I understand the issue, it ONLY affects those

Re: [VOTE] Release Solr 9.0.0 RC4

-0 for now, pending discussion of severity... I have hit a reproducing failure: ./gradlew :solr:core:test --tests "org.apache.solr.search.facet.TestCloudJSONFacetSKGEquiv.testRandom" -Ptests.jvms=5 -Ptests.jvmargs=-XX:TieredStopAtLevel=1 -Ptests.seed=C730F33909C71234 -Ptests.badapples=false

Re: [VOTE] Release Solr 9.0.0 RC4

+1 (binding) Smoketester succeeded with Java 11 and Java 17 -- SUCCESS! [2:04:03.678208] Unlike for some others, this succeeded on my first try. I guess I'm just lucky :) Tested building an application that uses EmbeddedSolrServer and depends on our maven artifacts - validated SOLR-16157,

Re: [VOTE] Release Solr 9.0.0 RC4

Thanks David, Although we have 4 +1's I'll wait over the weekend for more votes. Tests are indeed in a sad state, I think I ran buildAndPushRelease.py 10 times before successful. But then smoketester succeeded on first try after that. The fucit graphs are last 7 days, and we had 100% failure

Re: [VOTE] Release Solr 9.0.0 RC4

+1 (binding) but flaky tests are in sad shape; not worth holding up a release over. I ran the smoke tester and only one test failed: org.apache.solr.servlet.TestRequestRateLimiter.testConcurrentQueries However this test I recall from conversations has some known flakiness. But moreover, actually

Re: [VOTE] Release Solr 9.0.0 RC4

SUCCESS! [0:48:19.349163] +1 (binding) I also performed the following manual steps with the artifacts: - started Solr with the sql module - created a collection, - loaded data - queried from the sql admin screen - ran streaming expressions All worked as expected. Joel Bernstein

Re: [VOTE] Release Solr 9.0.0 RC4

SUCCESS! [1:12:29.134015] Also manually checked: - Compatibility with the Solr Operator - Backups (just local filesystem) - Prometheus Exporter +1 (binding) On Wed, Apr 27, 2022 at 10:15 PM Jan Høydahl wrote: > Please vote for release candidate 4 for Solr 9.0.0 > > The artifacts

[VOTE] Release Solr 9.0.0 RC4

Please vote for release candidate 4 for Solr 9.0.0 The artifacts can be downloaded from: https://dist.apache.org/repos/dist/dev/solr/solr-9.0.0-RC4-rev-d6e36d590896755ca962c6d2ddedf78ca4f463cc You can run the smoke tester directly with this command: python3 -u