http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
Bug 3997 depends on bug 4260, which changed state.
Bug 4260 Summary: rewrite DNS code to use a single socket, event-based model
http://bugzilla.spamassassin.org/show_bug.cgi?id=4260
What|Old Value |New Value
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
Bug 3997 depends on bug 4260, which changed state.
Bug 4260 Summary: rewrite DNS code to use a single socket, event-based model
http://bugzilla.spamassassin.org/show_bug.cgi?id=4260
What|Old Value |New Value
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
Bug 3997 depends on bug 4260, which changed state.
Bug 4260 Summary: rewrite DNS code to use a single socket, event-based model
http://bugzilla.spamassassin.org/show_bug.cgi?id=4260
What|Old Value |New Value
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution|
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
Bug 3997 depends on bug 4260, which changed state.
Bug 4260 Summary: rewrite DNS code to use a single socket, event-based model
http://bugzilla.spamassassin.org/show_bug.cgi?id=4260
What|Old Value |New Value
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
Bug 3997 depends on bug 4260, which changed state.
Bug 4260 Summary: rewrite DNS code to use a single socket, event-based model
http://bugzilla.spamassassin.org/show_bug.cgi?id=4260
What|Old Value |New Value
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
Bug 3997 depends on bug 4260, which changed state.
Bug 4260 Summary: rewrite DNS code to use a single socket, event-based model
http://bugzilla.spamassassin.org/show_bug.cgi?id=4260
What|Old Value |New Value
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
Bug 3997 depends on bug 4260, which changed state.
Bug 4260 Summary: rewrite DNS code to use a single socket, event-based model
http://bugzilla.spamassassin.org/show_bug.cgi?id=4260
What|Old Value |New Value
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-17 15:01 ---
OK, bug 4260 is now in testing -- if you're running into this bug and want to
try the fix out, see that bug.
--- You are receiving this mail because:
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-13 17:21 ---
Thanks for chasing this down everyone!
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
[EMAIL PROTECTED] changed:
What|Removed |Added
CC|[EMAIL PROTECTED] |
--- You are
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-12 18:24 ---
Good analysis.
I don't think the nameserver is likely to care about identical DNS IDs due to
spamd children. But in case one out there might, you could use the
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-12 20:01 ---
Created an attachment (id=2786)
-- (http://bugzilla.spamassassin.org/attachment.cgi?id=2786action=view)
new patch -- use our own ID counter
Thanks for the
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-12 20:12 ---
Created an attachment (id=2787)
-- (http://bugzilla.spamassassin.org/attachment.cgi?id=2787action=view)
additional patch on top of 2786
oops -- I made a booboo
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-12 20:16 ---
Do we not also need to check that ID number when reading the socket?
--- You are receiving this mail because: ---
You are the assignee for the bug, or
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-12 20:19 ---
Subject: Re: DNS answers get mixed up
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
actually, I've just realised I've only checked in half of the
solution...
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-12 20:25 ---
I'd keep the socket. In fact, I'd check to see if the socket is ready right
then since it is likely the answer has already arrived.
There's no extra hit from
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-12 20:40 ---
Subject: Re: DNS answers get mixed up
On Tue, Apr 12, 2005 at 08:01:48PM -0700, [EMAIL PROTECTED] wrote:
Here's an impl of what Sidney was talking about; it
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-12 21:13 ---
Sidney, I don't think you need to worry that much about a collision - firstly,
separate children will use different UDP ports. And from what I can see, bgsend
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-12 21:19 ---
'There's no extra hit from keeping the socket. We took a hit creating it and
doing the query, we might as well try and get the answer.'
well, there *is* a hit,
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-12 21:35 ---
Subject: Re: DNS answers get mixed up
--- Additional Comments From [EMAIL PROTECTED] 2005-04-12 21:19 ---
'There's no extra hit from keeping the
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-12 21:38 ---
Theo, I had to look carefully for that too. That's taken care of in
+sub new_dns_packet {
+ my ($host, $type, $class) = @_;
+
+ # increment our counter, and
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-12 21:49 ---
Justin, I know I'm being overly picky, but shouldn't
+sub init_dns_id_counter_from_pid {
+ $DNS_ID_COUNTER = (($$ 10) | (($$ 6) 0x));
use xor instead of
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-12 21:51 ---
ok, checked in the second half of the fix as r161157.
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-12 21:55 ---
Sidney -- I suppose either would work. it's actually Jonathan's snippet.
that arithmetic has a few basic ideas behind it:
1. different PIDs use different ranges
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-12 22:15 ---
Justin, as I said, I was being picky, but with an | operator the top 10 bits
each have a 3/4 chance of ending up as 1, assuming a random distribution of bits
to
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-13 00:55 ---
Subject: Re: DNS answers get mixed up
It's probably easier to manage the problem of DNS UDP socket confusion by
using a single socket for all queries. Then it
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-13 06:00 ---
Tony, yes, now that we are using the DNS ID to match up replies to queries there
is no reason to use more than one socket for that purpose. Where was your
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-13 06:07 ---
Subject: Re: DNS answers get mixed up
On Wed, 13 Apr 2005 [EMAIL PROTECTED] wrote:
Where was your single-socket-with-DNS-ID vision when we were trying to
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-13 06:41 ---
Created an attachment (id=2789)
-- (http://bugzilla.spamassassin.org/attachment.cgi?id=2789action=view)
patch to complete the read portion of the fix, checked in
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-13 07:04 ---
I admit I can't be sure. But I get the feeling this will leak sockets if DNS
replies simply get lost. Am I wrong?
--- You are receiving this mail because:
On 13 Apr 2005, at 09:00, [EMAIL PROTECTED]
wrote:
--- Additional Comments From [EMAIL PROTECTED] 2005-04-13 06:00
---
Tony, yes, now that we are using the DNS ID to match up replies to
queries there
is no reason to use more than one socket for that purpose. Where was
your
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-13 07:22 ---
Getting more relevant documentation in this one place... Here is Matt Sergeant's
post to sa-dev from last January with a recipe for the single-socket solution
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-13 07:34 ---
Subject: Re: DNS answers get mixed up
my $packet = $self-{res}-make_query_packet($host);
my $packet_data = $packet-data;
my $h =
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-13 07:41 ---
Thanks Tony Ackkk... I just looked at the source code in for
Net::Dns::Header. It not only calls nextid() each time to increment the ID, but
it initializes it
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-13 08:42 ---
As a transition step it might be easy to create a IO::Socket object when we call
Net::DNS::Resolver-new, save it as an instance variable $self-{socket}
alongside
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-13 10:01 ---
'I just looked at the source code in for
Net::Dns::Header. It not only calls nextid() each time to increment the ID, but
it initializes it to a random value when
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
[EMAIL PROTECTED] changed:
What|Removed |Added
BugsThisDependsOn||4260
--- Additional
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
[EMAIL PROTECTED] changed:
What|Removed |Added
CC|[EMAIL PROTECTED] |
--- You are receiving this
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-11 16:04 ---
Excuse my ignorance, but what are the three columns in that table under bogus
errors per run ?
??
The number of times a bogus DNS response was received per
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-12 02:39 ---
Subject: Re: DNS answers get mixed up
Same test, without the DNS cache flushes before each run.
fast - with Justin's patch
slow - without Justin's patch
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-12 02:55 ---
Sidney,
That patch does disable persistence the way I did it. Irrespective of any ad hoc
testing, I assure you that patch does fix problems, at least in my
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-12 04:02 ---
Just a quick coment that Jonathan's test method sounds reasonable to me.
He also identifies a very specific sequence of events that apparently leads to
the bug:
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-12 05:49 ---
Jonathan, I still don't understand how the source code and your explanation and
your tcpdump results fit together, or why the problem goes away in your
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-12 15:42 ---
I think I now understand the problem and a simnple solution.
The problem is that there is nothing in the RFCs to prevent reuse of a UDP
source port once there is
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-11 11:55 ---
Subject: Re: DNS answers get mixed up
Here are my results for a mass-check of 28k spam with a DNS cache flush
before each mass-check.
key:
fast - with
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-11 14:13 ---
Excuse my ignorance, but what are the three columns in that table under bogus
errors per run ?
Are you counting false negatives as well as false positives? False
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-11 15:33 ---
Daniel, is Justin's patch the one from comment #54? If so, I would not say
that your results show the persistence change helping the current code. The
patch does
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
---
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-07 22:46 ---
Created an attachment (id=2774)
-- (http://bugzilla.spamassassin.org/attachment.cgi?id=2774action=view)
3.0 patch -- disable socket persistence
Here's a patch
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-08 04:38 ---
Out of interest, I wasn't clear from bug 4249, but I have run with socket
persistence disabled and it works fine and the problem went away for me.
--- You
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
---
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-01 18:28 ---
Created an attachment (id=2753)
-- (http://bugzilla.spamassassin.org/attachment.cgi?id=2753action=view)
May trigger bug
Here's an additional message that may
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
[EMAIL PROTECTED] changed:
What|Removed |Added
Attachment #2753|May trigger bug |Another message that may
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-04-01 20:03 ---
Subject: Re: DNS answers get mixed up
Here's an additional message that may trigger this bug.
advicesfromdoctors24.info is listed in SURBLs, but aibotoys.com
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-03-29 16:06 ---
I got these errors during a small corpus run (both times when my DNS cache was
empty, I am running bind 9.2.1-2 from Debian), but only after applying the
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
[EMAIL PROTECTED] changed:
What|Removed |Added
Target Milestone|Undefined |3.1.1
--- Additional
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-03-23 20:41 ---
Just an update from me I've been running with the changes suggested in
Comment 47, Comment 48, and Comment 49 since January. I haven't had any false
positives
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-03-23 22:51 ---
Created an attachment (id=2728)
-- (http://bugzilla.spamassassin.org/attachment.cgi?id=2728action=view)
another patch on top of 2611
fwiw, here's a patch
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
---
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-02-10 20:56 ---
Just as a suggestion as well, people might want to report if they are using a
DNS cache, and what cache they are using if they are. It would be surprising if
it
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
---
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-01-22 19:49 ---
Well, here's what I propose. Vance, you might want to see what Daniel's opinion
of this is before you try it, as I am not in a position right now to test any
code
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-01-22 23:29 ---
--- Additional Comments From [EMAIL PROTECTED] 2005-01-22 17:37 ---
What do you think of writing a warning message to the log if an answer is
found
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-01-20 17:49 ---
(In reply to comment #41)
Vance, what version of Net::DNS were you running when the log entry in
bug comment 23 happened?
perl -le 'use Net::DNS; print
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
[EMAIL PROTECTED] changed:
What|Removed |Added
Summary|SURBL FP on a particular|DNS answers get mixed up
http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
--- Additional Comments From [EMAIL PROTECTED] 2005-01-19 22:13 ---
For SURBLs may I suggest using only A records and ignoring the TXT record, if
that's possible.
--- You are receiving this mail because: ---
You are the
67 matches
Mail list logo
