[Bug 8051] HeaderEval word_is_in_dictionary, deprecated triplets.txt usage

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8051 RvdH changed: What|Removed |Added CC||ruud.vd.h...@gmail.com --- Comment #2 from

[Bug 8044] 4.0.0 RC2 crash on Windows

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8044 --- Comment #56 from Henrik Krohns --- (In reply to RvdH from comment #55) > Can i still ask questions when possible issues with 4.0.0-rc2 arise on > Windows? > > When running with --debug is see a line, like: > Mon Sep 19 11:55:18 2022

[Bug 8051] New: HeaderEval word_is_in_dictionary, deprecated triplets.txt usage

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8051 Bug ID: 8051 Summary: HeaderEval word_is_in_dictionary, deprecated triplets.txt usage Product: Spamassassin Version: SVN Trunk (Latest Devel Version) Hardware: All

[Bug 8050] [REVIEW] Fix global_state_dir on Windows

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050 --- Comment #14 from Sidney Markowitz --- (In reply to RvdH from comment #13) > So now it always uses LOCAL_STATE_DIR on windows? > Even with when the --helpers-home-dir parameter is passed to spamd? The --helpers-home-dir is still used

[Bug 8044] 4.0.0 RC2 crash on Windows

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8044 --- Comment #55 from RvdH --- Can i still ask questions when possible issues with 4.0.0-rc2 arise on Windows? When running with --debug is see a line, like: Mon Sep 19 11:55:18 2022 [4276] dbg: eval: failed to locate the triplets.txt file

[Bug 8051] [REVIEW] HeaderEval word_is_in_dictionary, deprecated triplets.txt usage

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8051 Giovanni Bechis changed: What|Removed |Added CC||giova...@paclan.it --- Comment

[Bug 8050] [REVIEW] Fix global_state_dir on Windows

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050 --- Comment #16 from Sidney Markowitz --- +1 on the new patch -- You are receiving this mail because: You are the assignee for the bug.

[Bug 8051] [REVIEW] HeaderEval word_is_in_dictionary, deprecated triplets.txt usage

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8051 Sidney Markowitz changed: What|Removed |Added CC||sid...@sidney.com --- Comment

[Bug 8051] HeaderEval word_is_in_dictionary, deprecated triplets.txt usage

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8051 --- Comment #3 from Henrik Krohns --- Rule was removed in Bug 4766 -- You are receiving this mail because: You are the assignee for the bug.

[Bug 8051] [REVIEW] HeaderEval word_is_in_dictionary, deprecated triplets.txt usage

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8051 Bill Cole changed: What|Removed |Added CC||billc...@apache.org --- Comment #5

[Bug 8046] X-Spam-ASN header added without successful ASN lookup

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8046 --- Comment #8 from RvdH --- Here is a typical report for 3.4.6, where ASN lookup failed using routeviews X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-18) on mail.myserver.nl X-Spam-Flag: YES X-Spam-Level:

[Bug 8051] HeaderEval word_is_in_dictionary, deprecated triplets.txt usage

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8051 Henrik Krohns changed: What|Removed |Added CC||apa...@hege.li --- Comment #1 from

[Bug 8051] [REVIEW] HeaderEval word_is_in_dictionary, deprecated triplets.txt usage

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8051 Henrik Krohns changed: What|Removed |Added Summary|HeaderEval |[REVIEW] HeaderEval

[Bug 8051] HeaderEval word_is_in_dictionary, deprecated triplets.txt usage

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8051 --- Comment #4 from Henrik Krohns --- Created attachment 5829 --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5829=edit Deprecate check_for_unique_subject_id/word_is_in_dictionary Patch deprecates check_for_unique_subject_id()

[Bug 8046] X-Spam-ASN header added without successful ASN lookup

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8046 --- Comment #9 from RvdH --- FYI, i have not seen a single occasion where 4.0.0-rc2 didn't return a ASN using GeoLite2-ASN.mmdb, except for localhost (127.0.0.1) X-Spam-Checker-Version: SpamAssassin 4.0.0-r1903986 (2022-09-10) on

[Bug 8050] [REVIEW] Fix global_state_dir on Windows

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050 --- Comment #17 from RvdH --- Still kinda curious why the --helper-home-dir only is ignored on windows if (!am_running_on_windows()) { } When --helper-home-dir on windows is used on Windows it works OK, i was only this part that did not

[Bug 8050] [REVIEW] Fix global_state_dir on Windows

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050 --- Comment #18 from RvdH --- I mean, the --helper-home-dir param is used to define a path for temporary files created by razor, pyzor... etc So why not for temporary files for Dns::enter_helper_run_mode stuff? -- You are receiving this

[Bug 8050] [REVIEW] Fix global_state_dir on Windows

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050 --- Comment #13 from RvdH --- So now it always uses LOCAL_STATE_DIR on windows? Even with when the --helpers-home-dir parameter is passed to spamd? -- You are receiving this mail because: You are the assignee for the bug.

[Bug 8050] [REVIEW] Fix global_state_dir on Windows

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050 --- Comment #15 from RvdH ---  -- You are receiving this mail because: You are the assignee for the bug.

[Bug 8050] [REVIEW] Fix global_state_dir on Windows

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050 --- Comment #19 from Sidney Markowitz --- (In reply to RvdH from comment #18) > So why not for temporary files for Dns::enter_helper_run_mode stuff? Maybe because I was up later than I should have been while still looking at this? :) This

[Bug 8050] [REVIEW] Fix global_state_dir on Windows

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050 --- Comment #23 from Sidney Markowitz --- It looks like for Windows the correct location to use in a Windows-version portable and future-proof way is Win32::GetFolderPath(Win32::CSIDL_COMMON_APPDATA) And then create a .spamassassin

[Bug 8051] [REVIEW] HeaderEval word_is_in_dictionary, deprecated triplets.txt usage

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8051 Henrik Krohns changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 8050] [REVIEW] Fix global_state_dir on Windows

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050 --- Comment #21 from RvdH --- 1. it was ONLY a issue when running spamassassin from command line (example: spamassassin --debug --lint) > It seems Util::portable_getpwuid sets "/" as user home on Windows. Not sure > if this is the best

[Bug 8050] [REVIEW] Fix global_state_dir on Windows

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050 --- Comment #22 from RvdH --- Still not tested, but to give you an idea what i mean sub set_global_state_dir { my ($self) = @_; # try home_dir_for_helpers my $helper_dir = $self->{home_dir_for_helpers} || ''; if ($helper_dir) {

[Bug 8050] [REVIEW] Fix global_state_dir on Windows

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050 --- Comment #25 from Sidney Markowitz --- (In reply to RvdH from comment #24) > That is also C:\ProgramData, not? That's what it is on my Windows 10 VM Does that seem like a sensible place to you? I'm not a real Windows user. -- You are

[Bug 8050] [REVIEW] Fix global_state_dir on Windows

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050 Sidney Markowitz changed: What|Removed |Added Attachment #5828|0 |1 is obsolete|

[Bug 8050] [REVIEW] Fix global_state_dir on Windows

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050 --- Comment #29 from Henrik Krohns --- (In reply to Henrik Krohns from comment #28) > So probably something like this works. > { require Win32; $home = > Win32::GetFolderPath(Win32::CSIDL_COMMON_APPDATA()); } I meant eval { require.. }

[Bug 8050] [REVIEW] Fix global_state_dir on Windows

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050 --- Comment #20 from Sidney Markowitz --- (In reply to Sidney Markowitz from comment #19) > So, should this code be ending up with .spamassassin in the C:\Users\USER\ > directory after all? Or, this sub is called set_global_state_dir so

[Bug 8049] DecodeShortURLs cache relative path

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8049 Henrik Krohns changed: What|Removed |Added CC||apa...@hege.li --- Comment #1 from

[Bug 8050] [REVIEW] Fix global_state_dir on Windows

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050 --- Comment #24 from RvdH --- That is also C:\ProgramData, not? -- You are receiving this mail because: You are the assignee for the bug.

[Bug 8050] [REVIEW] Fix global_state_dir on Windows

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050 --- Comment #26 from RvdH --- Yes, that is the perfect location for user independent data as mentioned above, eg: that is exactly what it's ment for :) -- You are receiving this mail because: You are the assignee for the bug.

[Bug 8050] [REVIEW] Fix global_state_dir on Windows

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050 --- Comment #28 from Henrik Krohns --- It certainly does require "use Win32" here, just like mentioned in https://perldoc.perl.org/Win32 STRAWBERRY C:\Strawberry>perl\bin\perl -e "print

[Bug 8049] DecodeShortURLs cache relative path

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8049 --- Comment #5 from Henrik Krohns --- (In reply to Matus UHLAR - fantomas from comment #4) > I don't trust any database if multiple users can access it. This makes no sense. The "user" is not accessing a database, the SA plugin code is.

[Bug 8049] DecodeShortURLs cache relative path

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8049 --- Comment #3 from Henrik Krohns --- It doesn't really make sense to cache such lookups on a per-user level. If you don't trust SQLite in shared location, then you should probably use mysql or postgres. Not sure why those settings aren't

[Bug 8049] DecodeShortURLs cache relative path

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8049 --- Comment #4 from Matus UHLAR - fantomas --- I don't trust any database if multiple users can access it. I believe constructing default url_shortener_cache_dsn setting to DBI:sqlite:~/.spamassassin/DecodeShortURLs.sqlite would benefit to

[Bug 8049] DecodeShortURLs cache relative path

2022-09-19 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8049 Matus UHLAR - fantomas changed: What|Removed |Added CC||uh...@fantomas.sk ---