Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r10531612
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
@@ -0,0 +1,1055 @@
+/*
+ * Licensed to the Apache Software
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r10461572
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/model/DecisionTreeModel.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r10461542
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
@@ -0,0 +1,1055 @@
+/*
+ * Licensed to the Apache Software
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/79#discussion_r10461519
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
@@ -0,0 +1,1055 @@
+/*
+ * Licensed to the Apache Software
Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-37262156
@mengxr Thanks for such a detailed review. The code is already in a much
better shape after incorporating your suggested changes. I have fixed the
straightforward code
Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-37213685
Thanks for another round of reviews @mengxr. I will fix these style issues,
answer your comments and add more documentation around the optimizations later
today
Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-36973041
@mengxr @hsaputra Thanks for the code style comments. I have made a lot of
effort to document the code. I guess I still need to make the code consistent
with the Spark
Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/79#issuecomment-36755664
Thanks Sean.
Multi-class classification and feature importances are important features
that will be added soon. We implemented a minimal feature set since we
GitHub user manishamde opened a pull request:
https://github.com/apache/spark/pull/79
MLI-1 Decision Trees
Joint work with @hirakendu, @etrain, @atalwalkar and @harsha2010.
Key features:
+ Supports binary classification and regression
+ Supports gini, entropy and
