Re: Quick sync: what goes in migration guide vs release notes?

2020-06-10 Thread Wenchen Fan
How about we treat the migration guide as a part of the release notes? e.g. in the "breaking changes" section, just point to the migration guide. Thus, we don't change what to put in the release notes, but just move the breaking changes to a sub-doc. On Thu, Jun 11, 2020 at 11:13 AM Sean Owen wr

Re: Quick sync: what goes in migration guide vs release notes?

2020-06-10 Thread Sean Owen
If you are proposing to keep all important changes in release notes as usual: Sure, add more to the migration guide, too. It can't hurt, going forward. But many release-note changes have not much more to say about migration. If you're proposing to not mention most things in the release notes, whic

Re: Quick sync: what goes in migration guide vs release notes?

2020-06-10 Thread Wenchen Fan
Yea we can't update the 3.0.0 migration guide now, but AFAIK we do mention most of the breaking changes there, except for the ML module. I think we can still put all the ML breaking changes in the release notes this time. But in the future, shall we put breaking changes in the migration guide? It a

Re: Quick sync: what goes in migration guide vs release notes?

2020-06-10 Thread Hyukjin Kwon
I think the proposal doesn't mean to don't add the JIRAs with release-notes into the release notes (?). People will still label the JIRAs when the change is significant or breaking whether it's a bug or not, and they will be in the release notes. I guess the proposal TL;DR is: - If that's a legit

Re: Quick sync: what goes in migration guide vs release notes?

2020-06-10 Thread Sean Owen
This seems like a change to current practice, as breaking changes are marked for release notes with release-notes, etc: https://spark.apache.org/contributing.html My only concrete concern, is this seems to imply (?) that many JIRAs with release-notes and Docs text are not going to get included in r

Re: Quick sync: what goes in migration guide vs release notes?

2020-06-10 Thread Wenchen Fan
My 2 cents: Since we have a migration guide, I think people who hit problems when upgrading Spark will read it. We should mention all the breaking changes there, except for trivial ones like obvious bug fixes. Even if there is no meaningful migration to guide for things like removing a deprecated

Quick sync: what goes in migration guide vs release notes?

2020-06-09 Thread Sean Owen
A few different takes surfaced: https://issues.apache.org/jira/browse/SPARK-26043?focusedCommentId=17128908&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17128908 No significant disagreements, just might be worth clarifying a consensus policy. "I feel this is a