Re: [DISCUSS] Resolve ambiguous parser rule between two "create table"s

2020-03-25 Thread Jungtaek Lim
Thanks, filed SPARK-31257 . Thanks again for looking into this - I'll take a look whenever I get time sooner. On Thu, Mar 26, 2020 at 8:06 AM Ryan Blue wrote: > Feel free to open another issue, I just used that one since it describes > this and

Re: [DISCUSS] Resolve ambiguous parser rule between two "create table"s

2020-03-25 Thread Ryan Blue
Feel free to open another issue, I just used that one since it describes this and doesn't appear to be done. On Wed, Mar 25, 2020 at 4:03 PM Jungtaek Lim wrote: > UPDATE: Sorry I just missed the PR ( > https://github.com/apache/spark/pull/28026). I still think it'd be nice > to avoid recycling

Re: [DISCUSS] Resolve ambiguous parser rule between two "create table"s

2020-03-25 Thread Ryan Blue
Here's a WIP PR with the basic changes: https://github.com/apache/spark/pull/28026 I still need to update tests in that branch and add the conversions to the old Hive plans. But at least you can see how the parser part works and how I'm converting the extra clauses for DSv2. This also enables us

Re: [DISCUSS] Resolve ambiguous parser rule between two "create table"s

2020-03-25 Thread Jungtaek Lim
UPDATE: Sorry I just missed the PR ( https://github.com/apache/spark/pull/28026). I still think it'd be nice to avoid recycling the JIRA issue which was resolved before. Shall we have a new JIRA issue with linking to SPARK-30098, and set proper priority? On Thu, Mar 26, 2020 at 7:59 AM Jungtaek

Re: [DISCUSS] Resolve ambiguous parser rule between two "create table"s

2020-03-25 Thread Jungtaek Lim
Would it be better to prioritize this to make sure the change is included in Spark 3.0? (Maybe filing an issue and set as a blocker) Looks like there's consensus that SPARK-30098 brought ambiguous issue which should be fixed (though the consideration of severity seems to be different), and once