Re: The Myth: the forked Hive 1.2.1 is stabler than XXX

2019-11-22 Thread Dongjoon Hyun
Thank you, Steve and all. As a conclusion of this thread, we will merge the following PR and move forward. [SPARK-29981][BUILD] Add hive-1.2/2.3 profiles https://github.com/apache/spark/pull/26619 Please leave your comments if you have any concern. And, the following PRs and more will

Re: The Myth: the forked Hive 1.2.1 is stabler than XXX

2019-11-22 Thread Steve Loughran
On Thu, Nov 21, 2019 at 12:53 AM Dongjoon Hyun wrote: > Thank you for much thoughtful clarification. I agree with your all options. > > Especially, for Hive Metastore connection, `Hive isolated client loader` > is also important with Hive 2.3 because Hive 2.3 client cannot talk with > Hive 2.1

Re: The Myth: the forked Hive 1.2.1 is stabler than XXX

2019-11-20 Thread Dongjoon Hyun
t;>>>> the other hand, the Hive 1.2 integration code path in Spark has been >>>>> battle-tested for years. Yes, there are issues, but people have learned >>>>> how >>>>> to get along with these issues. And please don't forget that, for Spark &

Re: The Myth: the forked Hive 1.2.1 is stabler than XXX

2019-11-20 Thread Cheng Lian
ract with this Hive 1.2 fork, they >>>> can always use Hive 2.3 at their own risks. >>>> >>>> True, "stable" is quite vague a criterion, and hard to be proven. But >>>> that is exactly the reason why we may want to be conservative and wait for &

Re: The Myth: the forked Hive 1.2.1 is stabler than XXX

2019-11-20 Thread Cheng Lian
t; is quite vague a criterion, and hard to be proven. But >>> that is exactly the reason why we may want to be conservative and wait for >>> some time and see whether there are further signals suggesting that the >>> Hive 2.3 integration in Spark 3.0 is *unstable*. After on

Re: The Myth: the forked Hive 1.2.1 is stabler than XXX

2019-11-20 Thread Cheng Lian
l the outstanding issues and no more >> significant ones are showing up, we can declare that the Hive 2.3 >> integration in Spark 3.x is stable, and then we can consider removing >> reference to the Hive 1.2 fork. Does that make sense? >> >> Cheng >> >> O

Re: The Myth: the forked Hive 1.2.1 is stabler than XXX

2019-11-20 Thread Dongjoon Hyun
gt;> Just to add - hive 1.2 fork is definitely not more stable. We know of a >> few critical bug fixes that we cherry picked into a fork of that fork to >> maintain ourselves. >> >> >> ------ >> *From:* Dongjoon Hyun >> *Sent:* Wednesday, November 20, 2019 11:

Re: The Myth: the forked Hive 1.2.1 is stabler than XXX

2019-11-20 Thread Cheng Lian
add - hive 1.2 fork is definitely not more stable. We know of a > few critical bug fixes that we cherry picked into a fork of that fork to > maintain ourselves. > > > -- > *From:* Dongjoon Hyun > *Sent:* Wednesday, November 20, 2019 11:07:47 AM > *

Re: The Myth: the forked Hive 1.2.1 is stabler than XXX

2019-11-20 Thread Felix Cheung
Subject: Re: The Myth: the forked Hive 1.2.1 is stabler than XXX Thanks. That will be a giant step forward, Sean! > I'd prefer making it the default in the POM for 3.0. Bests, Dongjoon. On Wed, Nov 20, 2019 at 11:02 AM Sean Owen mailto:sro...@gmail.com>> wrote: Yeah 'stable' is ambiguous.

Re: The Myth: the forked Hive 1.2.1 is stabler than XXX

2019-11-20 Thread Dongjoon Hyun
Thanks. That will be a giant step forward, Sean! > I'd prefer making it the default in the POM for 3.0. Bests, Dongjoon. On Wed, Nov 20, 2019 at 11:02 AM Sean Owen wrote: > Yeah 'stable' is ambiguous. It's old and buggy, but at least it's the > same old and buggy that's been there a while.

The Myth: the forked Hive 1.2.1 is stabler than XXX

2019-11-20 Thread Dongjoon Hyun
Hi, All. I'm sending this email because it's important to discuss this topic narrowly and make a clear conclusion. `The forked Hive 1.2.1 is stable`? It sounds like a myth we created by ignoring the existing bugs. If you want to say the forked Hive 1.2.1 is stabler than XXX, please give us the