[GitHub] incubator-spark pull request: MLLIB-25: Implicit ALS runs out of m...

2014-02-23 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/incubator-spark/pull/629#issuecomment-35835626 @srowen good catch, thanks Sean. Didn't really think about this when I wrote it. Shows that testing on larger scale input data / params is always req

[GitHub] incubator-spark pull request: MLLIB-22. Support negative implicit ...

2014-02-19 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/incubator-spark/pull/500#issuecomment-35595951 @rxin can we look at merging this in? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. To do so

[GitHub] incubator-spark pull request: [Proposal] Adding sparse data suppor...

2014-02-18 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/incubator-spark/pull/575#issuecomment-35443064 @mengxr <https://github.com/mengxr> ok, that is interesting. I have always advocated for Breeze, but was told 6 months ago that it was a non-starter

[GitHub] incubator-spark pull request: [Proposal] Adding sparse data suppor...

2014-02-18 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/incubator-spark/pull/575#issuecomment-35438611 @mengxr <https://github.com/mengxr> at the risk of adding to your workload... I think (license issues aside since I suppose both Breeze and M

[GitHub] incubator-spark pull request: [Proposal] Adding sparse data suppor...

2014-02-14 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/incubator-spark/pull/575#issuecomment-35070192 I for one would prefer to use netlib-java, whether it is via MTJ or Breeze. I've used both and find the MTJ API pretty good and with good sparse su

[GitHub] incubator-spark pull request: [Proposal] Adding sparse data suppor...

2014-02-13 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/incubator-spark/pull/575#issuecomment-35055610 Originally sent this to dev list not github - the autopsy emails are a bit confusing on mobile :) @fommil @mengxr I think it's a

[GitHub] incubator-spark pull request: [Proposal] Adding sparse data suppor...

2014-02-13 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/incubator-spark/pull/575#issuecomment-35015689 I guess we should discuss on the JIRA ideally, but most of the discussion seems to be here. So I'll comment here. I've chimed in before in th

[GitHub] incubator-spark pull request: Support negative implicit input in A...

2014-02-09 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/incubator-spark/pull/500#issuecomment-34568750 This looks like a nice simple extension that gives some very useful functionality for practical use cases. Indeed it doesn't have any impact on the exi

[GitHub] incubator-spark pull request: [PySpark] Adding support for Sequenc...

2014-02-08 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/incubator-spark/pull/263#issuecomment-34546862 @laserson sorry this has gone quiet as I have been totally slammed with work stuff! From my side I just need to clean up some of @JoshRosen comments