[jira] [Commented] (SQOOP-842) Sqoop2: Put partition to template in Extractor as well

2013-01-30 Thread Cheolsoo Park (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13567044#comment-13567044 ] Cheolsoo Park commented on SQOOP-842: - +1. Sqoop2: Put partition to

Re: Review Request: SQOOP-843 Sqoop2: Generic JDBC connector is committing transaction on export with autoCommit on

2013-01-30 Thread Cheolsoo Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9069/#review15896 --- Ship it! Ship It! - Cheolsoo Park On Jan. 23, 2013, 5:38 p.m.,

Re: Review Request: SQOOP-845 Sqoop2: Improve Generic JDBC validator

2013-01-30 Thread Cheolsoo Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9070/#review15897 --- Looks good overall. I have suggestions regarding error messages as

Re: Review Request: SQOOP-841 Sqoop2: Remove final keyword from manager classes

2013-01-30 Thread Cheolsoo Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9067/#review15901 --- Ship it! Ship It! - Cheolsoo Park On Jan. 23, 2013, 4:32 p.m.,

[jira] [Commented] (SQOOP-841) Sqoop2: Remove final keyword from manager classes

2013-01-30 Thread Cheolsoo Park (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13567085#comment-13567085 ] Cheolsoo Park commented on SQOOP-841: - +1. I will commit it after running tests.

[jira] [Updated] (SQOOP-854) pg_bulkload: Return value of pg_bulkload utility is being ignored

2013-01-30 Thread Jarek Jarcec Cecho (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Jarcec Cecho updated SQOOP-854: - Attachment: bugSQOOP-854.patch pg_bulkload: Return value of pg_bulkload utility is

Re: Review Request: SQOOP-851 Sqoop2: NullPointerException in Mapreduce Submission engine initialization

2013-01-30 Thread Cheolsoo Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9076/#review15902 ---

[jira] [Commented] (SQOOP-852) Sqoop2: Mapreduce submission engine is not closing opened JobClient object

2013-01-30 Thread Cheolsoo Park (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13567107#comment-13567107 ] Cheolsoo Park commented on SQOOP-852: - +1. LGTM. Will commit it after running tests.

[jira] [Commented] (SQOOP-854) pg_bulkload: Return value of pg_bulkload utility is being ignored

2013-01-30 Thread Cheolsoo Park (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13567110#comment-13567110 ] Cheolsoo Park commented on SQOOP-854: - +1. pg_bulkload: Return value

Re: Review Request: SQOOP-854 pg_bulkload: Return value of pg_bulkload utility is being ignored

2013-01-30 Thread Venkat Ranganathan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9167/#review15905 --- Ship it! Hi Jarcec +1 It is a good catch and the fix looks good.

[jira] [Created] (SQOOP-855) pg_bulkload: NullPointerException will be thrown if user specified invalid path the binary

2013-01-30 Thread Jarek Jarcec Cecho (JIRA)
Jarek Jarcec Cecho created SQOOP-855: Summary: pg_bulkload: NullPointerException will be thrown if user specified invalid path the binary Key: SQOOP-855 URL: https://issues.apache.org/jira/browse/SQOOP-855

Re: Review Request: SQOOP-854 pg_bulkload: Return value of pg_bulkload utility is being ignored

2013-01-30 Thread Jarek Cecho
On Jan. 30, 2013, 11:54 p.m., Venkat Ranganathan wrote: Hi Jarcec +1 It is a good catch and the fix looks good. Should the Interruptedexception be ignored? I know it is not part of this JIRA, but I am wondering we should log for that also. I can create another JIRA if you think

Re: Review Request: SQOOP-855 pg_bulkload: NullPointerException will be thrown if user specified invalid path the binary

2013-01-30 Thread Cheolsoo Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9168/#review15909 --- Ship it! Ship It! - Cheolsoo Park On Jan. 30, 2013, 11:59 p.m.,

[jira] [Commented] (SQOOP-855) pg_bulkload: NullPointerException will be thrown if user specified invalid path the binary

2013-01-30 Thread Cheolsoo Park (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13567167#comment-13567167 ] Cheolsoo Park commented on SQOOP-855: - +1. LGTM. pg_bulkload:

[jira] [Commented] (SQOOP-855) pg_bulkload: NullPointerException will be thrown if user specified invalid path the binary

2013-01-30 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13567278#comment-13567278 ] Hudson commented on SQOOP-855: -- Integrated in Sqoop-ant-jdk-1.6-hadoop23 #731 (See

[jira] [Commented] (SQOOP-854) pg_bulkload: Return value of pg_bulkload utility is being ignored

2013-01-30 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13567281#comment-13567281 ] Hudson commented on SQOOP-854: -- Integrated in Sqoop-ant-jdk-1.6-hadoop20 #536 (See

[jira] [Commented] (SQOOP-841) Sqoop2: Remove final keyword from manager classes

2013-01-30 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13567289#comment-13567289 ] Hudson commented on SQOOP-841: -- Integrated in Sqoop2-hadoop200 #171 (See

[jira] [Commented] (SQOOP-855) pg_bulkload: NullPointerException will be thrown if user specified invalid path the binary

2013-01-30 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13567294#comment-13567294 ] Hudson commented on SQOOP-855: -- Integrated in Sqoop-ant-jdk-1.6-hadoop200 #536 (See

[jira] [Commented] (SQOOP-852) Sqoop2: Mapreduce submission engine is not closing opened JobClient object

2013-01-30 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13567295#comment-13567295 ] Hudson commented on SQOOP-852: -- Integrated in Sqoop2-hadoop100 #157 (See

[jira] [Commented] (SQOOP-842) Sqoop2: Put partition to template in Extractor as well

2013-01-30 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13567298#comment-13567298 ] Hudson commented on SQOOP-842: -- Integrated in Sqoop2-hadoop100 #157 (See

[jira] [Commented] (SQOOP-855) pg_bulkload: NullPointerException will be thrown if user specified invalid path the binary

2013-01-30 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13567312#comment-13567312 ] Hudson commented on SQOOP-855: -- Integrated in Sqoop-ant-jdk-1.6-hadoop100 #537 (See

Re: Review Request: BigDecimals converted to String in inconsistent format

2013-01-30 Thread David Robson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9081/ --- (Updated Jan. 31, 2013, 5:28 a.m.) Review request for Sqoop. Changes ---

[jira] [Updated] (SQOOP-830) HBase import formatting BigDecimal inconsistently

2013-01-30 Thread David Robson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Robson updated SQOOP-830: --- Attachment: SQOOP-830.patch HBase import formatting BigDecimal inconsistently