Re: Review Request 62492: SQOOP-3224: Mainframe FTP transfer should have an option to use binary mode for transfer

2017-12-13 Thread Chris Teoh
> On Dec. 1, 2017, 3:25 p.m., Szabolcs Vasas wrote: > > src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java > > Line 86 (original), 89 (patched) > > > > > > Do you think we could introduce a new FileLayout

Re: Review Request 64417: SQOOP-3153 Sqoop export with --as- error message could be more verbose

2017-12-13 Thread Fero Szabo via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64417/ --- (Updated Dec. 13, 2017, 11:19 a.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 64251: SQOOP-3266: Update 3rd party and manual test running related info in COMPILING.txt

2017-12-13 Thread Boglarka Egyed
> On Dec. 13, 2017, 10:17 a.m., Szabolcs Vasas wrote: > > COMPILING.txt > > Lines 147 (patched) > > > > > > I think the correct parameter name here is ms.sqlserver.username, can > > you please double check? You

Re: Review Request 64251: SQOOP-3266: Update 3rd party and manual test running related info in COMPILING.txt

2017-12-13 Thread Boglarka Egyed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64251/ --- (Updated Dec. 13, 2017, 10:59 a.m.) Review request for Sqoop, Fero Szabo and

Re: Review Request 64251: SQOOP-3266: Update 3rd party and manual test running related info in COMPILING.txt

2017-12-13 Thread Szabolcs Vasas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64251/#review193660 --- Hi Bogi, Thank you for filling this gap in our documentation, I

Re: Review Request 64417: SQOOP-3153 Sqoop export with --as- error message could be more verbose

2017-12-13 Thread Szabolcs Vasas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64417/#review193657 --- Hi Feró, Thank you for the patch and for the nice description on