Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54699/ --- (Updated Dec. 16, 2016, 11:24 a.m.) Review request for Sqoop, Attila Szabo and

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54699/#review159427 --- Fix it, then Ship it! Hi Anna, Thanks for spotting this

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54699/#review159422 --- Ship it! Ship It! - Boglarka Egyed On Dec. 14, 2016, 11:50

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54699/#review159420 --- Ship it! Thanks for adding testing too! - Erzsebet Szilagyi

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54699/ --- (Updated Dec. 14, 2016, 11:50 a.m.) Review request for Sqoop, Attila Szabo and

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54699/#review159134 ---

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54699/#review159129 --- src/java/org/apache/sqoop/SqoopOptions.java (line 2735)

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54699/ --- (Updated Dec. 14, 2016, 10:14 a.m.) Review request for Sqoop, Attila Szabo and

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54699/ --- (Updated Dec. 14, 2016, 9:52 a.m.) Review request for Sqoop, Attila Szabo and

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

> On Dec. 13, 2016, 3:27 p.m., Szabolcs Vasas wrote: > > src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java, line 81 > > > > > > Is the tableName already escaped or shall we invoke > >

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

> On Dec. 13, 2016, 2:37 p.m., Erzsebet Szilagyi wrote: > > Thank you! This change really makes our code base more consistent and safer > > to change later. > > Did you consider expanding our tests along this change? +1 Thanks for this improvement, Anna! I would also suggest to add specific

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54699/#review159010 ---

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54699/#review159003 --- Thank you! This change really makes our code base more consistent

Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54699/ --- Review request for Sqoop, Attila Szabo and Szabolcs Vasas. Bugs: SQOOP-3081