Re: Review Request 55132: support for DB2 XML data type when importing to hdfs

2017-02-24 Thread Attila Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55132/#review10 --- Ship it! Hey Ying Cao, Both implementation and testing looks

Re: Review Request 55132: support for DB2 XML data type when importing to hdfs

2017-02-23 Thread Ying Cao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55132/ --- (Updated 二月 24, 2017, 6:56 a.m.) Review request for Sqoop, Abraham Elmahrek

Re: Review Request 55132: support for DB2 XML data type when importing to hdfs

2017-02-23 Thread Szabolcs Vasas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55132/#review166509 --- Hi Ying, Thank you for the patch! I think the code you added

Re: Review Request 55132: support for DB2 XML data type when importing to hdfs

2017-02-09 Thread Ying Cao
> On 二月 8, 2017, 10:25 p.m., Abraham Elmahrek wrote: > > Hi Abraham Elmahrek, Thanks for your comments Angela - Ying --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55132/#review164793

Re: Review Request 55132: support for DB2 XML data type when importing to hdfs

2017-02-08 Thread Ying Cao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55132/ --- (Updated 二月 9, 2017, 3:39 a.m.) Review request for Sqoop, Abraham Elmahrek and

Re: Review Request 55132: support for DB2 XML data type when importing to hdfs

2017-02-08 Thread Ying Cao
> On 二月 8, 2017, 10:25 p.m., Abraham Elmahrek wrote: > > src/java/org/apache/sqoop/manager/Db2Manager.java, line 176 > > > > > > Is this a Hive specific type? Or a Java specific type? Hi Abraham Elmahrek, Thanks

Re: Review Request 55132: support for DB2 XML data type when importing to hdfs

2017-02-08 Thread Abraham Elmahrek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55132/#review164793 --- src/java/org/apache/sqoop/manager/Db2Manager.java (line 176)

Re: Review Request 55132: support for DB2 XML data type when importing to hdfs

2017-02-05 Thread Ying Cao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55132/ --- (Updated 二月 6, 2017, 3:19 a.m.) Review request for Sqoop, Abraham Elmahrek and

Re: Review Request 55132: support for DB2 XML data type when importing to hdfs

2017-01-25 Thread Boglarka Egyed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55132/#review162941 --- Hi Ying, I have one last minor finding, please correct it.

Re: Review Request 55132: support for DB2 XML data type when importing to hdfs

2017-01-22 Thread Ying Cao
> On 一月 18, 2017, 5:52 p.m., Boglarka Egyed wrote: > > src/java/org/apache/sqoop/manager/Db2Manager.java, line 53 > > > > > > Thanks for creating a constant for this, however, it would be great to > > check if there

Re: Review Request 55132: support for DB2 XML data type when importing to hdfs

2017-01-22 Thread Ying Cao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55132/ --- (Updated 一月 23, 2017, 6:17 a.m.) Review request for Sqoop, Abraham Elmahrek

Re: Review Request 55132: support for DB2 XML data type when importing to hdfs

2017-01-18 Thread Boglarka Egyed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55132/#review162140 --- Hi Angela, Thank you for the corrections, I have two more

Re: Review Request 55132: support for DB2 XML data type when importing to hdfs

2017-01-13 Thread Ying Cao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55132/ --- (Updated 一月 13, 2017, 9:46 a.m.) Review request for Sqoop, Abraham Elmahrek

Re: Review Request 55132: support for DB2 XML data type when importing to hdfs

2017-01-08 Thread Boglarka Egyed
> On Jan. 8, 2017, 12:57 p.m., Boglarka Egyed wrote: > > Hi Ying, I have some findings regarding your change, please find them below. Thanks, Bogi - Boglarka --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 55132: support for DB2 XML data type when importing to hdfs

2017-01-08 Thread Boglarka Egyed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55132/#review160508 --- src/java/org/apache/sqoop/manager/Db2Manager.java (line 144)

Review Request 55132: support for DB2 XML data type when importing to hdfs

2017-01-03 Thread Ying Cao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55132/ --- Review request for Sqoop, Abraham Elmahrek and Jarek Cecho. Bugs: SQOOP-1904