Re: Review Request 68032: SQOOP-3352: Bump java target version to 1.8

2018-07-25 Thread Fero Szabo via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68032/#review206442 --- Ship it! Ship It! - Fero Szabo On July 25, 2018, 9:43 a.m.,

Re: Review Request 68032: SQOOP-3352: Bump java target version to 1.8

2018-07-25 Thread Boglarka Egyed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68032/ --- (Updated July 25, 2018, 9:43 a.m.) Review request for Sqoop, Fero Szabo and

Re: Review Request 68032: SQOOP-3352: Bump java target version to 1.8

2018-07-25 Thread Szabolcs Vasas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68032/#review206441 --- Ship it! Ship It! - Szabolcs Vasas On July 25, 2018, 9:43

Re: Review Request 68032: SQOOP-3352: Bump java target version to 1.8

2018-07-25 Thread Boglarka Egyed
> On July 24, 2018, 4:12 p.m., Szabolcs Vasas wrote: > > COMPILING.txt > > Line 30 (original), 30 (patched) > > > > > > I have just realized that Ant 1.7.1 probably does not support Java 8, > > so this number should

Re: Review Request 68032: SQOOP-3352: Bump java target version to 1.8

2018-07-24 Thread Szabolcs Vasas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68032/#review206392 --- COMPILING.txt Line 30 (original), 30 (patched)

Re: Review Request 68032: SQOOP-3352: Bump java target version to 1.8

2018-07-24 Thread Szabolcs Vasas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68032/#review206391 --- Ship it! Ship It! - Szabolcs Vasas On July 24, 2018, 3:50

Re: Review Request 68032: SQOOP-3352: Bump java target version to 1.8

2018-07-24 Thread Boglarka Egyed
> On July 24, 2018, 3:36 p.m., Szabolcs Vasas wrote: > > Hi Bogi, > > > > Thanks for submitting this patch, it will be great to use the Java 8 > > features in Sqoop finally. > > > > I have left a minor comment and apart from that we should remove > > '-XX:PermSize=256m',

Re: Review Request 68032: SQOOP-3352: Bump java target version to 1.8

2018-07-24 Thread Boglarka Egyed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68032/ --- (Updated July 24, 2018, 3:50 p.m.) Review request for Sqoop, Fero Szabo and

Re: Review Request 68032: SQOOP-3352: Bump java target version to 1.8

2018-07-24 Thread Szabolcs Vasas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68032/#review206388 --- Hi Bogi, Thanks for submitting this patch, it will be great to

Review Request 68032: SQOOP-3352: Bump java target version to 1.8

2018-07-24 Thread Boglarka Egyed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68032/ --- Review request for Sqoop, Fero Szabo and Szabolcs Vasas. Bugs: SQOOP-3352