Re: Sqoop build infrastructure improvements

2018-12-10 Thread Szabolcs Vasas
Hi Attila, Thanks for raising this, I think it is a great idea to migrate as soon as possible, I have started a separate mail chain which can be used as a proof of community consensus. On Sun, Dec 9, 2018 at 9:48 PM Attila Szabó wrote: > Hello everyone, > > So if I'm not mistaken and according

Re: Sqoop build infrastructure improvements

2018-12-09 Thread Attila Szabó
Hello everyone, So if I'm not mistaken and according to the INFRA mail we've received during the weekend gitbox.apache.org is exactly what we wanted to have : Having both ASF commits and push privileges on Github side.. We would just need to have an official consensus in the dev community (

Re: Sqoop build infrastructure improvements

2018-11-30 Thread Szabolcs Vasas
Thanks for the question, I think we should stick to the commit format we had earlier so yes, we should go for squash and push. The easiest solution could be to download the diff file instead of the patch (e.g. https://github.com/apache/sqoop/pull/60.diff instead of

Re: Sqoop build infrastructure improvements

2018-11-30 Thread Attila Szabó
Hey Szabi, Thanks for the prompt response! I've thought the repos are connected back and forth and the close PR is the official way. In case of we still stack to the patch file and git apply then commit and push approach. My only question in this case : Do we have any agreement on how we commit

Re: Sqoop build infrastructure improvements

2018-11-30 Thread Szabolcs Vasas
Hi Attila, I think we won't be able to commit the pull requests on GitHub directly because our GitHub repo is just a mirror of the original Apache Sqoop repo . However the commit process is still simplified, the ASF GitHub Bot JIRA comment

Re: Sqoop build infrastructure improvements

2018-11-29 Thread Attila Szabó
Hi Szabi, First of all: Big Kudos for the more mature gradle build! I think this is a great step for the whole project! On the front of PRs: I would only make it official if the user management / authorization handling could be somehow automatically bound to the id.apache.org + project

Re: Sqoop build infrastructure improvements

2018-11-29 Thread Boglarka Egyed
Thank you Szabolcs for driving these efforts! +1 for using pull requests from now. Thanks, Bogi On Wed, Nov 28, 2018 at 4:54 PM Szabolcs Vasas wrote: > Dear Sqoop community, > > We have been working on quite a few exciting build infrastructure > improvements recently, I am sending this email

Sqoop build infrastructure improvements

2018-11-28 Thread Szabolcs Vasas
Dear Sqoop community, We have been working on quite a few exciting build infrastructure improvements recently, I am sending this email to summarize them. *Gradle can now execute all the Sqoop tests in a single JVM* This improvement makes the Gradle test tasks significantly faster since we do not