[jira] [Commented] (SQOOP-3171) Import as parquet jobs failed randomly while multiple jobs concurrently importing into targets with same parent

2018-03-26 Thread Xiaomin Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/SQOOP-3171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415010#comment-16415010
 ] 

Xiaomin Zhang commented on SQOOP-3171:
--

[~sanysand...@gmail.com] KITE-1155 is fixed upstream, however I don't see the 
fix version for KITE-1155.  Can we just update the dependency for Sqoop to 
include the Kite fix?  Thanks.

> Import as parquet jobs failed randomly while multiple jobs concurrently 
> importing into targets with same parent
> ---
>
> Key: SQOOP-3171
> URL: https://issues.apache.org/jira/browse/SQOOP-3171
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Xiaomin Zhang
>Assignee: Sandish Kumar HN
>Priority: Major
>
> Running multiple parquet import jobs concurrently into below target 
> directories:
> hdfs://ns/path/dataset1
> hdfs://ns/path/dataset2
> In some cases, one of the sqoop job will be failed with below error:
> 17/03/19 08:21:21 INFO mapreduce.Job: Job job_1488289274600_188649 failed 
> with state FAILED due to: Job commit failed: 
> org.kitesdk.data.DatasetIOException: Could not cleanly delete 
> path:hdfs://ns/path/.temp/job_1488289274600_188649
> at 
> org.kitesdk.data.spi.filesystem.FileSystemUtil.cleanlyDelete(FileSystemUtil.java:239)
> at 
> org.kitesdk.data.spi.filesystem.TemporaryFileSystemDatasetRepository.delete(TemporaryFileSystemDatasetRepository.java:61)
> at 
> org.kitesdk.data.mapreduce.DatasetKeyOutputFormat$MergeOutputCommitter.commitJob(DatasetKeyOutputFormat.java:395)
> at 
> org.apache.hadoop.mapreduce.v2.app.commit.CommitterEventHandler$EventProcessor.handleJobCommit(CommitterEventHandler.java:274)
> at 
> org.apache.hadoop.mapreduce.v2.app.commit.CommitterEventHandler$EventProcessor.run(CommitterEventHandler.java:237)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.io.FileNotFoundException: File hdfs://ns/path/.temp does not 
> exist.
> at 
> org.apache.hadoop.hdfs.DistributedFileSystem.listStatusInternal(DistributedFileSystem.java:705)
> at 
> org.apache.hadoop.hdfs.DistributedFileSystem.access$600(DistributedFileSystem.java:106)
> at 
> org.apache.hadoop.hdfs.DistributedFileSystem$15.doCall(DistributedFileSystem.java:763)
> at 
> org.apache.hadoop.hdfs.DistributedFileSystem$15.doCall(DistributedFileSystem.java:759)
> at 
> org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)
> at 
> org.apache.hadoop.hdfs.DistributedFileSystem.listStatus(DistributedFileSystem.java:759)
> at 
> org.kitesdk.data.spi.filesystem.FileSystemUtil.cleanlyDelete(FileSystemUtil.java:226)
> This is due to:
> https://issues.cloudera.org/browse/KITE-1155



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 66282: Mock ConnManager field in TestTableDefWriter

2018-03-26 Thread daniel voros

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66282/#review199972
---


Ship it!




Nice addition, ship it!

- daniel voros


On March 26, 2018, 2:02 p.m., Szabolcs Vasas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66282/
> ---
> 
> (Updated March 26, 2018, 2:02 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3308
> https://issues.apache.org/jira/browse/SQOOP-3308
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> This patch removes the externalColTypes field from TableDefWriter since it 
> was only used for testing purposes.
> TestTableDefWriter is fixed to mock the ConnManager object provided to the 
> TableDefWriter constructor and a minor refactoring is done on the class.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/hive/TableDefWriter.java e1424c383 
>   src/test/org/apache/sqoop/hive/TestTableDefWriter.java 496b5add9 
> 
> 
> Diff: https://reviews.apache.org/r/66282/diff/3/
> 
> 
> Testing
> ---
> 
> ant clean test
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>



Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build for Sqoop to make it more developer friendly / open

2018-03-26 Thread Anna Szonyi via Review Board


> On March 25, 2018, 7:15 p.m., Boglarka Egyed wrote:
> > Hi Anna,
> > 
> > I did some deeper testing with your change and found that the number of run 
> > 3rd party test cases in case of ant and gradle are different: 782 test 
> > cases run with ant but only 595 with gradle. I didn't check all the details 
> > but for example with ant 71 test cases runs in 
> > SQLServerDatatypeImportSequenceFileTest test class but 0 with gradle. Could 
> > you please check this?
> > 
> > I also have some minor comments again.
> > 
> > Otherwise your change looks very good in general, huge thanks for preparing 
> > this patch!
> > 
> > Many thanks,
> > Bogi
> 
> daniel voros wrote:
> Hi,
> 
> I can second Bogi. These are missing tests:
> ```
> 
> org.apache.sqoop.manager.sqlserver.SQLServerDatatypeExportDelimitedFileTest
> org.apache.sqoop.manager.sqlserver.SQLServerDatatypeExportSequenceFileTest
> 
> org.apache.sqoop.manager.sqlserver.SQLServerDatatypeImportDelimitedFileTest
> org.apache.sqoop.manager.sqlserver.SQLServerDatatypeImportSequenceFileTest
> ```
> 
> They've all failed in their setup phase with similar errors:
> 
> ```
> 2018-03-26 09:31:17,481 (Test worker) [ERROR - 
> org.apache.sqoop.manager.sqlserver.SQLServerDatatypeImportSequenceFileTest.(SQLServerDatatypeImportSequenceFileTest.java:88)]
>  java.io.FileNotFoundException: /Users/dvoros/repos/sqoop-tmp/testdata/null 
> (No such file or directory)
> at java.io.FileInputStream.open0(Native Method)
> at java.io.FileInputStream.open(FileInputStream.java:195)
> at java.io.FileInputStream.(FileInputStream.java:138)
> at java.io.FileInputStream.(FileInputStream.java:93)
> at java.io.FileReader.(FileReader.java:58)
> at 
> org.apache.sqoop.manager.sqlserver.MSSQLTestDataFileParser.parse(MSSQLTestDataFileParser.java:62)
> at 
> org.apache.sqoop.manager.sqlserver.SQLServerDatatypeImportSequenceFileTest.(SQLServerDatatypeImportSequenceFileTest.java:85)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at 
> org.junit.runners.BlockJUnit4ClassRunner.createTest(BlockJUnit4ClassRunner.java:217)
> at 
> org.junit.runners.BlockJUnit4ClassRunner$1.runReflectiveCall(BlockJUnit4ClassRunner.java:266)
> at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at 
> org.junit.runners.BlockJUnit4ClassRunner.methodBlock(BlockJUnit4ClassRunner.java:263)
> at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at 
> org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at 
> org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
> at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
> at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
> at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
> at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
> at com.sun.proxy.$Proxy2.processTestClass(Unknown 

Re: Review Request 66282: Mock ConnManager field in TestTableDefWriter

2018-03-26 Thread Szabolcs Vasas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66282/
---

(Updated March 26, 2018, 2:02 p.m.)


Review request for Sqoop.


Bugs: SQOOP-3308
https://issues.apache.org/jira/browse/SQOOP-3308


Repository: sqoop-trunk


Description
---

This patch removes the externalColTypes field from TableDefWriter since it was 
only used for testing purposes.
TestTableDefWriter is fixed to mock the ConnManager object provided to the 
TableDefWriter constructor and a minor refactoring is done on the class.


Diffs (updated)
-

  src/java/org/apache/sqoop/hive/TableDefWriter.java e1424c383 
  src/test/org/apache/sqoop/hive/TestTableDefWriter.java 496b5add9 


Diff: https://reviews.apache.org/r/66282/diff/3/

Changes: https://reviews.apache.org/r/66282/diff/2-3/


Testing
---

ant clean test


Thanks,

Szabolcs Vasas



[jira] [Updated] (SQOOP-3308) Mock ConnManager field in TestTableDefWriter

2018-03-26 Thread Szabolcs Vasas (JIRA)

 [ 
https://issues.apache.org/jira/browse/SQOOP-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Szabolcs Vasas updated SQOOP-3308:
--
Attachment: SQOOP-3308.patch

> Mock ConnManager field in TestTableDefWriter
> 
>
> Key: SQOOP-3308
> URL: https://issues.apache.org/jira/browse/SQOOP-3308
> Project: Sqoop
>  Issue Type: Sub-task
>Affects Versions: 1.5.0
>Reporter: Szabolcs Vasas
>Assignee: Szabolcs Vasas
>Priority: Major
> Attachments: SQOOP-3308.patch, SQOOP-3308.patch, SQOOP-3308.patch
>
>
> TableDefWriter has a dependency on ConnManager to retrieve the names and the 
> types of the table. It also introduces a field called _externalColTypes_ for 
> testing purposes and TestTableDefWriter uses this field to inject the test 
> table column names and types instead of mocking the ConnManager field.
> This setup makes it harder to add test cases to TestTableDefWriter and not a 
> good practice so it should be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SQOOP-3308) Mock ConnManager field in TestTableDefWriter

2018-03-26 Thread Szabolcs Vasas (JIRA)

 [ 
https://issues.apache.org/jira/browse/SQOOP-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Szabolcs Vasas updated SQOOP-3308:
--
Attachment: SQOOP-3308.patch

> Mock ConnManager field in TestTableDefWriter
> 
>
> Key: SQOOP-3308
> URL: https://issues.apache.org/jira/browse/SQOOP-3308
> Project: Sqoop
>  Issue Type: Sub-task
>Affects Versions: 1.5.0
>Reporter: Szabolcs Vasas
>Assignee: Szabolcs Vasas
>Priority: Major
> Attachments: SQOOP-3308.patch, SQOOP-3308.patch
>
>
> TableDefWriter has a dependency on ConnManager to retrieve the names and the 
> types of the table. It also introduces a field called _externalColTypes_ for 
> testing purposes and TestTableDefWriter uses this field to inject the test 
> table column names and types instead of mocking the ConnManager field.
> This setup makes it harder to add test cases to TestTableDefWriter and not a 
> good practice so it should be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 66282: Mock ConnManager field in TestTableDefWriter

2018-03-26 Thread Szabolcs Vasas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66282/
---

(Updated March 26, 2018, 1:58 p.m.)


Review request for Sqoop.


Bugs: SQOOP-3308
https://issues.apache.org/jira/browse/SQOOP-3308


Repository: sqoop-trunk


Description
---

This patch removes the externalColTypes field from TableDefWriter since it was 
only used for testing purposes.
TestTableDefWriter is fixed to mock the ConnManager object provided to the 
TableDefWriter constructor and a minor refactoring is done on the class.


Diffs (updated)
-

  src/java/org/apache/sqoop/hive/TableDefWriter.java e1424c383 
  src/test/org/apache/sqoop/hive/TestTableDefWriter.java 496b5add9 


Diff: https://reviews.apache.org/r/66282/diff/2/

Changes: https://reviews.apache.org/r/66282/diff/1-2/


Testing
---

ant clean test


Thanks,

Szabolcs Vasas



[jira] [Updated] (SQOOP-3308) Mock ConnManager field in TestTableDefWriter

2018-03-26 Thread Szabolcs Vasas (JIRA)

 [ 
https://issues.apache.org/jira/browse/SQOOP-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Szabolcs Vasas updated SQOOP-3308:
--
Attachment: SQOOP-3308.patch

> Mock ConnManager field in TestTableDefWriter
> 
>
> Key: SQOOP-3308
> URL: https://issues.apache.org/jira/browse/SQOOP-3308
> Project: Sqoop
>  Issue Type: Sub-task
>Affects Versions: 1.5.0
>Reporter: Szabolcs Vasas
>Assignee: Szabolcs Vasas
>Priority: Major
> Attachments: SQOOP-3308.patch
>
>
> TableDefWriter has a dependency on ConnManager to retrieve the names and the 
> types of the table. It also introduces a field called _externalColTypes_ for 
> testing purposes and TestTableDefWriter uses this field to inject the test 
> table column names and types instead of mocking the ConnManager field.
> This setup makes it harder to add test cases to TestTableDefWriter and not a 
> good practice so it should be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SQOOP-3308) Mock ConnManager field in TestTableDefWriter

2018-03-26 Thread Szabolcs Vasas (JIRA)
Szabolcs Vasas created SQOOP-3308:
-

 Summary: Mock ConnManager field in TestTableDefWriter
 Key: SQOOP-3308
 URL: https://issues.apache.org/jira/browse/SQOOP-3308
 Project: Sqoop
  Issue Type: Sub-task
Affects Versions: 1.5.0
Reporter: Szabolcs Vasas


TableDefWriter has a dependency on ConnManager to retrieve the names and the 
types of the table. It also introduces a field called _externalColTypes_ for 
testing purposes and TestTableDefWriter uses this field to inject the test 
table column names and types instead of mocking the ConnManager field.

This setup makes it harder to add test cases to TestTableDefWriter and not a 
good practice so it should be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Review Request 66282: Mock ConnManager field in TestTableDefWriter

2018-03-26 Thread Szabolcs Vasas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66282/
---

Review request for Sqoop.


Bugs: SQOOP-3308
https://issues.apache.org/jira/browse/SQOOP-3308


Repository: sqoop-trunk


Description
---

This patch removes the externalColTypes field from TableDefWriter since it was 
only used for testing purposes.
TestTableDefWriter is fixed to mock the ConnManager object provided to the 
TableDefWriter constructor and a minor refactoring is done on the class.


Diffs
-

  src/java/org/apache/sqoop/hive/TableDefWriter.java e1424c383 
  src/test/org/apache/sqoop/hive/TestTableDefWriter.java 496b5add9 


Diff: https://reviews.apache.org/r/66282/diff/1/


Testing
---

ant clean test


Thanks,

Szabolcs Vasas



[jira] [Updated] (SQOOP-3306) Connection resource related issues in DBOutputFormat and OracleManager

2018-03-26 Thread Laszlo Bodor (JIRA)

 [ 
https://issues.apache.org/jira/browse/SQOOP-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Laszlo Bodor updated SQOOP-3306:

Description: 
A fortify scan showed 2 possible resource leaks.

*Overview* : The function getRecordWriter() in DBOutputFormat.java sometimes 
fails to release a database resource allocated by getConnection() on line 117.
In the file DBOutputFormat.java similar issues were on line numbers 117

 

Connection should be closed before throwing IOException forward.
{code:java}
    try {

      Connection connection = dbConf.getConnection();

      PreparedStatement statement = null;

      statement = connection.prepareStatement(

                    constructQuery(tableName, fieldNames));

      return new org.apache.sqoop.mapreduce.db.DBOutputFormat.DBRecordWriter(

                     connection, statement);

    } catch (Exception ex) {

      throw new IOException(ex);

    }
{code}
 

*Overview* : The function makeConnection() in OracleManager.java sometimes 
fails to release a database resource allocated by getConnection() on line 321.
In the file OracleManager.java similar issues were on line numbers 321

 

Some connection post setup steps could be extracted to a separate method which 
could be enclosed by a try/catch.
{code:java}
connection.setTransactionIsolation(Connection.TRANSACTION_READ_COMMITTED);     
setSessionTimeZone(connection);
connection.setAutoCommit(false);
{code}

  was:
A fortify scan showed 2 possible resource leaks.



*Overview* : The function getRecordWriter() in DBOutputFormat.java sometimes 
fails to release a database resource allocated by getConnection() on line 117.
In the file DBOutputFormat.java similar issues were on line numbers 117

 

Connection should be closed before throwing IOException forward.
{code}

    try {

      Connection connection = dbConf.getConnection();

      PreparedStatement statement = null;

      statement = connection.prepareStatement(

                    constructQuery(tableName, fieldNames));

      return new org.apache.sqoop.mapreduce.db.DBOutputFormat.DBRecordWriter(

                     connection, statement);

    } catch (Exception ex) {

      throw new IOException(ex);

    }
{code}

 



*Overview* : The function makeConnection() in OracleManager.java sometimes 
fails to release a database resource allocated by getConnection() on line 321.
In the file OracleManager.java similar issues were on line numbers 321

 

Some connection setup steps could extract to a separated method which could be 
enclosed by a try/catch.
{code}
connection.setTransactionIsolation(Connection.TRANSACTION_READ_COMMITTED);     
setSessionTimeZone(connection);
connection.setAutoCommit(false);
{code}


> Connection resource related issues in DBOutputFormat and OracleManager
> --
>
> Key: SQOOP-3306
> URL: https://issues.apache.org/jira/browse/SQOOP-3306
> Project: Sqoop
>  Issue Type: Bug
>Affects Versions: 1.4.7
>Reporter: Laszlo Bodor
>Priority: Minor
> Fix For: 1.5.0
>
>
> A fortify scan showed 2 possible resource leaks.
> *Overview* : The function getRecordWriter() in DBOutputFormat.java sometimes 
> fails to release a database resource allocated by getConnection() on line 117.
> In the file DBOutputFormat.java similar issues were on line numbers 117
>  
> Connection should be closed before throwing IOException forward.
> {code:java}
>     try {
>       Connection connection = dbConf.getConnection();
>       PreparedStatement statement = null;
>       statement = connection.prepareStatement(
>                     constructQuery(tableName, fieldNames));
>       return new org.apache.sqoop.mapreduce.db.DBOutputFormat.DBRecordWriter(
>                      connection, statement);
>     } catch (Exception ex) {
>       throw new IOException(ex);
>     }
> {code}
>  
> *Overview* : The function makeConnection() in OracleManager.java sometimes 
> fails to release a database resource allocated by getConnection() on line 321.
> In the file OracleManager.java similar issues were on line numbers 321
>  
> Some connection post setup steps could be extracted to a separate method 
> which could be enclosed by a try/catch.
> {code:java}
> connection.setTransactionIsolation(Connection.TRANSACTION_READ_COMMITTED);    
>  
> setSessionTimeZone(connection);
> connection.setAutoCommit(false);
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Review Request 66277: Don't create HTML during Ivy report

2018-03-26 Thread daniel voros

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66277/
---

Review request for Sqoop.


Bugs: SQOOP-3307
https://issues.apache.org/jira/browse/SQOOP-3307


Repository: sqoop-trunk


Description
---

ant clean report invokes the ivy:report task and creates both HTML and GraphML 
reports.
Creation of the HTML reports takes ~7 minutes and results in a ~700MB html 
that's hard to make use of, while the GraphML reporting is fast and is easier 
to read.


Diffs
-

  build.xml d85cf71 


Diff: https://reviews.apache.org/r/66277/diff/1/


Testing
---

`ant clean report`


Thanks,

daniel voros



[jira] [Commented] (SQOOP-3307) Don't create HTML during Ivy report

2018-03-26 Thread Daniel Voros (JIRA)

[ 
https://issues.apache.org/jira/browse/SQOOP-3307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413747#comment-16413747
 ] 

Daniel Voros commented on SQOOP-3307:
-

Attaching review request.

> Don't create HTML during Ivy report
> ---
>
> Key: SQOOP-3307
> URL: https://issues.apache.org/jira/browse/SQOOP-3307
> Project: Sqoop
>  Issue Type: Task
>Affects Versions: 1.4.7
>Reporter: Daniel Voros
>Assignee: Daniel Voros
>Priority: Minor
> Fix For: 1.5.0
>
>
> {{ant clean report}} invokes the [ivy:report 
> |https://ant.apache.org/ivy/history/2.1.0/use/report.html] task and creates 
> both HTML and GraphML reports.
> Creation of the HTML reports takes ~7 minutes and results in a ~700MB html 
> that's hard to make use of, while the GraphML reporting is fast and is easier 
> to read.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SQOOP-3307) Don't create HTML during Ivy report

2018-03-26 Thread Daniel Voros (JIRA)
Daniel Voros created SQOOP-3307:
---

 Summary: Don't create HTML during Ivy report
 Key: SQOOP-3307
 URL: https://issues.apache.org/jira/browse/SQOOP-3307
 Project: Sqoop
  Issue Type: Task
Affects Versions: 1.4.7
Reporter: Daniel Voros
Assignee: Daniel Voros
 Fix For: 1.5.0


{{ant clean report}} invokes the [ivy:report 
|https://ant.apache.org/ivy/history/2.1.0/use/report.html] task and creates 
both HTML and GraphML reports.

Creation of the HTML reports takes ~7 minutes and results in a ~700MB html 
that's hard to make use of, while the GraphML reporting is fast and is easier 
to read.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SQOOP-3306) Connection resource related issues in DBOutputFormat and OracleManager

2018-03-26 Thread Laszlo Bodor (JIRA)
Laszlo Bodor created SQOOP-3306:
---

 Summary: Connection resource related issues in DBOutputFormat and 
OracleManager
 Key: SQOOP-3306
 URL: https://issues.apache.org/jira/browse/SQOOP-3306
 Project: Sqoop
  Issue Type: Bug
Affects Versions: 1.4.7
Reporter: Laszlo Bodor
 Fix For: 1.5.0


A fortify scan showed 2 possible resource leaks.



*Overview* : The function getRecordWriter() in DBOutputFormat.java sometimes 
fails to release a database resource allocated by getConnection() on line 117.
In the file DBOutputFormat.java similar issues were on line numbers 117

 

Connection should be closed before throwing IOException forward.
{code}

    try {

      Connection connection = dbConf.getConnection();

      PreparedStatement statement = null;

      statement = connection.prepareStatement(

                    constructQuery(tableName, fieldNames));

      return new org.apache.sqoop.mapreduce.db.DBOutputFormat.DBRecordWriter(

                     connection, statement);

    } catch (Exception ex) {

      throw new IOException(ex);

    }
{code}

 



*Overview* : The function makeConnection() in OracleManager.java sometimes 
fails to release a database resource allocated by getConnection() on line 321.
In the file OracleManager.java similar issues were on line numbers 321

 

Some connection setup steps could extract to a separated method which could be 
enclosed by a try/catch.
{code}
connection.setTransactionIsolation(Connection.TRANSACTION_READ_COMMITTED);     
setSessionTimeZone(connection);
connection.setAutoCommit(false);
{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SQOOP-3305) Upgrade to Hadoop 3.0.0

2018-03-26 Thread Daniel Voros (JIRA)
Daniel Voros created SQOOP-3305:
---

 Summary: Upgrade to Hadoop 3.0.0
 Key: SQOOP-3305
 URL: https://issues.apache.org/jira/browse/SQOOP-3305
 Project: Sqoop
  Issue Type: Task
Reporter: Daniel Voros
Assignee: Daniel Voros


To be able to eventually support the latest versions of Hive, HBase and 
Accumulo, we should start by upgrading our Hadoop dependencies to 3.0.0. See 
https://hadoop.apache.org/docs/r3.0.0/index.html

In this ticket I'll collect the necessary changes to do the upgrade. I'm not 
setting a fix version yet, since this might mean a major release and to be done 
together with the upgrade of related components.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 66221: SQOOP-3301 Document SQOOP-3216 - metastore related change

2018-03-26 Thread Boglarka Egyed

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66221/#review199945
---


Ship it!




Ship It!

- Boglarka Egyed


On March 22, 2018, 5:46 p.m., Fero Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66221/
> ---
> 
> (Updated March 22, 2018, 5:46 p.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3301
> https://issues.apache.org/jira/browse/SQOOP-3301
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> This is the documentation for the metastore related patch implemented by Zach 
> Berkowitz.
> 
> 
> Diffs
> -
> 
>   src/docs/man/sqoop-metastore.txt c10cc08d 
>   src/docs/user/metastore-purpose.txt 95c2d774 
>   src/docs/user/saved-jobs.txt 6885079f 
> 
> 
> Diff: https://reviews.apache.org/r/66221/diff/1/
> 
> 
> Testing
> ---
> 
> ant docs ran successfully
> 
> 
> Thanks,
> 
> Fero Szabo
> 
>