Re: Review Request 62523: SQOOP-3237: Mainframe FTP transfer option to insert custom FTP commands prior to transfer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62523/#review211186 --- Fix it, then Ship it! Hi Chris, I also had a look at this

Re: Review Request 69434: SQOOP-3410: Test S3 import with fs.s3a.security.credential.provider.path

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69434/#review210832 --- Ship it! Lgtm - Fero Szabo On Nov. 22, 2018, 4:06 p.m.,

Re: Review Request 69433: Setting up Travis CI using Gradle test categories

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69433/#review210825 --- Ship it! Hi Szabi, not an issue, just an idea. In any case,

Re: Review Request 69433: Setting up Travis CI using Gradle test categories

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69433/#review210809 --- Hi Szabi, The whole change looks good to me, haven't spotted any

Re: Review Request 69430: SQOOP-3409: Fix temporary rootdir clean up in Sqoop-S3 tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69430/#review210803 --- Ship it! Ship It! - Fero Szabo On Nov. 22, 2018, 1:37 p.m.,

Re: Review Request 69429: Introduce a Gradle build parameter to set the default forkEvery value for the tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69429/#review210799 --- Ship it! Ship It! - Fero Szabo On Nov. 22, 2018, 1:11 p.m.,

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

> On Nov. 22, 2018, 8:29 a.m., Boglarka Egyed wrote: > > src/test/org/apache/sqoop/importjob/configuration/MysqlImportJobTestConfiguration.java > > Lines 24 (patched) > > > > > > Renamed files are shown as new files

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/ --- (Updated Nov. 22, 2018, 1:39 p.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

> On Nov. 21, 2018, 2:05 p.m., Boglarka Egyed wrote: > > src/test/org/apache/sqoop/importjob/numerictypes/OracleNumericTypesImportTest.java > > Lines 1 (patched) > > > > > > Apache headers are missing from new files.

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/ --- (Updated Nov. 21, 2018, 3 p.m.) Review request for Sqoop, Boglarka Egyed and

Re: Review Request 69414: Sqoop should not try to execute test category interfaces as tests with Ant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69414/#review210763 --- Ship it! Ship It! - Fero Szabo On Nov. 21, 2018, 12:22

Re: Review Request 69413: Introduce methods instead of TEMP_BASE_DIR and LOCAL_WAREHOUSE_DIR static fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69413/#review210754 --- Ship it! Lgtm. - Fero Szabo On Nov. 20, 2018, 5:29 p.m.,

Re: Review Request 69414: Sqoop should not try to execute test category interfaces as tests with Ant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69414/#review210753 --- build.xml Lines 950 (patched)

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/ --- (Updated Nov. 21, 2018, 10:20 a.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/ --- (Updated Nov. 21, 2018, 9:31 a.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/ --- (Updated Nov. 21, 2018, 9:29 a.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/ --- (Updated Nov. 21, 2018, 9:07 a.m.) Review request for Sqoop, Boglarka Egyed

Review Request 69407: Refactor: break up Parameterized tests on a per database basis

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69407/ --- Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas. Bugs: SQOOP-3405

Re: Review Request 69346: Categorize all tests in the project

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69346/#review210576 --- Ship it! Hi Szabi, lgtm, just a minor suggestion.

Re: Review Request 69060: SQOOP-3382 Add parquet numeric support for Parquet in hdfs import

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69060/ --- (Updated Nov. 12, 2018, 4:33 p.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 69060: SQOOP-3382 Add parquet numeric support for Parquet in hdfs import

> On Nov. 9, 2018, 2:26 p.m., Boglarka Egyed wrote: > > src/test/org/apache/sqoop/importjob/avro/AvroImportForNumericTypesTest.java > > Lines 220 (patched) > > > > > > I think these tests could be parameterized as

Re: Review Request 69060: SQOOP-3382 Add parquet numeric support for Parquet in hdfs import

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69060/ --- (Updated Nov. 8, 2018, 3:34 p.m.) Review request for Sqoop, Boglarka Egyed and

Re: Review Request 69060: SQOOP-3382 Add parquet numeric support for Parquet in hdfs import

> On Oct. 26, 2018, 7:40 a.m., Szabolcs Vasas wrote: > > src/test/org/apache/sqoop/importjob/avro/AvroImportForNumericTypesTest.java > > Lines 292 (patched) > > > > > > Since the readAll* methods of ParquetReader

Re: Review Request 69199: Create tests for SQOOP-2949, quote escaping in split-by

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69199/ --- (Updated Oct. 31, 2018, 1:51 p.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 69199: Create tests for SQOOP-2949, quote escaping in split-by

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69199/ --- (Updated Oct. 31, 2018, 12:54 p.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 69199: Create tests for SQOOP-2949, quote escaping in split-by

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69199/ --- (Updated Oct. 30, 2018, 4:26 p.m.) Review request for Sqoop, Boglarka Egyed

Review Request 69199: Create tests for SQOOP-2949, quote escaping in split-by

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69199/ --- Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas. Bugs: SQOOP-3400

Review Request 69200: SQL Syntax error when split-by column is of character type and min or max value has single quote inside it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69200/ --- Review request for Sqoop, Boglarka Egyed, Fero Szabo, and Szabolcs Vasas.

Re: Review Request 69060: SQOOP-3382 Add parquet numeric support for Parquet in hdfs import

> On Oct. 24, 2018, 2:31 p.m., Szabolcs Vasas wrote: > > Hi Feró, > > > > Thank you for submitting this improvement! > > I have left some comments, see them below. > > Apart from that I think we need to test explicitly that if the > > sqoop.parquet.logical_types.decimal.enable flag is true

Re: Review Request 69139: TestS3ImportWithHadoopCredProvider fails if credential generator command is not provided

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69139/#review209969 --- Ship it! Lgtm. I've only run this one test though. - Fero

Re: Review Request 69066: SQOOP-3390: Document S3Guard usage with Sqoop

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69066/#review209964 --- Ship it! Bogi, thanks for enhancing our documentation as well!

Re: Review Request 69141: Tests using HiveMiniCluster can be unstable on some platforms

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69141/#review209963 --- Ship it! gradlew test and thirdpartytest are successful on my

Re: Review Request 68064: SQOOP-3355 Document SQOOP-1905 DB2 --schema option

> On Oct. 24, 2018, 12:21 p.m., Szabolcs Vasas wrote: > > src/docs/user/connectors.txt > > Lines 41 (patched) > > > > > > Are you sure import-all-tables supports --schema properly? > > By looking at the code of

Re: Review Request 69060: SQOOP-3382 Add parquet numeric support for Parquet in hdfs import

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69060/ --- (Updated Oct. 24, 2018, 12:25 p.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 69070: SQOOP-3394: External Hive table tests should use unique external dir names

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69070/#review209779 --- Ship it! Lgtm - Fero Szabo On Oct. 18, 2018, 5:49 p.m.,

Re: Review Request 69060: SQOOP-3382 Add parquet numeric support for Parquet in hdfs import

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69060/ --- (Updated Oct. 18, 2018, 5:40 p.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 69063: SQOOP-3391: Test storing AWS credentials in Hadoop CredentialProvider during import

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69063/#review209740 --- Ship it! lgtm - Fero Szabo On Oct. 18, 2018, 11:45 a.m.,

Review Request 69060: SQOOP-3382 Add parquet numeric support and reuse existing Avro numeric tests Parquet

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69060/ --- Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas. Bugs: SQOOP-3382

Re: Review Request 68687: SQOOP-3381 Upgrade the Parquet library

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68687/ --- (Updated Oct. 16, 2018, 9:37 a.m.) Review request for Sqoop, Boglarka Egyed,

Re: Review Request 68687: SQOOP-3381 Upgrade the Parquet library

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68687/ --- (Updated Oct. 15, 2018, 2:13 p.m.) Review request for Sqoop, Boglarka Egyed,

Re: Review Request 68979: SQOOP-3384: Document import into external Hive table backed by S3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68979/#review209540 --- Ship it! Ship It! - Fero Szabo On Oct. 10, 2018, 3:42 p.m.,

Re: Review Request 68712: SQOOP-3376: Test import into external Hive table backed by S3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68712/#review209226 --- Ship it! Lgtm! It is interesting to see that you ran into the

Re: Review Request 68687: SQOOP-3381 Upgrade the Parquet library

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68687/ --- (Updated Sept. 12, 2018, 2:53 p.m.) Review request for Sqoop, Boglarka Egyed,

Re: Review Request 68687: SQOOP-3381 Upgrade the Parquet library

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68687/ --- (Updated Sept. 12, 2018, 2:15 p.m.) Review request for Sqoop, Boglarka Egyed,

Review Request 68687: SQOOP-3381 Upgrade the Parquet library

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68687/ --- Review request for Sqoop, Boglarka Egyed, daniel voros, and Szabolcs Vasas.

Re: Review Request 68569: HiveMiniCluster does not restore hive-site.xml location

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68569/#review208248 --- Ship it! Ship It! - Fero Szabo On Aug. 30, 2018, 11:27

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

> On Aug. 28, 2018, 11:41 a.m., Fero Szabo wrote: > > All ant tests passed on my system. (unit, 3rd party and s3). Gradle unit tests passed as well. - Fero --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68475/#review208030 --- Fix it, then Ship it!

Re: Review Request 68516: Improve third party tests to be able to execute them in a single JVM

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68516/#review208019 --- Ship it! Unit and S3 tests passed for me as well. (Except for

Re: Review Request 68475: SQOOP-3363: Test incremental import with S3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68475/#review207962 ---

Re: Review Request 68500: Fix tests using HiveMiniCluster

> On Aug. 24, 2018, 1:35 p.m., Fero Szabo wrote: > > Hi Szabi, > > > > I tried to reproduce the issue without your change, by running > > org.apache.sqoop.hive.TestHiveServer2TextImport, but couldn't. > > > > I deleted calcite from the ~/.ivy2 and ~/m2 directories and calcite was > >

Re: Review Request 68500: Fix tests using HiveMiniCluster

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68500/#review207950 --- Ship it! Ship It! - Fero Szabo On Aug. 24, 2018, 1:16 p.m.,

Re: Review Request 68500: Fix tests using HiveMiniCluster

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68500/#review207877 --- Hi Szabi, I tried to reproduce the issue without your change, by

Re: Review Request 68470: SQOOP-3366 Improve unit tests to be able to execute them in a single JVM

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68470/#review207820 --- Ship it! Ship It! - Fero Szabo On Aug. 23, 2018, 3:54 p.m.,

Re: Review Request 37353: Support snappy compression in Sqoop Import with HCatalog.The Jira is SQOOP-2331

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37353/#review207078 --- Hi Shashank, Other than the minor issue with the default value

Re: Review Request 68278: Add LOG message for git hash

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68278/#review207025 --- src/java/org/apache/sqoop/Sqoop.java Lines 95 (patched)

Re: Review Request 68254: Change MainframeImportTool to refer to MainframeManager class directly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68254/#review207024 --- Ship it! Ship It! - Fero Szabo On Aug. 7, 2018, 9:33 a.m.,

Re: Review Request 68023: Remove Kite dependency from the Gradle dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68023/#review206542 --- Ship it! Lgtm. Unit and 3rd party are successful. - Fero

Re: Review Request 68038: Sqoop should not check incremental constraints for HBase imports

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68038/#review206537 --- Ship it! Ship It! - Fero Szabo On July 25, 2018, 2:44 p.m.,

Re: Review Request 68045: Fix tests which use warehouse-dir as target-dir

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68045/#review206506 --- Ship it! Applies cleanly and tests are successful on my side.

Review Request 68064: SQOOP-3355 Document SQOOP-1905 DB2 --schema option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68064/ --- Review request for Sqoop, Boglarka Egyed, daniel voros, and Szabolcs Vasas.

Re: Review Request 68032: SQOOP-3352: Bump java target version to 1.8

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68032/#review206442 --- Ship it! Ship It! - Fero Szabo On July 25, 2018, 9:43 a.m.,

Re: Review Request 68000: SQOOP-3347: Make verify() more generic in AvroTestUtils

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68000/#review206281 --- Ship it! Lgtm! My 50cents: Seems like, in the long term we

Re: Review Request 67929: Remove Kite dependency from the Sqoop project

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67929/#review206150 --- Ship it! A long-awaited patch! :) (Anyway, you could link the

Re: Review Request 67926: Document Parquet support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67926/#review206101 --- Ship it! Ship It! - Fero Szabo On July 16, 2018, 1:42 p.m.,

Re: Review Request 67926: Document Parquet support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67926/#review206097 --- LGTM. Perhaps you could consider another example with the

Re: Review Request 67675: SQOOP-3332 Extend Documentation of --resilient flag and add warning message when detected

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67675/ --- (Updated June 28, 2018, 12:29 p.m.) Review request for Sqoop, Boglarka Egyed,

Re: Review Request 67675: SQOOP-3332 Extend Documentation of --resilient flag and add warning message when detected

> On June 28, 2018, 8:42 a.m., daniel voros wrote: > > Hi Fero, > > > > If I understand correclty, with this patch we're only displaying a warning > > when using --resilient to let the users know they should add --split-by > > (even if they do so?). > > > > In the documentation you're saying

Re: Review Request 67628: Implement an alternative solution for Parquet reading and writing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67628/#review205359 --- Ship it! Ship It! - Fero Szabo On June 26, 2018, 9:15 a.m.,

Re: Review Request 67675: SQOOP-3332 Extend Documentation of --resilient flag and add warning message when detected

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67675/ --- (Updated June 25, 2018, 3:17 p.m.) Review request for Sqoop, Boglarka Egyed,

Re: Review Request 67628: Implement an alternative solution for Parquet reading and writing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67628/#review205279 --- Hi Szabi, LGTM! :) What might be a good addition to this patch:

Re: Review Request 67629: SQOOP-3334 Improve ArgumentArrayBuilder, so arguments are replaceable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67629/ --- (Updated June 25, 2018, 12:45 p.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 67629: SQOOP-3334 Improve ArgumentArrayBuilder, so arguments are replaceable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67629/ --- (Updated June 22, 2018, 2:08 p.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 67689: Use hive executable in (non-JDBC) Hive imports

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67689/#review205234 --- Hi Dani, I had a look at your patch and it basically looks good

Review Request 67675: SQOOP-3332 Extend Documentation of --resilient option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67675/ --- Review request for Sqoop, Boglarka Egyed, daniel voros, and Szabolcs Vasas.

Re: Review Request 67524: SQOOP-3333 Change default behavior of the MS SQL connector to non-resilient.

> On June 19, 2018, 7:16 a.m., Szabolcs Vasas wrote: > > src/docs/user/connectors.txt > > Line 151 (original), 151 (patched) > > > > > > Shouldn't we just say "This will retry"? Certainly sounds better. > On June

Re: Review Request 67524: SQOOP-3333 Change default behavior of the MS SQL connector to non-resilient.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67524/ --- (Updated June 19, 2018, 10:28 a.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 67524: SQOOP-3333 Change default behavior of the MS SQL connector to non-resilient.

> On June 18, 2018, 12:35 p.m., daniel voros wrote: > > Hi Fero, > > > > Thank you for taking care of this! I think it's always a good idea to avoid > > these nagating options. I've posted a few minor issues/questions. > > > > Regards, > > Daniel Thanks for the review! I've modified the

Re: Review Request 67524: SQOOP-3333 Change default behavior of the MS SQL connector to non-resilient.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67524/ --- (Updated June 18, 2018, 2:48 p.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 67524: SQOOP-3333 Change default behavior of the MS SQL connector to non-resilient.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67524/#review204926 --- src/docs/user/connectors.txt Lines 154 (patched)

Re: Review Request 67628: Implement an alternative solution for Parquet reading and writing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67628/#review204919 ---

Review Request 67629: SQOOP-3334 Improve ArgumentArrayBuilder, so arguments are replaceable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67629/ --- Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas. Bugs: SQOOP-3334

Re: Review Request 67524: SQOOP-3333 Change default behavior of the MS SQL connector to non-resilient.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67524/ --- (Updated June 18, 2018, 10:25 a.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 67524: SQOOP-3333 Change default behavior of the MS SQL connector to non-resilient.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67524/ --- (Updated June 18, 2018, 9:26 a.m.) Review request for Sqoop, Boglarka Egyed

Review Request 67524: SQOOP-3333 Change default behavior of the MS SQL connector to non-resilient.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67524/ --- Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas. Bugs: SQOOP-

Re: Review Request 67407: SQOOP-3327: Mainframe FTP needs to Include "Migrated" datasets when parsing the FTP list

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67407/#review204185 ---

Re: Review Request 62492: SQOOP-3224: Mainframe FTP transfer should have an option to use binary mode for transfer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62492/#review203967 --- Hi Chris, I had a quick glance at your patch. Mainly, it seems

Re: Review Request 67086: SQOOP-3324 Document SQOOP-816: Sqoop add support for external Hive tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67086/ --- (Updated May 11, 2018, 1:58 p.m.) Review request for Sqoop, Boglarka Egyed,

Re: Review Request 67086: SQOOP-3324 Document SQOOP-816: Sqoop add support for external Hive tables

> On May 11, 2018, 11:32 a.m., daniel voros wrote: > > src/docs/user/hive.txt > > Lines 115 (patched) > > > > > > nit: I'm sure we have this wrong elsewhere too, but I think we should > > say "switch" or "option"

Review Request 67086: SQOOP-3324 Document SQOOP-816: Sqoop add support for external Hive tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67086/ --- Review request for Sqoop, Boglarka Egyed, daniel voros, and Szabolcs Vasas.

Re: Review Request 67005: Version differences between ivy configurations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67005/#review202841 --- Ship it! Seems ok to me. I've ran unit and 3rd party tests as

Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build for Sqoop to make it more developer friendly / open

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66067/#review201828 --- build.gradle Lines 349 (patched)

Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build for Sqoop to make it more developer friendly / open

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66067/#review201727 --- Hi Anna, I couldn't apply the patch cleanly, I ran into the

Re: Review Request 66361: Implement HiveServer2 client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66361/#review201413 --- Ship it! Ship It! - Fero Szabo On April 17, 2018, 10:14

Re: Review Request 66446: SQOOP-2567 SQOOP import for Oracle fails with invalid precision/scale for decimal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66446/ --- (Updated April 17, 2018, 1:15 p.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 66446: SQOOP-2567 SQOOP import for Oracle fails with invalid precision/scale for decimal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66446/ --- (Updated April 17, 2018, 1:11 p.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 66446: SQOOP-2567 SQOOP import for Oracle fails with invalid precision/scale for decimal

> On April 16, 2018, 2:28 p.m., Szabolcs Vasas wrote: > > src/test/org/apache/sqoop/manager/mysql/MySQLTestUtils.java > > Lines 131 (patched) > > > > > > Now that we have MySqlDatabaseAdapter shouldn't we move this

Re: Review Request 66446: SQOOP-2567 SQOOP import for Oracle fails with invalid precision/scale for decimal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66446/ --- (Updated April 17, 2018, 12:29 p.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 66361: Implement HiveServer2 client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66361/#review201189 --- src/java/org/apache/sqoop/hive/HiveClientFactory.java Lines 54

Re: Review Request 66446: SQOOP-2567 SQOOP import for Oracle fails with invalid precision/scale for decimal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66446/ --- (Updated April 13, 2018, 3:45 p.m.) Review request for Sqoop, Boglarka Egyed

  1   2   >