Re: Review Request 66446: SQOOP-2567 SQOOP import for Oracle fails with invalid precision/scale for decimal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66446/ --- (Updated April 13, 2018, 3:02 p.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 66446: SQOOP-2567 Sqoop import using oraoop fails validation intermittently

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66446/ --- (Updated April 12, 2018, 10:06 a.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 66221: SQOOP-3301 Document SQOOP-3216 - metastore related change

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66221/ --- (Updated April 9, 2018, 2:35 p.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 66361: Implement HiveServer2 client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66361/#review200554 --- src/java/org/apache/sqoop/hive/HiveServer2Client.java Lines 75

Re: Review Request 66353: Connection resource related issues in DBOutputFormat and OracleManager

> On March 29, 2018, 9:32 a.m., Fero Szabo wrote: > > src/java/org/apache/sqoop/manager/OracleManager.java > > Lines 334-336 (patched) > > > > > > You probably missed some spaces here :) oops, the patch itself

Re: Review Request 66353: Connection resource related issues in DBOutputFormat and OracleManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66353/#review200179 --- Ship it! Good catch! Lgtm!

Re: Review Request 66195: Implement JDBC and Kerberos tools for HiveServer2 support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66195/#review199877 --- Ship it! Ship It! - Fero Szabo On March 21, 2018, 12:48

Review Request 66221: SQOOP-3301 Document SQOOP-3216 - metastore related change

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66221/ --- Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas. Bugs: SQOOP-3301

Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build for Sqoop to make it more developer friendly / open

> On March 22, 2018, 4:19 p.m., Boglarka Egyed wrote: > > Hi Anna, > > > > This is a superb improvement in Sqoop, many thanks for taking this huge > > effort! Using Gradle would indeed ease the life of the developers as well > > as let more enhancements to come in the future. > > > > However

Re: Review Request 66062: SQOOP-3293 Documentation for avro padding (SQOOP-2976)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66062/ --- (Updated March 22, 2018, 4:25 p.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 66062: SQOOP-3292 Documentation for avro padding (SQOOP-2976)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66062/ --- (Updated March 21, 2018, 1:42 p.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 66062: SQOOP-3292 Documentation for avro padding (SQOOP-2976)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66062/ --- (Updated March 21, 2018, 1:20 p.m.) Review request for Sqoop, Boglarka Egyed

Review Request 66062: SQOOP-3292 Documentation for avro padding (SQOOP-2976)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66062/ --- Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas. Bugs: SQOOP-3292

Re: Review Request 65884: SqoopJobDataPublisher is invoked before Hive/HCat imports succeed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65884/#review198933 --- src/java/org/apache/sqoop/hive/HiveImport.java Lines 312-316

Re: Review Request 65530: MySQL thirdparty tests hang if there's no USER environment variable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65530/#review197523 --- Ship it! Hi Dani, The fix works for me. Now, all we need is

Re: Review Request 65607: SQOOP-2976 Flag to expand decimal values to fit AVRO schema

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65607/ --- (Updated Feb. 14, 2018, 9:45 a.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 65607: SQOOP-2976 Flag to expand decimal values to fit AVRO schema

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65607/ --- (Updated Feb. 13, 2018, 4:13 p.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 65607: SQOOP-2976 Flag to expand decimal values to fit AVRO schema

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65607/ --- (Updated Feb. 13, 2018, 4:07 p.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 65607: SQOOP-2976 Flag to expand decimal values to fit AVRO schema

> On Feb. 13, 2018, 11:39 a.m., Szabolcs Vasas wrote: > > src/java/org/apache/sqoop/avro/AvroUtil.java > > Lines 88 (patched) > > > > > > I think this if statement is redundant since if schemaContainingScale > > is

Re: Review Request 65530: MySQL thirdparty tests hang if there's no USER environment variable

> On Feb. 12, 2018, 4:50 p.m., Fero Szabo wrote: > > Hi Dani, > > > > Great catch! > > > > I like in your solution that it's greatly simplified compared to the > > original code. However, I believe that the process that executes the whoami > > command is never destroyed and hangs around in

Re: Review Request 65530: MySQL thirdparty tests hang if there's no USER environment variable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65530/#review197280 --- Hi Dani, Great catch! I like in your solution that it's greatly

Re: Review Request 65607: SQOOP-2976 Flag to expand decimal values to fit AVRO schema

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65607/ --- (Updated Feb. 12, 2018, 2:31 p.m.) Review request for Sqoop, Boglarka Egyed

Review Request 65607: SQOOP-2976 Flag to expand decimal values to fit AVRO schema

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65607/ --- Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas. Bugs: SQOOP-2976

Re: Review Request 65017: Removing com.cloudera.sqoop packages

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65017/#review195572 --- Ship it! Hi Szabi, Thanks for removing these deprecated

Re: Review Request 65020: HBase test cases should start mini DFS cluster as well

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65020/#review194949 --- Ship it! src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java

Re: Review Request 63920: Sqoop ignores metastore properties defined in sqoop-site.xml

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63920/#review194847 --- Ship it! Ship It! - Fero Szabo On Jan. 5, 2018, 10:05 a.m.,

Re: Review Request 64715: SQOOP-3241 ImportAllTablesTool uses the same SqoopOptions object for every table import

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64715/ --- (Updated Jan. 4, 2018, 2:37 p.m.) Review request for Sqoop, Boglarka Egyed and

Re: Review Request 64715: SQOOP-3241 ImportAllTablesTool uses the same SqoopOptions object for every table import

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64715/ --- (Updated Jan. 4, 2018, 2:23 p.m.) Review request for Sqoop, Boglarka Egyed and

Re: Review Request 64715: SQOOP-3241 ImportAllTablesTool uses the same SqoopOptions object for every table import

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64715/#review194688 --- src/java/org/apache/sqoop/tool/ImportAllTablesTool.java Lines

Re: Review Request 64715: SQOOP-3241 ImportAllTablesTool uses the same SqoopOptions object for every table import

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64715/ --- (Updated Jan. 3, 2018, 11:16 a.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 64715: SQOOP-3241 ImportAllTablesTool uses the same SqoopOptions object for every table import

> On Dec. 22, 2017, 12:02 p.m., Szabolcs Vasas wrote: > > src/java/org/apache/sqoop/tool/ImportAllTablesTool.java > > Line 109 (original), 110 (patched) > > > > > > Now that we clone the whole SqoopOptions object

Re: Review Request 64715: SQOOP-3241 ImportAllTablesTool uses the same SqoopOptions object for every table import

- Fero --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64715/#review194418 --- On Dec. 27, 2017, 3:36 p.m., Fero Szabo wrote: > >

Re: Review Request 64715: SQOOP-3241 ImportAllTablesTool uses the same SqoopOptions object for every table import

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64715/ --- (Updated Dec. 27, 2017, 3:36 p.m.) Review request for Sqoop, Boglarka Egyed

Review Request 64715: SQOOP-3241 ImportAllTablesTool uses the same SqoopOptions object for every table import

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64715/ --- Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas. Bugs: SQOOP-3241

Re: Review Request 64417: SQOOP-3153 Sqoop export with --as- error message could be more verbose

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64417/ --- (Updated Dec. 14, 2017, 1:45 p.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 64417: SQOOP-3153 Sqoop export with --as- error message could be more verbose

> On Dec. 13, 2017, 9:56 a.m., Szabolcs Vasas wrote: > > src/java/org/apache/sqoop/tool/ExportTool.java > > Lines 22 (patched) > > > > > > This import is unused. Removed. I've turned on the 'Optimize imports on the

Re: Review Request 64417: SQOOP-3153 Sqoop export with --as- error message could be more verbose

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64417/ --- (Updated Dec. 13, 2017, 11:19 a.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 64417: SQOOP-3153 Sqoop export with --as- error message could be more verbose

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64417/ --- (Updated Dec. 8, 2017, 3:55 p.m.) Review request for Sqoop, Boglarka Egyed and

Re: Review Request 64251: SQOOP-3266: Update 3rd party and manual test running related info in COMPILING.txt

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64251/#review193139 --- Ship it! Ship It! - Fero Szabo On Dec. 7, 2017, 4:46 p.m.,

Review Request 64417: SQOOP-3153 Sqoop export with --as- error message could be more verbose

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64417/ --- Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas. Bugs: SQOOP-3153

Re: Review Request 64371: SQOOP-3233: SqoopHCatImportHelper.convertNumberTypes check for Varchar instead of Char

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64371/ --- (Updated Dec. 7, 2017, 5:23 p.m.) Review request for Sqoop, Boglarka Egyed and

Re: Review Request 64251: SQOOP-3266: Update 3rd party and manual test running related info in COMPILING.txt

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64251/#review193127 --- COMPILING.txt Lines 105-106 (patched)

Re: Review Request 64371: SQOOP-3233: SqoopHCatImportHelper.convertNumberTypes check for Varchar instead of Char

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64371/ --- (Updated Dec. 6, 2017, 2:13 p.m.) Review request for Sqoop, Boglarka Egyed and

Review Request 64371: SQOOP-3233: SqoopHCatImportHelper.convertNumberTypes check for Varchar instead of Char

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64371/ --- Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas. Bugs: SQOOP-3233

<    1   2