Re: Review Request 57551: SQOOP-2272 - Import decimal columns from mysql to hive 0.14

2018-07-13 Thread Eric Lin via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57551/ --- (Updated July 13, 2018, 8:06 a.m.) Review request for Sqoop, Attila Szabo and

Re: Review Request 67424: SQOOP-3330 - Sqoop --append does not work with -Dmapreduce.output.basename

2018-07-12 Thread Eric Lin via Review Board
> On July 10, 2018, 4:05 p.m., Boglarka Egyed wrote: > > .gitignore > > Lines 39 (patched) > > > > > > Just as in https://reviews.apache.org/r/54528/ why do we need this here? > > Eric Lin wrote: > It happened

Re: Review Request 67424: SQOOP-3330 - Sqoop --append does not work with -Dmapreduce.output.basename

2018-07-12 Thread Eric Lin via Review Board
> On July 12, 2018, 3:41 p.m., Szabolcs Vasas wrote: > > src/test/org/apache/sqoop/TestAppendUtils.java > > Lines 331 (patched) > > > > > > Nit: can you please use generic List here, otherwise the compiler gives >

Re: Review Request 67424: SQOOP-3330 - Sqoop --append does not work with -Dmapreduce.output.basename

2018-07-12 Thread Eric Lin via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67424/ --- (Updated July 13, 2018, 5:25 a.m.) Review request for Sqoop and Boglarka

Re: Review Request 67424: SQOOP-3330 - Sqoop --append does not work with -Dmapreduce.output.basename

2018-07-12 Thread Eric Lin via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67424/ --- (Updated July 12, 2018, 8:11 a.m.) Review request for Sqoop and Boglarka

Re: Review Request 61615: Add Sqoop1 (import + --incremental + --check-column) support for functions/expressions

2018-07-11 Thread Eric Lin via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61615/ --- (Updated July 11, 2018, 11:45 a.m.) Review request for Sqoop and Boglarka

Re: Review Request 54528: SQOOP-3042 - Sqoop does not clear compile directory under /tmp/sqoop-/compile automatically

2018-07-11 Thread Eric Lin via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54528/ --- (Updated July 11, 2018, 8:25 a.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 54528: SQOOP-3042 - Sqoop does not clear compile directory under /tmp/sqoop-/compile automatically

2018-07-11 Thread Eric Lin via Review Board
> On July 9, 2018, 12:36 p.m., Boglarka Egyed wrote: > > src/java/org/apache/sqoop/tool/BaseSqoopTool.java > > Lines 105 (patched) > > > > > > Could you please add documentation to this new option in the relevant >

Re: Review Request 54528: SQOOP-3042 - Sqoop does not clear compile directory under /tmp/sqoop-/compile automatically

2018-07-11 Thread Eric Lin via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54528/ --- (Updated July 11, 2018, 8:13 a.m.) Review request for Sqoop, Boglarka Egyed

Re: Review Request 54528: SQOOP-3042 - Sqoop does not clear compile directory under /tmp/sqoop-/compile automatically

2018-07-11 Thread Eric Lin via Review Board
> On July 9, 2018, 11:34 a.m., Szabolcs Vasas wrote: > > .gitignore > > Lines 30 (patched) > > > > > > Why do we need this new folder here? It happened to me a few times that "out" directory was created after

Re: Review Request 67424: SQOOP-3330 - Sqoop --append does not work with -Dmapreduce.output.basename

2018-07-11 Thread Eric Lin via Review Board
> On July 10, 2018, 4:05 p.m., Boglarka Egyed wrote: > > .gitignore > > Lines 39 (patched) > > > > > > Just as in https://reviews.apache.org/r/54528/ why do we need this here? It happened to me a few times that

Re: Review Request 67424: SQOOP-3330 - Sqoop --append does not work with -Dmapreduce.output.basename

2018-07-11 Thread Eric Lin via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67424/ --- (Updated July 11, 2018, 7:24 a.m.) Review request for Sqoop and Boglarka

Re: Review Request 61615: Add Sqoop1 (import + --incremental + --check-column) support for functions/expressions

2018-07-05 Thread Eric Lin via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61615/ --- (Updated July 5, 2018, 8:56 a.m.) Review request for Sqoop and Boglarka Egyed.

Re: Review Request 54528: SQOOP-3042 - Sqoop does not clear compile directory under /tmp/sqoop-/compile automatically

2018-07-05 Thread Eric Lin via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54528/ --- (Updated July 5, 2018, 8:03 a.m.) Review request for Sqoop, Boglarka Egyed and

Re: Review Request 60587: SQOOP-3039 - Sqoop unable to export Time data "13:14:12.1234" into Time colum in RMDBS

2018-06-02 Thread Eric Lin via Review Board
> On Sept. 24, 2017, 11:18 a.m., Sandish Kumar HN wrote: > > src/java/org/apache/sqoop/orm/Time.java > > Lines 18 (patched) > > > > > > no new line between licence comment and package declaration. New line already

Re: Review Request 60587: SQOOP-3039 - Sqoop unable to export Time data "13:14:12.1234" into Time colum in RMDBS

2018-06-02 Thread Eric Lin via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60587/ --- (Updated June 2, 2018, 9:11 p.m.) Review request for Sqoop, Attila Szabo and

Review Request 67424: SQOOP-3330 - Sqoop --append does not work with -Dmapreduce.output.basename

2018-06-02 Thread Eric Lin via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67424/ --- Review request for Sqoop. Bugs: SQOOP-3330