Re: Review Request 68032: SQOOP-3352: Bump java target version to 1.8

2018-07-25 Thread Fero Szabo via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68032/#review206442
---


Ship it!




Ship It!

- Fero Szabo


On July 25, 2018, 9:43 a.m., Boglarka Egyed wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68032/
> ---
> 
> (Updated July 25, 2018, 9:43 a.m.)
> 
> 
> Review request for Sqoop, Fero Szabo and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3352
> https://issues.apache.org/jira/browse/SQOOP-3352
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> * Bumped targetJavaVersion and sourceJavaVersion to 1.8 in build.xml
> * Bumped javaSourceCompatibilityVersion to 1.8 in gradle.properties
> * Updated documentation
> 
> 
> Diffs
> -
> 
>   COMPILING.txt 9abf0b211b24de65b53351ece170b09e4851938b 
>   README.txt b8f0a7a2c7d760c72f9811435b36c23cde354b15 
>   build.gradle 8b8b55575ab05187eec0b8ca6b6da17e0a318d72 
>   build.xml 0ae729bce035f6f1afef78702a3d888bb6c5a9ff 
>   gradle.properties a571e6cb26ddd3d687f3b3a2a69615a5e1fc71d5 
>   src/docs/man/sqoop.txt 7977e13091af184f6b1d10028aa827e033c9452a 
> 
> 
> Diff: https://reviews.apache.org/r/68032/diff/3/
> 
> 
> Testing
> ---
> 
> Successfully ran with ant:
> ant
> ant clean compile
> ant clean package
> ant clean test
> ant cobertura -Dcobertura.home=/path/to/cobertura
> ant clean test -Dthirdparty= ...
> ant checkstyle
> ant mvn-install
> ant docs
> ant eclipse
> 
> Succesfully ran with gradle:
> ./gradlew clean
> ./gradlew package
> ./gradlew test
> ./gradlew jacocoTestReport
> ./gradlew -Dsqoop.thirdparty.lib.dir= 
> thirdPartyTest
> ./gradlew checkStyleMain
> ./gradlew compileJava
> ./gradlew publishToMavenLocal
> 
> 
> Thanks,
> 
> Boglarka Egyed
> 
>

Re: Review Request 68032: SQOOP-3352: Bump java target version to 1.8

2018-07-25 Thread Boglarka Egyed 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68032/
---

(Updated July 25, 2018, 9:43 a.m.)


Review request for Sqoop, Fero Szabo and Szabolcs Vasas.


Changes
---

Bumped required Ant version in document


Bugs: SQOOP-3352
https://issues.apache.org/jira/browse/SQOOP-3352


Repository: sqoop-trunk


Description
---

* Bumped targetJavaVersion and sourceJavaVersion to 1.8 in build.xml
* Bumped javaSourceCompatibilityVersion to 1.8 in gradle.properties
* Updated documentation


Diffs (updated)
-

  COMPILING.txt 9abf0b211b24de65b53351ece170b09e4851938b 
  README.txt b8f0a7a2c7d760c72f9811435b36c23cde354b15 
  build.gradle 8b8b55575ab05187eec0b8ca6b6da17e0a318d72 
  build.xml 0ae729bce035f6f1afef78702a3d888bb6c5a9ff 
  gradle.properties a571e6cb26ddd3d687f3b3a2a69615a5e1fc71d5 
  src/docs/man/sqoop.txt 7977e13091af184f6b1d10028aa827e033c9452a 


Diff: https://reviews.apache.org/r/68032/diff/3/

Changes: https://reviews.apache.org/r/68032/diff/2-3/


Testing
---

Successfully ran with ant:
ant
ant clean compile
ant clean package
ant clean test
ant cobertura -Dcobertura.home=/path/to/cobertura
ant clean test -Dthirdparty= ...
ant checkstyle
ant mvn-install
ant docs
ant eclipse

Succesfully ran with gradle:
./gradlew clean
./gradlew package
./gradlew test
./gradlew jacocoTestReport
./gradlew -Dsqoop.thirdparty.lib.dir= 
thirdPartyTest
./gradlew checkStyleMain
./gradlew compileJava
./gradlew publishToMavenLocal


Thanks,

Boglarka Egyed

Re: Review Request 68032: SQOOP-3352: Bump java target version to 1.8

2018-07-25 Thread Szabolcs Vasas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68032/#review206441
---


Ship it!




Ship It!

- Szabolcs Vasas


On July 25, 2018, 9:43 a.m., Boglarka Egyed wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68032/
> ---
> 
> (Updated July 25, 2018, 9:43 a.m.)
> 
> 
> Review request for Sqoop, Fero Szabo and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3352
> https://issues.apache.org/jira/browse/SQOOP-3352
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> * Bumped targetJavaVersion and sourceJavaVersion to 1.8 in build.xml
> * Bumped javaSourceCompatibilityVersion to 1.8 in gradle.properties
> * Updated documentation
> 
> 
> Diffs
> -
> 
>   COMPILING.txt 9abf0b211b24de65b53351ece170b09e4851938b 
>   README.txt b8f0a7a2c7d760c72f9811435b36c23cde354b15 
>   build.gradle 8b8b55575ab05187eec0b8ca6b6da17e0a318d72 
>   build.xml 0ae729bce035f6f1afef78702a3d888bb6c5a9ff 
>   gradle.properties a571e6cb26ddd3d687f3b3a2a69615a5e1fc71d5 
>   src/docs/man/sqoop.txt 7977e13091af184f6b1d10028aa827e033c9452a 
> 
> 
> Diff: https://reviews.apache.org/r/68032/diff/3/
> 
> 
> Testing
> ---
> 
> Successfully ran with ant:
> ant
> ant clean compile
> ant clean package
> ant clean test
> ant cobertura -Dcobertura.home=/path/to/cobertura
> ant clean test -Dthirdparty= ...
> ant checkstyle
> ant mvn-install
> ant docs
> ant eclipse
> 
> Succesfully ran with gradle:
> ./gradlew clean
> ./gradlew package
> ./gradlew test
> ./gradlew jacocoTestReport
> ./gradlew -Dsqoop.thirdparty.lib.dir= 
> thirdPartyTest
> ./gradlew checkStyleMain
> ./gradlew compileJava
> ./gradlew publishToMavenLocal
> 
> 
> Thanks,
> 
> Boglarka Egyed
> 
>

Re: Review Request 68032: SQOOP-3352: Bump java target version to 1.8

2018-07-25 Thread Boglarka Egyed 


> On July 24, 2018, 4:12 p.m., Szabolcs Vasas wrote:
> > COMPILING.txt
> > Line 30 (original), 30 (patched)
> > 
> >
> > I have just realized that Ant 1.7.1 probably does not support Java 8, 
> > so this number should be bumped too.

You are totally right, I have corrected it. Thanks!


- Boglarka


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68032/#review206392
---


On July 25, 2018, 9:43 a.m., Boglarka Egyed wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68032/
> ---
> 
> (Updated July 25, 2018, 9:43 a.m.)
> 
> 
> Review request for Sqoop, Fero Szabo and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3352
> https://issues.apache.org/jira/browse/SQOOP-3352
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> * Bumped targetJavaVersion and sourceJavaVersion to 1.8 in build.xml
> * Bumped javaSourceCompatibilityVersion to 1.8 in gradle.properties
> * Updated documentation
> 
> 
> Diffs
> -
> 
>   COMPILING.txt 9abf0b211b24de65b53351ece170b09e4851938b 
>   README.txt b8f0a7a2c7d760c72f9811435b36c23cde354b15 
>   build.gradle 8b8b55575ab05187eec0b8ca6b6da17e0a318d72 
>   build.xml 0ae729bce035f6f1afef78702a3d888bb6c5a9ff 
>   gradle.properties a571e6cb26ddd3d687f3b3a2a69615a5e1fc71d5 
>   src/docs/man/sqoop.txt 7977e13091af184f6b1d10028aa827e033c9452a 
> 
> 
> Diff: https://reviews.apache.org/r/68032/diff/3/
> 
> 
> Testing
> ---
> 
> Successfully ran with ant:
> ant
> ant clean compile
> ant clean package
> ant clean test
> ant cobertura -Dcobertura.home=/path/to/cobertura
> ant clean test -Dthirdparty= ...
> ant checkstyle
> ant mvn-install
> ant docs
> ant eclipse
> 
> Succesfully ran with gradle:
> ./gradlew clean
> ./gradlew package
> ./gradlew test
> ./gradlew jacocoTestReport
> ./gradlew -Dsqoop.thirdparty.lib.dir= 
> thirdPartyTest
> ./gradlew checkStyleMain
> ./gradlew compileJava
> ./gradlew publishToMavenLocal
> 
> 
> Thanks,
> 
> Boglarka Egyed
> 
>

Re: Review Request 68032: SQOOP-3352: Bump java target version to 1.8

2018-07-24 Thread Szabolcs Vasas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68032/#review206392
---




COMPILING.txt
Line 30 (original), 30 (patched)


I have just realized that Ant 1.7.1 probably does not support Java 8, so 
this number should be bumped too.



README.txt
Line 23 (original), 23 (patched)


I have just realized that Ant 1.7.1 probably does not support Java 8, so 
this number should be bumped too.


- Szabolcs Vasas


On July 24, 2018, 3:50 p.m., Boglarka Egyed wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68032/
> ---
> 
> (Updated July 24, 2018, 3:50 p.m.)
> 
> 
> Review request for Sqoop, Fero Szabo and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3352
> https://issues.apache.org/jira/browse/SQOOP-3352
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> * Bumped targetJavaVersion and sourceJavaVersion to 1.8 in build.xml
> * Bumped javaSourceCompatibilityVersion to 1.8 in gradle.properties
> * Updated documentation
> 
> 
> Diffs
> -
> 
>   COMPILING.txt 9abf0b211b24de65b53351ece170b09e4851938b 
>   README.txt b8f0a7a2c7d760c72f9811435b36c23cde354b15 
>   build.gradle 8b8b55575ab05187eec0b8ca6b6da17e0a318d72 
>   build.xml 0ae729bce035f6f1afef78702a3d888bb6c5a9ff 
>   gradle.properties a571e6cb26ddd3d687f3b3a2a69615a5e1fc71d5 
>   src/docs/man/sqoop.txt 7977e13091af184f6b1d10028aa827e033c9452a 
> 
> 
> Diff: https://reviews.apache.org/r/68032/diff/2/
> 
> 
> Testing
> ---
> 
> Successfully ran with ant:
> ant
> ant clean compile
> ant clean package
> ant clean test
> ant cobertura -Dcobertura.home=/path/to/cobertura
> ant clean test -Dthirdparty= ...
> ant checkstyle
> ant mvn-install
> ant docs
> ant eclipse
> 
> Succesfully ran with gradle:
> ./gradlew clean
> ./gradlew package
> ./gradlew test
> ./gradlew jacocoTestReport
> ./gradlew -Dsqoop.thirdparty.lib.dir= 
> thirdPartyTest
> ./gradlew checkStyleMain
> ./gradlew compileJava
> ./gradlew publishToMavenLocal
> 
> 
> Thanks,
> 
> Boglarka Egyed
> 
>

Re: Review Request 68032: SQOOP-3352: Bump java target version to 1.8

2018-07-24 Thread Szabolcs Vasas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68032/#review206391
---


Ship it!




Ship It!

- Szabolcs Vasas


On July 24, 2018, 3:50 p.m., Boglarka Egyed wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68032/
> ---
> 
> (Updated July 24, 2018, 3:50 p.m.)
> 
> 
> Review request for Sqoop, Fero Szabo and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3352
> https://issues.apache.org/jira/browse/SQOOP-3352
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> * Bumped targetJavaVersion and sourceJavaVersion to 1.8 in build.xml
> * Bumped javaSourceCompatibilityVersion to 1.8 in gradle.properties
> * Updated documentation
> 
> 
> Diffs
> -
> 
>   COMPILING.txt 9abf0b211b24de65b53351ece170b09e4851938b 
>   README.txt b8f0a7a2c7d760c72f9811435b36c23cde354b15 
>   build.gradle 8b8b55575ab05187eec0b8ca6b6da17e0a318d72 
>   build.xml 0ae729bce035f6f1afef78702a3d888bb6c5a9ff 
>   gradle.properties a571e6cb26ddd3d687f3b3a2a69615a5e1fc71d5 
>   src/docs/man/sqoop.txt 7977e13091af184f6b1d10028aa827e033c9452a 
> 
> 
> Diff: https://reviews.apache.org/r/68032/diff/2/
> 
> 
> Testing
> ---
> 
> Successfully ran with ant:
> ant
> ant clean compile
> ant clean package
> ant clean test
> ant cobertura -Dcobertura.home=/path/to/cobertura
> ant clean test -Dthirdparty= ...
> ant checkstyle
> ant mvn-install
> ant docs
> ant eclipse
> 
> Succesfully ran with gradle:
> ./gradlew clean
> ./gradlew package
> ./gradlew test
> ./gradlew jacocoTestReport
> ./gradlew -Dsqoop.thirdparty.lib.dir= 
> thirdPartyTest
> ./gradlew checkStyleMain
> ./gradlew compileJava
> ./gradlew publishToMavenLocal
> 
> 
> Thanks,
> 
> Boglarka Egyed
> 
>

Re: Review Request 68032: SQOOP-3352: Bump java target version to 1.8

2018-07-24 Thread Boglarka Egyed 


> On July 24, 2018, 3:36 p.m., Szabolcs Vasas wrote:
> > Hi Bogi,
> > 
> > Thanks for submitting this patch, it will be great to use the Java 8 
> > features in Sqoop finally.
> > 
> > I have left a minor comment and apart from that we should remove 
> > '-XX:PermSize=256m', '-XX:MaxPermSize=512m' parameters from the jvmArgs 
> > properties in build.gradle since these JVM arguments are not supported in 
> > Java 8.
> > 
> > Szabolcs

Good catch, thank you!


- Boglarka


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68032/#review206388
---


On July 24, 2018, 3:50 p.m., Boglarka Egyed wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68032/
> ---
> 
> (Updated July 24, 2018, 3:50 p.m.)
> 
> 
> Review request for Sqoop, Fero Szabo and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3352
> https://issues.apache.org/jira/browse/SQOOP-3352
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> * Bumped targetJavaVersion and sourceJavaVersion to 1.8 in build.xml
> * Bumped javaSourceCompatibilityVersion to 1.8 in gradle.properties
> * Updated documentation
> 
> 
> Diffs
> -
> 
>   COMPILING.txt 9abf0b211b24de65b53351ece170b09e4851938b 
>   README.txt b8f0a7a2c7d760c72f9811435b36c23cde354b15 
>   build.gradle 8b8b55575ab05187eec0b8ca6b6da17e0a318d72 
>   build.xml 0ae729bce035f6f1afef78702a3d888bb6c5a9ff 
>   gradle.properties a571e6cb26ddd3d687f3b3a2a69615a5e1fc71d5 
>   src/docs/man/sqoop.txt 7977e13091af184f6b1d10028aa827e033c9452a 
> 
> 
> Diff: https://reviews.apache.org/r/68032/diff/2/
> 
> 
> Testing
> ---
> 
> Successfully ran with ant:
> ant
> ant clean compile
> ant clean package
> ant clean test
> ant cobertura -Dcobertura.home=/path/to/cobertura
> ant clean test -Dthirdparty= ...
> ant checkstyle
> ant mvn-install
> ant docs
> ant eclipse
> 
> Succesfully ran with gradle:
> ./gradlew clean
> ./gradlew package
> ./gradlew test
> ./gradlew jacocoTestReport
> ./gradlew -Dsqoop.thirdparty.lib.dir= 
> thirdPartyTest
> ./gradlew checkStyleMain
> ./gradlew compileJava
> ./gradlew publishToMavenLocal
> 
> 
> Thanks,
> 
> Boglarka Egyed
> 
>

Re: Review Request 68032: SQOOP-3352: Bump java target version to 1.8

2018-07-24 Thread Boglarka Egyed 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68032/
---

(Updated July 24, 2018, 3:50 p.m.)


Review request for Sqoop, Fero Szabo and Szabolcs Vasas.


Changes
---

Removed ignored JVM options from build.gradle, updated documentation


Bugs: SQOOP-3352
https://issues.apache.org/jira/browse/SQOOP-3352


Repository: sqoop-trunk


Description
---

* Bumped targetJavaVersion and sourceJavaVersion to 1.8 in build.xml
* Bumped javaSourceCompatibilityVersion to 1.8 in gradle.properties
* Updated documentation


Diffs (updated)
-

  COMPILING.txt 9abf0b211b24de65b53351ece170b09e4851938b 
  README.txt b8f0a7a2c7d760c72f9811435b36c23cde354b15 
  build.gradle 8b8b55575ab05187eec0b8ca6b6da17e0a318d72 
  build.xml 0ae729bce035f6f1afef78702a3d888bb6c5a9ff 
  gradle.properties a571e6cb26ddd3d687f3b3a2a69615a5e1fc71d5 
  src/docs/man/sqoop.txt 7977e13091af184f6b1d10028aa827e033c9452a 


Diff: https://reviews.apache.org/r/68032/diff/2/

Changes: https://reviews.apache.org/r/68032/diff/1-2/


Testing
---

Successfully ran with ant:
ant
ant clean compile
ant clean package
ant clean test
ant cobertura -Dcobertura.home=/path/to/cobertura
ant clean test -Dthirdparty= ...
ant checkstyle
ant mvn-install
ant docs
ant eclipse

Succesfully ran with gradle:
./gradlew clean
./gradlew package
./gradlew test
./gradlew jacocoTestReport
./gradlew -Dsqoop.thirdparty.lib.dir= 
thirdPartyTest
./gradlew checkStyleMain
./gradlew compileJava
./gradlew publishToMavenLocal


Thanks,

Boglarka Egyed

Re: Review Request 68032: SQOOP-3352: Bump java target version to 1.8

2018-07-24 Thread Szabolcs Vasas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68032/#review206388
---



Hi Bogi,

Thanks for submitting this patch, it will be great to use the Java 8 features 
in Sqoop finally.

I have left a minor comment and apart from that we should remove 
'-XX:PermSize=256m', '-XX:MaxPermSize=512m' parameters from the jvmArgs 
properties in build.gradle since these JVM arguments are not supported in Java 
8.

Szabolcs


src/docs/man/sqoop.txt
Line 44 (original), 44 (patched)


We should change Sun to Oracle as well since it has been already acquired. 
The download link is redirected to Oracle but it would be better to change to 
an Oracle download link.


- Szabolcs Vasas


On July 24, 2018, 12:49 p.m., Boglarka Egyed wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68032/
> ---
> 
> (Updated July 24, 2018, 12:49 p.m.)
> 
> 
> Review request for Sqoop, Fero Szabo and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3352
> https://issues.apache.org/jira/browse/SQOOP-3352
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> * Bumped targetJavaVersion and sourceJavaVersion to 1.8 in build.xml
> * Bumped javaSourceCompatibilityVersion to 1.8 in gradle.properties
> * Updated documentation
> 
> 
> Diffs
> -
> 
>   COMPILING.txt 9abf0b211b24de65b53351ece170b09e4851938b 
>   README.txt b8f0a7a2c7d760c72f9811435b36c23cde354b15 
>   build.xml 0ae729bce035f6f1afef78702a3d888bb6c5a9ff 
>   gradle.properties a571e6cb26ddd3d687f3b3a2a69615a5e1fc71d5 
>   src/docs/man/sqoop.txt 7977e13091af184f6b1d10028aa827e033c9452a 
> 
> 
> Diff: https://reviews.apache.org/r/68032/diff/1/
> 
> 
> Testing
> ---
> 
> Successfully ran with ant:
> ant
> ant clean compile
> ant clean package
> ant clean test
> ant cobertura -Dcobertura.home=/path/to/cobertura
> ant clean test -Dthirdparty= ...
> ant checkstyle
> ant mvn-install
> ant docs
> ant eclipse
> 
> Succesfully ran with gradle:
> ./gradlew clean
> ./gradlew package
> ./gradlew test
> ./gradlew jacocoTestReport
> ./gradlew -Dsqoop.thirdparty.lib.dir= 
> thirdPartyTest
> ./gradlew checkStyleMain
> ./gradlew compileJava
> ./gradlew publishToMavenLocal
> 
> 
> Thanks,
> 
> Boglarka Egyed
> 
>

Review Request 68032: SQOOP-3352: Bump java target version to 1.8

2018-07-24 Thread Boglarka Egyed 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68032/
---

Review request for Sqoop, Fero Szabo and Szabolcs Vasas.


Bugs: SQOOP-3352
https://issues.apache.org/jira/browse/SQOOP-3352


Repository: sqoop-trunk


Description
---

* Bumped targetJavaVersion and sourceJavaVersion to 1.8 in build.xml
* Bumped javaSourceCompatibilityVersion to 1.8 in gradle.properties
* Updated documentation


Diffs
-

  COMPILING.txt 9abf0b211b24de65b53351ece170b09e4851938b 
  README.txt b8f0a7a2c7d760c72f9811435b36c23cde354b15 
  build.xml 0ae729bce035f6f1afef78702a3d888bb6c5a9ff 
  gradle.properties a571e6cb26ddd3d687f3b3a2a69615a5e1fc71d5 
  src/docs/man/sqoop.txt 7977e13091af184f6b1d10028aa827e033c9452a 


Diff: https://reviews.apache.org/r/68032/diff/1/


Testing
---

Successfully ran with ant:
ant
ant clean compile
ant clean package
ant clean test
ant cobertura -Dcobertura.home=/path/to/cobertura
ant clean test -Dthirdparty= ...
ant checkstyle
ant mvn-install
ant docs
ant eclipse

Succesfully ran with gradle:
./gradlew clean
./gradlew package
./gradlew test
./gradlew jacocoTestReport
./gradlew -Dsqoop.thirdparty.lib.dir= 
thirdPartyTest
./gradlew checkStyleMain
./gradlew compileJava
./gradlew publishToMavenLocal


Thanks,

Boglarka Egyed