[jira] [Commented] (STORM-1864) StormSubmitter should show proper error messages for submitter hook invocation.

[ https://issues.apache.org/jira/browse/STORM-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317864#comment-15317864 ] ASF GitHub Bot commented on STORM-1864: --- Github user asfgit closed the pull request at:

[GitHub] storm pull request #1469: STORM-1864 : StormSubmitter should throw respectiv...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1469 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (STORM-1864) StormSubmitter should show proper error messages for submitter hook invocation.

[ https://issues.apache.org/jira/browse/STORM-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317861#comment-15317861 ] ASF GitHub Bot commented on STORM-1864: --- Github user harshach commented on the issue:

[GitHub] storm issue #1469: STORM-1864 : StormSubmitter should throw respective excep...

Github user harshach commented on the issue: https://github.com/apache/storm/pull/1469 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (STORM-1864) StormSubmitter should show proper error messages for submitter hook invocation.

[ https://issues.apache.org/jira/browse/STORM-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317838#comment-15317838 ] ASF GitHub Bot commented on STORM-1864: --- Github user satishd commented on the issue:

[GitHub] storm issue #1469: STORM-1864 : StormSubmitter should throw respective excep...

Github user satishd commented on the issue: https://github.com/apache/storm/pull/1469 @harshach Can you merge this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm issue #1446: STORM-1864 StormSubmitter should throw respective excepti...

Github user satishd commented on the issue: https://github.com/apache/storm/pull/1446 @harshach Thanks for merging into master. `NimbusClient` is not auto closeable in 1.x branch. Raised #1469, Can you merge that? --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (STORM-1864) StormSubmitter should show proper error messages for submitter hook invocation.

[ https://issues.apache.org/jira/browse/STORM-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317837#comment-15317837 ] ASF GitHub Bot commented on STORM-1864: --- Github user satishd commented on the issue:

[jira] [Commented] (STORM-1864) StormSubmitter should show proper error messages for submitter hook invocation.

[ https://issues.apache.org/jira/browse/STORM-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317836#comment-15317836 ] ASF GitHub Bot commented on STORM-1864: --- GitHub user satishd opened a pull request:

[GitHub] storm pull request #1469: STORM-1864 : StormSubmitter should throw respectiv...

GitHub user satishd opened a pull request: https://github.com/apache/storm/pull/1469 STORM-1864 : StormSubmitter should throw respective exceptions and log respective errors forregistered submitter hook invocation Cherry picked form master #1446 and made relevant changes for this

[GitHub] storm issue #1446: STORM-1864 StormSubmitter should throw respective excepti...

Github user harshach commented on the issue: https://github.com/apache/storm/pull/1446 @satishd merged into master but getting following error on 1.x-branch [ERROR] COMPILATION ERROR : [INFO] - [ERROR]

[jira] [Commented] (STORM-1864) StormSubmitter should show proper error messages for submitter hook invocation.

[ https://issues.apache.org/jira/browse/STORM-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317728#comment-15317728 ] ASF GitHub Bot commented on STORM-1864: --- Github user harshach commented on the issue:

[jira] [Commented] (STORM-1864) StormSubmitter should show proper error messages for submitter hook invocation.

[ https://issues.apache.org/jira/browse/STORM-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317724#comment-15317724 ] ASF GitHub Bot commented on STORM-1864: --- Github user asfgit closed the pull request at:

[GitHub] storm pull request #1446: STORM-1864 StormSubmitter should throw respective ...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1446 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (STORM-1575) TwitterSampleSpout throws NPE on close

[ https://issues.apache.org/jira/browse/STORM-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317715#comment-15317715 ] ASF GitHub Bot commented on STORM-1575: --- Github user harshach commented on the issue:

[GitHub] storm issue #1153: [STORM-1575] fix TwitterSampleSpout NPE on close

Github user harshach commented on the issue: https://github.com/apache/storm/pull/1153 +1. build failure not related to the patch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm issue #1468: STORM-1885. python script for squashing and merging prs.

Github user harshach commented on the issue: https://github.com/apache/storm/pull/1468 @ptgoetz makes sense. We can make explicit case for not merging this PR if the origin PR has commits from multiple authors and also can be integrated into the tool to not to proceed if thats the

[jira] [Commented] (STORM-1885) python script for squashing and merging prs

[ https://issues.apache.org/jira/browse/STORM-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317711#comment-15317711 ] ASF GitHub Bot commented on STORM-1885: --- Github user harshach commented on the issue:

[GitHub] storm issue #1446: STORM-1864 StormSubmitter should throw respective excepti...

Github user harshach commented on the issue: https://github.com/apache/storm/pull/1446 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (STORM-1864) StormSubmitter should show proper error messages for submitter hook invocation.

[ https://issues.apache.org/jira/browse/STORM-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317676#comment-15317676 ] ASF GitHub Bot commented on STORM-1864: --- Github user harshach commented on the issue:

[jira] [Commented] (STORM-1885) python script for squashing and merging prs

[ https://issues.apache.org/jira/browse/STORM-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317640#comment-15317640 ] ASF GitHub Bot commented on STORM-1885: --- Github user ptgoetz commented on the issue:

[GitHub] storm issue #1468: STORM-1885. python script for squashing and merging prs.

Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1468 @harshach The source of the file is referenced here: https://github.com/apache/storm/pull/1468/files#diff-da45fe3972445a9f82ef768808dd8853R20 I'd like to get clearance that what this

[jira] [Commented] (STORM-1885) python script for squashing and merging prs

[ https://issues.apache.org/jira/browse/STORM-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317583#comment-15317583 ] ASF GitHub Bot commented on STORM-1885: --- Github user ptgoetz commented on the issue:

[GitHub] storm issue #1468: STORM-1885. python script for squashing and merging prs.

Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1468 > We won't be able capture this in JIRA either. I am not sure how much of this is important to have all the commits from each contributor for a single JIRA which in itself is rare unless its a big

[jira] [Commented] (STORM-1885) python script for squashing and merging prs

[ https://issues.apache.org/jira/browse/STORM-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317521#comment-15317521 ] ASF GitHub Bot commented on STORM-1885: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm issue #1468: STORM-1885. python script for squashing and merging prs.

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1468 @harshach I skimmed a bit, and guess determining fix version will not work since branch names we use are different from Spark and Kafka and so on. We can still input them by hand so there's

[jira] [Commented] (STORM-1885) python script for squashing and merging prs

[ https://issues.apache.org/jira/browse/STORM-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317511#comment-15317511 ] ASF GitHub Bot commented on STORM-1885: --- Github user harshach commented on the issue:

[GitHub] storm issue #1468: STORM-1885. python script for squashing and merging prs.

Github user harshach commented on the issue: https://github.com/apache/storm/pull/1468 @HeartSaVioR already ran a simple tests. I like it because it allows us to tag the reviewers and additional committers in the tag message and can be picked onto other branches as well. It does work

[jira] [Commented] (STORM-1885) python script for squashing and merging prs

[ https://issues.apache.org/jira/browse/STORM-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317510#comment-15317510 ] ASF GitHub Bot commented on STORM-1885: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm issue #1468: STORM-1885. python script for squashing and merging prs.

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1468 @harshach Yeah, I don't know what things Kafka improve from Spark script so I wanted to see the benefit if you know about it. As I commented earlier, just adopting script doesn't work since we

[GitHub] storm issue #1468: STORM-1885. python script for squashing and merging prs.

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1468 Actually I was the one which claims separated credits from other project. (https://github.com/OpenTSDB/asynchbase/pull/122) But there was a strong reason to do so, and I think it's not

[jira] [Commented] (STORM-1885) python script for squashing and merging prs

[ https://issues.apache.org/jira/browse/STORM-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317490#comment-15317490 ] ASF GitHub Bot commented on STORM-1885: --- Github user harshach commented on the issue:

[GitHub] storm issue #1468: STORM-1885. python script for squashing and merging prs.

Github user harshach commented on the issue: https://github.com/apache/storm/pull/1468 @HeartSaVioR Not aware of spark script. I am ok with using either one or make this one work as we needed. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (STORM-1885) python script for squashing and merging prs

[ https://issues.apache.org/jira/browse/STORM-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317482#comment-15317482 ] ASF GitHub Bot commented on STORM-1885: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm issue #1468: STORM-1885. python script for squashing and merging prs.

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1468 1. What's the difference between Spark script vs Kafka script? Spark script is origin of Kafka and Zeppelin, so unless there're specific improvements, I think picking Spark script is more

[GitHub] storm pull request #1468: STORM-1885. python script for squashing and mergin...

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1468#discussion_r65986785 --- Diff: dev-tools/storm-merge-pr.py --- @@ -0,0 +1,468 @@ +#!/usr/bin/env python + +# +# Licensed to the Apache Software Foundation

[jira] [Commented] (STORM-1885) python script for squashing and merging prs

[ https://issues.apache.org/jira/browse/STORM-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317399#comment-15317399 ] ASF GitHub Bot commented on STORM-1885: --- Github user harshach commented on the issue:

[GitHub] storm issue #1468: STORM-1885. python script for squashing and merging prs.

Github user harshach commented on the issue: https://github.com/apache/storm/pull/1468 "That means it removes authorship information. If we tag a squashed commit as coming from multiple authors, we still wouldn't be able to differentiate what code was contributed by the individual

[jira] [Commented] (STORM-1885) python script for squashing and merging prs

[ https://issues.apache.org/jira/browse/STORM-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316993#comment-15316993 ] ASF GitHub Bot commented on STORM-1885: --- Github user ptgoetz commented on the issue:

[GitHub] storm issue #1468: STORM-1885. python script for squashing and merging prs.

Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1468 > It will ask for primary authors and the user who is merging this can input more than one author at the time of merge. That means it removes authorship information. If we tag a squashed

[GitHub] storm issue #1458: STORM-1878: Flux can now handle IStatefulBolts

Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1458 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1468: STORM-1885. python script for squashing and merging prs.

Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1468 I'm a little on the fence in terms of squashing the commits of others vs. asking the contributor to do so. There are a lot of situations where spreading out a big patch over multiple commits makes

[jira] [Commented] (STORM-1885) python script for squashing and merging prs

[ https://issues.apache.org/jira/browse/STORM-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316941#comment-15316941 ] ASF GitHub Bot commented on STORM-1885: --- Github user harshach commented on the issue:

[GitHub] storm issue #1468: STORM-1885. python script for squashing and merging prs.

Github user harshach commented on the issue: https://github.com/apache/storm/pull/1468 commits can be preserved in contributors branch as they seem fit but it doesn't help having them in the main repo. As a contributor they know what those commits means but everyone else will doesn't

[jira] [Commented] (STORM-1885) python script for squashing and merging prs

[ https://issues.apache.org/jira/browse/STORM-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316925#comment-15316925 ] ASF GitHub Bot commented on STORM-1885: --- Github user ptgoetz commented on the issue:

[GitHub] storm issue #1466: Update worker.xml

Github user harshach commented on the issue: https://github.com/apache/storm/pull/1466 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [DISCUSSION] Squashing commits before merging in.

Thanks Jungtaek for starting this thread. Its on of my pet peeves that our commit log is very noisy. It would be great if we can squash commits into one commit message before merging the PR. This would keep the commit log clean and if someone wants to refer to particular JIRA patch its easy to go

[jira] [Commented] (STORM-1865) update command line client document

[ https://issues.apache.org/jira/browse/STORM-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316862#comment-15316862 ] ASF GitHub Bot commented on STORM-1865: --- GitHub user harshach opened a pull request:

[GitHub] storm pull request #1468: STORM-1865. python script for squashing and mergin...

GitHub user harshach opened a pull request: https://github.com/apache/storm/pull/1468 STORM-1865. python script for squashing and merging prs. You can merge this pull request into a Git repository by running: $ git pull https://github.com/harshach/incubator-storm STORM-1885

[jira] [Created] (STORM-1885) python script for squashing and merging prs

Sriharsha Chintalapani created STORM-1885: - Summary: python script for squashing and merging prs Key: STORM-1885 URL: https://issues.apache.org/jira/browse/STORM-1885 Project: Apache Storm

[jira] [Commented] (STORM-1771) HiveState should flushAndClose before closing old or idle Hive connections

[ https://issues.apache.org/jira/browse/STORM-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316837#comment-15316837 ] ASF GitHub Bot commented on STORM-1771: --- GitHub user harshach opened a pull request:

[GitHub] storm pull request #1467: STORM-1771. HiveState should flushAndClose before ...

GitHub user harshach opened a pull request: https://github.com/apache/storm/pull/1467 STORM-1771. HiveState should flushAndClose before closing old or idle Hive connections. You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (STORM-1719) Introduce REST API: Topology metric stats for stream

[ https://issues.apache.org/jira/browse/STORM-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316809#comment-15316809 ] ASF GitHub Bot commented on STORM-1719: --- Github user harshach commented on the issue:

[GitHub] storm issue #1347: STORM-1719 (1.x) Introduce REST API: Topology metric stat...

Github user harshach commented on the issue: https://github.com/apache/storm/pull/1347 @HeartSaVioR this looks great. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request #1466: Update worker.xml

GitHub user precabal opened a pull request: https://github.com/apache/storm/pull/1466 Update worker.xml properly reference Metrics appender in Storm 0.10.1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/precabal/storm patch-2

[GitHub] storm pull request #1465: Update worker.xml

Github user precabal closed the pull request at: https://github.com/apache/storm/pull/1465 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1465: Update worker.xml

Github user precabal commented on the issue: https://github.com/apache/storm/pull/1465 closing pull request to generate a working fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm issue #1465: Update worker.xml

Github user precabal commented on the issue: https://github.com/apache/storm/pull/1465 it should actually read: `appender-ref ref="METRICS"` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm pull request #1465: Update worker.xml

GitHub user precabal opened a pull request: https://github.com/apache/storm/pull/1465 Update worker.xml fixed bug on metrics appender You can merge this pull request into a Git repository by running: $ git pull https://github.com/precabal/storm patch-1 Alternatively you can

[jira] [Commented] (STORM-1884) In RedisKeyValueState.prepareCommit keys in pendingPrepare should have priority over pendingCommit

[ https://issues.apache.org/jira/browse/STORM-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316624#comment-15316624 ] ASF GitHub Bot commented on STORM-1884: --- GitHub user kosii opened a pull request:

[GitHub] storm pull request #1464: STORM-1884: Prioritize pendingPrepare over pending...

GitHub user kosii opened a pull request: https://github.com/apache/storm/pull/1464 STORM-1884: Prioritize pendingPrepare over pendingCommit You can merge this pull request into a Git repository by running: $ git pull https://github.com/s4mDev/storm fix_storm_1884

[jira] [Created] (STORM-1884) In RedisKeyValueState.prepareCommit keys in pendingPrepare should have priority over pendingCommit

Balazs Kossovics created STORM-1884: --- Summary: In RedisKeyValueState.prepareCommit keys in pendingPrepare should have priority over pendingCommit Key: STORM-1884 URL:

[GitHub] storm pull request #1453: STORM-1873 Implement alternative behaviour for lat...

Github user kosii commented on a diff in the pull request: https://github.com/apache/storm/pull/1453#discussion_r65866008 --- Diff: storm-core/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java --- @@ -188,6 +189,10 @@ private void validate(Map stormConf, Count

[GitHub] storm issue #939: [STORM-1175] State store for windowing operations

Github user kosii commented on the issue: https://github.com/apache/storm/pull/939 @arunmahadevan yes, I'm on it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request #1453: STORM-1873 Implement alternative behaviour for lat...

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/1453#discussion_r65863969 --- Diff: storm-core/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java --- @@ -188,6 +189,10 @@ private void validate(Map stormConf, Count

[GitHub] storm issue #939: [STORM-1175] State store for windowing operations

Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/939 @kosii Thanks for reporting. Yes the keys in `pendingPrepare` should have priority. Typically this case does not happen since when a prepare fails, the txn is rolled-back and retried (i.e a

[GitHub] storm pull request #:

Github user kosii commented on the pull request: https://github.com/apache/storm/commit/4623d8f87f044a9a8737a55bd32f955485900ce1#commitcomment-17749543 In external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java: In

[GitHub] storm pull request #:

Github user kosii commented on the pull request: https://github.com/apache/storm/commit/4623d8f87f044a9a8737a55bd32f955485900ce1#commitcomment-17749399 In external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java: In