[GitHub] storm pull request #1512: Adding hdfs-conf.yaml to all test cases to support...

2016-06-22 Thread csivaguru
GitHub user csivaguru opened a pull request: https://github.com/apache/storm/pull/1512 Adding hdfs-conf.yaml to all test cases to support security. You can merge this pull request into a Git repository by running: $ git pull https://github.com/csivaguru/storm STORM-1924

[GitHub] storm pull request #1511: Adding hdfs-conf.yaml to all test cases to support...

2016-06-22 Thread csivaguru
Github user csivaguru closed the pull request at: https://github.com/apache/storm/pull/1511 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (STORM-1766) A better algorithm server rack selection for RAS

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345535#comment-15345535 ] ASF GitHub Bot commented on STORM-1766: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm issue #1398: [STORM-1766] - A better algorithm server rack selection f...

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1398 @jerrypeng Since master branch is target to 2.0.0 and we don't have timeframe so it may be better to add it to 1.1.0 if you think it's not experimental feature. --- If your project is set up

[jira] [Updated] (STORM-1766) A better algorithm server rack selection for RAS

2016-06-22 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim updated STORM-1766: Fix Version/s: 2.0.0 > A better algorithm server rack selection for RAS >

[jira] [Commented] (STORM-1565) Multi-Lang Performance Improvements

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345483#comment-15345483 ] ASF GitHub Bot commented on STORM-1565: --- Github user dan-blanchard commented on the issue:

[GitHub] storm issue #1136: [STORM-1565] Multi-Lang Performance Improvements

2016-06-22 Thread dan-blanchard
Github user dan-blanchard commented on the issue: https://github.com/apache/storm/pull/1136 Yup. I subscribed yesterday. On Wed, Jun 22, 2016 at 8:35 PM Jungtaek Lim wrote: > OK great. Could you subscribe dev@ mailing list? I occasionally

[jira] [Commented] (STORM-1565) Multi-Lang Performance Improvements

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345477#comment-15345477 ] ASF GitHub Bot commented on STORM-1565: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm issue #1136: [STORM-1565] Multi-Lang Performance Improvements

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1136 OK great. Could you subscribe dev@ mailing list? I occasionally initiate discussion from there (multilang, too) so you might want to have a talk regarding to multilang. --- If your project is

Storm UI local eclipse mode

2016-06-22 Thread Arjun Rao
This might be a question answered before, but is there a way (or maybe an open ticket) to see the Storm UI while running the topology from the local eclipse workspace during development? Thanks! Best, Arjun

[GitHub] storm pull request #1442: Adding hdfs-conf.yaml to all test cases to support...

2016-06-22 Thread csivaguru
Github user csivaguru closed the pull request at: https://github.com/apache/storm/pull/1442 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1442: Adding hdfs-conf.yaml to all test cases to support securi...

2016-06-22 Thread csivaguru
Github user csivaguru commented on the issue: https://github.com/apache/storm/pull/1442 I have created a PR against 1.x-branch. I am closing this PR. https://github.com/apache/storm/pull/1511 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm pull request #1511: Adding hdfs-conf.yaml to all test cases to support...

2016-06-22 Thread csivaguru
GitHub user csivaguru opened a pull request: https://github.com/apache/storm/pull/1511 Adding hdfs-conf.yaml to all test cases to support security. You can merge this pull request into a Git repository by running: $ git pull https://github.com/csivaguru/storm STORM-1924

[jira] [Commented] (STORM-817) Kafka Wildcard Topic Support

2016-06-22 Thread Mike Treadway (JIRA)
[ https://issues.apache.org/jira/browse/STORM-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345162#comment-15345162 ] Mike Treadway commented on STORM-817: - Hi there, I'm seeing an issue with this implementation and I'm

[jira] [Updated] (STORM-1924) Add a config file parameter to HDFS test topologies

2016-06-22 Thread Sivaguru Kannan (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sivaguru Kannan updated STORM-1924: --- Summary: Add a config file parameter to HDFS test topologies (was: Adding hdfs-conf.yaml to

[jira] [Created] (STORM-1924) Adding hdfs-conf.yaml to test cases

2016-06-22 Thread Sivaguru Kannan (JIRA)
Sivaguru Kannan created STORM-1924: -- Summary: Adding hdfs-conf.yaml to test cases Key: STORM-1924 URL: https://issues.apache.org/jira/browse/STORM-1924 Project: Apache Storm Issue Type: Bug

[jira] [Commented] (STORM-1866) Update Resource Aware Scheduler Documentation

2016-06-22 Thread Boyang Jerry Peng (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345044#comment-15345044 ] Boyang Jerry Peng commented on STORM-1866: -- [~ptgoetz] Sorry I have been busy for the last couple

[jira] [Commented] (STORM-1866) Update Resource Aware Scheduler Documentation

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345040#comment-15345040 ] ASF GitHub Bot commented on STORM-1866: --- GitHub user jerrypeng opened a pull request:

[GitHub] storm pull request #1510: [STORM-1866] - Update Resource Aware Scheduler Doc...

2016-06-22 Thread jerrypeng
GitHub user jerrypeng opened a pull request: https://github.com/apache/storm/pull/1510 [STORM-1866] - Update Resource Aware Scheduler Documentation You can merge this pull request into a Git repository by running: $ git pull https://github.com/jerrypeng/storm STORM-1866

[jira] [Commented] (STORM-1565) Multi-Lang Performance Improvements

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345034#comment-15345034 ] ASF GitHub Bot commented on STORM-1565: --- Github user dan-blanchard commented on the issue:

[GitHub] storm issue #1136: [STORM-1565] Multi-Lang Performance Improvements

2016-06-22 Thread dan-blanchard
Github user dan-blanchard commented on the issue: https://github.com/apache/storm/pull/1136 > Pystorm seems great, and we lack contributors who care multi-lang implementations as one of major module so I'd still rather rely on stable implementation than build from scratch. Just one

[jira] [Updated] (STORM-1923) Storm site page not found

2016-06-22 Thread darion yaphet (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] darion yaphet updated STORM-1923: - Description:

[jira] [Comment Edited] (STORM-1879) Supervisor may not shut down workers cleanly

2016-06-22 Thread Nico Meyer (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344582#comment-15344582 ] Nico Meyer edited comment on STORM-1879 at 6/22/16 3:55 PM: I am not sure

[jira] [Commented] (STORM-1879) Supervisor may not shut down workers cleanly

2016-06-22 Thread Nico Meyer (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344582#comment-15344582 ] Nico Meyer commented on STORM-1879: --- I am not sure about the problem Jeyendran Balakrishnan described,

[jira] [Commented] (STORM-1916) Add ability for worker-first classpath

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344482#comment-15344482 ] ASF GitHub Bot commented on STORM-1916: --- Github user knusbaum commented on the issue:

[GitHub] storm issue #1507: STORM-1916: Add ability for worker-first classpath

2016-06-22 Thread knusbaum
Github user knusbaum commented on the issue: https://github.com/apache/storm/pull/1507 @HeartSaVioR @abhishekagarwal87 Yes, I accidentally included STORM-1913 in this PR. I'll remove it. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (STORM-1879) Supervisor may not shut down workers cleanly

2016-06-22 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344431#comment-15344431 ] Robert Joseph Evans commented on STORM-1879: I have not seen either of these issue on our

[jira] [Created] (STORM-1922) Supervisor summary default order by host

2016-06-22 Thread Xin Wang (JIRA)
Xin Wang created STORM-1922: --- Summary: Supervisor summary default order by host Key: STORM-1922 URL: https://issues.apache.org/jira/browse/STORM-1922 Project: Apache Storm Issue Type: Improvement

[jira] [Resolved] (STORM-1911) Inconsistency of timestamp between IMetricsConsumer and IClusterMetricsConsumer

2016-06-22 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim resolved STORM-1911. - Resolution: Fixed Fix Version/s: 1.1.0 2.0.0 > Inconsistency of

[jira] [Commented] (STORM-1872) Storm Redis connection release

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344391#comment-15344391 ] ASF GitHub Bot commented on STORM-1872: --- Github user darionyaphet commented on the issue:

[GitHub] storm issue #1455: [STORM-1872]Release Jedis connection when topology shutdo...

2016-06-22 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1455 @HeartSaVioR done ! travis ci started and working . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (STORM-1921) Update parallelism_hint date type to integer

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344389#comment-15344389 ] ASF GitHub Bot commented on STORM-1921: --- Github user darionyaphet commented on the issue:

[GitHub] storm issue #1509: [STORM-1921] Update parallelism_hint date type to integer

2016-06-22 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1509 @HeartSaVioR done ! travis ci started and working . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (STORM-1844) Some tests are flaky due to low timeout

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344386#comment-15344386 ] ASF GitHub Bot commented on STORM-1844: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm issue #1421: STORM-1844: Make netty unit test use STORM_TEST_TIMEOUT_M...

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1421 +1 Sorry it took long to be here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (STORM-1921) Update parallelism_hint date type to integer

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344371#comment-15344371 ] ASF GitHub Bot commented on STORM-1921: --- Github user darionyaphet commented on the issue:

[jira] [Commented] (STORM-1921) Update parallelism_hint date type to integer

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344379#comment-15344379 ] ASF GitHub Bot commented on STORM-1921: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm issue #1509: [STORM-1921] Update parallelism_hint date type to integer

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1509 Yes please update your master branch to recent version, and git rebase master from STORM-1921 branch, and push STORM-1921 branch with --force option. --- If your project is set up for it, you

[GitHub] storm issue #1509: [STORM-1921] Update parallelism_hint date type to integer

2016-06-22 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1509 Hi @HeartSaVioR I should running `git rebase master` ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm issue #1436: add hadoop-common dependency in README for storm-hdfs

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1436 And filing a new JIRA would be ideal. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm issue #1436: add hadoop-common dependency in README for storm-hdfs

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1436 @mazhechao Could you please add hadoop-auth, too? Thanks in advance! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (STORM-1888) add description for storm shell command

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344358#comment-15344358 ] ASF GitHub Bot commented on STORM-1888: --- Github user vesense commented on the issue:

[GitHub] storm issue #1472: STORM-1888: add description for shell command

2016-06-22 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1472 @HeartSaVioR Updated and rebased. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (STORM-1872) Storm Redis connection release

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344356#comment-15344356 ] ASF GitHub Bot commented on STORM-1872: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm issue #1455: [STORM-1872]Release Jedis connection when topology shutdo...

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1455 @darionyaphet Could you rebase it to recent master to trigger build? Thanks in advance! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (STORM-1872) Storm Redis connection release

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344355#comment-15344355 ] ASF GitHub Bot commented on STORM-1872: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm issue #1455: [STORM-1872]Release Jedis connection when topology shutdo...

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1455 The change looks good. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request #1472: STORM-1888: add description for shell command

2016-06-22 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/1472#discussion_r68058773 --- Diff: bin/storm.py --- @@ -485,6 +485,11 @@ def kill_workers(*args): extrajars=[USER_CONF_DIR, os.path.join(STORM_DIR, "bin")])

[jira] [Commented] (STORM-1888) add description for storm shell command

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344349#comment-15344349 ] ASF GitHub Bot commented on STORM-1888: --- Github user vesense commented on a diff in the pull

[jira] [Commented] (STORM-1921) Update parallelism_hint date type to integer

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344327#comment-15344327 ] ASF GitHub Bot commented on STORM-1921: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm issue #1509: [STORM-1921] Update parallelism_hint date type to integer

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1509 @darionyaphet Could you rebase this to current master so that CI can test the pull request correctly? Thanks in advance! --- If your project is set up for it, you can reply to this email

[jira] [Commented] (STORM-1920) version of parent pom for storm-kafka-monitor is set 1.0.2-SNAPSHOT in master branch

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344325#comment-15344325 ] ASF GitHub Bot commented on STORM-1920: --- Github user asfgit closed the pull request at:

[jira] [Resolved] (STORM-1920) version of parent pom for storm-kafka-monitor is set 1.0.2-SNAPSHOT in master branch

2016-06-22 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim resolved STORM-1920. - Resolution: Fixed Fix Version/s: 2.0.0 > version of parent pom for storm-kafka-monitor is

[GitHub] storm issue #1508: STORM-1920 version of parent pom for storm-kafka-monitor ...

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1508 CI build green. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (STORM-1920) version of parent pom for storm-kafka-monitor is set 1.0.2-SNAPSHOT in master branch

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344324#comment-15344324 ] ASF GitHub Bot commented on STORM-1920: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm pull request #1508: STORM-1920 version of parent pom for storm-kafka-m...

2016-06-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1508 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (STORM-1872) Storm Redis connection release

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344110#comment-15344110 ] ASF GitHub Bot commented on STORM-1872: --- Github user darionyaphet commented on a diff in the pull

[GitHub] storm pull request #1455: [STORM-1872]Release Jedis connection when topology...

2016-06-22 Thread darionyaphet
Github user darionyaphet commented on a diff in the pull request: https://github.com/apache/storm/pull/1455#discussion_r68033224 --- Diff: external/storm-redis/src/main/java/org/apache/storm/redis/common/container/JedisCommandsInstanceContainer.java --- @@ -34,4 +36,10 @@

[jira] [Commented] (STORM-1872) Storm Redis connection release

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344066#comment-15344066 ] ASF GitHub Bot commented on STORM-1872: --- Github user HeartSaVioR commented on a diff in the pull

[GitHub] storm pull request #1455: [STORM-1872]Release Jedis connection when topology...

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1455#discussion_r68027394 --- Diff: external/storm-redis/src/main/java/org/apache/storm/redis/common/container/JedisCommandsInstanceContainer.java --- @@ -34,4 +36,10 @@

[GitHub] storm issue #1457: Fix jira-github-join tools: Apache Jira doesn't allow req...

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1457 I'd be happy if someone take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (STORM-1883) FileReader extends Closeable Interface

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344055#comment-15344055 ] ASF GitHub Bot commented on STORM-1883: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm issue #1462: [STORM-1883] FileReader extends Closeable Interface

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1462 I'm also in favor of using standard java interface. Just it seems not have any valuable benefits. I'm fine either change or keep it as is. --- If your project is set up for it, you can reply to

[GitHub] storm issue #1466: Update worker.xml

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1466 Great finding. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[jira] [Commented] (STORM-1921) Update parallelism_hint date type to integer

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344039#comment-15344039 ] ASF GitHub Bot commented on STORM-1921: --- GitHub user darionyaphet opened a pull request:

[jira] [Commented] (STORM-1885) python script for squashing and merging prs

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344040#comment-15344040 ] ASF GitHub Bot commented on STORM-1885: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm issue #1468: STORM-1885. python script for squashing and merging prs.

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1468 I'll take a deep look and describe what this script actually does. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm pull request #1509: [STORM-1921] Update parallelism_hint date type to ...

2016-06-22 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1509 [STORM-1921] Update parallelism_hint date type to integer [STORM-1921](https://issues.apache.org/jira/browse/STORM-1921) Update TopologyBuilder's parallelism_hint date type from Number

[jira] [Commented] (STORM-1885) python script for squashing and merging prs

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344034#comment-15344034 ] ASF GitHub Bot commented on STORM-1885: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm issue #1468: STORM-1885. python script for squashing and merging prs.

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1468 I'd really like to go forward with automated tools for developers / committers. What I've stated from dev@ mailing list, many projects already use specific tools for merging, and the merge

[jira] [Commented] (STORM-1888) add description for storm shell command

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344020#comment-15344020 ] ASF GitHub Bot commented on STORM-1888: --- Github user HeartSaVioR commented on a diff in the pull

[GitHub] storm pull request #1472: STORM-1888: add description for shell command

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1472#discussion_r68023943 --- Diff: bin/storm.py --- @@ -485,6 +485,11 @@ def kill_workers(*args): extrajars=[USER_CONF_DIR, os.path.join(STORM_DIR, "bin")])

[jira] [Commented] (STORM-1895) blobstore replication-factor argument

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343999#comment-15343999 ] ASF GitHub Bot commented on STORM-1895: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm issue #1477: [STORM-1895] Blob Store replication-factor argument

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1477 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (STORM-1881) storm-redis is missing dependant libraries in distribution

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343994#comment-15343994 ] ASF GitHub Bot commented on STORM-1881: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm issue #1480: STORM-1881: Create fat-jar of storm-redis which contains ...

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1480 Getting rid of Guava seems easy since storm-redis uses Precondition, ImmutableMap, Maps, Lists. Getting rid of Jackson seems not easy since we take StateConfig to JSON format so we need JSON

[jira] [Commented] (STORM-1914) Storm Kafka Field Topic Selector

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343991#comment-15343991 ] ASF GitHub Bot commented on STORM-1914: --- Github user abhishekagarwal87 commented on the issue:

[GitHub] storm issue #1501: [STORM-1914] Storm Kafka Field Topic Selector

2016-06-22 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the issue: https://github.com/apache/storm/pull/1501 Looks good to me too. Thank you @darionyaphet --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Created] (STORM-1921) Update parallelism_hint date type to integer

2016-06-22 Thread darion yaphet (JIRA)
darion yaphet created STORM-1921: Summary: Update parallelism_hint date type to integer Key: STORM-1921 URL: https://issues.apache.org/jira/browse/STORM-1921 Project: Apache Storm Issue

[jira] [Commented] (STORM-1881) storm-redis is missing dependant libraries in distribution

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343973#comment-15343973 ] ASF GitHub Bot commented on STORM-1881: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm issue #1480: STORM-1881: Create fat-jar of storm-redis which contains ...

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1480 Let me have a look. I guess storm-redis doesn't need to depend on other than storm-core and Jedis. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm issue #1482: STORM-1876: Option to build storm-kafka and storm-kafka-c...

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1482 I guess what we would want is - We describe default version of storm-kafka and storm-kafka-client clearly so that users can use it directly when version is matched to what users want. -

[jira] [Commented] (STORM-1876) Provide option to build storm-kafka against different kafka clients

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343966#comment-15343966 ] ASF GitHub Bot commented on STORM-1876: --- Github user HeartSaVioR commented on the issue:

[jira] [Commented] (STORM-1875) Separate Jedis/JedisCluster Config

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343944#comment-15343944 ] ASF GitHub Bot commented on STORM-1875: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm issue #1483: [STORM-1875] : Separate Jedis/JedisCluster Config

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1483 It breaks backward compatibility so we can't go on this. And in fact, separation of Jedis and JedisCluster is only needed when users want to use multiple keys operation, which is not applied

[GitHub] storm issue #1485: [STORM-1899] Release HBase connection when topology shutd...

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1485 While Storm doesn't guarantee that cleanup() will be called during shutdown, it will be better than now. +1 --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (STORM-1899) Release HBase connection when topology shutdown

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343935#comment-15343935 ] ASF GitHub Bot commented on STORM-1899: --- Github user HeartSaVioR commented on the issue:

[jira] [Commented] (STORM-1902) add a simple & flexible FileNameFormat for storm-hdfs

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343926#comment-15343926 ] ASF GitHub Bot commented on STORM-1902: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm issue #1490: STORM-1902 (1.x): add a simple & flexible FileNameFormat ...

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1490 The change looks good. I just would like to add kind explanation to letting users know and use new feature. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (STORM-1902) add a simple & flexible FileNameFormat for storm-hdfs

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343909#comment-15343909 ] ASF GitHub Bot commented on STORM-1902: --- Github user HeartSaVioR commented on a diff in the pull

[GitHub] storm pull request #1490: STORM-1902 (1.x): add a simple & flexible FileName...

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1490#discussion_r68013918 --- Diff: external/storm-hdfs/README.md --- @@ -159,6 +159,8 @@ For example: By default, prefix is empty and extenstion is ".txt".

[jira] [Commented] (STORM-1920) version of parent pom for storm-kafka-monitor is set 1.0.2-SNAPSHOT in master branch

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343900#comment-15343900 ] ASF GitHub Bot commented on STORM-1920: --- Github user darionyaphet commented on the issue:

[GitHub] storm issue #1508: STORM-1920 version of parent pom for storm-kafka-monitor ...

2016-06-22 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1508 `versions-maven-plugin` is used when we want to manage the versions in a project's POM file . `Storm` have lot of modules this is maybe useful . --- If your project is set up for

[jira] [Commented] (STORM-1914) Storm Kafka Field Topic Selector

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343890#comment-15343890 ] ASF GitHub Bot commented on STORM-1914: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm issue #1501: [STORM-1914] Storm Kafka Field Topic Selector

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1501 @darionyaphet Thanks for following up quickly. +1 on me. @abhishekagarwal87 Could you review it again? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm pull request #1479: [STORM-1880] Support EXISTS Command Storm-Redis

2016-06-22 Thread darionyaphet
Github user darionyaphet closed the pull request at: https://github.com/apache/storm/pull/1479 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1501: [STORM-1914] Storm Kafka Field Topic Selector

2016-06-22 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1501 @HeartSaVioR I misunderstood what you meant. keep constructor with fieldName/fieldIndex and default topic name . thanks ~ --- If your project is set up for it, you can reply

[GitHub] storm issue #1501: [STORM-1914] Storm Kafka Field Topic Selector

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1501 In other word, constructors which receives two parameters are fine with me, but constructors which receives only one parameter are bad for me. --- If your project is set up for it, you can

[jira] [Commented] (STORM-1914) Storm Kafka Field Topic Selector

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343830#comment-15343830 ] ASF GitHub Bot commented on STORM-1914: --- Github user HeartSaVioR commented on the issue:

[jira] [Commented] (STORM-1914) Storm Kafka Field Topic Selector

2016-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343827#comment-15343827 ] ASF GitHub Bot commented on STORM-1914: --- Github user HeartSaVioR commented on the issue:

  1   2   >