Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1757
@hmcl merged into master but can't cherry-pick into storm-1.x. Here is the
error I am getting
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.1:compile
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1777
STORM-2202 [Storm SQL] Document how to use supported connectors and formats
Copy setting up external data sources to reference page, and add
description on data sources (connectors) and
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1757
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1687
@harshach done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user hmcl closed the pull request at:
https://github.com/apache/storm/pull/1687
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1687
@hmcl This PR here has two commits right?
https://github.com/apache/storm/pull/1757/commits . Why do we want to merge
this PR again?. Closing the PR doesn't mean you'll loose comments.
I am not
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1757
@harshach changed the title of the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1687
@harshach I have changed the titles of the PRs, however what is really
important are the git commit messages, and those were correct. Once the patch
is merged, no one will ever look at the PR titles
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1687
@hmcl also this PR is the same as this one with one more commit?
https://github.com/apache/storm/pull/1757/commits . If so can you close
this one.
---
If your project is set up for it, you can
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1687
@hmcl these PR titles are very confusing. Can you fix that in both the PRs.
Not sure what it means by "Apache master storm 1694 top storm 2097". Just add
the JIRA title as PR title.
---
If your
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1776
STORM-1446 also addresses STORM-2200, so this patch doesn't need to be
merged when STORM-1446 is merged earlier.
---
If your project is set up for it, you can reply to this email and have your
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1734
This is against STORM-2200 which is discussed on dev@. Closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user HeartSaVioR closed the pull request at:
https://github.com/apache/storm/pull/1734
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1736
Also addressed STORM-2200: Drop Aggregate & Join support on Trident mode
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1776
STORM-2200 [Storm SQL] Drop Aggregate & Join support on Trident mode
* Dropping aggregate & join support based on discussion
* These implementation will be reused when we introduce them
Github user HeartSaVioR closed the pull request at:
https://github.com/apache/storm/pull/1594
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1595
Closing in favor of STORM-2153, we're going to build new metrics.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user HeartSaVioR closed the pull request at:
https://github.com/apache/storm/pull/1595
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1594
Closing in favor of STORM-2153, we're going to build new metrics.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Some issues on Storm SQL are resolved but not documented yet. I'll file an
issue and assign to 1.1.0 release epic.
And also I want to address dropping aggregation and join on Storm SQL
Trident mode before releasing. I'll assign it too.
- Jungtaek Lim (HeartSaVioR)
2016년 11월 15일 (화) 오전 5:55, P.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1775
Confirmed 1c1029f addresses my review comments from #1756, and unit tests
passed in my local.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1679
+1
@jfenc91 thanks for the extra cleanup.
@revans2 as far as I am concerned this patch is ready to merge. Thanks for
your clarifying comments.
---
If your project is set up for it,
Github user jfenc91 commented on the issue:
https://github.com/apache/storm/pull/1679
@hmcl thanks for the review. I believe I made all the requested changes
here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jfenc91 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1679#discussion_r87907464
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/SingleTopicKafkaSpoutTest.java
---
@@ -0,0 +1,250 @@
+/*
+ *
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1756
FYI I put up a separate pull request based off of this one at #1775
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/1775
STORM-1278: Port org.apache.storm.daemon.worker to java
This replaces pull request #1756
You can merge this pull request into a Git repository by running:
$ git pull
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1756#discussion_r87902202
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/worker/Worker.java ---
@@ -0,0 +1,426 @@
+/**
+ * Licensed to the Apache Software Foundation
I think we’re very close. I would like to confirm that the 1.x-branch is not
affected by STORM-2176.
The worker lifecycle API was added in 1.0, but doesn’t work in any released
version due to STORM-2176.
If there are any other open JIRAs that anyone is passionate about, now would be
a good
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1756
OK I'll get started on this. Should hopefully have something up soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1754
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1754
CSV -> TSV
```
CREATE EXTERNAL TABLE ORDERS (ID INT PRIMARY KEY, UNIT_PRICE INT, QUANTITY
INT) STORED AS INPUTFORMAT 'org.apache.storm.sql.runtime.serde.csv.CsvScheme'
OUTPUTFORMAT
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1754
@vesense
Changeset looks good. I'll do some manual tests later today or tomorrow.
Thanks for nice work.
---
If your project is set up for it, you can reply to this email and have your
32 matches
Mail list logo
