Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2454
@hmcl I don't think the drawback scenario can happen "normally", since the
spout never has OffsetManagers for partitions it isn't assigned except when
reactivating after deactivation. It's mainly a
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2454#discussion_r157134976
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -442,10 +435,13 @@ private boolean isEmitTuple(List
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2454#discussion_r157134967
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -442,10 +435,13 @@ private boolean isEmitTuple(List
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2454
@srdo Can you explain how can the drawback scenario you describe in your
[comment](https://github.com/apache/storm/pull/2454#issuecomment-351428500)
happen? When activate happens, refresh partitions
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2454#discussion_r157104947
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -442,10 +435,13 @@ private boolean isEmitTuple(List
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2454#discussion_r157061077
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -442,10 +435,13 @@ private boolean isEmitTuple(List
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2457
+1
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2458
+1
---
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2461
Thanks @HeartSaVioR @kishorvpatil
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2458
@ptgoetz @arunmahadevan
Addressed or left comments. Please take a look again.
---
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2458#discussion_r157095359
--- Diff: conf/storm.yaml.example ---
@@ -72,4 +72,11 @@
# argument:
# - endpoint: "metrics-collector.mycompany.org"
#
-#
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2459
+1
There're number of reporting on current image.
https://github.com/travis-ci/travis-ci/issues?q=is%3Aissue+is%3Aopen+label%3A2017-Q4-trusty-env-update
Let's just back and
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2461
I believe this and STORM-2794 are (and should be) just a short term
solution. Based on the assumption I'm +1 except minor comment.
---
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2461#discussion_r157092913
--- Diff:
storm-client/src/jvm/org/apache/storm/validation/ConfigValidation.java ---
@@ -562,14 +562,24 @@ public void validateField(String name, Object
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2458#discussion_r157091935
--- Diff: storm-core/src/jvm/org/apache/storm/metric/IEventLogger.java ---
@@ -31,32 +32,54 @@
/**
* A wrapper for the fields that we
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2458#discussion_r157091241
--- Diff: storm-core/src/jvm/org/apache/storm/metric/IEventLogger.java ---
@@ -31,32 +32,54 @@
/**
* A wrapper for the fields that we
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2458#discussion_r157090966
--- Diff: storm-core/src/jvm/org/apache/storm/metric/IEventLogger.java ---
@@ -31,32 +32,54 @@
/**
* A wrapper for the fields that we
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2458#discussion_r157090722
--- Diff: conf/storm.yaml.example ---
@@ -72,4 +72,11 @@
# argument:
# - endpoint: "metrics-collector.mycompany.org"
#
-#
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2458#discussion_r157090250
--- Diff: conf/storm.yaml.example ---
@@ -72,4 +72,11 @@
# argument:
# - endpoint: "metrics-collector.mycompany.org"
#
-#
GitHub user Ethanlm opened a pull request:
https://github.com/apache/storm/pull/2461
[STORM-2857] Loosen some constraints to support running topologies of older
version
Some explanation in https://issues.apache.org/jira/browse/STORM-2857
I have been thinking about some
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2458#discussion_r157074167
--- Diff: conf/storm.yaml.example ---
@@ -72,4 +72,11 @@
# argument:
# - endpoint: "metrics-collector.mycompany.org"
#
-#
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2458
+1, once the minor nits are addressed.
---
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2457#discussion_r157072382
--- Diff: docs/Eventlogging.md ---
@@ -94,3 +95,29 @@ public interface IEventLogger {
void close();
}
```
+
+The default
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2456#discussion_r157072777
--- Diff:
storm-server/src/test/java/org/apache/storm/scheduler/resource/TestResourceAwareScheduler.java
---
@@ -640,6 +641,150 @@ public void
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/2442
cool this got open sourced!
---
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2459
+1
---
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2447
+1
---
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2458#discussion_r157056998
--- Diff: storm-core/src/jvm/org/apache/storm/metric/IEventLogger.java ---
@@ -31,32 +32,54 @@
/**
* A wrapper for the fields that we
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2458#discussion_r157056272
--- Diff: conf/storm.yaml.example ---
@@ -72,4 +72,11 @@
# argument:
# - endpoint: "metrics-collector.mycompany.org"
#
-#
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2203
> Looks like we compose metric name and lookup from REGISTRY every time,
even without executor ID and stream ID. I can see more calculation should be
done after addressing, but not sure how much it
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2460
STORM-2851 1.x
See https://github.com/apache/storm/pull/2453
Will squash once reviewed.
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2459
STORM-2855: Revert to 2017Q4 Ubuntu image in Travis to fix build
This is just to get builds working again. I've raised
https://issues.apache.org/jira/browse/STORM-2856 to figure out why it's broken
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2453
@hmcl I'll put up a 1.x version later today. It would be good to get 1.2.0
out soon, but my impression is that we're still waiting for metrics v2, as well
as a few other storm-kafka-client fixes
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2428
@srdo don't worry about the authorship. It was just a code review for which
I created a PR to make it easier to discuss.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2453
@srdo do you know when you will get the chance to create the PR for 1.x?
Not to rush, but I was hoping we could start converging towards getting 1.2.0
out. Thanks.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2458
Tested manually with FileBasedEventLogger.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2457
Tested manually with FileBasedEventLogger.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2203
@ptgoetz
Looks like we compose metric name and lookup from REGISTRY every time, even
without executor ID and stream ID. I can see more calculation should be done
after addressing, but not
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/2458
(1.x) STORM-2854 Expose IEventLogger to make event logging pluggable
* expose option to register IEventLogger similar to metrics consumer
* change the interface of IEventLogger slightly
39 matches
Mail list logo
