[GitHub] storm issue #2518: STORM-2902: Some improvements for storm-rocketmq module

Github user vongosling commented on the issue: https://github.com/apache/storm/pull/2518 Good Catch, what's the plan for this pr? I noticed that we have kept the unmerged status for a long time. ---

Storm multilang - .net core (WAS: [apache/storm] .NET Core 2.0 multi-lang adapter (#2613))

Jungtaek, everyone, I am very sorry that we missed your reply – If you received an undeliverable message from Microsoft, could you please forward to my private email address (mau...@live.com) ? I need to make sure that this does not happen again – I am now subscribed to

[GitHub] storm issue #2591: STORM-2979: WorkerHooks EOFException during run_worker_sh...

Github user hummelm commented on the issue: https://github.com/apache/storm/pull/2591 Here is a new implementation which is compatible with stateful workerhook. I think this implementation is better isn't it ? ---

[GitHub] storm pull request #2621: [STORM-3017] Refactor pacemaker client exception h...

GitHub user Ethanlm opened a pull request: https://github.com/apache/storm/pull/2621 [STORM-3017] Refactor pacemaker client exception handling https://issues.apache.org/jira/browse/STORM-3017 Better exception handling for pacemaker client You can merge this pull request

[GitHub] storm issue #2620: STORM-2994: KafkaSpout doesn't commit offsets for null tu...

Github user reiabreu commented on the issue: https://github.com/apache/storm/pull/2620 Yeah, going through the Travis logs it does seem they are unstable. Thank you for your help. Much appreciated. ---

[GitHub] storm issue #2620: STORM-2994: KafkaSpout doesn't commit offsets for null tu...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2620 Sorry, the tests sadly are very unstable on travis on the 1.x branch. Ran the storm-kafka-client tests locally and verified that they work on Java 7. ---

[GitHub] storm pull request #2620: STORM-2994: KafkaSpout doesn't commit offsets for ...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2620 ---

[GitHub] storm pull request #2620: STORM-2994: KafkaSpout doesn't commit offsets for ...

GitHub user reiabreu reopened a pull request: https://github.com/apache/storm/pull/2620 STORM-2994: KafkaSpout doesn't commit offsets for null tuples You can merge this pull request into a Git repository by running: $ git pull https://github.com/reiabreu/storm 1.x-branch

[GitHub] storm pull request #2620: STORM-2994: KafkaSpout doesn't commit offsets for ...

Github user reiabreu closed the pull request at: https://github.com/apache/storm/pull/2620 ---

[GitHub] storm pull request #2620: STORM-2994: KafkaSpout doesn't commit offsets for ...

GitHub user reiabreu opened a pull request: https://github.com/apache/storm/pull/2620 STORM-2994: KafkaSpout doesn't commit offsets for null tuples You can merge this pull request into a Git repository by running: $ git pull https://github.com/reiabreu/storm 1.x-branch

[GitHub] storm issue #600: STORM-903: fix java.lang.ClassNotFoundException with org.a...

Github user d2r commented on the issue: https://github.com/apache/storm/pull/600 I have closed this PR due to inactivity. Jira STORM-903 remains open. Please re-open or create a new PR if we want to fix this. ---

[GitHub] storm pull request #600: STORM-903: fix java.lang.ClassNotFoundException wit...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/600 ---

[GitHub] storm issue #2593: STORM-2994 KafkaSpout doesn't commit null tuples offsets

Github user reiabreu commented on the issue: https://github.com/apache/storm/pull/2593 @srdo Sure, I'll have a look ---

[GitHub] storm issue #2593: STORM-2994 KafkaSpout doesn't commit null tuples offsets

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2593 @reiabreu Merged to master. Looks like there are some small modifications to do to get it on to 1.x or earlier branches. Could you put up a PR against 1.x as well (should be pretty easy with `git

[GitHub] storm pull request #2593: STORM-2994 KafkaSpout doesn't commit null tuples o...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2593 ---

[GitHub] storm issue #2613: .NET Core 2.0 multi-lang adapter

Github user MaurGi commented on the issue: https://github.com/apache/storm/pull/2613 Darn – Did not realize that you replied but we did not receive the mail – Looking at the thread now - -MG- From: Jungtaek Lim Sent: Monday,

[GitHub] storm issue #2618: [STORM-2905] Fix KeyNotFoundException when kill a storm a...

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2618 Just FYI I files STORM-3020 to address the race that I just found. ---

[GitHub] storm issue #2618: [STORM-2905] Fix KeyNotFoundException when kill a storm a...

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2618 @danny0405 {{updateBlobs}} does not need to be guarded by a lock. This is what I was talking about with the code being complex. {{requestDownloadBaseTopologyBlobs}} is protected

[GitHub] storm issue #2603: [STORM-3003] Adding Assignment caching to Nimbus

Github user kishorvpatil commented on the issue: https://github.com/apache/storm/pull/2603 @HeartSaVioR , I think changes in #2433 do take care of caching assignments within `InMemoryAssignmentBackend`, so the changes proposed in #2603 are no longer needed. I am closing this PR ---

[GitHub] storm pull request #2603: [STORM-3003] Adding Assignment caching to Nimbus

Github user kishorvpatil closed the pull request at: https://github.com/apache/storm/pull/2603 ---

[GitHub] storm pull request #2618: [STORM-2905] Fix KeyNotFoundException when kill a ...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2618#discussion_r178852812 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/Slot.java --- @@ -497,7 +497,6 @@ static DynamicState

[GitHub] storm issue #2389: [STORM-2693] Storm heartbeats promotion

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2389 @danny0405 Let's close this. ---

[GitHub] storm issue #2593: STORM-2994 KafkaSpout doesn't commit null tuples offsets

Github user reiabreu commented on the issue: https://github.com/apache/storm/pull/2593 Thank you for guiding me through the changes. I've squashed all the commits and pushed a fresh one ---