[GitHub] storm issue #2698: STORM-2882: shade storm-client dependencies

2018-05-30 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2698 Shading here is different from how it is in 1.x. For this one there is a separate package that creates a shaded uber jar. The code inside storm-client and storm-server that need to use it will

[GitHub] storm issue #2698: STORM-2882: shade storm-client dependencies

2018-05-30 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2698 Dependencies for the client in 1.2.1 asm clojure - removed in 2.x disruptor - removed by this patch gmetric4j kryo log4j2 log4j1.2-api metrics-core

[GitHub] storm pull request #2698: STORM-2882: shade storm-client dependencies

2018-05-30 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/2698 STORM-2882: shade storm-client dependencies You can merge this pull request into a Git repository by running: $ git pull https://github.com/revans2/incubator-storm STORM-2882 Alternatively

[GitHub] storm issue #2693: STORM-3084 fix Nimbus NPE

2018-05-30 Thread agresch
Github user agresch commented on the issue: https://github.com/apache/storm/pull/2693 Can we get this merged? Thanks. ---

[GitHub] storm issue #2686: STORM-3053 prevent race deleting blobs before topologies ...

2018-05-30 Thread agresch
Github user agresch commented on the issue: https://github.com/apache/storm/pull/2686 @srdo - made the changes you requested. ---

[GitHub] storm issue #2636: 1.1.x branch - Add SSL functionality

2018-05-30 Thread danny0405
Github user danny0405 commented on the issue: https://github.com/apache/storm/pull/2636 @cfriaszapater You should first build and install your dependencies modules successfully. ---

[GitHub] storm pull request #2636: 1.1.x branch - Add SSL functionality

2018-05-30 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2636#discussion_r191670402 --- Diff: integration-test/pom.xml --- @@ -22,7 +22,7 @@ storm org.apache.storm -1.2.0-SNAPSHOT +

[GitHub] storm pull request #2636: 1.1.x branch - Add SSL functionality

2018-05-30 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2636#discussion_r191670022 --- Diff: external/storm-cassandra/src/main/java/org/apache/storm/cassandra/client/SslProps.java --- @@ -0,0 +1,92 @@ +/** + * Licensed to the

[GitHub] storm pull request #2636: 1.1.x branch - Add SSL functionality

2018-05-30 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2636#discussion_r191669779 --- Diff: external/storm-cassandra/README.md --- @@ -24,6 +24,12 @@ The following properties may be passed to storm configuration. |

[GitHub] storm pull request #2636: 1.1.x branch - Add SSL functionality

2018-05-30 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2636#discussion_r191669691 --- Diff: external/storm-cassandra/README.md --- @@ -24,6 +24,12 @@ The following properties may be passed to storm configuration. |