Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2728
---
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2723
@revans2
I draw a img to describe what the work flow was before this
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2726
@choojoyq Let us port back first if it is OK to be merged.
---
Github user milantracy commented on the issue:
https://github.com/apache/storm/pull/2729
@srdo could you review this pull request
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2727
---
GitHub user milantracy opened a pull request:
https://github.com/apache/storm/pull/2729
STORM-3064: PartitionedTridentSpoutExecutor should use getPartitionsFâ¦
â¦orTask
You can merge this pull request into a Git repository by running:
$ git pull
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2711#discussion_r196843356
--- Diff:
examples/storm-elasticsearch-examples/src/main/java/org/apache/storm/elasticsearch/common/EsTestUtil.java
---
@@ -56,7 +57,7 @@ public static
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2711#discussion_r196846579
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/Task.java ---
@@ -112,15 +112,15 @@ public Task(Executor executor, Integer taskId) throws
IOException
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2711#discussion_r196842510
--- Diff:
external/storm-elasticsearch/src/test/java/org/apache/storm/elasticsearch/common/EsTestUtil.java
---
@@ -63,7 +64,7 @@
public static
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2711#discussion_r196843622
--- Diff:
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/bolt/format/TestSimpleFileNameFormat.java
---
@@ -69,8 +70,8 @@ public void
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2711#discussion_r196839063
--- Diff: storm-client/src/jvm/org/apache/storm/utils/CustomIndexArray.java
---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2711#discussion_r196843223
--- Diff:
examples/storm-elasticsearch-examples/src/main/java/org/apache/storm/elasticsearch/common/EsTestUtil.java
---
@@ -56,7 +57,7 @@ public static
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2711#discussion_r196848589
--- Diff: storm-server/src/main/java/org/apache/storm/Testing.java ---
@@ -660,8 +661,8 @@ public static Tuple testTuple(List values,
MkTupleParam param) {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2711#discussion_r196841115
--- Diff: storm-client/src/jvm/org/apache/storm/utils/CustomIndexArray.java
---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2711#discussion_r196839436
--- Diff: storm-client/src/jvm/org/apache/storm/utils/CustomIndexArray.java
---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2711#discussion_r196838549
--- Diff: storm-client/src/jvm/org/apache/storm/utils/CustomIndexArray.java
---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2723
@danny0405 There is a lot of code here and I am trying to understand what
exactly this is doing, because it is hard to get it from just the code. I can
see the extra caching that you put in for the
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2714
We have 4 separate metrics APIs right now
2 for daemons
https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/metric/api/IClusterMetricsConsumer.java
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2723
@revans2 @HeartSaVioR
Hi, Bobby, HeartSaVioR, please help me to review this if you have time, thx
in advance.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2721
So you are running with authentication, but run as user is disabled,
because you are running on windows. That is a use case that I missed, sorry
about that.
This is not a security issue
Github user choojoyq commented on the issue:
https://github.com/apache/storm/pull/2726
@HeartSaVioR
Thanks for the fast reply. I pointed this pull request to 1.x-branch.
Does it make sense to open one more pull request for 1.0.x-branch as well?
---
21 matches
Mail list logo
