Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2831
---
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2840
STORM-3147: Add metrics based on ClusterSummary
Rebase and update of https://github.com/apache/storm/pull/2764.
@zd-project Please take a look when you have a chance.
You can merge this pull
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2836
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2805
---
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2831
https://user-images.githubusercontent.com/6090397/45646222-afa9d500-ba90-11e8-9651-56b153e7ce42.png;>
@revans2 I fixed the position and removed duplicate space entries showing
FLUX
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2836
Looks good, thanks. +1
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2836
@srdo I think I addressed all of your review comments.
---
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2831
OMG, my bad.. looks like the span tag is added twice. Let me fix it..
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2836#discussion_r218177587
--- Diff: storm-server/pom.xml ---
@@ -171,7 +171,7 @@
maven-checkstyle-plugin
-
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2831
Sorry to pull my +1 back. On both Firefox and Chrome it looks off to me.
Could you take a look at this again?
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2836#discussion_r218174414
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/HeartbeatCache.java
---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2836#discussion_r218174140
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4624,7 +4569,7 @@ public boolean isRemoteBlobExists(String blobKey)
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2836#discussion_r218173878
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/HeartbeatCache.java
---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2836#discussion_r218173746
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/HeartbeatCache.java
---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2836#discussion_r218173536
--- Diff: storm-server/pom.xml ---
@@ -171,7 +171,7 @@
maven-checkstyle-plugin
-
GitHub user agresch opened a pull request:
https://github.com/apache/storm/pull/2839
STORM-3228 allow refernce counting of differing PortAndAssignment objâ¦
â¦ects to work properly
You can merge this pull request into a Git repository by running:
$ git pull
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2805
Test failure looks unrelated, it's getting a permission error when writing
to the local maven repo.
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2832
---
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2838
STORM-3227: Only push credentials if going to expected user
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-3227
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2805#discussion_r218150464
--- Diff: storm-server/src/main/java/org/apache/storm/LocalDRPC.java ---
@@ -38,9 +39,9 @@
private final DRPC drpc;
private final String
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2805#discussion_r218148492
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Container.java ---
@@ -219,11 +201,11 @@ public void kill() throws IOException {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2836#discussion_r218142320
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/HeartbeatCache.java
---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache Software
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2836#discussion_r218121407
--- Diff: storm-server/pom.xml ---
@@ -171,7 +171,7 @@
maven-checkstyle-plugin
-
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2836#discussion_r217911368
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/HeartbeatCache.java
---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache Software
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2836#discussion_r217911059
--- Diff: storm-client/src/jvm/org/apache/storm/stats/ClientStatsUtil.java
---
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2836#discussion_r218140315
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/HeartbeatCache.java
---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache Software
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2836#discussion_r218124022
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/HeartbeatCache.java
---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache Software
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2836#discussion_r218140867
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4624,7 +4569,7 @@ public boolean isRemoteBlobExists(String blobKey)
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2833
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2837
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2834
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2805
@kishorvpatil yes but the merge conflicts are minor. I wanted to get this
reviewed so @srdo can address any review comments at the same time as fixing
the merge conflicts so we can get this in ASAP
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2805
@revans2 Looks like we have few conflicts on this PR?
---
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2834#discussion_r218116277
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Supervisor.java
---
@@ -135,7 +135,7 @@ public Supervisor(Map conf, IContext
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2805
Also the merge conflicts are really minor.
---
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2805#discussion_r218107287
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Container.java ---
@@ -219,11 +201,11 @@ public void kill() throws IOException {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2805#discussion_r218106022
--- Diff: storm-server/src/main/java/org/apache/storm/LocalDRPC.java ---
@@ -38,9 +39,9 @@
private final DRPC drpc;
private final String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2836#discussion_r218088968
--- Diff: storm-client/src/jvm/org/apache/storm/stats/ClientStatsUtil.java
---
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/2836#discussion_r218086663
--- Diff: storm-client/src/jvm/org/apache/storm/stats/ClientStatsUtil.java
---
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software
I think we are really close on this and I would love to see us get an RC
out ASAP.
We are still missing some things that Stig called out.
https://github.com/apache/storm/pull/2719 has a build issue, not sure if we
need to make an alternative patch or not.
40 matches
Mail list logo
