[GitHub] storm pull request #2843: STORM-3230: Add in sync if key not found

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2843#discussion_r218922619 --- Diff: storm-client/src/jvm/org/apache/storm/security/auth/workertoken/WorkerTokenAuthorizer.java --- @@ -95,9 +95,12 @@ private static

[GitHub] storm pull request #2841: STORM-3105: upgrade version of hive

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2841 ---

[GitHub] storm pull request #2840: STORM-3147: Add metrics based on ClusterSummary

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2840 ---

[GitHub] storm pull request #2843: STORM-3230: Add in sync if key not found

Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2843#discussion_r218905963 --- Diff: storm-client/src/jvm/org/apache/storm/security/auth/workertoken/WorkerTokenAuthorizer.java --- @@ -95,9 +95,12 @@ private static

[GitHub] storm pull request #2843: STORM-3230: Add in sync if key not found

Github user agresch commented on a diff in the pull request: https://github.com/apache/storm/pull/2843#discussion_r218902320 --- Diff: storm-client/src/jvm/org/apache/storm/cluster/StormClusterStateImpl.java --- @@ -903,6 +911,7 @@ public void removeAllPrivateWorkerKeys(String

[GitHub] storm issue #2840: STORM-3147: Add metrics based on ClusterSummary

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2840 I worked with @zd-project fairly closely to come up with the goals for the metrics. I just think we can do better on some of the metrics, but it is not something we have to do right now. I am +1

[GitHub] storm pull request #2843: STORM-3230: Add in sync if key not found

GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/2843 STORM-3230: Add in sync if key not found You can merge this pull request into a Git repository by running: $ git pull https://github.com/revans2/incubator-storm STORM-3230 Alternatively you

Re: Regarding releasing Apache Storm 2.0.0

Sounds good. I just filed https://issues.apache.org/jira/browse/STORM-3230 and I'll be putting up a pull request shortly. I would like to see it in before a 2.x release, but it is kind of minor because ZK has to really be overloaded to hit this, and we tend to recover after a while. I'll look at

[GitHub] storm issue #2842: STORM-3229: Add in better error reporting

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2842 @danny0405 I changed the log to info. That is a great point, because the only time you would see that under normally would be if someone had configured the cluster to use digest auth, which we

[GitHub] storm pull request #2842: STORM-3229: Add in better error reporting

Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2842#discussion_r218691752 --- Diff: storm-client/src/jvm/org/apache/storm/security/auth/workertoken/WorkerTokenAuthorizer.java --- @@ -112,13 +112,21 @@ private static