[GitHub] storm issue #2869: Revert "[STORM-3233] Updated zookeeper client to version ...

2018-10-11 Thread agresch
Github user agresch commented on the issue: https://github.com/apache/storm/pull/2869 What was the reason for the upgrade? Do we need a JIRA to upgrade later? At what point? ---

[GitHub] storm pull request #2875: STORM-3253: Deprecates the storm repl subcommand

2018-10-11 Thread d2r
GitHub user d2r opened a pull request: https://github.com/apache/storm/pull/2875 STORM-3253: Deprecates the storm repl subcommand You can merge this pull request into a Git repository by running: $ git pull https://github.com/d2r/storm storm-3253-deprecate-storm-repl

[GitHub] storm pull request #2874: Clarifies example mvn commands given new profiles

2018-10-11 Thread d2r
GitHub user d2r opened a pull request: https://github.com/apache/storm/pull/2874 Clarifies example mvn commands given new profiles You can merge this pull request into a Git repository by running: $ git pull https://github.com/d2r/storm dev-doc-clarify-maven-profiles

[GitHub] storm pull request #2873: STORM-3243: Removes and cleans up Clojure dependen...

2018-10-11 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/2873#discussion_r224601543 --- Diff: docs/STORM-UI-REST-API.md --- @@ -1572,15 +1572,6 @@ Sample Response: The API returns 500 HTTP status codes in case of any errors.

[GitHub] storm pull request #2873: STORM-3243: Removes and cleans up Clojure dependen...

2018-10-11 Thread d2r
GitHub user d2r opened a pull request: https://github.com/apache/storm/pull/2873 STORM-3243: Removes and cleans up Clojure dependencies You can merge this pull request into a Git repository by running: $ git pull https://github.com/d2r/storm storm-3243-clojure-deps-removal

[GitHub] storm issue #2871: [STORM-3252] Bug fix for blobstore sync

2018-10-11 Thread arunmahadevan
Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/2871 @revans2 , updated the log message, please check if it makes sense. @kishorvpatil I am not sure if we want to swallow IOException, since it may be due to some serious problem which we

[GitHub] storm pull request #2871: [STORM-3252] Bug fix for blobstore sync

2018-10-11 Thread arunmahadevan
Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/2871#discussion_r224559083 --- Diff: storm-server/src/main/java/org/apache/storm/blobstore/BlobStoreUtils.java --- @@ -191,6 +192,8 @@ public static boolean

[GitHub] storm pull request #2871: [STORM-3252] Bug fix for blobstore sync

2018-10-11 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2871#discussion_r224558607 --- Diff: storm-server/src/main/java/org/apache/storm/blobstore/BlobStoreUtils.java --- @@ -191,6 +192,8 @@ public static boolean downloadUpdatedBlob(Map

[GitHub] storm pull request #2872: STORM-3251 properly determine if logviewer filter ...

2018-10-11 Thread agresch
GitHub user agresch opened a pull request: https://github.com/apache/storm/pull/2872 STORM-3251 properly determine if logviewer filter is enabled You can merge this pull request into a Git repository by running: $ git pull https://github.com/agresch/storm

[GitHub] storm pull request #2871: [STORM-3252] Bug fix for blobstore sync

2018-10-11 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2871#discussion_r224550336 --- Diff: storm-server/src/main/java/org/apache/storm/blobstore/BlobStoreUtils.java --- @@ -191,6 +192,8 @@ public static boolean downloadUpdatedBlob(Map

[GitHub] storm pull request #2871: [STORM-3252] Bug fix for blobstore sync

2018-10-11 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2871#discussion_r224547803 --- Diff: storm-server/src/main/java/org/apache/storm/blobstore/BlobStoreUtils.java --- @@ -191,6 +192,8 @@ public static boolean downloadUpdatedBlob(Map

[GitHub] storm pull request #2871: [STORM-3252] Bug fix for blobstore sync

2018-10-11 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/2871#discussion_r224548982 --- Diff: storm-server/src/main/java/org/apache/storm/blobstore/BlobStoreUtils.java --- @@ -191,6 +192,8 @@ public static boolean

[GitHub] storm issue #2773: Blobstore sync bug fix

2018-10-11 Thread arunmahadevan
Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/2773 @HeartSaVioR created https://github.com/apache/storm/pull/2871 and linked to a JIRA. Maybe good to get this in 2.0 release. ---

[CANCELED] [VOTE] Release Apache Storm 2.0.0 (rc2)

2018-10-11 Thread P. Taylor Goetz
Canceling so blockers can be fixed for the 2.0.0 release. -Taylor > On Oct 9, 2018, at 4:03 PM, P. Taylor Goetz wrote: > > This is a call to vote on releasing Apache Storm 2.0.0 (rc2) > > Full list of changes in this release: > >

[GitHub] storm pull request #2871: [STORM-3252] Bug fix for blobstore sync

2018-10-11 Thread arunmahadevan
Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/2871#discussion_r224541248 --- Diff: storm-server/src/main/java/org/apache/storm/blobstore/BlobStoreUtils.java --- @@ -191,6 +192,8 @@ public static boolean

[GitHub] storm pull request #2871: [STORM-3252] Bug fix for blobstore sync

2018-10-11 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/2871#discussion_r224538909 --- Diff: storm-server/src/main/java/org/apache/storm/blobstore/BlobStoreUtils.java --- @@ -191,6 +192,8 @@ public static boolean

[GitHub] storm issue #2871: [STORM-3252] Bug fix for blobstore sync

2018-10-11 Thread arunmahadevan
Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/2871 Cherry picked commits from https://github.com/apache/storm/pull/2773 and linked with a JIRA. ---

[GitHub] storm pull request #2871: [STORM-3252] Bug fix for blobstore sync

2018-10-11 Thread arunmahadevan
GitHub user arunmahadevan opened a pull request: https://github.com/apache/storm/pull/2871 [STORM-3252] Bug fix for blobstore sync 1.Bug fix for blob sync frequency with time unit error. 2.Bug fix for blob sync delete file, add catch NoSuchFileException. 3.Bug fix for blob

Re: [VOTE] Release Apache Storm 2.0.0 (rc2)

2018-10-11 Thread Kishorkumar Patil
Yes, we need fix for security bug - STORM-3251. -Kishor On Thu, Oct 11, 2018 at 12:26 PM Derek Dagit wrote: > I agree with Aaron, we should fix STORM-3251 first. > -1 > > On Thu, Oct 11, 2018 at 11:22 AM Aaron Gresch wrote: > > > -1 (non-binding?)

Re: [VOTE] Release Apache Storm 2.0.0 (rc2)

2018-10-11 Thread Derek Dagit
I agree with Aaron, we should fix STORM-3251 first. -1 On Thu, Oct 11, 2018 at 11:22 AM Aaron Gresch wrote: > -1 (non-binding?) https://issues.apache.org/jira/browse/STORM-3251 > > Just found a security-related issue related to a change I recently made > (original change causing the bug: > >

Re: [VOTE] Release Apache Storm 2.0.0 (rc2)

2018-10-11 Thread Aaron Gresch
-1 (non-binding?) https://issues.apache.org/jira/browse/STORM-3251 Just found a security-related issue related to a change I recently made (original change causing the bug: https://github.com/apache/storm/commit/06a64949c8c5b764a33a10beb6088cdd8f182aa0 ). On Wed, Oct 10, 2018 at 6:46 PM

Re: [VOTE] Release Apache Storm 2.0.0 (rc2)

2018-10-11 Thread Bobby Evans
Sorry everyone. I forgot that I had not reverted the 3.4.13 ZK upmerge. We need to do that before a 2.0 is released. I'll do it right now. On Wed, Oct 10, 2018 at 6:47 PM Jungtaek Lim wrote: > Thanks all for the quick turnaround! Here's my +1 (binding). > > > source > > - verify file

[GitHub] storm pull request #2870: Revert "[STORM-3233] Updated zookeeper client to v...

2018-10-11 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/2870 Revert "[STORM-3233] Updated zookeeper client to version 3.4.13 which… … fixes various issues including ZOOKEEPER-2184 that prevents ZooKeeper Java clients working in dynamic IP (container /

[GitHub] storm pull request #2869: Revert "[STORM-3233] Updated zookeeper client to v...

2018-10-11 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/2869 Revert "[STORM-3233] Updated zookeeper client to version 3.4.13 which… … fixes various issues including ZOOKEEPER-2184 that prevents ZooKeeper Java clients working in dynamic IP (container /

[GitHub] storm pull request #2868: Revert "[STORM-3233] Updated zookeeper client to v...

2018-10-11 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/2868 Revert "[STORM-3233] Updated zookeeper client to version 3.4.13 which… … fixes various issues including ZOOKEEPER-2184 that prevents ZooKeeper Java clients working in dynamic IP (container /

Incorrect Zookeeper version number in change log / jira

2018-10-11 Thread Peter Chamberlain
Incorrect Zookeeper version number in change log / jira Seems like zookeeper client is listed as 3.4.14 in change log for v2.0 rc-2, Pretty sure that doesn't actually exist yet, and would likely cause confusion when it does actually get released. STORM-3233