[GitHub] [storm] bipinprasad commented on a diff in pull request #3539: [STORM-3913] Update rocksdb to version 8.1.1 that has Mac OSX JNI lib

2023-04-28 Thread via GitHub
bipinprasad commented on code in PR #3539: URL: https://github.com/apache/storm/pull/3539#discussion_r1180617441 ## storm-server/pom.xml: ## @@ -60,6 +60,7 @@ org.rocksdb rocksdbjni +${rocksdb-version} Review Comment: I missed

[GitHub] [storm] bipinprasad commented on a diff in pull request #3539: [STORM-3913] Update rocksdb to version 8.1.1 that has Mac OSX JNI lib

2023-04-28 Thread via GitHub
bipinprasad commented on code in PR #3539: URL: https://github.com/apache/storm/pull/3539#discussion_r1180600883 ## storm-server/pom.xml: ## @@ -60,6 +60,7 @@ org.rocksdb rocksdbjni +${rocksdb-version} Review Comment: The

[GitHub] [storm] agresch commented on a diff in pull request #3539: [STORM-3913] Update rocksdb to version 8.1.1 that has Mac OSX JNI lib

2023-04-28 Thread via GitHub
agresch commented on code in PR #3539: URL: https://github.com/apache/storm/pull/3539#discussion_r1180543200 ## storm-server/pom.xml: ## @@ -60,6 +60,7 @@ org.rocksdb rocksdbjni +${rocksdb-version} Review Comment: even though

[GitHub] [storm] bipinprasad commented on a diff in pull request #3539: [STORM-3913] Update rocksdb to version 8.1.1 that has Mac OSX JNI lib

2023-04-28 Thread via GitHub
bipinprasad commented on code in PR #3539: URL: https://github.com/apache/storm/pull/3539#discussion_r1180506358 ## storm-server/pom.xml: ## @@ -60,6 +60,7 @@ org.rocksdb rocksdbjni +${rocksdb-version} Review Comment: Not

[GitHub] [storm] agresch commented on a diff in pull request #3539: [STORM-3913] Update rocksdb to version 8.1.1 that has Mac OSX JNI lib

2023-04-28 Thread via GitHub
agresch commented on code in PR #3539: URL: https://github.com/apache/storm/pull/3539#discussion_r1180464412 ## storm-server/pom.xml: ## @@ -60,6 +60,7 @@ org.rocksdb rocksdbjni +${rocksdb-version} Review Comment: just curious