[GitHub] storm issue #2719: STORM-3105 Update hive.version to stable hive release.

Github user aandis commented on the issue: https://github.com/apache/storm/pull/2719 In our case, we have copied the hive [dependencies](https://github.com/apache/storm/blob/4137328b75c06771f84414c3c2113e2d1c757c08/external/storm-hive/pom.xml#L54) into our pom with the right version

[GitHub] storm issue #2719: STORM-3105 Update hive.version to stable hive release.

Github user aandis commented on the issue: https://github.com/apache/storm/pull/2719 cc: @roshannaik ---

[GitHub] storm pull request #2719: STORM-3105 Update hive.version to stable hive rele...

GitHub user aandis opened a pull request: https://github.com/apache/storm/pull/2719 STORM-3105 Update hive.version to stable hive release. [STORM-3105](https://issues.apache.org/jira/browse/STORM-3105) You can merge this pull request into a Git repository by running: $ git

[GitHub] storm issue #1971: STORM-2384 Add log statements when spout skips calling ne...

Github user aandis commented on the issue: https://github.com/apache/storm/pull/1971 @HeartSaVioR does `Log4j` support that? I couldn't find anything on the topic. I think I'll need to write a custom class which stores the last logged message and logs new message immediately if it's

[GitHub] storm issue #1971: STORM-2384 Add log statements when spout skips calling ne...

Github user aandis commented on the issue: https://github.com/apache/storm/pull/1971 @HeartSaVioR changed log level to debug. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request #1971: STORM-2384 Add log statements when spout skips cal...

GitHub user aandis opened a pull request: https://github.com/apache/storm/pull/1971 STORM-2384 Add log statements when spout skips calling nextTuple. You can merge this pull request into a Git repository by running: $ git pull https://github.com/aandis/storm STORM-2384

[GitHub] storm issue #1798: Storm-2203 Add a getAll method to KeyValueState interface

Github user aandis commented on the issue: https://github.com/apache/storm/pull/1798 Thanks @arunmahadevan. :) Out of curiosity, why don't we use github's merge branch feature to merge branches directly from this page? Or was it just a temporary thing because of integration tests

[GitHub] storm pull request #1798: Storm-2203 Add a getAll method to KeyValueState in...

Github user aandis closed the pull request at: https://github.com/apache/storm/pull/1798 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm pull request #1798: Storm-2203 Add a getAll method to KeyValueState in...

Github user aandis commented on a diff in the pull request: https://github.com/apache/storm/pull/1798#discussion_r93878165 --- Diff: external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueStateIterator.java --- @@ -0,0 +1,104 @@ +/** + * Licensed

[GitHub] storm issue #1798: Storm-2203 Add a getAll method to KeyValueState interface

Github user aandis commented on the issue: https://github.com/apache/storm/pull/1798 @HeartSaVioR @arunmahadevan ready for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm issue #1798: Storm-2203 Add a getAll method to KeyValueState interface

Github user aandis commented on the issue: https://github.com/apache/storm/pull/1798 @HeartSaVioR yep. will do in next couple of days. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm issue #1798: Storm-2203 Add a getAll method to KeyValueState interface

Github user aandis commented on the issue: https://github.com/apache/storm/pull/1798 Ping @HeartSaVioR @arunmahadevan can you review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request #1798: Storm-2203 Add a getAll method to KeyValueState in...

Github user aandis commented on a diff in the pull request: https://github.com/apache/storm/pull/1798#discussion_r90408316 --- Diff: storm-core/src/jvm/org/apache/storm/state/KeyValueState.java --- @@ -45,4 +47,9 @@ * @return the value or defaultValue if no mapping

[GitHub] storm pull request #1798: Storm-2203 Add a getAll method to KeyValueState in...

Github user aandis commented on a diff in the pull request: https://github.com/apache/storm/pull/1798#discussion_r90405070 --- Diff: storm-core/src/jvm/org/apache/storm/state/KeyValueState.java --- @@ -45,4 +47,9 @@ * @return the value or defaultValue if no mapping

[GitHub] storm pull request #1798: Storm-2203 Add a getAll method to KeyValueState in...

Github user aandis commented on a diff in the pull request: https://github.com/apache/storm/pull/1798#discussion_r90398126 --- Diff: storm-core/src/jvm/org/apache/storm/state/KeyValueState.java --- @@ -45,4 +47,9 @@ * @return the value or defaultValue if no mapping

[GitHub] storm pull request #1798: Storm 2203 Add a getAll method to KeyValueState in...

GitHub user aandis opened a pull request: https://github.com/apache/storm/pull/1798 Storm 2203 Add a getAll method to KeyValueState interface Adds a `getAll` to `InMemoryKeyValueState` and `RedisKeyValueState`. I'll add tests once the changes are approved. You can merge this pull

[GitHub] storm pull request #1721: Update storm kafka docs.

GitHub user aandis opened a pull request: https://github.com/apache/storm/pull/1721 Update storm kafka docs. [docs/storm-kafka.md](https://github.com/apache/storm/blob/d88558237f37de87d81fad0be7d51042328c615e/docs/storm-kafka.md) is out of date. This updates it to be the same