GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2499
STORM-2881: Explicitly specify the curator dependencies in storm-druid pom
https://github.com/apache/storm/pull/2498 applied to 1.x branch.
You can merge this pull request into a Git
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2499
ping @omkreddy , @HeartSaVioR
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2498
ping @omkreddy , @HeartSaVioR
---
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2498
STORM-2881: Explicitly specify the curator dependencies in storm-druid pom
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arunmahadevan
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2480
+1
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2495
@omkreddy , thanks for the patch. +1
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2482
+1 LGTM, left one comment.
---
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2482#discussion_r158759325
--- Diff:
storm-client/src/jvm/org/apache/storm/metric/FileBasedEventLogger.java ---
@@ -59,8 +62,12 @@ private void initLogWriter(Path logFilePath
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2483
+1 LGTM, left one comment.
---
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2483#discussion_r158759249
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/FileBasedEventLogger.java ---
@@ -60,8 +64,12 @@ private void initLogWriter(Path logFilePath
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r158731526
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/KafkaUtils.java
---
@@ -0,0 +1,114 @@
+/**
+ * Licensed
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2203
Hi @revans2 , do you have any additional comments or are we good to merge
this ?
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2203
@ptgoetz , can you rebase ?
@revans2 , can you take a look again so that we can get this in 1.2 ?
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2457
+1
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2458
+1
---
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2458#discussion_r157074167
--- Diff: conf/storm.yaml.example ---
@@ -72,4 +72,11 @@
# argument:
# - endpoint: "metrics-collector.mycompan
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2458
+1, once the minor nits are addressed.
---
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2457#discussion_r157072382
--- Diff: docs/Eventlogging.md ---
@@ -94,3 +95,29 @@ public interface IEventLogger {
void close();
}
```
+
+The default
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2428
@HeartSaVioR can we look at merging this? @hmcl if you have any further
comments you can put it here asap.
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2438
@HeartSaVioR , can we look at merging this if your comments have been
addressed ?
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2203
+1, @ptgoetz @HeartSaVioR , are there any more changes planned in this
patch? If no can we look at merging asap so that it can be included in 1.2.0?
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2376
+1
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2374
+1
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2375
+1
---
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r140967211
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/reporters/ScheduledStormReporter.java
---
@@ -0,0 +1,88 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r140966853
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/reporters/StormReporter.java ---
@@ -0,0 +1,32 @@
+/**
+ * Licensed to the Apache
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2310
+1
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2309
+1
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2308
+1
---
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r135689031
--- Diff: conf/defaults.yaml ---
@@ -231,20 +234,35 @@ topology.multilang.serializer:
"org.apache.storm.multilang.JsonSeria
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2233
@kamleshbhatt , thanks for the patch, I have squashed and merged the patch
to master. You can close this PR.
---
If your project is set up for it, you can reply to this email and have your
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2233
Also please squash the commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r134441630
--- Diff:
storm-client/src/jvm/org/apache/storm/streams/processors/CoGroupByKeyProcessor.java
---
@@ -0,0 +1,78 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r134441647
--- Diff:
storm-client/src/jvm/org/apache/storm/streams/processors/CoGroupByKeyProcessor.java
---
@@ -0,0 +1,78 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r133946525
--- Diff: docs/Stream-API.md ---
@@ -276,6 +276,21 @@ PairStream<String, Double> scores = ...
// list of scores per user in the last windo
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r133947663
--- Diff:
storm-client/src/jvm/org/apache/storm/streams/processors/CoGroupByKeyProcessor.java
---
@@ -0,0 +1,78 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r133947567
--- Diff:
storm-client/src/jvm/org/apache/storm/streams/processors/CoGroupByKeyProcessor.java
---
@@ -0,0 +1,78 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r133946658
--- Diff: docs/Stream-API.md ---
@@ -276,6 +276,21 @@ PairStream<String, Double> scores = ...
// list of scores per user in the last windo
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r133946510
--- Diff: docs/Stream-API.md ---
@@ -276,6 +276,21 @@ PairStream<String, Double> scores = ...
// list of scores per user in the last windo
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r133947083
--- Diff: storm-client/src/jvm/org/apache/storm/streams/PairStream.java ---
@@ -380,6 +382,26 @@
return partitionBy(KEY
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r133948483
--- Diff:
storm-client/test/jvm/org/apache/storm/streams/processors/CoGroupByKeyProcessorTest.java
---
@@ -0,0 +1,112 @@
+/**
+ * Licensed
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2275
STORM-2692: Load only configs specific to the topology in
populateCredentials
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2218
Thanks for the reviews, squashed and merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r131659700
--- Diff: storm-client/src/jvm/org/apache/storm/streams/PairStream.java ---
@@ -380,6 +383,22 @@
return partitionBy(KEY
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r131680183
--- Diff:
storm-client/src/jvm/org/apache/storm/streams/processors/CoGroupByKeyProcessor.java
---
@@ -0,0 +1,75 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r131682043
--- Diff:
storm-client/test/jvm/org/apache/storm/streams/processors/CoGroupByKeyProcessorTest.java
---
@@ -0,0 +1,107 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r131690416
--- Diff: storm-client/src/jvm/org/apache/storm/streams/PairStream.java ---
@@ -380,6 +383,22 @@
return partitionBy(KEY
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131219494
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/SimpleWindowPartitionCacheTest.java
---
@@ -0,0 +1,232 @@
+/**
+ * Licensed
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2218
@srdo , @satishd, thanks for the review. Pushed some changes to address
the latest review comments.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130528810
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,596 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130528860
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/WindowManager.java ---
@@ -111,14 +125,86 @@ public void add(Event windowEvent
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130528788
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,596 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r130523483
--- Diff: conf/defaults.yaml ---
@@ -253,11 +244,15 @@ topology.trident.batch.emit.interval.millis: 500
topology.testing.always.try.serialize
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r130441519
--- Diff:
storm-client/src/jvm/org/apache/storm/streams/processors/CoGroupByKeyProcessor.java
---
@@ -0,0 +1,105 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r130441506
--- Diff:
storm-client/src/jvm/org/apache/storm/streams/processors/CoGroupByKeyProcessor.java
---
@@ -0,0 +1,105 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r130434940
--- Diff:
storm-client/src/jvm/org/apache/storm/streams/processors/CoGroupByKeyProcessor.java
---
@@ -0,0 +1,105 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r130434631
--- Diff: storm-client/src/jvm/org/apache/storm/streams/PairStream.java ---
@@ -400,6 +422,18 @@
return new PairStream<>(streamB
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r130435926
--- Diff:
storm-client/src/jvm/org/apache/storm/streams/processors/CoGroupByKeyProcessor.java
---
@@ -0,0 +1,105 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r130434218
--- Diff: storm-client/src/jvm/org/apache/storm/streams/PairStream.java ---
@@ -380,6 +383,25 @@
return partitionBy(KEY
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r130429097
--- Diff: storm-client/src/jvm/org/apache/storm/streams/PairStream.java ---
@@ -380,6 +383,25 @@
return partitionBy(KEY
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r130436004
--- Diff:
storm-client/src/jvm/org/apache/storm/streams/processors/CoGroupByKeyProcessor.java
---
@@ -0,0 +1,105 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273957
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/WindowManager.java ---
@@ -111,14 +125,86 @@ public void add(Event windowEvent
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130274015
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/TupleWindowIterImpl.java ---
@@ -0,0 +1,80 @@
+/**
+ * Licensed to the Apache
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130274003
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/WindowManager.java ---
@@ -111,14 +125,86 @@ public void add(Event windowEvent
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273929
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2363,7 +2363,7 @@ private CommonTopoInfo getCommonTopoInfo
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273915
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutorTest.java
---
@@ -0,0 +1,261 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273903
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutorTest.java
---
@@ -0,0 +1,261 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273891
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutorTest.java
---
@@ -0,0 +1,261 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273846
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutorTest.java
---
@@ -0,0 +1,261 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273878
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutorTest.java
---
@@ -0,0 +1,261 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273860
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutorTest.java
---
@@ -0,0 +1,261 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273816
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/WatermarkCountEvictionPolicy.java
---
@@ -17,20 +17,28 @@
*/
package
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273840
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutorTest.java
---
@@ -0,0 +1,261 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273783
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/WindowManager.java ---
@@ -111,14 +125,86 @@ public void add(Event windowEvent
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273789
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/WindowManager.java ---
@@ -289,4 +414,22 @@ public String toString
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273736
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,596 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273719
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,596 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273744
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,596 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273697
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,596 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273758
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/WindowManager.java ---
@@ -53,28 +61,34 @@
public static final int
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273727
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,596 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273647
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/WindowPartitionCache.java ---
@@ -0,0 +1,142 @@
+/**
+ * Licensed to the Apache
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273679
--- Diff: docs/Windowing.md ---
@@ -266,3 +266,108 @@ tuples can be received within the timeout period.
An example toplogy `SlidingWindowTopology
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273640
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,596 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273666
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/SimpleWindowPartitionCache.java
---
@@ -0,0 +1,191 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130273607
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/base/BaseStatefulWindowedBolt.java
---
@@ -151,6 +158,38 @@
return
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2241
Agree with @HeartSaVioR. If possible lets break this down into multiple
patches like (1) JCQ replacing disruptor (2) changing the threading model (3)
micro optimizations and so on which makes
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r130009128
--- Diff:
storm-client/src/jvm/org/apache/storm/serialization/KryoTupleDeserializer.java
---
@@ -39,7 +38,7 @@ public KryoTupleDeserializer(final Map
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2218
@srdo, addressed your comments, let me know if I missed something.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129763588
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,563 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129763692
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/SimpleWindowPartitionCache.java
---
@@ -0,0 +1,191 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129763781
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/TupleWindowIterImpl.java ---
@@ -0,0 +1,80 @@
+/**
+ * Licensed to the Apache
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129763573
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,563 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129763661
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/SimpleWindowPartitionCache.java
---
@@ -0,0 +1,191 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129763759
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java ---
@@ -127,26 +154,30 @@ private void validate(Map<String, Obj
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129763707
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java ---
@@ -102,6 +109,18 @@ private int getMaxSpoutPending(Map<Str
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129763468
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,563 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129763520
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java
---
@@ -0,0 +1,563 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129763418
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/PersistentWindowingTopology.java
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129763373
--- Diff: docs/Windowing.md ---
@@ -266,3 +266,105 @@ tuples can be received within the timeout period.
An example toplogy `SlidingWindowTopology
101 - 200 of 787 matches
Mail list logo
