Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1360#issuecomment-214998893
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1360#issuecomment-214962026
> Not sure why you say this. In my case for example, I using runit to start
storm components like nimbus, ui, etc and the problem is applicable to
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1360#issuecomment-214272514
@dsKarthick the change looks good. Can you also raise a jira (at
https://issues.apache.org/jira/browse/STORM) and update the PR title ?
This would likely
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1339#issuecomment-213257503
updated the PR with the commit that fixes the issue found during test.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1343#issuecomment-211524696
@HeartSaVioR refactored and extracted common logic to a common parent of
StatefulBoltExecutor and CheckpointTupleForwarder. Please review.
---
If your project
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1343#discussion_r60036656
--- Diff:
storm-core/src/jvm/org/apache/storm/topology/CheckpointTupleForwarder.java ---
@@ -53,6 +53,10 @@
private long lastTxid
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1343#issuecomment-210853684
@harshach yes both master and 1.x branch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/1343
[STORM-1714] StatefulBolts ends up as normal bolts while using
TopologyBuilder.setBolt without parallelism
Refactored IstatefulBolt to be independent of IRichBolt so that setBolt
overloads
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/1339
[STORM-1711] Kerberos principals gets mixed up while using storm-hive
Storm-hive uses UserGroupInformation.loginUserFromKeytab which updates the
static variable that stores current UGI
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1169#issuecomment-209760668
@harshach @haohui this has been pending for a long time. Could you take a
look and merge if it looks fine?
---
If your project is set up for it, you can reply
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/1336
[STORM-1709] Added group by support in storm sql standalone mode
Added group by support for storm-sql in standalone mode and handle user
defined aggregation operations as well.
Note
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1217#issuecomment-206117168
@roshannaik yes, it will make the behavior consistent with "ackers". You
may also want to update the tooltip. Since this PR is already merged, you
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1217#discussion_r58577654
--- Diff: storm-core/src/ui/public/js/script.js ---
@@ -220,19 +220,21 @@ function topologyActionJson(id, encodedId, name,
status, msgTimeout, debug
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1269#issuecomment-204244154
@ptgoetz updated the doc to reflect the new (disabled by default) behavior.
Please review.
---
If your project is set up for it, you can reply to this email
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1217#issuecomment-204239172
@roshannaik thanks for fixing it in the right way. I have run some quick
tests and patch it works as expected.
+1
---
If your project is set up
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1217#issuecomment-203792662
1 . The tooltip takes some time to show up, whereas the tooltip on other
elements like the title elements under Topology summary shows up immediately. I
played
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1269#issuecomment-202733505
Appears that some html pages are broken. E.g.
http://storm.apache.org/releases/1.0.0-SNAPSHOT/State-checkpointing.html beyond
the section "IStateful bolt
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1272#issuecomment-202728331
>I tested on roshan's topology with no modifying.
I also tried that and it was producing weird results, so I changed it to
emit a constant l
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1272#issuecomment-202725876
@HeartSaVioR actually this patch has no effect with eventlogger=0. I assume
you modified BasicTopology to emit a constant long. I also restart all the
storm
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1272#issuecomment-202711879
@HeartSaVioR could you take a look ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/1272
[STORM-1662] Reduce map lookups in send_to_eventlogger
Reducing map lookup in send_to_eventlogger can improve performance when
when a spout emits in a tight loop.
You can merge this pull
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1269#issuecomment-202704798
@revans2 @ptgoetz added a link in docs/index.md
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/1269
[STORM-1544] Document Debug/Sampling of Topologies
Added documentation for logging/sampling events in a topology.
You can merge this pull request into a Git repository by running:
$ git
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1217#issuecomment-201412463
With the BasicTopology.java uploaded in the Jira I was not getting
consistent results and in some cases the throughput without event logger turned
out to be less
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1072#issuecomment-201194400
+1 for merging this. If we are including this in 1.0, its better to update
the trident api docs as well in 1.0.
---
If your project is set up for it, you can
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1217#issuecomment-200677018
@harshach I had removed the sleep in the latest run to match what
@roshannaik was evaluating.
---
If your project is set up for it, you can reply to this email
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1217#issuecomment-200672407
@harshach
> @arunmahadevan @HeartSaVioR Looking at the perf analysis from @roshannaik
It looks to be there is enough evidence to consider this as seri
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1217#issuecomment-200669173
@roshannaik did you try passing the map values are arguments and take the
measurements? Based on your earlier results it appeared that PersistentMap
lookup
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1072#issuecomment-200303590
1. The event time based windows are not exposed via trident, can you file a
follow up JIRA ?
2. Trident api docs needs to be updated with windowing apis.
3
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143584
--- Diff:
storm-core/src/jvm/org/apache/storm/trident/windowing/strategy/WindowStrategyFactory.java
---
@@ -0,0 +1,60 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143565
--- Diff:
storm-core/src/jvm/org/apache/storm/trident/windowing/config/WindowConfig.java
---
@@ -0,0 +1,55 @@
+/**
+ * Licensed to the Apache
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143513
--- Diff:
storm-core/src/jvm/org/apache/storm/trident/windowing/WindowTridentProcessor.java
---
@@ -0,0 +1,265 @@
+/**
+ * Licensed
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143286
--- Diff:
storm-core/src/jvm/org/apache/storm/trident/operation/builtin/Debug.java ---
@@ -40,7 +42,7 @@ public Debug(String name
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143253
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -594,19 +607,155 @@ public Stream aggregate(Fields inputFields
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143259
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -594,19 +607,155 @@ public Stream aggregate(Fields inputFields
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143154
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/windowing/HBaseWindowsStoreFactory.java
---
@@ -0,0 +1,54
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143240
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -594,19 +607,155 @@ public Stream aggregate(Fields inputFields
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143217
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -594,19 +607,155 @@ public Stream aggregate(Fields inputFields
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143245
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -594,19 +607,155 @@ public Stream aggregate(Fields inputFields
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143185
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -594,19 +607,155 @@ public Stream aggregate(Fields inputFields
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143236
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -594,19 +607,155 @@ public Stream aggregate(Fields inputFields
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143182
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -594,19 +607,155 @@ public Stream aggregate(Fields inputFields
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143268
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -594,19 +607,155 @@ public Stream aggregate(Fields inputFields
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r57143132
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/windowing/HBaseWindowsStore.java
---
@@ -0,0 +1,275
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1217#issuecomment-20024
Re-ran the exclamation topology with,
- no anchoring/acking
- TestWordSpout emitting a fixed word without any sleep
- spout, bolt parallelism = 1
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1239#issuecomment-199733850
@abhishekagarwal87 ok makes sense. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1239#issuecomment-199648569
@abhishekagarwal87 @harshach the changes looks good and putting the
storm-sql jars in external/sql/storm-sql-core is consistent with other external
modules whose
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1217#issuecomment-199235692
@roshannaik profiled "org.apache.storm.starter.ExclamationTopology" after
setting log level to ERROR and the `send_to_eventlogger` doesn't show up in t
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1169#issuecomment-199183363
@haohui addressed comments, can you take a look again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1044#issuecomment-198995107
@dossett thanks for the clarification. So the tuples with different schema
are written to the next rotated file. I was assuming some association between
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769644
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -565,19 +578,155 @@ public Stream aggregate(Fields inputFields
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769652
--- Diff:
storm-core/src/jvm/org/apache/storm/trident/operation/builtin/Debug.java ---
@@ -40,7 +42,7 @@ public Debug(String name
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769635
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -6,9 +6,9 @@
* to you under the Apache License, Version 2.0
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769629
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/windowing/HBaseWindowsStore.java
---
@@ -0,0 +1,275
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769646
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -565,19 +578,155 @@ public Stream aggregate(Fields inputFields
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769600
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/trident/TridentHBaseWindowingStoreTopology.java
---
@@ -0,0 +1,122
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769622
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/trident/TridentWindowingInmemoryStoreTopology.java
---
@@ -0,0 +1,133
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769608
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/trident/TridentHBaseWindowingStoreTopology.java
---
@@ -0,0 +1,122
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769598
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/trident/TridentHBaseWindowingStoreTopology.java
---
@@ -0,0 +1,122
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769591
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/trident/TridentHBaseWindowingStoreTopology.java
---
@@ -0,0 +1,122
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769585
--- Diff: examples/storm-starter/pom.xml ---
@@ -177,6 +185,36 @@
storm-redis
${project.version
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r56769580
--- Diff: examples/storm-starter/pom.xml ---
@@ -31,10 +31,13 @@
storm-starter
- UTF-8
-
- provided
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1199#issuecomment-197702133
@knusbaum I guess the main concern against builder is that we want to
maintain compatibility between core and trident. If so I am fine to change both
the apis
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1217#issuecomment-197707627
@roshannaik Thanks for the details. I will try and run a similar topology
to see the difference and see if there is something we can do. Do you have any
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1217#issuecomment-197523828
@roshannaik setting `topology.eventlogger.executors: 0` completely disables
event logging by default (i.e. no threads are started to handle event logging
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1044#issuecomment-198255363
@dossett I went through the patch again and I have one question regarding
the writer key. I see that you maintain a separate writer per writer key. In
the docs
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1072#issuecomment-197175210
@harshach I haven't reviewed the code yet, plan to do that within a couple
of days.
---
If your project is set up for it, you can reply to this email and have
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1199#issuecomment-196684996
@knusbaum @ptgoetz in the proposed name based approach, the naming needs to
be done only when one wants to pass specific configs to the node executing
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1072#issuecomment-196279990
Haven't gone through the code in great detail, but when I ran a simple
topology with a tumbling time window of 3 secs,
- If the spout emits a batch
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1072#discussion_r55989920
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -565,19 +578,169 @@ public Stream aggregate(Fields inputFields
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1044#issuecomment-196194151
@dossett @harshach the changes looks good overall, but I have a few
questions/comments and once those are addressed I will review it again.
---
If your project
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1044#discussion_r55965933
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/AbstractHdfsBolt.java
---
@@ -223,29 +259,57 @@ public final void execute(Tuple
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1044#discussion_r55965923
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/AbstractHdfsBolt.java
---
@@ -223,29 +259,57 @@ public final void execute(Tuple
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1044#discussion_r55965901
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/AbstractHdfsBolt.java
---
@@ -198,22 +194,62 @@ public final void execute(Tuple
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1044#discussion_r55965890
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/AbstractHdfsBolt.java
---
@@ -198,22 +194,62 @@ public final void execute(Tuple
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1044#discussion_r55965843
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/AbstractHdfsBolt.java
---
@@ -145,13 +134,20 @@ public final void execute(Tuple
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1044#discussion_r55965855
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/AbstractHdfsBolt.java
---
@@ -198,22 +194,62 @@ public final void execute(Tuple
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1044#discussion_r55965826
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/AbstractHdfsBolt.java
---
@@ -52,9 +54,10 @@
* Half of the default
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1044#discussion_r55965801
--- Diff: external/storm-hdfs/README.md ---
@@ -240,6 +240,23 @@ If you are using Trident and sequence files you can do
something like
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1199#discussion_r55792475
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -124,6 +124,31 @@ public Stream parallelismHint(int hint
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1199#discussion_r55633878
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -124,6 +124,31 @@ public Stream parallelismHint(int hint
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1190#issuecomment-194268412
@revans2 @ptgoetz I have refactored the code and removed the auto
anchoring/acking for both stateful and non-stateful bolts in a stateful
topology. Currently
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1190#issuecomment-193616307
@revans2 anchoring/acking in enforced for stateful & non-stateful bolts in
a stateful topology to provide at-least once guarantee for the state upd
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/1190
[STORM-1608] Fix stateful topology acking behavior
Right now the acking is automatically taken care of for the non-stateful
bolts in a stateful topology. This leads to double acking
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1169#discussion_r54837625
--- Diff: external/sql/storm-sql-core/src/codegen/includes/parserImpls.ftl
---
@@ -83,4 +83,23 @@ SqlNode SqlCreateTable
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/1169
[Storm-1585] Add DDL support for UDFs in storm-sql
This patch proposes to expose the user defined function support added
in STORM-1585 via DDL statements.
Note: This includes
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1141#issuecomment-190325738
Addressed latest comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/1162
[STORM-1586] Add UDF support in ExprComplier
The proposed patch adds UDF support in ExprComplier. This can then be
exposed via DDL. (https://issues.apache.org/jira/browse/STORM-1585
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1141#issuecomment-190040776
- Removed the second commit. I will raise follow up JIRAs to support UDF
and expose it via DDL.
- Removed guava test dep from storm-sql-runtime (not sure why
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/1159
[STORM-1576] fix ConcurrentModificationException in addCheckpointInputs
Proposed patch addresses the ConcurrentModificationException while
creating a topology with an IStatefulBolt having
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1141#issuecomment-189154415
@haohui In some cases like `true AND null` the query was still returning
results, hence I had changed `StormSqlFunctions.eq` and `StormSqlFunctions.ne`
to return
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/1151
[STORM-1576] fix ConcurrentModificationException in addCheckpointInputs
Proposed patch addresses the ConcurrentModificationException while
creating a topology with an IStatefulBolt having
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/1141
[STORM-1570] Storm SQL support for nested fields and UDF
Added support to handle array, map and nested field lookups and user
defined functions
in Storm SQL.
You can merge this pull
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1119#issuecomment-187307627
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1119#issuecomment-187103123
the first commit has that change but seems to have disappeared after the
upmerge.
---
If your project is set up for it, you can reply to this email and have
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1133#issuecomment-187064662
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1123#issuecomment-187022132
When the unit tests are run it creates log files under /logs. It should
ideally be under system tmp directory.
Maybe unrelated, but when an example
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1127#issuecomment-186883739
@harshach `storm.home` is not set during unit tests so the logs were
created under wrong directory. Commit
https://github.com/apache/storm/commit
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1127#issuecomment-186520455
@ptgoetz updated log message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1127#issuecomment-186096220
@ptgoetz can you take a look ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
501 - 600 of 787 matches
Mail list logo
