Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/651#issuecomment-13151
@tandrup can you please open a JIRA here
https://issues.apache.org/jira/browse/STORM/ and also update the PR with JIRA
number in the title.
---
If your project is set
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/649#issuecomment-131588513
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/664#issuecomment-131588005
@arunmahadevan since you've made changes to HdfsBolt as part of STORM-837
can you take look at this PR check if its already handled by your changes.
---
If
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/669#discussion_r37148057
--- Diff: external/storm-kafka/src/jvm/storm/kafka/SpoutConfig.java ---
@@ -27,6 +27,9 @@
public String zkRoot = null;
public String id
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/669#discussion_r37148051
--- Diff: external/storm-kafka/src/jvm/storm/kafka/PartitionManager.java ---
@@ -137,8 +137,14 @@ public EmitState next(SpoutOutputCollector collector
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/673#issuecomment-131586602
@arunmahadevan is there any option for the user to set that they want to %
of flowing tuples in a topology?
Overall this looks good to me but we need a doc on how
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/665#issuecomment-131583675
I volunteer to be sponsor for this connector
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37147769
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/schema/builder/RestJsonSchemaBuilder.java
---
@@ -0,0 +1,53 @@
+package
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/686#issuecomment-131219427
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/662#issuecomment-130838110
@knusbaum it will make lot easier for commands to be in java and we can
have just wrappers for windows & nix* os. We don't need to have python
dependency a
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/665#issuecomment-130751200
I made a initial pass on the PR. Overall it looks good to me. It needs
README to document on how to use Bolt and TridentState.
---
If your project is set up for it
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r36993719
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/schema/builder/RestJsonSchemaBuilder.java
---
@@ -0,0 +1,53 @@
+package
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r36992356
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/mapper/SolrJsonMapper.java
---
@@ -0,0 +1,97 @@
+package org.apache.storm.solr.mapper
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r36990730
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/AbstractSolrBolt.java
---
@@ -0,0 +1,33 @@
+package org.apache.storm.solr.bolt
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r36990357
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
---
@@ -0,0 +1,107 @@
+package org.apache.storm.solr.bolt
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r36987568
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
---
@@ -0,0 +1,107 @@
+package org.apache.storm.solr.bolt
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/670#issuecomment-130488992
@ptgoetz will look into the fb & goog calls and also generating the news
feed. As far as separate branch goes thats fine by me but another issue could
be that the
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/670#issuecomment-130447771
@ptgoetz if these issues are layout please list them out we can send a new
patch. I don't think website layout needs to be blocked on docs or other fixes.
I want t
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/656#issuecomment-130439312
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/666#issuecomment-130404466
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r36863654
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/AbstractSolrBolt.java
---
@@ -0,0 +1,33 @@
+package org.apache.storm.solr.bolt
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/670#issuecomment-130134736
@revans2 @ptgoetz waiting for you to take a look at it before we can merge
it in.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/670#issuecomment-129636717
@ptgoetz can you take a look at it as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/666#issuecomment-129559848
@arunmahadevan can you upmerge this with master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/670#issuecomment-129523372
@HeartSaVioR Thanks. Will file a follow-up jira for the issues you raised.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/670#issuecomment-129465676
@HeartSaVioR Thanks for the review.
All links which point to javadoc are broken. Can I expect it will work when
site resources are deployed to official site
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/670#issuecomment-129286465
@HeartSaVioR @revans2 my bad looks like I missed a commit last time. Please
try again. Thanks
---
If your project is set up for it, you can reply to this email and
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/670#issuecomment-129286293
@revans2 how are you running this I didn't see any issues with resources or
js missing 404s.
@HeartSaVioR can you please check this PR . I ran though the
GitHub user harshach opened a pull request:
https://github.com/apache/storm/pull/670
STORM-950. Apache Storm website redesign.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/harshach/incubator-storm STORM-950-V7
Alternatively
Github user harshach closed the pull request at:
https://github.com/apache/storm/pull/663
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/666#issuecomment-129284763
@arunmahadevan can you please file a jira and send a pr with jira number in
it.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user harshach opened a pull request:
https://github.com/apache/storm/pull/663
STORM-950. Apache Storm website redesign.
To run
1. Install Jekyll
2. jekyll serve -w will start a webserver at localhost:4000
You can merge this pull request into a Git repository by
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/663#issuecomment-126795885
@HeartSaVioR @ptgoetz please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/653#issuecomment-126708790
@dossett Thanks for the patch. Pushed to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/644#issuecomment-126706239
I am +1 on the last approach. @arunmahadevan please add to the README
under storm-hdfs.
---
If your project is set up for it, you can reply to this email and have
Github user harshach closed the pull request at:
https://github.com/apache/storm/pull/659
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/659#issuecomment-126424522
@HeartSaVioR your comments from previous one addressed in this one
https://github.com/apache/storm/pull/654#issuecomment-125104496 . Please take a
look
---
If your
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/659#issuecomment-126424575
@ptgoetz please take a look as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user harshach opened a pull request:
https://github.com/apache/storm/pull/659
STORM-950. Apache Storm website redesign.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/harshach/incubator-storm STORM-950-V4
Alternatively
Github user harshach closed the pull request at:
https://github.com/apache/storm/pull/654
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/653#issuecomment-126338285
+1 @dossett can you up merge the changes with the branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/653#discussion_r35793063
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -43,23 +43,25 @@
import java.util.concurrent.Executors
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/653#discussion_r35762109
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -104,16 +106,30 @@ public void execute(Tuple tuple
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/653#discussion_r35761939
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -43,23 +43,25 @@
import java.util.concurrent.Executors
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/653#discussion_r35761875
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -104,16 +106,30 @@ public void execute(Tuple tuple
GitHub user harshach opened a pull request:
https://github.com/apache/storm/pull/654
STORM-950. Apache Storm website redesign.
To test this. Install jekyll
on OS X sudo gem install jekyll
cd storm/docs/
jekyll serve -w
You can merge this pull request into a Git
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/650#issuecomment-125015093
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/644#issuecomment-124856128
@ptgoetz @arunmahadevan can we not make this as a default behaviour
instead make this as option. We can document that exactly-once behaviour comes
with limitations
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/644#issuecomment-124537309
@revans2 @ptgoetz can you take a look at this patch. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/645#discussion_r35425503
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -170,10 +170,10 @@ public void run
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/644#discussion_r35240425
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/trident/HdfsState.java
---
@@ -136,33 +193,40 @@ public void run() {
private
GitHub user harshach opened a pull request:
https://github.com/apache/storm/pull/645
STORM-951. Storm Hive connector leaking connections.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/harshach/incubator-storm STORM-951
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/641#issuecomment-122480198
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/642#issuecomment-122480095
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/405#issuecomment-120979666
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/627#issuecomment-120416074
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/405#issuecomment-120415203
@slora which version of storm are you using
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/561#issuecomment-120216042
@sumitchawla sorry for the delay. looks like you need to do another up
merge. These lot of changes we need to run some tests . Also can you add any
new config you added
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/610#discussion_r34051657
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -83,7 +83,7 @@ public void prepare(Map conf, TopologyContext
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/609#issuecomment-119236414
@dossett will this work with Hive 0.13?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/610#issuecomment-119069596
@dossett not sure why these changes necessary here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/601#issuecomment-116895161
@anishek my bad missed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/561#issuecomment-116740320
@sumitchawla can you upmerge this I'll take a look. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/601#issuecomment-116731268
@anishek can you please add this config to README.md
https://github.com/apache/storm/blob/master/external/storm-kafka/README.md
few lines about what it does
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/601#discussion_r33413898
--- Diff: external/storm-kafka/src/jvm/storm/kafka/SpoutConfig.java ---
@@ -29,6 +29,7 @@
// setting for how often to save the current kafka
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/601#issuecomment-116099001
@anishek can you also update the README.md with doc on this config.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/600#issuecomment-115940765
@revans2 agree on not shading. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/600#issuecomment-115866496
@revans2 this line
https://github.com/apache/storm/blob/master/storm-core/pom.xml#L259 so the
reason we excluded is there is commons-codec in path from storm as its
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/600#issuecomment-115835563
@revans2 what about the hadoop-auth that we are including right now can we
atleast remove the "exclude commons-codec" from hadoop-auth dependency. It will
gi
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/600#issuecomment-115360459
@revans2 we are shipping security in 0.10 that means we need to provide a
way for UI daemon to be secured hence the reason we are including kerberos
filter as part of
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/600#issuecomment-115349321
@revans2 not sure this addresses the issue for using KerberosFilter from
hadoop for securing UI when used in kerberos cluster. We excluded commons-codec
from hadoop
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/573#issuecomment-114161607
@sweetest thanks for the quick turnaround. I'll take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/540#issuecomment-114000816
Thanks @tedxia merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/540#issuecomment-113997697
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/544#issuecomment-113997109
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/553#issuecomment-113996523
@oleg03 can you send us a new patch with @revans2 feedback . Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/583#issuecomment-113996410
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/586#issuecomment-113996119
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/594#issuecomment-113996072
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/569#issuecomment-113995740
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/573#discussion_r32904099
--- Diff: external/storm-elasticsearch/README.md ---
@@ -0,0 +1,71 @@
+# Storm ElasticSearch Bolt & Trident State
+
+ EsIndex
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/573#issuecomment-113995462
@sweetest it looks good on my first look. I volunteer to be a sponsor for
this connector. Can you upmerge this. I'll work on getting this in. Thanks.
---
If
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/597#issuecomment-113995243
@kishorvpatil would it makes sense to log the exception as well? , allows
users to know the cause of jvm exit.
---
If your project is set up for it, you can reply to
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/595#issuecomment-113980284
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/596#issuecomment-113552940
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/581#issuecomment-109855687
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/571#issuecomment-108095464
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/418#issuecomment-107257398
@ssudhaiyer can you give us some steps on reproducing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/546#issuecomment-103352452
+1 looks good to me. Ran examples on local mode and wordcount on storm
cluster.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/556#issuecomment-103227689
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/551#issuecomment-101470751
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/547#issuecomment-100752288
@revans2 I am +1 on the patch. Good to remove metastore_db before running
tests.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/528#issuecomment-94299407
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/492#issuecomment-91033826
Thanks @knusbaum merged it into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/511#issuecomment-90938279
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/509#issuecomment-90778496
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/479#issuecomment-90751945
Thanks for the review @Parth-Brahmbhatt . Updated the security.md .
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/492#issuecomment-90666963
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/479#issuecomment-90316831
@ptgoetz @Parth-Brahmbhatt @revans2 appreciate any feedback on this PR>
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/493#issuecomment-90309348
@ptgoetz addressed your comments. Can you please take a look at this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
901 - 1000 of 1251 matches
Mail list logo
